edde746
810ef002ad
When mpv bitstreams (audio-spdif), audio-params describe the IEC 61937 carrier - 192 kHz "stereo" for E-AC-3 - so the performance overlay told users their 5.1 track was playing as 2ch stereo. Every recent "EAC3 downgraded to PCM" report in #1300 reads back this string while the receiver route stays healthy. Show the source track's channel layout and sample rate instead, plus an explicit Passthrough row naming the bitstreamed codec, on both the mpv-channel and Android mpv-fallback stats paths.
121 lines
3.8 KiB
Dart
121 lines
3.8 KiB
Dart
import 'dart:async';
|
|
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:plezy/mpv/mpv.dart';
|
|
import 'package:plezy/widgets/video_controls/widgets/performance_overlay/performance_stats.dart';
|
|
import 'package:plezy/widgets/video_controls/widgets/performance_overlay/performance_stats_service.dart';
|
|
|
|
/// Player fake that answers mpv property queries from a fixed map.
|
|
class _PropertyPlayer implements Player {
|
|
_PropertyPlayer(this.properties);
|
|
|
|
final Map<String, String> properties;
|
|
|
|
@override
|
|
final PlayerStreams streams = const PlayerStreams(
|
|
playing: Stream.empty(),
|
|
completed: Stream.empty(),
|
|
buffering: Stream.empty(),
|
|
position: Stream.empty(),
|
|
duration: Stream.empty(),
|
|
seekable: Stream.empty(),
|
|
buffer: Stream.empty(),
|
|
volume: Stream.empty(),
|
|
rate: Stream.empty(),
|
|
tracks: Stream.empty(),
|
|
track: Stream.empty(),
|
|
log: Stream.empty(),
|
|
error: Stream.empty(),
|
|
audioDevice: Stream.empty(),
|
|
audioDevices: Stream.empty(),
|
|
bufferRanges: Stream.empty(),
|
|
playbackRestart: Stream.empty(),
|
|
fileStarted: Stream.empty(),
|
|
fileLoaded: Stream.empty(),
|
|
fileLoadFailed: Stream.empty(),
|
|
primaryMediaReady: Stream.empty(),
|
|
backendSwitched: Stream.empty(),
|
|
);
|
|
|
|
@override
|
|
bool get providesNativeStats => false;
|
|
|
|
@override
|
|
Future<String?> getProperty(String name) async => properties[name];
|
|
|
|
@override
|
|
Future<String> runtimePlayerType() async => 'mpv';
|
|
|
|
@override
|
|
dynamic noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
|
|
}
|
|
|
|
Future<PerformanceStats> _firstStats(_PropertyPlayer player) async {
|
|
final service = PerformanceStatsService(player);
|
|
try {
|
|
final first = service.statsStream.first;
|
|
service.startPolling();
|
|
return await first;
|
|
} finally {
|
|
service.dispose();
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
TestWidgetsFlutterBinding.ensureInitialized();
|
|
|
|
group('PerformanceStatsService audio display', () {
|
|
test('spdif passthrough reports the source track, not the IEC carrier (#1300)', () async {
|
|
// mpv's audio-params during E-AC-3 bitstreaming: the 192 kHz "stereo"
|
|
// IEC 61937 carrier. The overlay must show the 48 kHz 5.1 source track.
|
|
final stats = await _firstStats(
|
|
_PropertyPlayer({
|
|
'audio-codec-name': 'eac3',
|
|
'audio-params/format': 'spdif-eac3',
|
|
'audio-params/samplerate': '192000',
|
|
'audio-params/hr-channels': 'stereo',
|
|
'current-tracks/audio/demux-samplerate': '48000',
|
|
'current-tracks/audio/demux-channel-count': '6',
|
|
}),
|
|
);
|
|
|
|
expect(stats.audioSamplerate, 48000);
|
|
expect(stats.audioChannels, '5.1');
|
|
expect(stats.audioPassthrough, isTrue);
|
|
expect(stats.audioPassthroughFormatted, 'E-AC3');
|
|
});
|
|
|
|
test('locally decoded audio keeps mpv audio-params verbatim', () async {
|
|
final stats = await _firstStats(
|
|
_PropertyPlayer({
|
|
'audio-codec-name': 'eac3',
|
|
'audio-params/format': 'floatp',
|
|
'audio-params/samplerate': '48000',
|
|
'audio-params/hr-channels': '5.1',
|
|
'current-tracks/audio/demux-samplerate': '48000',
|
|
'current-tracks/audio/demux-channel-count': '6',
|
|
}),
|
|
);
|
|
|
|
expect(stats.audioSamplerate, 48000);
|
|
expect(stats.audioChannels, '5.1');
|
|
expect(stats.audioPassthrough, isFalse);
|
|
});
|
|
|
|
test('passthrough with unavailable track metadata degrades to N/A, never the carrier', () async {
|
|
final stats = await _firstStats(
|
|
_PropertyPlayer({
|
|
'audio-params/format': 'spdif-dts-hd',
|
|
'audio-params/samplerate': '192000',
|
|
'audio-params/hr-channels': 'stereo',
|
|
}),
|
|
);
|
|
|
|
expect(stats.audioSamplerate, isNull);
|
|
expect(stats.audioChannels, isNull);
|
|
expect(stats.audioPassthrough, isTrue);
|
|
expect(stats.audioPassthroughFormatted, 'DTS-HD');
|
|
});
|
|
});
|
|
}
|