edde746 e67bf996c5 fix(player): keep subtitles on the picture when ambient lighting is on ...

With ambient lighting enabled, ASS subtitles anchored to a corner (and PGS
bitmaps) rendered against the whole screen instead of the video: the effect
stretches mpv's frame to the window with video-aspect-override and lets the
shader composite the real picture inside it, and mpv places subtitles against
that stretched frame.

The pinned libmpv now carries --sub-video-rect-aspect (edde746/mpv-build
ec08018), which makes mpv derive its subtitle margins from the picture's real
aspect inside the displayed rect. AmbientLightingService hands it the video
aspect before overriding the frame, so a libmpv without the option refuses
cleanly with the frame untouched, and resets it on disable.

Verified on a Pixel 7 (2400x1080) with a 16:9 file whose OP credits are
\pos-anchored: subtitle extents are pixel-identical with ambient lighting on
and off, and mpv reports OSD borders l=240 r=240 for the overridden frame.

close #2120

2026-09-03 21:28:10 +02:00

..

catalog

fix(seerr): decode media status per product and model failed/completed request states

2026-08-21 19:23:42 +02:00

companion_remote

chore: reuse drainPages, SerialFutureQueue, and FutureCoalescer for hand-rolled equivalents

2026-09-03 11:36:29 +02:00

jellyfin_client/parts

chore: reuse drainPages, SerialFutureQueue, and FutureCoalescer for hand-rolled equivalents

2026-09-03 11:36:29 +02:00

library_events

fix(networking): connect in resolver address order with a Happy Eyeballs race

2026-09-03 07:35:34 +02:00

music

feat(music): restore the last music session paused on launch

2026-08-29 19:11:58 +02:00

plex_client/parts

chore(plex): map metadata type codes and fetch detail metadata in one place

2026-09-03 11:36:29 +02:00

seerr

fix(seerr): seed advanced requests from the Sonarr anime defaults and expose tags

2026-09-03 16:46:27 +02:00

trackers

chore(trackers,downloads): share rating request matching and download queue feedback

2026-09-03 11:36:29 +02:00

account_preferences_accounts.dart

chore(profiles): let AccountPreferencesController own the active user's playback preferences

2026-09-03 11:36:56 +02:00

account_preferences_repository.dart

chore(profiles): let AccountPreferencesController own the active user's playback preferences

2026-09-03 11:36:56 +02:00

ambient_lighting_service.dart

fix(player): keep subtitles on the picture when ambient lighting is on

2026-09-03 21:28:10 +02:00

api_cache.dart

fix(database): restore api_cache.cached_at read by the playback freshness gate

2026-08-17 20:47:40 +02:00

app_exit_service.dart

feat(simkl): report playback progress while it happens

2026-07-30 11:55:13 +02:00

apple_tv_remote_touch_service.dart

fix(tvos): match Siri Remote navigation to measured native focus-engine physics

2026-08-24 13:41:44 +02:00

assistive_technology_service.dart

perf(android): skip the semantics tree when no enabled accessibility service can read it

2026-09-02 22:38:11 +02:00

background_work_diagnostics_service.dart

feat(downloads): warn about Android background restrictions

2026-07-26 04:24:55 +02:00

base_peer_service.dart

refactor: strip obvious comments

2026-05-04 22:40:18 +02:00

base_shared_preferences_service.dart

feat(player): apply separate default quality on cellular connections

2026-08-27 14:14:01 +02:00

bif_thumbnail_service.dart

fix(emby): show scrub previews from the /Videos/{id}/index.bif transport

2026-08-14 13:36:29 +02:00

cached_playback_metadata_service.dart

fix(plex): honor disabled credits detection when synthesizing chapter markers

2026-08-27 10:16:05 +02:00

car_ux_restrictions_service.dart

feat(automotive): read the vehicle's driver-distraction state

2026-08-06 03:45:09 +02:00

credential_vault.dart

fix(startup): move optional work off the launch gate

2026-08-23 18:13:39 +02:00

data_aggregation_service.dart

fix(networking): surface cancelled responses as cancellation and stop crediting a failed Plex hub fetch

2026-08-21 19:23:40 +02:00

device_adjustment_service.dart

feat(player): remember the swipe brightness level between playbacks

2026-08-31 06:43:47 +02:00

device_performance.dart

fix(images): fetch full-resolution tile artwork on low-end hardware

2026-08-19 13:16:36 +02:00

discord_rpc_service.dart

fix(providers): keep reconnects, retained libraries, and Discord presence alive after failures

2026-08-21 19:23:40 +02:00

display_mode_service.dart

fix(native): bound cross-platform lifecycle ownership

2026-07-24 03:56:40 +02:00

donation_service.dart

feat(windows): package for the Microsoft Store as an MSIX bundle

2026-07-30 20:03:04 +02:00

download_artwork_helpers.dart

feat: jellyfin

2026-05-01 01:20:36 +02:00

download_artwork_service.dart

refactor: remove unreachable code paths and unused members

2026-07-26 06:09:47 +02:00

download_manager_service.dart

perf(downloads): resolve cache scopes once per server and build one deletion plan

2026-09-03 11:36:29 +02:00

download_storage_service.dart

fix(downloads): store music tracks as Music/{Artist}/{Album}/{NN - Title}

2026-08-27 16:58:52 +02:00

downloaded_video_source.dart

fix(downloads): stream from the server when a downloaded SAF copy is unreachable

2026-08-24 19:27:20 +02:00

driver_distraction.dart

feat(automotive): read the vehicle's driver-distraction state

2026-08-06 03:45:09 +02:00

episode_navigation_service.dart

refactor(media): plain LocalPlayQueue, trimmed MediaItem factory, one library-content entry point

2026-08-17 19:02:19 +02:00

external_player_service.dart

fix(discover): let a refreshed row override a stale local watch patch

2026-08-08 09:09:48 +02:00

favorite_channels_repository.dart

feat: jellyfin

2026-05-01 01:20:36 +02:00

file_info_parser.dart

refactor(services): delete dead branches, write-only fields, and test-only cache/service surface

2026-08-17 19:02:25 +02:00

file_picker_service.dart

build(deps): upgrade Flutter package dependencies

2026-07-24 03:56:40 +02:00

fullscreen_state_manager.dart

refactor(services): delete dead branches, write-only fields, and test-only cache/service surface

2026-08-17 19:02:25 +02:00

gamepad_service.dart

fix(gamepad): release held-direction state when a controller disconnects

2026-08-21 19:23:40 +02:00

image_cache_service.dart

refactor(networking): drop Cronet and NSURLSession for the tuned dart:io client

2026-08-27 09:21:48 +02:00

jellyfin_api_cache.dart

refactor(media): delete write-only item fields, dead copyWith/getters, and the unread live-TV activity wrapper

2026-08-17 19:02:23 +02:00

jellyfin_auth_header.dart

feat(emby): add Emby as a MediaBrowser backend alongside Jellyfin

2026-08-05 06:09:26 +02:00

jellyfin_auth_service.dart

fix(i18n): translate the strings that still reached the UI in English

2026-08-24 05:23:05 +02:00

jellyfin_cache_resolver.dart

perf(downloads): resolve cache scopes once per server and build one deletion plan

2026-09-03 11:36:29 +02:00

jellyfin_client.dart

chore(profiles): let AccountPreferencesController own the active user's playback preferences

2026-09-03 11:36:56 +02:00

jellyfin_display_metadata.dart

refactor(media): centralize HDR classification

2026-07-12 08:42:25 +02:00

jellyfin_endpoint_discovery.dart

refactor(discovery): expand server url candidates through one shared helper

2026-08-25 03:07:14 +02:00

jellyfin_lan_discovery_service.dart

feat(emby): add Emby as a MediaBrowser backend alongside Jellyfin

2026-08-05 06:09:26 +02:00

jellyfin_mappers.dart

fix(player): stop letting item metadata language override the audio track

2026-09-03 13:08:46 +02:00

jellyfin_media_info_mapper.dart

fix(emby): show scrub previews from the /Videos/{id}/index.bif transport

2026-08-14 13:36:29 +02:00

jellyfin_playback_bundle.dart

fix(jellyfin): pin MediaSourceId on every static stream URL

2026-07-31 21:45:33 +02:00

jellyfin_playback_urls.dart

feat(music): add music data layer for plex and jellyfin

2026-07-05 15:55:52 +02:00

jellyfin_sequential_launcher.dart

refactor(media): plain LocalPlayQueue, trimmed MediaItem factory, one library-content entry point

2026-08-17 19:02:19 +02:00

jellyfin_trickplay_service.dart

fix(images): stop decoding artwork nothing ever displays

2026-08-23 17:51:27 +02:00

keyboard_shortcuts_service.dart

fix(watch-together): declare rate changes to the room and stop the host clock during its own stalls

2026-09-02 12:31:27 +02:00

library_query_translator.dart

chore(plex): map metadata type codes and fetch detail metadata in one place

2026-09-03 11:36:29 +02:00

live_seek_accumulator.dart

fix(live-tv): stabilize HLS playback

2026-07-18 20:04:09 +02:00

live_session_tracker.dart

refactor(services): delete dead branches, write-only fields, and test-only cache/service surface

2026-08-17 19:02:25 +02:00

local_playback_history.dart

build: migrate to Flutter 3.47.1 (#2092)

2026-08-24 12:32:05 +02:00

log_upload_service.dart

fix(startup): report and repair a failed launch instead of showing "Error"

2026-07-31 21:45:32 +02:00

macos_window_service.dart

refactor: extract shared mixins and helpers, drop dead abstractions

2026-07-26 06:09:48 +02:00

media_browser_account_preferences_source.dart

feat(settings): account preferences, stored on the server instead of the device (#2112)

2026-08-25 08:42:48 +02:00

media_browser_paths.dart

feat(settings): account preferences, stored on the server instead of the device (#2112)

2026-08-25 08:42:48 +02:00

media_control_router.dart

refactor: extract shared mixins and helpers, drop dead abstractions

2026-07-26 06:09:48 +02:00

media_controls_manager.dart

feat(player): surface skip forward/back on the iOS and tvOS lock screen and remote

2026-08-18 04:06:11 +02:00

media_list_playback_launcher.dart

fix(ui): show loading feedback while play actions fetch

2026-08-17 13:47:00 +02:00

mpv_sidecar_open_guard.dart

fix(player): load subtitle sidecars with media

2026-07-17 23:09:07 +02:00

multi_server_manager.dart

fix(plex): keep a LAN session on its local endpoint after device sleep

2026-09-03 18:13:28 +02:00

native_window_service.dart

fix: native monitor-aware fullscreen on windows

2026-04-16 23:13:15 +02:00

offline_mode_source.dart

fix: dispose services and subscriptions, persist client id

2026-04-21 12:04:48 +02:00

offline_watch_sync_service.dart

fix(discover): let a refreshed row override a stale local watch patch

2026-08-08 09:09:48 +02:00

pip_service.dart

fix(i18n): translate the strings that still reached the UI in English

2026-08-24 05:23:05 +02:00

play_queue_launcher.dart

fix(plex): surface instant mix failures instead of silently doing nothing

2026-08-27 16:59:08 +02:00

playback_context.dart

refactor(services): delete dead branches, write-only fields, and test-only cache/service surface

2026-08-17 19:02:25 +02:00

playback_coordinator.dart

feat(music): mpv audio playback engine with gapless queue service

2026-07-05 19:26:28 +02:00

playback_initialization_service.dart

fix(subtitles): load external subtitle files with the media whether or not selected

2026-08-10 21:23:55 +02:00

playback_initialization_types.dart

fix(player): seek Plex transcodes in-band instead of pre-warming at the resume offset

2026-08-10 23:04:35 +02:00

playback_progress_tracker.dart

build: migrate to Flutter 3.47.1 (#2092)

2026-08-24 12:32:05 +02:00

playback_report_session.dart

fix(plex): stop recording a second play when the server already logged one

2026-08-02 16:16:19 +02:00

playback_session.dart

refactor(services): delete dead branches, write-only fields, and test-only cache/service surface

2026-08-17 19:02:25 +02:00

playback_source_resolver.dart

refactor(services): delete dead branches, write-only fields, and test-only cache/service surface

2026-08-17 19:02:25 +02:00

playback_subtitle_resolver.dart

fix(subtitles): let the server deliver subtitles on a transcode

2026-08-09 07:30:47 +02:00

playback_track_preview.dart

fix(detail): make the track status read-only and right-align it

2026-09-03 13:03:24 +02:00

playlist_items_loader.dart

refactor: extract shared mixins and helpers, drop dead abstractions

2026-07-26 06:09:48 +02:00

plex_account_preferences_source.dart

feat(settings): account preferences, stored on the server instead of the device (#2112)

2026-08-25 08:42:48 +02:00

plex_api_cache.dart

refactor(services): delete dead branches, write-only fields, and test-only cache/service surface

2026-08-17 19:02:25 +02:00

plex_auth_service.dart

chore(profiles): let AccountPreferencesController own the active user's playback preferences

2026-09-03 11:36:56 +02:00

plex_client.dart

chore(plex): map metadata type codes and fetch detail metadata in one place

2026-09-03 11:36:29 +02:00

plex_constants.dart

chore(plex): map metadata type codes and fetch detail metadata in one place

2026-09-03 11:36:29 +02:00

plex_discover_client.dart

fix(explore): match Plex Discover titles to the library again

2026-07-30 01:33:46 +02:00

plex_lyrics_parser.dart

fix(plex): handle malformed lyrics XML

2026-07-16 14:36:48 +02:00

plex_mappers.dart

fix(player): stop letting item metadata language override the audio track

2026-09-03 13:08:46 +02:00

plex_mappers.g.dart

fix(player): stop letting item metadata language override the audio track

2026-09-03 13:08:46 +02:00

plex_playback_mapper.dart

chore(player): report marker counts when loading playback extras

2026-08-02 04:55:54 +02:00

prefs_recovery.dart

refactor(services): delete dead branches, write-only fields, and test-only cache/service surface

2026-08-17 19:02:25 +02:00

saf_storage_service.dart

fix(downloads): stream from the server when a downloaded SAF copy is unreachable

2026-08-24 19:27:20 +02:00

scoped_player_prefs.dart

feat(player): persist player-sheet changes at a configurable scope

2026-08-18 06:09:11 +02:00

scrub_preview_source.dart

Fix BIF scrub preview aspect ratio and raise desktop size limit

2026-05-28 15:46:08 -04:00

sensitive_prefs.dart

feat(mdblist): sync watched history, scrobbles and ratings with MDBList

2026-08-05 12:03:05 +02:00

server_registry.dart

feat: jellyfin

2026-05-01 01:20:36 +02:00

settings_binding_owner.dart

refactor(settings): share preference binding lifecycle

2026-07-12 08:42:25 +02:00

settings_export_service.dart

feat(player): apply separate default quality on cellular connections

2026-08-27 14:14:01 +02:00

settings_service.dart

feat(plex): make the covered-source direct play optional

2026-08-31 11:32:07 +02:00

shader_asset_loader.dart

refactor: fold single-use helpers into their call sites

2026-07-26 06:09:49 +02:00

shader_service.dart

fix(apple): use platform-specific mpv rendering

2026-05-10 13:33:02 +02:00

shortcut_action.dart

refactor: fold single-use helpers into their call sites

2026-07-26 06:09:49 +02:00

sleep_timer_service.dart

refactor: share focus chrome and simplify the TV picker and browse paths

2026-07-26 06:09:49 +02:00

startup_diagnostics.dart

fix(startup): lead the damaged-store screen with the repair, not retry

2026-08-02 04:37:29 +02:00

storage_service.dart

fix(prefs): route every credential read through the tolerant path

2026-07-31 21:45:32 +02:00

subtitle_preference.dart

fix(player): preserve the forced-subtitle class across episode boundaries

2026-07-30 02:46:10 +02:00

sync_rule_executor.dart

feat(player): apply separate default quality on cellular connections

2026-08-27 14:14:01 +02:00

system_shelf_service.dart

fix(i18n): translate the strings that still reached the UI in English

2026-08-24 05:23:05 +02:00

track_manager.dart

feat(player): persist player-sheet changes at a configurable scope

2026-08-18 06:09:11 +02:00

track_selection_service.dart

fix(player): stop letting item metadata language override the audio track

2026-09-03 13:08:46 +02:00

tvos_system_navigation_service.dart

fix(supply-chain): verify CI and production inputs

2026-07-24 03:56:40 +02:00

update_service.dart

refactor(services): delete dead branches, write-only fields, and test-only cache/service surface

2026-08-17 19:02:25 +02:00

video_decode_capabilities.dart

fix(jellyfin): advertise video codecs from a native hardware-decode probe

2026-08-26 16:53:14 +02:00

video_filter_manager.dart

feat(player): persist player-sheet changes at a configurable scope

2026-08-18 06:09:11 +02:00

video_volume_controller.dart

fix(runtime): harden application service boundaries

2026-07-24 03:46:46 +02:00

watch_actions.dart

fix(discover): let a refreshed row override a stale local watch patch

2026-08-08 09:09:48 +02:00

watch_state_resolver.dart

refactor: extract shared mixins and helpers, drop dead abstractions

2026-07-26 06:09:48 +02:00