From 123d05b7d37c5b2c97f33d047b0193e6d4b9869e Mon Sep 17 00:00:00 2001
From: zZebrahz <zzebrahz@gmail.com>
Date: Sat, 30 May 2026 03:28:51 +0000
Subject: [PATCH] fix(people): refresh incomplete metadata inline

---
 internal/api/handlers/people.go | 33 +++++++++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

diff --git a/internal/api/handlers/people.go b/internal/api/handlers/people.go
index 484aa406..2f866600 100644
--- a/internal/api/handlers/people.go
+++ b/internal/api/handlers/people.go
@@ -133,9 +133,9 @@ func (h *PeopleHandler) HandleGetPerson(w http.ResponseWriter, r *http.Request)
 		return
 	}
 
-	h.enqueuePersonRefreshIfDue(*person)
+	personValue := h.refreshPersonOnViewIfDue(r.Context(), *person)
 
-	writeJSON(w, http.StatusOK, h.toResponse(r.Context(), *person))
+	writeJSON(w, http.StatusOK, h.toResponse(r.Context(), personValue))
 }
 
 // HandleRefreshPerson serves POST /api/v1/people/:id/refresh.
@@ -378,6 +378,35 @@ func (h *PeopleHandler) enqueuePersonRefreshIfDue(person models.Person) {
 	}
 }
 
+func (h *PeopleHandler) refreshPersonOnViewIfDue(ctx context.Context, person models.Person) models.Person {
+	if !personHasRefreshableProviderID(person) {
+		return person
+	}
+
+	if !personMetadataIncomplete(person) {
+		h.enqueuePersonRefreshIfDue(person)
+		return person
+	}
+
+	if h.refresher == nil {
+		h.enqueuePersonRefreshIfDue(person)
+		return person
+	}
+
+	refreshCtx, cancel := context.WithTimeout(ctx, 2*time.Minute)
+	defer cancel()
+
+	refreshed, err := h.refresher.RefreshPerson(refreshCtx, person.ID)
+	if err != nil {
+		slog.Warn("people: automatic person refresh failed", "id", person.ID, "error", err)
+		return person
+	}
+	if refreshed == nil {
+		return person
+	}
+	return *refreshed
+}
+
 func personHasRefreshableProviderID(person models.Person) bool {
 	return person.TmdbID != "" || person.ImdbID != "" || person.TvdbID != ""
 }