* perf(jellycompat,sections): bound resume scan, batch leaf detail progress, widen section concurrency Three low-risk fixes from the section-fetch performance investigation (docs/superpowers/plans/2026-07-03-section-fetch-performance.md): - jellycompat: bound loadProgressPage at resumeScanMaxRows=300 so a single request never pages through more than that many in-progress rows. The cap is unconditional: it also covers the sparse-visible-set case (a heavy watcher whose recent rows are mostly dismissed/superseded, or a Series/Season-only request that matches no leaf in-progress row), where the page never fills and the loop would otherwise scan the entire history — previously an O(history) scan reaching tens of seconds. In the common case the loop exits far earlier, so the cap only bounds the pathological worst case; 300 leaves ample headroom to fill a ~20-item Continue Watching page. Beyond the cap the reported total is a clamped lower bound. Covered by TestLoadProgressPage_BoundsScanForSparseVisibleSet. - jellycompat: batch the leaf-item (movie/episode) progress lookup in GetItemDetailsByIDs via ListProgressWithCompletedHistory instead of a per-item GetProgressWithCompletedHistory (~100 sequential queries for a 50-item detail page). Series keep the per-item episode-rollup path (they own no progress row). Output is unchanged; a batch-lookup failure is now logged rather than silently dropping played state for the whole page. - sections: raise fetchAllMaxConcurrency 4 -> 6 to cut FetchAll wave count for large home layouts, staying within the default 20-conn pool. Part of the home/continue-watching latency work. AI-use disclosure: implemented with AI (Claude) assistance. * perf(jellycompat): keep Latest browse on the cross-library fast path under isPlayed /Items/Latest with isPlayed=false is the highest-frequency compat browse (~10.8k calls/day). The played overlay can't be pushed into SQL, so browse over-fetches and filters locally. The cross-library recently_added fast path (BrowseRecentlyAddedAcrossLibraries: one ~1ms index walk per library) was gated on Offset==0, so a heavy watcher who had already seen the newest items needed a 2nd chunk and fell through to BrowsePage — a whole-catalog MIN(first_seen_at) + GROUP BY HashAggregate over ~147k movies measured at ~755ms per call (0.8-1.6s observed end-to-end). Fetch the entire over-fetch budget (maxScannedRows) in a single merged fast-path walk instead of paging into BrowsePage, so the loop fills from one call. The clamp caveat (MaxLimit=1000 leaves a fall-through only for requestedLimit>200, off the Latest hot path) is documented inline. Part of the home/browse latency work. AI-use disclosure: implemented with AI (Claude) assistance. * fix(jellycompat): scope resume scan cap to resume path and bound the fast-path loop Addresses PR #292 review feedback: - Codex (P2): the resumeScanMaxRows cap was applied unconditionally in the general loop, which also paginates the completed (watched-items) list. Gate it on resumeFiltered so the completed path keeps exact TotalRecordCount and deep StartIndex pagination. Covered by TestLoadProgressPage_CompletedScanNotCapped. - CodeRabbit (Critical): the earlier raw-offset fast-path loop — the default Continue Watching shape and the sections-fallback route — had the same unbounded-scan bug and was not covered by the cap (the existing test forces EnableTotalRecordCount=true, routing around it). Bound it with the same resumeScanMaxRows guard. Covered by TestLoadProgressPage_BoundsFastPathScanForSparseVisibleSet. - CodeRabbit (Minor): tag the doc's fenced example blocks as text to satisfy markdownlint MD040. AI-use disclosure: implemented with AI (Claude) assistance. * perf(sections): cache shared user-agnostic home rails per access scope Home-screen rails that are identical for everyone who can see the same libraries (recently added, recently released, genre, trending on server, most watched, new to library, critically acclaimed, award winners, format showcase, seasonal, mood, trending discover, admin-curated lists, and library collections) were rebuilt from Postgres once per request, per user. Only the overlay on top of each row (watched flags, play position, presigned poster URLs) is actually per-user. Insert a process-global resolved-list cache at the FetchOne choke point in internal/sections. Each cacheable row is built once per access scope, held with a 15m TTL, and refreshed in the background 3m before expiry; singleflight collapses cold-miss stampedes into a single build. The per-user overlay still runs fresh in buildSectionsResponse, so no profile state is ever shared. Random and per-user rows (continue watching, next up, recommendations, hidden gems, forgotten favorites, activity feed, user collections) bypass the cache. The access-scope key captures every access boundary the fetch path enforces -- section identity (type + id + config hash) + item limit + accessible and disabled libraries + max content rating + excluded media types + name prefix + allowed-content-id allowlist -- and nothing per-user, so entries are safely shared. Empty membership is never cached (avoids freezing a transiently empty rail); background refreshes are bounded by a timeout. Scale (analytical, derived from the cache behavior -- not a measured latency): for the user-agnostic rows, Postgres section-query volume collapses from O(rows x concurrent requests) to O(rows x distinct access scopes) per 15m refresh window, because most users share a handful of access scopes. Illustrative -- 40 cacheable rows on a home screen, 1000 concurrent users falling into ~5 distinct access scopes: - before: ~40 x 1000 = ~40,000 section queries per wave of home loads - after: ~40 x 5 = ~200 builds per 15m window (plus one background refresh per row per scope), i.e. a warm home load runs zero section queries for these rows. That is a ~99% reduction in shared section-query load at that concurrency; the win grows with concurrency and shrinks as access-scope diversity rises. Design/plan doc added under docs/superpowers/plans/. * perf(jellycompat): serve per-library Latest via the cached recently-added section A jellyfin-compat per-library /Items/Latest rail is the same user-agnostic list as the native "recently added" library rail -- both order by mil.first_seen_at DESC. It was rebuilt on every request through directContentService.BrowseItems, missing the resolved-list cache entirely. Route per-library Latest for movies and series libraries through the native section fetch instead, so it reuses the shared cache. HandleLatest resolves the library's type once, and for a movies/series library builds a synthetic SectionRecentlyAdded with the same type + config + limit + access scope the native rail uses and calls FetchOne; the per-user overlay (favorites, progress, episode targets, presign) is extracted into buildLatestItemDTOs and shared by both the native and BrowseItems paths, so no overlay logic is duplicated. Cached *models.MediaItem values are read-only -- LocalizeItemModels deep-copies before any presign mutation. To let the two surfaces share one entry, resolvedListCacheKey no longer includes the arbitrary section ID: every cacheable section type derives its membership from type + config + limit + scope, never from its own ID (audited all 14 cacheable types plus the library-collection path; the sole s.ID read lives in the non-cacheable user-collection branch). A native recently-added rail and the compat Latest for the same library + scope now collapse to ONE cache entry, built once and reused. Access-scope isolation is unchanged -- the removed ID never carried access information, and every access boundary (libraries, rating cap, excluded types, content allow-list, name prefix) still keys the entry. Guardrails: the native path is restricted to movies and series libraries; every other library type (ebook, music, manga, mixed) is ignored and keeps its exact BrowseItems behavior -- important because an unfiltered recently-added fetch would otherwise surface non-video items to Jellyfin clients that only expect video. Deeper pages, played-filter and backdrop-required requests, a client asking for a type other than the library's own, and any FetchOne error also fall back to BrowseItems. Chosen over an alternative that gave the synthetic section a deterministic ID (which kept two separate cache entries): both returned identical data with similar complexity, so the shared-entry design won. * fix(sections,jellycompat): post-review fixes for the shared-list cache and Latest path Consolidates fixes from the branch's adversarial review and PR #292 review comments into one commit: - Latest fast path: fall back to BrowseItems when a request carries a genre, name-prefix, or person filter (the synthetic recently-added section cannot express these, so serving it unfiltered would return a wrong, broader set). Eligibility is decided by latestFastPathEligible and covered by a test. - Clamp the /Items/Latest page size to compatBrowseMaxLimit before building the section, matching the BrowseItems fallback, so a large client Limit can't drive an oversized recently-added fetch or explode the shared cache key with unbounded ItemLimit values. - Evict expired entries from the process-global resolvedListCache: resolvedListSet sweeps expired keys at most once per minute, bounding the map to scopes seen within one TTL window. Covered by TestResolvedListCacheEvictsExpiredEntries. - Log a short digest of the cache key (resolvedListLogKey) instead of the raw key in the background-refresh panic/error paths, since the key embeds user-controlled access-scope fields such as NamePrefix. Skipped review comments (verified already fixed or stale against current code): the resume fast-path scan bound and watched-items cap (04d2e795) and the docs fence-language tags (already addressed). Build, vet, and go test -race pass for internal/sections and internal/jellycompat. * perf(plugins): cache plugin installations in-memory, invalidated on lifecycle change ## Problem Every poster/image on a warm home rail re-read plugin_installations from Postgres to answer "is this plugin enabled?" and to acquire the plugin client (Source A: metadata chain buildProviders enabled-check; Source B: ensureClient -> loadInstallation). Plugin-resolved image URLs are never URL-cached, so the plugin source and the DB read behind it fired again on every identical warm request; 100% of images in the target library are plugin-backed. ## Solution - Guarded in-memory installation cache (map[int]*Installation + RWMutex) in plugins.Service. loadInstallation reads through it; the requireEnabled gate stays after the cache read so ErrInstallationDisabled semantics are unchanged. invalidateInstallationCache clears it and is self-registered as a lifecycle hook, so Service.OnLifecycleChange wipes it on install/enable/disable/update/ uninstall. - A generation counter closes an invalidate-vs-repopulate race: captured before installations.GetByID and re-checked under the write lock, so a row fetched before a lifecycle mutation is never written into a freshly cleared cache (would otherwise resurrect a just-disabled plugin). - Route the metadata chain enabled-check through the same cache via a structural InstallationEnabledChecker interface (nil-safe: falls back to the pool query when no checker is injected), wired in cmd/silo/main.go. ## Post-review fix (auto-update reliability blocker) AutoUpdateService mutated installations (new InstallPath, old dir deleted) on the default auto update policy without firing OnLifecycleChange, leaving the cache stale and breaking plugins with "stored plugin manifest mismatch" until restart. It now takes an onChange callback wired to Service.OnLifecycleChange and fires it once per Check run that mutated a row. ## Verification go build/vet, go test ./internal/plugins/... ./internal/metadata/... (-race). Tests: cache hit/invalidation, racing-invalidation guard, IsInstallationEnabled, auto-update fires onChange. ## AI-use disclosure Implemented with AI assistance (Claude). * perf(jellycompat): batch per-item presign, and enrich series on the cached Latest path ## Problem List rails presigned each item's poster/backdrop/logo/still image individually (~160 singular resolver calls for a 40-item page where 4 batched calls suffice), and ItemsHandler carried a near-verbatim duplicate of the batch presigner. ## Solution (batching) Promote the batch presigner to a shared package-level presignCompatListItems (presign_list.go) with a generic collectImagePaths[T]; convert the per-item loops (cached home/Latest rail, favorites, batch loaders, userdata favorites) to one batched PresignImageURLsWithExpiry per image type per page; batch the season/episode collections; delete the three duplicate presign helpers. URL output is unchanged (verified byte-for-byte). ## Post-review fix (series Latest data-parity regression) The native cached Latest fast path built items via compatListItemsFromModels + buildLatestItemDTOs and never ran the series watch-state rollup, so a series library's Latest lost Played / UnplayedItemCount and page 1 disagreed with the BrowseItems fallback. enrichSeriesUserData is promoted to the ContentService interface and called on the native path (reused, not duplicated). ## Verification go build/vet, go test ./internal/jellycompat/... ./internal/catalog/... Tests: bounded presign invocation counts + per-item URL mapping; series rollup populated on the native Latest path. ## AI-use disclosure Implemented with AI assistance (Claude). * perf(sections): gate personalized rails out of the shared cache; widen refresh lead ## Problem 1. The shared home-rail cache whitelisted custom_filter/genre sections by TYPE alone, but those route through fetchFiltered -> ParseQueryDefinition and can carry personalized (per-profile) rules/sorts (watched, favorited, in_watchlist, in_progress, last_watched; sorts progress/date_viewed/plays). Their membership is per-profile yet the cache key excludes userID/profileID, so a personalized rail built for one profile was served to others in the same access scope for up to 15m -- a cross-profile watchlist/watch-state leak. 2. The background-refresh lead was tuned so steady traffic is served a warm entry from a longer soft window. ## Solution - Add QueryDefinition.IsPersonalized() (reusing the existing QueryFieldRequiresProfile/QuerySortRequiresProfile helpers). isCacheableSectionType now parses the section QueryDefinition and refuses to cache custom_filter/genre when personalized; non-personalized definitions stay cacheable. Seasonal/mood/trending build their definitions server-side and stay unconditionally cacheable. - resolvedListRefreshLead 3m -> 10m (soft threshold builtAt+5min instead of builtAt+12min). ## Verification go build/vet, go test ./internal/sections/... ./internal/catalog/... (-race). Test: personalized custom_filter/genre not cacheable; non-personalized are. ## AI-use disclosure Implemented with AI assistance (Claude). * fix(sections,metadata): post-review fixes for shared cache and plugin chain staleness Addresses three review findings on PR #292: - sections: canonicalize section config JSON before hashing so configs differing only in whitespace/field order share a cache entry (native + jellycompat rail sharing). Added TestHashSectionConfigCanonicalizes. - metadata: invalidate the resolved-chain cache on plugin lifecycle changes; the installation-enabled check already reads the invalidated plugin cache, but resolveChainCached could serve a stale provider chain for up to chainCacheTTL after a provider's availability changed. - jellycompat: move ctx to the first parameter of presignCompatListItems for consistency with the other presign helpers. Skipped the episode-image presign batching nitpick: the resolver already dedupes+singleflights, so it is a Minor perf-only item not worth the two-pass refactor risk in this pass. * fix(sections,jellycompat): harden shared rail cache and Latest fast path per review Addresses the eight findings from the deep review of this PR: - Detach the blocking cold-miss rebuild from the singleflight leader's request context (context.WithoutCancel + the shared 30s build timeout) so one client disconnect no longer fails every collapsed waiter and leaves the entry uncached. - Stop client-controlled values minting unbounded cache entries: the compat Latest fast path now always fetches a fixed 100-row budget and slices to the requested limit (one entry per scope+library instead of one per Limit value), and an unrecognized MaxOfficialRating string disqualifies the fast path instead of entering the global cache key. - Add release_date to the sections item projection/scan so movies served via the Latest fast path keep PremiereDate (Jellyfin default-set field) in parity with the BrowseItems fallback. - Fall back to per-item progress lookups when the batched leaf progress query fails, restoring one-item-at-a-time degradation instead of blanking played state for the whole page. - Derive cache eligibility from a single source of truth: fetchSection and isCacheableSectionType now share the userAgnosticSectionFetcher table, whose no-userID/profileID signature makes a fetcher drop out of the cacheable set at compile time if it ever gains per-profile inputs. - Decide Latest fast-path eligibility off the actual browse params the fallback would receive, so any filter later added to buildBrowseParams automatically disqualifies the cached path; share one compatDefaultBrowseLimit constant between both paths. - Extract AccessFilter.WriteAccessScopeCacheKey as the shared, security- critical serializer for all access-scoped caches (resolved-list, editorial candidates, audiobook groups); the editorial key now captures ExcludedMediaTypes, which its loaders already applied in SQL. - Strip leaked agent-transcript markup from the section-fetch plan doc. go build ./..., go vet, gofmt clean; go test -race on internal/sections, internal/catalog, internal/jellycompat passes (TestBeginWebOperation* failures are the known pre-existing flakes). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Quick <31828688+Quick104@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
10 KiB
Shared List Cache (Home Rails) Implementation Plan
For agentic workers: REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (
- [ ]) syntax for tracking. Commands assume the repository root is the cwd.
Goal: Cut repeated database work and tail latency on the home screen by caching the shared part of every user-agnostic home rail once per access scope, refreshing it in the background before it expires (target TTL ~15 min), and layering the cheap per-user part (watched flags, play position, poster links) on top of the cached list on every request.
Architecture: Option A — an in-process, process-global resolved-list cache inserted at the native section fetch choke point (internal/sections). The section fetcher already returns a shared, non-personalized item list; the per-user overlay is applied later in the API handler. We cache at that boundary for the wider/fuller set of user-agnostic section types (including admin-curated collections). Redis is not the store — it is an optional invalidation signal only.
Tech Stack: Go, golang.org/x/sync/singleflight (already used in internal/sections), in-process map + mutex (mirrors the existing editorialCandidateCache), existing catalog.AccessFilter, targeted Go tests.
Scope target: Native Silo sections path (internal/sections/fetcher.go + internal/api/handlers/sections.go).
Validated Direction
Confirmed directly against the code on main:
- The shared base list and the per-user overlay are already separated.
Fetcher.fetchSection(internal/sections/fetcher.go) returns raw[]*models.MediaItemand, for the user-agnostic section types, takes only the accessfilter— no user/profile. The per-user overlay (watched state, play position, presigned poster URLs, overlay badges) is applied afterward inSectionHandler.buildSectionsResponse(internal/api/handlers/sections.go) on every request. This makes the fetcher output a clean, presign-free cache boundary. - There is precedent to copy.
editorialCandidateCache(internal/sections/fetcher.go) is already an in-process TTL cache guarded by a mutex +singleflight.Group, keyed by subject/library/access-filter (never by user). It caches candidate ID lists; this plan generalizes it to a resolved item list with a short TTL and refresh-ahead. - The fetch choke point is
Fetcher.FetchOne. BothHandleHomeSections(viaFetchAll→FetchOne) andHandleHomeSectionItemsroute through it. Caching there covers the whole native home path in one place. - The cache must be process-global, not per-
Fetcher. The process constructs several independentsections.NewFetcher(...)instances (e.g. native API and recommendations). A cache stored on theFetcherstruct (aseditorialCandidateCacheis today) would be duplicated per instance and could never be shared across surfaces. A package-level cache lets any current or future consumer ofFetchOnereuse the same warm entries. Collectionis not uniformly user-agnostic.fetchCollectionserves library collections (shared) but routes tofetchUserCollectionwhencfg.UserCollectionID != ""(profile-scoped). The cache must exclude the user-collection case or it would leak one profile's list to another.
What is cached (the fuller user-agnostic set)
These rows are identical for everyone who can see the same libraries at the same content-rating cap, so they are cached by access scope:
- Recently Added (
SectionRecentlyAdded) - Recently Released / New Releases (
SectionRecentlyReleased) - Genre and custom-filter rows (
SectionGenre,SectionCustomFilter) - Trending on this server (
SectionTrendingOnServer), Most Watched (SectionMostWatched) - New to Library (
SectionNewToLibrary) - Critically Acclaimed (
SectionCriticallyAcclaimed), Award Winners (SectionAwardWinners) - Editorial Spotlight / featured (
SectionEditorialSpotlight) - Seasonal (
SectionSeasonalThemed), Mood (SectionMoodCollection), Format Showcase (SectionFormatShowcase) - Trending Discover (
SectionTrendingDiscover) - Admin-curated lists (
SectionAdminCuratedList) - Library collections only (
SectionCollectionwherecfg.UserCollectionID == "")
What is NOT cached
- Per-user rows (no shared base): Continue Watching, Next Up, Next in Series, Recommended For You / Because You Watched / Similar Users Liked / Taste Match, Hidden Gems, Forgotten Favorites, Profile Activity Feed, and user collections (
SectionCollectionwith aUserCollectionID). These bypass the cache entirely. SectionRandomis technically user-agnostic but intentionally randomized per request; caching would freeze it. Excluded to preserve behavior.
The per-user overlay always runs fresh (correctness)
Even for a cached row, each request still computes, per person: watched flags (isPlayed/UserData), play position, and freshly presigned poster URLs — all in buildSectionsResponse. The cache only stores the membership and ordering of the row (presign-free *models.MediaItem). No request ever sees another user's watched state, and no cached entry carries a poster URL that could expire mid-cache.
The access-scope cache key (security-critical)
If the key fails to capture an access boundary, the cache can serve items a user must not see. The key MUST include, and nothing that is per-user:
- Section identity: section type + section ID + a hash of the section
Config(so two genre rows with different filters never collide). - Requested
ItemLimit(row size). Callers may request different sizes for the same section; the key must separate them (or the cache must store a superset and slice down). - Access scope: sorted accessible library IDs, sorted disabled library IDs, max content rating, excluded media types, plus sort/order.
Model the string builder on the existing editorialCandidateCacheKey, extended with section ID + config hash + ItemLimit.
Background refresh before expiry (the key behavior)
Each entry stores builtAt, a soft refreshAfter (e.g. builtAt + 12min), and a hard expiresAt (e.g. builtAt + 15min). A getOrRefresh(ctx, key, loader) helper implements:
now < refreshAfter→ return cached value, do nothing.refreshAfter <= now < expiresAt→ return cached value and kick off one async rebuild viasingleflight(only one rebuild per key). The fresh value swaps in when ready.now >= expiresAt→ block on the build;singleflightcollapses concurrent blockers into one build (stampede protection).
Net effect under steady traffic: entries are refreshed ahead of expiry, so live requests are served warm and never pay the cold rebuild. An optional low-frequency sweeper can keep rarely-hit hot scopes warm.
Optional invalidation (freshness)
Newly scanned content otherwise appears up to ~15 min late in these rails — acceptable for "recently added"/"trending". Optionally subscribe to the existing Redis EventScanComplete / EventMetadataUpdated events (internal/cache) and drop affected scopes for near-instant freshness. This is a nice-to-have layered on top of the TTL, not a dependency.
File Structure
- Add
internal/sections/resolvedlistcache.go- Package-level cache:
map[string]resolvedListEntry(value = presign-free[]*models.MediaItem+TotalCount+builtAt/refreshAfter/expiresAt), guarded by async.RWMutexand a package-levelsingleflight.Group. getOrRefresh(ctx, key, ttl, refreshLead, loader)implementing serve / refresh-ahead / block-only-when-dead. Reuse thef.now()clock indirection for deterministic tests.resolvedListCacheKey(...)builder (section type + section ID + config hash +ItemLimit+ access scope), modeled oneditorialCandidateCacheKey.isCacheableSectionType(resolved)guard implementing the whitelist above, including thecfg.UserCollectionID == ""check forSectionCollectionand theSectionRandomexclusion.
- Package-level cache:
- Modify
internal/sections/fetcher.go- Wrap the user-agnostic branch of
FetchOne(and theSectionEditorialSpotlightbranch) so that cacheable section types resolve throughgetOrRefresh; everything else calls the existing loader path unchanged. - Return defensive copies so callers cannot mutate cached slices.
- Wrap the user-agnostic branch of
- Add
internal/sections/resolvedlistcache_test.go- Distinct access scopes never cross-serve (security).
SectionCollectionwith aUserCollectionIDis never cached.- Refresh-ahead returns the current value without blocking; only a fully-expired entry blocks.
- Stampede: concurrent cold requests collapse to a single loader call.
- Overlay parity: a cached row produces the same per-user response as the uncached path (drive through
buildSectionsResponseininternal/api/handlers).
No migration is planned. No plugin repo changes are planned. No client changes are planned.
Deferred (explicitly out of scope here)
- The cross-library recently-added path in
directContentService.BrowseItemsis a separate choke point with its own per-user overlay, and is a separate follow-up.
Tasks
- Add
resolvedlistcache.go(cache struct,getOrRefresh, key builder, section-type whitelist). - Wire
FetchOneto route cacheable section types through the cache; leave per-user types untouched. - Add the
SectionCollectionuser-collection exclusion andSectionRandomexclusion. - Add unit tests (scope isolation, user-collection exclusion, refresh-ahead non-blocking, stampede collapse).
- Add an overlay-parity test through
buildSectionsResponse. - (Optional) Subscribe to
EventScanComplete/EventMetadataUpdatedto invalidate affected scopes. make lint,go test ./internal/sections/... ./internal/api/...,make verify-local-paths.
Risks / follow-ups
- Security key completeness is the number-one risk; when in doubt, add a field to the key and add a scope-isolation test.
- Approximate totals: hiding watched items post-cache keeps
TotalRecordCountapproximate — already an accepted tradeoff on theisPlayedpath; unchanged here. - Staleness window up to ~15 min for newly scanned content; mitigated by the optional scan-complete invalidation.
- Memory: ~200 items × small metadata × tens of scopes is negligible; cap entry count and evict LRU as a backstop.