* feat(watchsync): sync watchlists with Trakt/Simkl/MDBList Extend the watch-providers feature to sync a user's watchlist, generalizing the existing favorites pipeline rather than duplicating it. What changed - Generalize the favorites sync into one ListKind-parameterized pipeline (internal/watchsync/lists.go) driving both favorites and watchlist; the per-favorites service methods are replaced by kind-generic ones. The shadow table watch_provider_favorite_items becomes watch_provider_list_items with a list_kind discriminator. - Providers: Trakt gains watchlist sync (/sync/watchlist, distinct from favorites); Simkl gains plan-to-watch sync; MDBList is re-mapped from favorites to watchlist (its only list is a watchlist) — its capabilities now report import_favorites=false / import_watchlist=true, and the migration re-binds existing MDBList connections. - Auto-remove watched items from the watchlist: a standalone, default-on profile preference (user_profiles.remove_watched_from_watchlist) removes a movie when watched and a series once every episode is watched. Implemented as watchstate.CompletionObserver (internal/watchlist.Maintainer), wired into the manual mark-watched, playback-stop, and jellycompat mark-played paths. - Optional MDBList sort-order mirroring: an opt-in, capability-gated toggle mirrors MDBList's watchlist order into Silo via user_watchlist.sort_index; ListWatchlist orders by sort_index then added_at, so both /api/v1/watchlist and the catalog watchlist view inherit it. - Real-time + scheduled: local add/remove pushes to connected providers immediately (removals gated by the opt-in removals toggle); the hourly job is the inbound/import + retry/reconcile path. - Web: watch-provider settings gain watchlist import/export/removals and "mirror watchlist order" toggles plus watchlist sync stats. Why - The favorites and watchlist pipelines are ~90% identical; generalizing keeps one code path (per CLAUDE.md's anti-duplication guidance) instead of cloning. API/compat - All new fields on ConnectionStatus/Capabilities/ConnectionUpdate/SyncRun and the web types are additive (Silo v1 additive-only rule). No existing field is renamed, removed, or retyped. Risks / follow-up - MDBList capability flip is intentional and client-visible: silo-android / silo-apple may need to surface MDBList under the watchlist (not favorites) UI. - MDBList existing users: their MDBList list previously mirrored Silo favorites and now mirrors Silo watchlist; the first post-migration sync is a union (removals default off), so nothing is destructively purged. - Order mirroring reflects the order MDBList returns from /watchlist/items (couldn't confirm against their docs — Cloudflare-blocked); if it ever diverges from the UI sort, a sort param is the small follow-up. Tests: new maintainer (auto-remove) and watchlist-order unit tests; provider + service tests updated. go build, go test (affected pkgs), migrate-validate, verify-local-paths, web prettier/eslint/tsc all pass. AI-use disclosure: implemented with Claude Code (Claude Opus 4.8). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(watchsync): update list shadow table references * fix(watchsync): address review — retry/progress + error propagation Addresses CodeRabbit review on #227: - maintainer: propagate transient catalog lookup errors instead of silently treating every items.GetByID failure as "maybe an episode". - exportList: mark every queued item not confirmed sent (not_found, failed, or omitted) so the pending loop always advances; the next run's upsert clears the error and re-attempts, so transient failures still retry. - removePendingListItems + realtime removal: treat Sent and NotFound as reconciled; leave true failures pending (no last_error, which would strand them from the removal query) so the scheduled run retries, using in-memory dedupe to terminate the loop. - exportLocalListItems: send the normalized items (with computed ProviderItemKey), not the original event slice. - UpdateConnection: clear mirrored watchlist order before persisting the disable and propagate failures, so a failed clear can't report "disabled" while sort_index ordering is still active. - web: include favorite + watchlist removal counts in the exported "sent" total. - test: align serviceFakeRepo list-state with Postgres (clear last_error on successful transitions); add maintainer error-propagation test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
56 lines
2.1 KiB
Go
56 lines
2.1 KiB
Go
package catalog
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func normalizePredicateSQL(s string) string {
|
|
return strings.Join(strings.Fields(s), " ")
|
|
}
|
|
|
|
func TestOrphanedProvisionalPredicatePreservesDurableMediaItemReferences(t *testing.T) {
|
|
predicate := normalizePredicateSQL(orphanedProvisionalMediaItemPredicate)
|
|
for _, want := range []string{
|
|
"public.abs_bookmarks ab WHERE ab.library_item_id = mi.content_id",
|
|
"public.abs_playback_sessions aps WHERE aps.content_id = mi.content_id",
|
|
"public.abs_rss_feeds arf WHERE arf.library_item_id = mi.content_id",
|
|
"public.episodes e WHERE e.series_id = mi.content_id",
|
|
"public.podcast_feeds pf WHERE pf.media_item_id = mi.content_id",
|
|
"public.seasons s WHERE s.series_id = mi.content_id",
|
|
"public.user_audio_preferences uap WHERE uap.series_id = mi.content_id",
|
|
"public.user_home_item_dismissals uhid WHERE uhid.media_item_id = mi.content_id",
|
|
"public.user_home_item_dismissals uhid_series WHERE uhid_series.series_id = mi.content_id",
|
|
"public.user_personal_collection_items upci WHERE upci.media_item_id = mi.content_id",
|
|
"public.user_series_playback_preferences uspp WHERE uspp.series_id = mi.content_id",
|
|
"public.user_subtitle_preferences usp WHERE usp.series_id = mi.content_id",
|
|
"public.watch_provider_list_items wpli WHERE wpli.media_item_id = mi.content_id",
|
|
} {
|
|
if !strings.Contains(predicate, normalizePredicateSQL(want)) {
|
|
t.Fatalf("cleanup predicate missing durable reference guard %q", want)
|
|
}
|
|
}
|
|
for _, droppedTable := range []string{
|
|
"abs_collection_items",
|
|
"abs_playlist_items",
|
|
"abs_playlists",
|
|
"watch_provider_favorite_items",
|
|
} {
|
|
if strings.Contains(predicate, droppedTable) {
|
|
t.Fatalf("cleanup predicate must not reference dropped legacy table %q", droppedTable)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestOrphanedProvisionalCleanerDeleteQueryReturnsIDsForSearchIndexCleanup(t *testing.T) {
|
|
query := normalizePredicateSQL(deleteOrphanedProvisionalBatchSQL)
|
|
for _, want := range []string{
|
|
"DELETE FROM public.media_items mi",
|
|
"RETURNING mi.content_id",
|
|
} {
|
|
if !strings.Contains(query, want) {
|
|
t.Fatalf("orphaned provisional cleanup delete query missing %q: %s", want, query)
|
|
}
|
|
}
|
|
}
|