* feat(observability): OpenTelemetry logs+traces with secret redaction Part of #265. Adds opt-in OpenTelemetry (logs + traces) alongside the existing stderr + opslog pipeline, plus secret redaction on all sinks. Default-off: with no OTEL_* / SILO_OTEL_ENABLED config, behavior is unchanged. Bootstrap (internal/telemetry): - Setup() builds one shared resource, a TracerProvider (parent-based trace-id ratio sampler), a LoggerProvider, and the W3C TraceContext+Baggage propagator from env. It installs NO MeterProvider — metrics stay on Prometheus, and the built-in no-op global MeterProvider keeps the trace instrumentation libs from double-emitting. Shutdown is deferred with a flush timeout. - Logs are bridged via otelslog fan-out (slog.MultiHandler), level-gated by the shared LevelVar and best-effort so a failing collector can't break the console or DB branches. stderr + opslog stay untouched. Secret redaction (internal/logredact): - A slog.Handler masks secret-keyed attributes (password, token, api_key, authorization, cookie, ...) — including .With-bound attrs, nested groups, secret-keyed group subtrees, and values behind a LogValuer — on the console and OTLP sinks, with a no-op fast path when a record has no secret keys. opslog.shouldRedact delegates to logredact.SecretKey so all sinks share one marker list. Rotation is infra-managed (no custom file sink): container runtime for stderr, collector/backend for OTLP, opslog partition-pruning for the DB. Documented in docs/architecture/observability.md. Verification: go build ./..., go vet, gofmt -l — clean; go test ./internal/telemetry/ ./internal/logredact/ -race pass. AI-use disclosure: implemented with AI assistance (Claude Code), including adversarial reviews that hardened the bootstrap and fixed two redaction leak paths; reviewed by the author. * refactor(observability): slog context+component sweep, sloglint gate (phase 3) Part of #265. Builds on the OTel bootstrap + redaction commit. Standardizes every log call site onto the context-carrying slog variants so records correlate with the active OpenTelemetry trace, and locks the standard in with a machine gate so future code (human- or AI-authored) can't drift back. - Call-site sweep: converted the remaining slog.<Level>(...) calls to the slog.<Level>Context(ctx, ...) form wherever a context.Context is in scope (background/init calls with no ctx are left as-is), across 183 files. Applied via a type-aware AST codemod. Log levels and message strings are preserved verbatim; a component attr (canonical per-package name) is added to direct package-level slog calls. Bound-logger calls keep their existing .With bindings. The main.go and telemetry package conversions rode with their file in the previous commit to keep each file within a single commit. - Enforcement (.golangci.yml): enable sloglint with context=scope, static-msg, key-naming-case=snake, no-mixed-args. After the sweep all four report zero violations repo-wide (tests included), so make lint / CI now blocks any regression to the non-context form. The gate ships with the sweep because it cannot be green until the legacy sites are converted. Metrics remain on Prometheus; no behavior change to /metrics or Grafana. Verification: go build ./..., go vet ./..., gofmt -l — clean; sloglint (all 4 rules) 0 violations repo-wide; log levels verified unchanged. AI-use disclosure: implemented with AI assistance (Claude Code), including the codemod; reviewed by the author. * fix(observability): honor per-signal OTLP protocol and secret WithGroup names Two Codex review findings on PR #290: - telemetry: OTEL_EXPORTER_OTLP_{TRACES,LOGS}_PROTOCOL now override the generic OTEL_EXPORTER_OTLP_PROTOCOL per signal, so mixed collector setups (e.g. HTTP logs + gRPC traces) build the right exporter. - logredact: entering a group whose name is secret-bearing (e.g. WithGroup("authorization")) now masks every leaf in that subtree, matching how slog.Group("authorization", ...) is masked as a whole. * fix(observability): address review feedback on telemetry bootstrap - Telemetry setup failure no longer kills boot: Setup returns usable no-op providers alongside the error and main logs and continues with telemetry disabled, honoring the best-effort contract. - Honor OTEL_TRACES_SAMPLER (always_on/off, traceidratio, parentbased_* variants); unsupported values fall back to parentbased_traceidratio. - Attach node identity as semconv service.instance.id instead of the non-semconv node.name. - Rename opslog retention-scope log attrs to target_component/target_level so they no longer collide with the canonical component routing key, and tag those lines with component=opslog. - Fix stale levelGated comment casing; use WarnContext in the telemetry shutdown defer; document the LogValuer double-resolve on the redaction slow path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Quick <31828688+Quick104@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
116 lines
3.2 KiB
Go
116 lines
3.2 KiB
Go
package nodepool
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"log/slog"
|
|
"net/http"
|
|
"sync"
|
|
"time"
|
|
)
|
|
|
|
// healthResponse is the JSON response from a node's /health endpoint.
|
|
type healthResponse struct {
|
|
Status string `json:"status"`
|
|
ActiveJobs int `json:"active_jobs"`
|
|
EgressKbps int `json:"egress_kbps"`
|
|
}
|
|
|
|
// CheckNode pings a node's /health endpoint and returns its health status,
|
|
// active job count, and reported egress bandwidth.
|
|
func CheckNode(ctx context.Context, n *Node) (healthy bool, activeJobs, egressKbps int) {
|
|
client := &http.Client{Timeout: 5 * time.Second}
|
|
ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
|
|
defer cancel()
|
|
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, n.URL+"/api/v1/health", nil)
|
|
if err != nil {
|
|
return false, 0, 0
|
|
}
|
|
|
|
resp, err := client.Do(req)
|
|
if err != nil {
|
|
return false, 0, 0
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode != http.StatusOK {
|
|
return false, 0, 0
|
|
}
|
|
|
|
var hr healthResponse
|
|
if err := json.NewDecoder(resp.Body).Decode(&hr); err != nil {
|
|
return false, 0, 0
|
|
}
|
|
|
|
return true, hr.ActiveJobs, hr.EgressKbps
|
|
}
|
|
|
|
// HealthChecker runs periodic health checks on all nodes in both pools,
|
|
// updating in-memory state and optionally persisting to the database.
|
|
type HealthChecker struct {
|
|
proxyPool *ProxyPool
|
|
transcodePool *TranscodePool
|
|
repo *Repository // may be nil (proxy/transcode modes have no DB)
|
|
interval time.Duration
|
|
}
|
|
|
|
// NewHealthChecker creates a health checker for the given pools.
|
|
func NewHealthChecker(proxyPool *ProxyPool, transcodePool *TranscodePool, repo *Repository) *HealthChecker {
|
|
return &HealthChecker{
|
|
proxyPool: proxyPool,
|
|
transcodePool: transcodePool,
|
|
repo: repo,
|
|
interval: 30 * time.Second,
|
|
}
|
|
}
|
|
|
|
// Start runs health checks in a background goroutine. Stops when ctx is cancelled.
|
|
func (hc *HealthChecker) Start(ctx context.Context) {
|
|
go func() {
|
|
hc.checkAll(ctx)
|
|
ticker := time.NewTicker(hc.interval)
|
|
defer ticker.Stop()
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
return
|
|
case <-ticker.C:
|
|
hc.checkAll(ctx)
|
|
}
|
|
}
|
|
}()
|
|
}
|
|
|
|
func (hc *HealthChecker) checkAll(ctx context.Context) {
|
|
var wg sync.WaitGroup
|
|
check := func(n *Node, applyHealth func(int, bool, int, int, time.Time)) {
|
|
wg.Go(func() {
|
|
healthy, activeJobs, egressKbps := CheckNode(ctx, n)
|
|
|
|
// Publish the result through the pool lock so readers never see
|
|
// a Node struct mutated in place (the pool swaps in a copy).
|
|
applyHealth(n.ID, healthy, activeJobs, egressKbps, time.Now())
|
|
|
|
if n.Healthy && !healthy {
|
|
slog.WarnContext(ctx, "stream node unhealthy", "component", "nodepool", "id", n.ID, "name", n.Name, "url", n.URL)
|
|
} else if !n.Healthy && healthy {
|
|
slog.InfoContext(ctx, "stream node recovered", "component", "nodepool", "id", n.ID, "name", n.Name, "url", n.URL)
|
|
}
|
|
|
|
if hc.repo != nil {
|
|
if err := hc.repo.UpdateHealth(ctx, n.ID, healthy, activeJobs, egressKbps); err != nil {
|
|
slog.ErrorContext(ctx, "failed to persist node health", "component", "nodepool", "id", n.ID, "error", err)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
for _, n := range hc.proxyPool.Nodes() {
|
|
check(n, hc.proxyPool.ApplyHealth)
|
|
}
|
|
for _, n := range hc.transcodePool.Nodes() {
|
|
check(n, hc.transcodePool.ApplyHealth)
|
|
}
|
|
wg.Wait()
|
|
}
|