866392fecd
Audiobook and ebook libraries previously never entered the Recently Added pipeline: availability detection only ran for TV/movie/mixed libraries and release_events only knew episode/movie kinds, so server channels (Discord/generic webhooks) could not announce new audiobooks or ebooks. Generalize the movie path into a flat-item-kind registry (internal/notifications/item_kind.go) driving availability detection, recording, channel toggles, payload rendering, test fixtures, and the admin backfill seeder. New kinds share a kind-discriminated item_availability table; movie_availability stays as-is. Channels gain notify_new_audiobooks/notify_new_ebooks toggles (default on, additive API fields) and embeds carry the author from item_people. Flood-safe by construction: existing libraries seed silently on their first post-upgrade full scan. Extract internal/librarykind to replace the is*LibraryType helper copies that had drifted across scanner, libraryingest, and metadata (metadata's movie check silently included mixed; now spelled explicitly). Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
80 lines
2.5 KiB
Go
80 lines
2.5 KiB
Go
package notifications
|
|
|
|
import "testing"
|
|
|
|
func TestFlatItemKindRegistry(t *testing.T) {
|
|
seenKinds := make(map[string]struct{})
|
|
for _, k := range flatItemKinds {
|
|
if _, dup := seenKinds[k.Kind]; dup {
|
|
t.Fatalf("duplicate registry kind %q", k.Kind)
|
|
}
|
|
seenKinds[k.Kind] = struct{}{}
|
|
if k.Kind == EventKindEpisode {
|
|
t.Fatal("episodes are not a flat item kind")
|
|
}
|
|
if k.ItemType == "" || k.AvailabilityTable == "" {
|
|
t.Fatalf("incomplete registry entry %+v", k)
|
|
}
|
|
if k.WantsToggle == nil || k.Selected == nil {
|
|
t.Fatalf("registry entry %q missing accessors", k.Kind)
|
|
}
|
|
}
|
|
for _, kind := range []string{EventKindMovie, EventKindAudiobook, EventKindEbook} {
|
|
if _, ok := flatKindByString(kind); !ok {
|
|
t.Errorf("flatKindByString(%q) not found", kind)
|
|
}
|
|
}
|
|
for _, kind := range []string{EventKindEpisode, "", "music"} {
|
|
if _, ok := flatKindByString(kind); ok {
|
|
t.Errorf("flatKindByString(%q) unexpectedly found", kind)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestFlatItemKindToggleAndSelectionMapping(t *testing.T) {
|
|
// Each kind's channel toggle and ingest-scope flag must read its own
|
|
// field, not a neighbor's.
|
|
toggles := map[string]ServerChannel{
|
|
EventKindMovie: {NotifyNewMovies: true},
|
|
EventKindAudiobook: {NotifyNewAudiobooks: true},
|
|
EventKindEbook: {NotifyNewEbooks: true},
|
|
}
|
|
selections := map[string]AvailabilityKinds{
|
|
EventKindMovie: {Movies: true},
|
|
EventKindAudiobook: {Audiobooks: true},
|
|
EventKindEbook: {Ebooks: true},
|
|
}
|
|
for _, k := range flatItemKinds {
|
|
for kind, ch := range toggles {
|
|
if got, want := k.WantsToggle(ch), kind == k.Kind; got != want {
|
|
t.Errorf("kind %q WantsToggle(channel with only %q on) = %v, want %v",
|
|
k.Kind, kind, got, want)
|
|
}
|
|
}
|
|
for kind, sel := range selections {
|
|
if got, want := k.Selected(sel), kind == k.Kind; got != want {
|
|
t.Errorf("kind %q Selected(scope with only %q on) = %v, want %v",
|
|
k.Kind, kind, got, want)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSampleContentGroupsCoverEveryKind(t *testing.T) {
|
|
groups := sampleContentGroups()
|
|
if len(groups) != len(flatItemKinds)+1 {
|
|
t.Fatalf("got %d sample groups, want %d", len(groups), len(flatItemKinds)+1)
|
|
}
|
|
for i, k := range flatItemKinds {
|
|
if groups[i].Kind != k.Kind {
|
|
t.Errorf("sample group %d kind = %q, want %q", i, groups[i].Kind, k.Kind)
|
|
}
|
|
if groups[i].Meta.Title == "" {
|
|
t.Errorf("sample group %d missing title", i)
|
|
}
|
|
}
|
|
if groups[len(groups)-1].Kind != EventKindEpisode {
|
|
t.Fatalf("last sample group should be the episode fixture, got %q", groups[len(groups)-1].Kind)
|
|
}
|
|
}
|