* docs(markers): design + implementation plans for multi-source markers & TheIntroDB contribution * fix(markers): TheIntroDB read-path correctness (TVDB, real confidence, best candidate) Honor TVDB ids in /media lookups (previously dropped — anime/TheTVDB-first libraries got no markers), decode and use the real per-segment confidence and submission_count instead of a hardcoded 0.9, and pick the most-submitted / highest-confidence candidate when several are returned. Adds httptest coverage for the introdb client and provider. Phase 1 of docs/superpowers/plans/2026-06-06-marker-sources-and-contribution-implementation.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(markers): multi-source dispatch, per-provider config, per-segment provenance Add marker_provider_config (per-provider fetch enable/priority + contribute gates, contribution off by default) and a cached ProviderConfigStore. Add Registry.FetchMerged: query all fetch-enabled providers concurrently and keep the best candidate per segment (submission_count, then confidence, then fetch priority), stamping each winning marker with its provider/algorithm. Thread per-segment provenance through MarkerUpdatePayload and scanner.MarkerUpdate (additive SegmentProvenance overrides) so a merged result writes correct per-segment provider/confidence/algorithm; the legacy shared columns keep a summary. The lazy-playback path now uses FetchMerged. With only TheIntroDB enabled, behavior is unchanged. Phase 2 of docs/superpowers/plans/2026-06-06-marker-sources-and-contribution-implementation.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(markers): TheIntroDB submission client, contribution audit, service engine Add a markers.Submitter capability and implement it on the introdb provider (POST /v3/submit, GET /v3/user/stats; key required, usage-limit aware, applies the null start/end conventions). Add the marker_contributions audit table and a value-hash-keyed ContributionStore for idempotency. Add ContributionService: resolves enabled submitter providers, gates eligibility (never re-submit online-sourced markers; auto runs require contribute_auto_local + scanner-intro above the per-provider confidence threshold), checks idempotency, submits, and records. Wired in main.go; no trigger yet (admin API and task follow). Phase 3 of docs/superpowers/plans/2026-06-06-marker-sources-and-contribution-implementation.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(api): admin marker editing, contribution, and provider config endpoints Add the RequireAdmin marker API: GET/PUT /admin/files/{id}/markers (read with provenance; manual upsert where a segment object sets and null clears), DELETE .../markers/{segment}, POST .../contribute and GET .../contributions, plus GET/PUT /admin/markers/providers[/{provider}] and a .../validate key-check returning user stats. Manual writes go through the priority-gated UpsertMarkers (source=manual) and notify live sessions; a new FileRepository.ClearMarkers nulls a segment's columns. Validation mirrors the contribution rules. Phase 4 of docs/superpowers/plans/2026-06-06-marker-sources-and-contribution-implementation.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(markers): daily auto-contribution task for local intro markers Add ContributeMarkersTask (daily 04:00, after local detection): when a provider has contribute_enabled + contribute_auto_local, page through episode files with a scanner intro marker at/above the provider's confidence threshold (new ContributionStore.CandidateLocalIntroFiles keyset query) and run them through ContributionService with Auto=true. No-op when no provider opts in; idempotent and resumable across runs. Phase 5 of docs/superpowers/plans/2026-06-06-marker-sources-and-contribution-implementation.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(intromarkers): refine chromaprint starts with dialogue cues * feat(markers): finish marker management backend * feat(web): add marker editing UI * feat(markers): use plugin marker providers * fix(markers): address PR review feedback * feat(player): show marker labels on seek hover * fix(markers): type nullable marker mutation params * feat(markers): audit marker edits and add permission --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
114 lines
3.9 KiB
Go
114 lines
3.9 KiB
Go
package playback
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"github.com/Silo-Server/silo-server/internal/models"
|
|
)
|
|
|
|
func TestMarkerUpdateNotifierTargetsMatchingSessions(t *testing.T) {
|
|
sessions := NewSessionManager(0, 0)
|
|
matchA, _ := sessions.StartSession(1, "profile-a", 100, PlayDirect, false)
|
|
matchB, _ := sessions.StartSession(2, "profile-b", 100, PlayDirect, false)
|
|
matchRequested, _ := sessions.StartSessionWithFiles(4, "profile-d", 200, 100, PlayDirect, false)
|
|
other, _ := sessions.StartSession(3, "profile-c", 101, PlayDirect, false)
|
|
|
|
_ = sessions.SetRealtimeConnection(matchA.ID, true)
|
|
_ = sessions.SetRealtimeConnection(matchB.ID, true)
|
|
_ = sessions.SetRealtimeConnection(matchRequested.ID, true)
|
|
_ = sessions.SetRealtimeConnection(other.ID, true)
|
|
|
|
hub := NewRealtimeHub()
|
|
connA := &dispatchTestConn{}
|
|
connB := &dispatchTestConn{}
|
|
connRequested := &dispatchTestConn{}
|
|
connOther := &dispatchTestConn{}
|
|
regA := hub.Register(matchA.ID, connA)
|
|
regB := hub.Register(matchB.ID, connB)
|
|
regRequested := hub.Register(matchRequested.ID, connRequested)
|
|
regOther := hub.Register(other.ID, connOther)
|
|
defer hub.Unregister(regA)
|
|
defer hub.Unregister(regB)
|
|
defer hub.Unregister(regRequested)
|
|
defer hub.Unregister(regOther)
|
|
|
|
introStart := 12.0
|
|
introEnd := 75.0
|
|
creditsStart := 3600.0
|
|
creditsEnd := 3660.0
|
|
notifier := NewMarkerUpdateNotifier(sessions, hub)
|
|
notifier.MarkersUpdated(context.Background(), &models.MediaFile{
|
|
ID: 100,
|
|
IntroStart: &introStart,
|
|
IntroEnd: &introEnd,
|
|
CreditsStart: &creditsStart,
|
|
CreditsEnd: &creditsEnd,
|
|
})
|
|
|
|
if len(connA.messages) != 1 {
|
|
t.Fatalf("matching session A messages = %d, want 1", len(connA.messages))
|
|
}
|
|
if len(connB.messages) != 1 {
|
|
t.Fatalf("matching session B messages = %d, want 1", len(connB.messages))
|
|
}
|
|
if len(connRequested.messages) != 1 {
|
|
t.Fatalf("requested-file session messages = %d, want 1", len(connRequested.messages))
|
|
}
|
|
if len(connOther.messages) != 0 {
|
|
t.Fatalf("non-matching session messages = %d, want 0", len(connOther.messages))
|
|
}
|
|
|
|
event, ok := connA.messages[0].(EventEnvelope)
|
|
if !ok {
|
|
t.Fatalf("message type = %T, want EventEnvelope", connA.messages[0])
|
|
}
|
|
if event.Type != RealtimeMessageTypeEvent || event.Name != RealtimeEventMarkersUpdated {
|
|
t.Fatalf("event = %#v, want markers updated event", event)
|
|
}
|
|
|
|
var payload MarkersUpdatedPayload
|
|
if err := json.Unmarshal(event.Payload, &payload); err != nil {
|
|
t.Fatalf("json.Unmarshal(payload): %v", err)
|
|
}
|
|
if payload.SessionID != matchA.ID || payload.FileID != 100 {
|
|
t.Fatalf("payload = %#v, want session/file identifiers", payload)
|
|
}
|
|
if payload.Intro == nil || payload.Intro.Start != introStart || payload.Intro.End != introEnd {
|
|
t.Fatalf("payload.Intro = %#v, want intro range", payload.Intro)
|
|
}
|
|
if payload.Credits == nil || payload.Credits.Start != creditsStart || payload.Credits.End != creditsEnd {
|
|
t.Fatalf("payload.Credits = %#v, want credits range", payload.Credits)
|
|
}
|
|
}
|
|
|
|
func TestMarkerUpdateNotifierSendsAllClearedMarkers(t *testing.T) {
|
|
sessions := NewSessionManager(0, 0)
|
|
session, _ := sessions.StartSession(1, "profile-a", 100, PlayDirect, false)
|
|
_ = sessions.SetRealtimeConnection(session.ID, true)
|
|
|
|
hub := NewRealtimeHub()
|
|
conn := &dispatchTestConn{}
|
|
reg := hub.Register(session.ID, conn)
|
|
defer hub.Unregister(reg)
|
|
|
|
notifier := NewMarkerUpdateNotifier(sessions, hub)
|
|
notifier.MarkersUpdated(context.Background(), &models.MediaFile{ID: 100})
|
|
|
|
if len(conn.messages) != 1 {
|
|
t.Fatalf("messages = %d, want 1 all-cleared marker update", len(conn.messages))
|
|
}
|
|
event, ok := conn.messages[0].(EventEnvelope)
|
|
if !ok {
|
|
t.Fatalf("message type = %T, want EventEnvelope", conn.messages[0])
|
|
}
|
|
var payload MarkersUpdatedPayload
|
|
if err := json.Unmarshal(event.Payload, &payload); err != nil {
|
|
t.Fatalf("json.Unmarshal(payload): %v", err)
|
|
}
|
|
if payload.Intro != nil || payload.Credits != nil || payload.Recap != nil || payload.Preview != nil {
|
|
t.Fatalf("payload markers = %#v, want all nil", payload)
|
|
}
|
|
}
|