silo-server/internal/plugins/builtin_guard_test.go

package plugins

import (
	"context"
	"errors"
	"os"
	"testing"
	"time"

	"github.com/jackc/pgx/v5/pgxpool"
)

func TestInstallationIsBuiltin(t *testing.T) {
	if (&Installation{Kind: KindBuiltin}).IsBuiltin() != true {
		t.Error("kind=builtin must report IsBuiltin")
	}
	if (&Installation{Kind: KindPlugin}).IsBuiltin() {
		t.Error("kind=plugin must not report IsBuiltin")
	}
	if (&Installation{}).IsBuiltin() {
		t.Error("zero-value kind must not report IsBuiltin")
	}
}

// The reserved builtin plugin id must be rejected at install time so a
// malicious or accidental catalog entry cannot hijack the reserved row.
func TestReservedPluginIDRejected(t *testing.T) {
	if !isReservedPluginID("silo.builtin") {
		t.Error("silo.builtin must be reserved")
	}
	if isReservedPluginID("silo.tmdb") || isReservedPluginID("silo.tvdb") {
		t.Error("first-party plugin ids must stay installable")
	}
	if isReservedPluginID("community.example") {
		t.Error("community plugin ids must stay installable")
	}
}

// PreloadEnabled must skip builtin installations explicitly: the sentinel
// install path has no manifest on disk, and without the skip preload would
// fail (its caller is log.Fatalf) or at best emit spurious warnings.
func TestPreloadEnabledSkipsBuiltinInstallation(t *testing.T) {
	store := newFakeServiceInstallationStore(&Installation{
		ID:          1,
		PluginID:    "silo.builtin",
		Kind:        KindBuiltin,
		Enabled:     true,
		InstallPath: "/nonexistent/silo-builtin",
	})
	svc := &Service{installations: store}

	if err := svc.PreloadEnabled(context.Background()); err != nil {
		t.Fatalf("PreloadEnabled with builtin-only store = %v, want nil (builtin must be skipped)", err)
	}
}

// InstallationStore.Delete must reject builtin rows at the store layer: the
// delete cascades through every NFO chain row and RemoveAlls the install dir.
func TestInstallationStoreDeleteRejectsBuiltin(t *testing.T) {
	pool := builtinGuardTestPool(t)
	ctx := context.Background()

	id := seedBuiltinTestInstallation(t, pool, "test.builtin.delete")

	store := NewInstallationStore(pool)
	err := store.Delete(ctx, id)
	if err == nil {
		t.Fatal("Delete(builtin) = nil, want error")
	}
	if !errors.Is(err, ErrBuiltinInstallationImmutable) {
		t.Fatalf("Delete(builtin) error = %v, want ErrBuiltinInstallationImmutable", err)
	}

	var count int
	if qErr := pool.QueryRow(ctx, `SELECT COUNT(*) FROM plugin_installations WHERE id = $1`, id).Scan(&count); qErr != nil {
		t.Fatalf("count row: %v", qErr)
	}
	if count != 1 {
		t.Fatalf("builtin row count after rejected delete = %d, want 1", count)
	}
}

func builtinGuardTestPool(t *testing.T) *pgxpool.Pool {
	t.Helper()
	dsn := os.Getenv("SILO_TEST_DATABASE_URL")
	if dsn == "" {
		t.Skip("SILO_TEST_DATABASE_URL is not set")
	}
	pool, err := pgxpool.New(context.Background(), dsn)
	if err != nil {
		t.Fatalf("connect test database: %v", err)
	}
	t.Cleanup(pool.Close)
	return pool
}

func seedBuiltinTestInstallation(t *testing.T, pool *pgxpool.Pool, pluginID string) int {
	t.Helper()
	var id int
	err := pool.QueryRow(context.Background(),
		`INSERT INTO plugin_installations (plugin_id, version, install_path, enabled, update_policy, kind)
		 VALUES ($1, '0', '/nonexistent/silo-builtin-test', true, 'manual', 'builtin')
		 RETURNING id`, pluginID+time.Now().UTC().Format("-20060102150405.000000000")).Scan(&id)
	if err != nil {
		t.Fatalf("seed builtin installation: %v", err)
	}
	t.Cleanup(func() {
		_, _ = pool.Exec(context.Background(), `DELETE FROM plugin_installations WHERE id = $1`, id)
	})
	return id
}