Files
silo-server/migrations/sql/20260701170000_push_delivery_attempts.sql
cf0db385f3 Add Apple push notifications support (#255)
* Add push notifications support

* fix(notifications): address push notification review findings

- Gate the capability endpoint's apple_push availability on the admin
  delivery toggle, matching web push: Available now means setup will
  actually deliver.
- Reject direct admin writes to push_relay_deployment_id/api_key; the
  relay issues them as a pair during registration and a lone write
  desyncs them (and poisons the next rotation request).
- Purge a device's registrations under other profiles when it
  re-registers, so a profile switch on a shared device stops the old
  profile's pushes (attempts cascade); adds a DB-backed test.
- Extract the shared channelDispatcher core + retry sweep and rebuild
  the webhook/web push/Apple push dispatchers on it instead of keeping
  three copies of the worker-pool/retry loop.
- Deduplicate relay URL validation (admin setting + register flow) and
  the push outbox attempt-building loops behind shared helpers.
- Cap free-text decline reasons in notification display bodies.
- Fix TestHandleApplePushDisplayDB expectations to match the shared
  display copy (test previously failed under SILO_TEST_DATABASE_URL).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(notifications): route push relay URL writes through registration only

Direct writes to notifications.push_relay_url via the admin settings
endpoint bypassed the relay registration flow, letting the stored URL
drift out of sync with the deployment id / API key pair the relay
minted for it. Reject the URL alongside the deployment id and API key
in the settings handler; POST /admin/notifications/push/relay/register
remains the only path that persists all three together.

The admin UI's Relay URL field now edits local draft state and is
applied by the Register/Rotate action instead of the settings save.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-01 17:25:16 -04:00

46 lines
2.1 KiB
SQL

-- +goose Up
-- +goose StatementBegin
CREATE TABLE public.push_delivery_attempts (
id text PRIMARY KEY,
notification_delivery_id text REFERENCES public.notification_deliveries(id) ON DELETE CASCADE,
push_device_id text NOT NULL REFERENCES public.push_devices(id) ON DELETE CASCADE,
trigger_type text NOT NULL DEFAULT 'delivery',
provider text NOT NULL,
platform text NOT NULL,
attempt_number integer NOT NULL DEFAULT 0,
attempted_at timestamptz NOT NULL DEFAULT now(),
next_retry_at timestamptz,
outcome text NOT NULL DEFAULT 'pending',
relay_request_id text,
upstream_status integer,
upstream_reason varchar(256),
failure_message varchar(256),
created_at timestamptz NOT NULL DEFAULT now(),
updated_at timestamptz NOT NULL DEFAULT now(),
CONSTRAINT push_delivery_attempts_trigger_check CHECK (trigger_type IN ('delivery', 'test')),
CONSTRAINT push_delivery_attempts_delivery_required_check CHECK (
(trigger_type = 'delivery' AND notification_delivery_id IS NOT NULL)
OR trigger_type = 'test'
),
CONSTRAINT push_delivery_attempts_provider_check CHECK (provider IN ('silo_relay')),
CONSTRAINT push_delivery_attempts_platform_check CHECK (platform IN ('apple')),
CONSTRAINT push_delivery_attempts_outcome_check CHECK (outcome IN ('pending', 'delivered', 'retrying', 'failed'))
);
CREATE UNIQUE INDEX push_delivery_attempts_delivery_unique
ON public.push_delivery_attempts (push_device_id, notification_delivery_id, attempt_number)
WHERE notification_delivery_id IS NOT NULL;
CREATE INDEX push_delivery_attempts_delivery_idx
ON public.push_delivery_attempts (notification_delivery_id)
WHERE notification_delivery_id IS NOT NULL;
CREATE INDEX push_delivery_attempts_retry_idx
ON public.push_delivery_attempts (outcome, next_retry_at);
CREATE INDEX push_delivery_attempts_device_history_idx
ON public.push_delivery_attempts (push_device_id, attempted_at DESC);
-- +goose StatementEnd
-- +goose Down
-- +goose StatementBegin
DROP TABLE IF EXISTS public.push_delivery_attempts;
-- +goose StatementEnd