Files
silo-server/internal/scanner/probe.go
T
854d07cf8f feat(playback): add protocol v3 planning and recovery (#398)
* docs(playback): plan protocol v3 server implementation

* docs(playback): incorporate protocol v3 review

* feat(playback): implement protocol v3 server

* fix(playback): persist empty route diagnostics

* feat(playback): harden protocol v3 HDR routing

* feat(playback): complete protocol v3 client contract

* fix(playback): harden protocol v3 recovery

* fix(playback): restore dovi_rpu strip filter for DV remuxes

The v3 work renamed the Dolby Vision strip recipe to a dovi_split=mode=bl
bitstream filter that does not exist in stock FFmpeg or jellyfin-ffmpeg;
the probe failed closed on every deployment, disabling the new validated
DV7-to-HDR10 route and regressing the previously working dovi_rpu=strip=1
remux path from main. Restore dovi_rpu across the probe, remux and HLS
copy arguments, and the recipe-card constant.

Also from review: validate the remux DV mode for every profile (garbage
modes on non-P7 sources silently no-opped), reject preserve mode for P7
outright (a base-layer-only remux cannot preserve dual-layer DV), tag
dvhe sample entries only for the explicit v3 preserve recipe so legacy
web/jellycompat remuxes keep their pre-v3 hev1 labeling, and honor the
token-frozen DV mode in the proxy remux path instead of legacy-auto.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(playback): correct v3 planner policy and contract validation

Review fixes to the v3 planner and wire contracts:

- Bar Profile 7 sources from the non-strip progressive remux route: a
  base-layer-only remux can never deliver native dual-layer DV, so the
  planner no longer emits plans claiming validated Dolby Vision while
  the executed remux drops the enhancement layer.
- Accept the device-quirks feature flag from either capability location,
  matching every other dual-location feature check.
- Treat legacy hdr_unknown rows as HDR10 for HDR10-capable clients with
  a degradation warning instead of leaving them unplayable under v3.
- Honor bandwidth_cap_kbps as a hard ceiling in every quality mode and
  wire the previously dead Metered signal into conservative auto rungs.
- Degrade to the validated source-quality route instead of a terminal
  when only an implicit quality reduction demanded an unsupported
  transcode; explicit user-selected rungs keep terminal behavior.
- Bound inner capability lists and strings; compare attempt keys exactly
  instead of case-folded; make ParseTrackIDV3 strict about canonical
  numerics; accept dvdsub/pgssub/dvbsub aliases and stop promising
  burn-in for unknown subtitle codecs; probe every h264 encoder rather
  than requiring libx264; normalize the file-level bitrate fallback.
- Evaluate subtitle renderability against the engine each candidate
  route executes on, not always media3_direct.
- Pin the with-quirks attempt-key preimage arity in the cross-language
  fixture so the Kotlin client stays in lockstep.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(playback): harden v3 control-plane reliability

Review fixes to the v3 session, store, and handler layer:

- Bound concurrent replans with a slot semaphore: each replan pins a
  pooled connection for its advisory lock while issuing further store
  queries from the same pool, so an unbounded recovery storm could turn
  every connection into a lock holder and deadlock the server.
- Make CompleteReplan a real compare-and-swap (base-revision predicate,
  ErrReplanSupersededV3) and map BeginReplan insert races to a replay
  instead of a raw unique violation.
- Fingerprint start requests (request_digest column): an attempt ID
  reused with different input is now a 409-style conflict rather than a
  silent replay, and both replay paths check session liveness so dead
  sessions surface as retryable terminals.
- Pre-delete expired attempt rows on SaveAttempt so a retry during the
  cleanup window cannot wedge on an unreachable conflict.
- Align the in-memory store's semantics with Postgres and add DB-backed
  planstore tests (SILO_TEST_DATABASE_URL), including a regression test
  inserting every route-event name against the real CHECK constraint.
- Session manager: v3 route-set updates own RemuxDVMode outright so a
  replan onto an SDR source clears a stale strip mode; replacement
  reservations survive unrelated legacy stream updates; replacement
  admission excludes the replaced session explicitly instead of
  decrementing totals it may no longer be part of; the admission CAS
  loop is bounded and decider errors are logged.
- Map transient store failures to 500s instead of terminal 404/403s;
  authorize route events via identity-only projections after the rate
  limiter; keep sanitized diagnostics deterministic.
- Merge the server-computed durable plan key into replan exclusions so
  unreproducible client history cannot re-select the failed route.
- Remap tracks only when the effective edition changes (a same-file
  replan no longer switches audio to a lookalike track) and remap
  ID-only subtitle selections on edition fallback.
- Cache the v3/shadow feature flags for five seconds instead of one
  settings SELECT per playback request; stop remote transports
  best-effort when the start call times out; carry dvm/tid claims and
  the transport-scoped job identity through the legacy audio-change
  re-mint; index playback_route_events(received_at) for the retention
  delete; run store maintenance for DB-less deployments too.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(transcode): reap idle node jobs and gate WebVTT conversion

- Add an idle reaper to the transcode node: a job untouched by manifest
  or segment requests for ten minutes is closed and unregistered. After
  a v3 replan retires a transport ID, a stale in-flight stream token
  could resurrect the old job via reconstruct and encode to end-of-file
  for nobody; jobs waiting on readiness count registration as access
  and are never reaped mid-wait, and reaping keeps the recipe so a
  still-valid token reconstructs on the next hit.
- Reject bitmap subtitle tracks (PGS) on the .vtt conversion path with
  415 before headers are written instead of spawning an ffmpeg command
  that always fails mid-response, and make the extract-format override
  fall back to source-driven mapping for bitmap codecs.
- Drain error bodies on non-202 node responses so the HTTP transport
  can reuse connections.
- Pin the transcode-dir cleanup separator-boundary semantics with a
  regression test (a session ID sharing another's prefix must not
  retain foreign directories).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(playback): close v3 planner policy gaps from review

- Clamp the final transcode bitrate to bandwidth_cap_kbps: the ladder has
  no rung below 480p/1500kbps, so lower caps were silently exceeded even
  though the cap is documented as a hard delivery ceiling.
- Treat video-only media as audio-compatible instead of forcing an AAC
  conversion (or an audio_conversion_unsupported terminal) onto a file
  with no audio stream. Tracks whose codec failed to probe keep the gate.
- Only promise a bitmap subtitle sidecar for embedded PGS with an engine
  that renders embedded bitmap: external/downloaded bitmap and embedded
  DVD/DVB published artifact URLs that always failed at fetch. They now
  fall through to burn-in or its terminal.
- Accept client_video_transformations_v1 from either client_features or
  the nested context when validating client-executor transformations,
  matching the planner's dual-source reads.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(playback): probe and execute DV remuxes with one ffmpeg binary

The v3 transformation registry probed the configured playback.ffmpeg_path
while progressive remux execution resolved the process-global discovery
path, so a deployment where only one binary carries dovi_rpu could plan a
server_dv7_to_hdr10 route and then fail it at stream time. Resolution now
goes through a shared ResolveFFmpegPath (configured path first, discovery
fallback — the same rule the transcode pipeline already used), the
dovi_rpu probe is cached per binary path, and the stream handler and proxy
worker pass their configured path into ServeRemuxWithDVMode.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(playback): harden v3 replan identity and control-plane limits

- Seed failure-replan track selections from the durable current plan
  before overlaying the request: after an alternate-version fallback the
  normalized request still carries requested-edition track IDs, so a
  replan omitting unchanged tracks was rejected as a track/file mismatch.
- Remap ID-only audio selections across edition changes (parse the ID to
  an index like the subtitle remap already does) instead of leaving a
  stale file-bound ID to fail validation.
- Release the node planner reservation when a prepared remote transport
  rolls back after the node accepted the job; repeated failed starts
  could otherwise pin max-job/bandwidth budgets for the full reservation
  age.
- Size the replan semaphore below the PostgreSQL pool via a store
  capacity advisor: with max_connections at or below the fixed bound,
  advisory-lock holders could starve the inner store queries they need
  to finish.
- Contain shadow-planner panics with a recover boundary; it runs on a
  bare goroutine where an escaped panic kills the process for what is
  telemetry-only work. Document why the memory store's session lock is
  deliberately a no-op.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(transcode): serialize node job teardown against reconstructs

- Look up and touch manifest/segment sessions in one critical section so
  the idle reaper cannot unregister a job between the lookup and its
  liveness refresh.
- Re-validate each reap candidate under the per-session lifecycle lock
  before closing it: Close removes the output directory, and without the
  lock it could race a token reconstruct and wipe the segments the fresh
  ffmpeg is writing.
- Take the lifecycle lock in handleStop so a stop racing a RequireReady
  start's readiness wait blocks until registration and tears the job
  down, instead of 404ing and orphaning the ffmpeg until the reaper.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-14 11:51:27 -04:00

607 lines
16 KiB
Go

package scanner
import (
"context"
"encoding/json"
"fmt"
"os/exec"
"slices"
"strconv"
"strings"
"github.com/Silo-Server/silo-server/internal/lang"
"github.com/Silo-Server/silo-server/internal/models"
)
// ffprobeOutput represents the top-level JSON output from ffprobe.
type ffprobeOutput struct {
Format ffprobeFormat `json:"format"`
Streams []ffprobeStream `json:"streams"`
Chapters []ffprobeChapter `json:"chapters"`
}
// ffprobeScalarString accepts ffprobe fields that may be emitted as either
// JSON strings or numbers depending on codec/container details.
type ffprobeScalarString string
func (s *ffprobeScalarString) UnmarshalJSON(data []byte) error {
if string(data) == "null" {
*s = ""
return nil
}
var str string
if err := json.Unmarshal(data, &str); err == nil {
*s = ffprobeScalarString(str)
return nil
}
var num json.Number
if err := json.Unmarshal(data, &num); err == nil {
*s = ffprobeScalarString(num.String())
return nil
}
return fmt.Errorf("unsupported ffprobe scalar %s", string(data))
}
// ffprobeFormat represents the "format" section of ffprobe JSON output.
type ffprobeFormat struct {
Filename string `json:"filename"`
FormatName string `json:"format_name"`
FormatLongName string `json:"format_long_name"`
Duration string `json:"duration"`
Size string `json:"size"`
BitRate string `json:"bit_rate"`
Tags map[string]string `json:"tags"`
}
// ffprobeStream represents a single stream entry in ffprobe JSON output.
type ffprobeStream struct {
Index int `json:"index"`
CodecName string `json:"codec_name"`
CodecLongName string `json:"codec_long_name"`
CodecType string `json:"codec_type"`
Profile string `json:"profile"`
Level int `json:"level"`
Width int `json:"width"`
Height int `json:"height"`
DisplayAspectRatio string `json:"display_aspect_ratio"`
FieldOrder string `json:"field_order"`
AvgFrameRate string `json:"avg_frame_rate"`
BitRate string `json:"bit_rate"`
ColorTransfer string `json:"color_transfer"`
ColorPrimaries string `json:"color_primaries"`
ColorSpace string `json:"color_space"`
PixFmt string `json:"pix_fmt"`
Refs int `json:"refs"`
BitsPerRawSample ffprobeScalarString `json:"bits_per_raw_sample"`
BitsPerSample ffprobeScalarString `json:"bits_per_sample"`
Channels int `json:"channels"`
ChannelLayout string `json:"channel_layout"`
SampleRate string `json:"sample_rate"`
Disposition ffprobeDisp `json:"disposition"`
Tags map[string]string `json:"tags"`
SideDataList []ffprobeSideData `json:"side_data_list"`
}
type ffprobeChapter struct {
ID int `json:"id"`
Start ffprobeScalarString `json:"start"`
End ffprobeScalarString `json:"end"`
TimeBase string `json:"time_base"`
StartTime ffprobeScalarString `json:"start_time"`
EndTime ffprobeScalarString `json:"end_time"`
Tags map[string]string `json:"tags"`
}
type ffprobeSideData struct {
SideDataType string `json:"side_data_type"`
DVProfile int `json:"dv_profile"`
DVBlPresent int `json:"dv_bl_present"`
DVElPresent int `json:"dv_el_present"`
DVBLCompatID int `json:"dv_bl_signal_compatibility_id"`
}
// ffprobeDisp represents the disposition flags on a stream.
type ffprobeDisp struct {
Default int `json:"default"`
Forced int `json:"forced"`
}
// ProbeFile runs ffprobe on the given file and returns parsed ProbeData.
// ffprobePath is the path to the ffprobe binary. filePath is the media file to probe.
func ProbeFile(ctx context.Context, ffprobePath string, filePath string) (*ProbeData, error) {
cmd := exec.CommandContext(ctx, ffprobePath,
"-v", "quiet",
"-print_format", "json",
"-show_format",
"-show_streams",
"-show_chapters",
filePath,
)
output, err := cmd.Output()
if err != nil {
return nil, fmt.Errorf("ffprobe failed for %s: %w", filePath, err)
}
var raw ffprobeOutput
if err := json.Unmarshal(output, &raw); err != nil {
return nil, fmt.Errorf("ffprobe JSON parse failed for %s: %w", filePath, err)
}
return convertProbeData(&raw), nil
}
// FFprobePathFromFFmpeg derives the sibling ffprobe binary path from a configured ffmpeg path.
func FFprobePathFromFFmpeg(ffmpegPath string) string {
if i := strings.LastIndex(ffmpegPath, "ffmpeg"); i >= 0 {
ffprobePath := ffmpegPath[:i] + "ffprobe" + ffmpegPath[i+len("ffmpeg"):]
if ffprobePath != "" && ffprobePath != ffmpegPath {
return ffprobePath
}
}
return "ffprobe"
}
// convertProbeData transforms raw ffprobe JSON output into ProbeData.
func convertProbeData(raw *ffprobeOutput) *ProbeData {
pd := &ProbeData{
Container: detectContainer(raw.Format.FormatName),
}
// Parse duration from format (ffprobe reports seconds).
// Some containers (notably MKV) may produce duration in microseconds;
// detect and normalise to seconds when the value is unreasonably large.
if raw.Format.Duration != "" {
if dur, err := strconv.ParseFloat(raw.Format.Duration, 64); err == nil {
const maxReasonableSec = 100_000 // ~27.8 hours
if dur > maxReasonableSec {
dur = dur / 1_000_000 // microseconds → seconds
}
pd.Duration = int(dur)
}
}
// Parse bitrate from format (bps to kbps).
if raw.Format.BitRate != "" {
if br, err := strconv.Atoi(raw.Format.BitRate); err == nil {
pd.Bitrate = br / 1000
}
}
for _, s := range raw.Streams {
switch s.CodecType {
case "video":
dvProfile := dolbyVisionProfileNumber(s.SideDataList)
track := VideoTrackInfo{
Title: firstNonEmpty(s.Tags["title"], s.CodecLongName, strings.ToUpper(s.CodecName)),
Codec: s.CodecName,
DolbyVision: dolbyVisionProfile(s.SideDataList),
DVProfile: dvProfile,
DVBLCompatID: dolbyVisionBLCompatID(s.SideDataList),
DVELPresent: dolbyVisionELPresent(s.SideDataList),
DVEnhancementLayer: dolbyVisionEnhancementLayer(dolbyVisionELPresent(s.SideDataList)),
HDR10Plus: hasHDR10Plus(s.SideDataList),
Profile: s.Profile,
Level: s.Level,
Width: s.Width,
Height: s.Height,
AspectRatio: s.DisplayAspectRatio,
Interlaced: isInterlaced(s.FieldOrder),
FrameRate: normalizeFrameRate(s.AvgFrameRate),
Bitrate: parseNumeric(s.BitRate) / 1000,
VideoRange: videoRangeLabel(s),
VideoRangeType: videoRangeType(s),
ColorPrimaries: s.ColorPrimaries,
ColorSpace: s.ColorSpace,
ColorTransfer: s.ColorTransfer,
BitDepth: models.NormalizeVideoBitDepth(parseBitDepth(s), s.PixFmt, s.Profile),
PixelFormat: s.PixFmt,
ReferenceFrames: s.Refs,
}
pd.VideoTracks = append(pd.VideoTracks, track)
if pd.CodecVideo == "" {
pd.CodecVideo = s.CodecName
pd.Resolution = mapResolution(s.Width, s.Height)
pd.HDR = isHDR(s.ColorTransfer) || dvProfile > 0 || track.HDR10Plus
}
case "audio":
track := AudioTrackInfo{
Title: firstNonEmpty(s.Tags["title"], s.CodecLongName, strings.ToUpper(s.CodecName)),
EmbeddedTitle: s.Tags["title"],
Language: lang.Canonical(s.Tags["language"]),
Codec: s.CodecName,
Profile: s.Profile,
Layout: s.ChannelLayout,
Channels: s.Channels,
Bitrate: parseNumeric(s.BitRate) / 1000,
SampleRate: parseNumeric(s.SampleRate),
BitDepth: parseBitDepth(s),
Default: s.Disposition.Default == 1,
}
pd.AudioTracks = append(pd.AudioTracks, track)
if pd.CodecAudio == "" {
pd.CodecAudio = s.CodecName
pd.AudioChannels = s.Channels
}
case "subtitle":
track := SubtitleTrackInfo{
Index: s.Index,
Codec: s.CodecName,
Language: lang.Canonical(s.Tags["language"]),
Title: firstNonEmpty(s.Tags["title"], strings.ToUpper(s.CodecName)),
EmbeddedTitle: s.Tags["title"],
Resolution: subtitleResolutionLabel(s),
Forced: s.Disposition.Forced == 1,
Default: s.Disposition.Default == 1,
HearingImpaired: dispositionFlag(s.Tags, "hearing_impaired"),
}
pd.SubtitleTracks = append(pd.SubtitleTracks, track)
}
}
pd.Chapters = normalizeChapters(raw.Chapters, pd.Duration)
pd.FormatTags = normalizeFormatTags(raw.Format.Tags)
return pd
}
func parseNumeric(raw string) int {
if raw == "" {
return 0
}
v, err := strconv.Atoi(raw)
if err != nil {
return 0
}
return v
}
func parseFloat(raw string) float64 {
if raw == "" {
return 0
}
value, err := strconv.ParseFloat(raw, 64)
if err != nil {
return 0
}
return value
}
func normalizeChapters(raw []ffprobeChapter, durationSeconds int) []ChapterInfo {
if len(raw) == 0 {
return []ChapterInfo{}
}
limit := float64(durationSeconds)
type chapterRange struct {
title string
start float64
end float64
}
ranges := make([]chapterRange, 0, len(raw))
for _, chapter := range raw {
start := parseFloat(string(chapter.StartTime))
end := parseFloat(string(chapter.EndTime))
if end <= 0 {
end = parseFloat(string(chapter.End))
}
if start <= 0 {
start = parseFloat(string(chapter.Start))
}
if limit > 0 {
if start < 0 {
start = 0
}
if end > limit {
end = limit
}
}
if end <= start {
continue
}
title := strings.TrimSpace(firstNonEmpty(
chapter.Tags["title"],
chapter.Tags["TITLE"],
))
ranges = append(ranges, chapterRange{
title: title,
start: start,
end: end,
})
}
if len(ranges) == 0 {
return []ChapterInfo{}
}
slices.SortStableFunc(ranges, func(a, b chapterRange) int {
switch {
case a.start < b.start:
return -1
case a.start > b.start:
return 1
case a.end < b.end:
return -1
case a.end > b.end:
return 1
default:
return 0
}
})
chapters := make([]ChapterInfo, 0, len(ranges))
for i, chapter := range ranges {
end := chapter.end
if i+1 < len(ranges) && ranges[i+1].start < end {
end = ranges[i+1].start
}
if end <= chapter.start {
continue
}
title := chapter.title
if title == "" {
title = fmt.Sprintf("Chapter %02d", len(chapters)+1)
}
chapters = append(chapters, ChapterInfo{
Index: len(chapters),
Title: title,
StartSeconds: chapter.start,
EndSeconds: end,
Source: "embedded",
})
}
return chapters
}
func parseBitDepth(s ffprobeStream) int {
if v := parseNumeric(string(s.BitsPerRawSample)); v > 0 {
return v
}
return parseNumeric(string(s.BitsPerSample))
}
func normalizeFrameRate(raw string) string {
if raw == "" || raw == "0/0" {
return ""
}
parts := strings.SplitN(raw, "/", 2)
if len(parts) != 2 {
return raw
}
num, err1 := strconv.ParseFloat(parts[0], 64)
den, err2 := strconv.ParseFloat(parts[1], 64)
if err1 != nil || err2 != nil || den == 0 {
return raw
}
return strconv.FormatFloat(num/den, 'f', 3, 64)
}
func isInterlaced(fieldOrder string) bool {
switch strings.ToLower(fieldOrder) {
case "tt", "bb", "tb", "bt":
return true
default:
return false
}
}
func videoRangeLabel(s ffprobeStream) string {
if dv := dolbyVisionProfile(s.SideDataList); dv != "" {
return "DolbyVision"
}
if isHDR(s.ColorTransfer) {
return "HDR"
}
return ""
}
func dolbyVisionProfile(sideData []ffprobeSideData) string {
if profile := dolbyVisionProfileNumber(sideData); profile > 0 {
return fmt.Sprintf("Profile %d", profile)
}
return ""
}
func dolbyVisionProfileNumber(sideData []ffprobeSideData) int {
for _, data := range sideData {
if strings.EqualFold(data.SideDataType, "DOVI configuration record") && data.DVProfile > 0 {
return data.DVProfile
}
}
return 0
}
func dolbyVisionBLCompatID(sideData []ffprobeSideData) int {
for _, data := range sideData {
if strings.EqualFold(data.SideDataType, "DOVI configuration record") && data.DVBLCompatID > 0 {
return data.DVBLCompatID
}
}
return 0
}
func dolbyVisionELPresent(sideData []ffprobeSideData) bool {
for _, data := range sideData {
if strings.EqualFold(data.SideDataType, "DOVI configuration record") {
return data.DVElPresent > 0
}
}
return false
}
// dolbyVisionEnhancementLayer remains conservative until a libdovi-backed
// analyzer has inspected the RPU mapping. ffprobe can prove that an enhancement
// layer exists, but it cannot distinguish MEL from FEL.
func dolbyVisionEnhancementLayer(present bool) string {
if !present {
return "none"
}
return "unknown"
}
func hasHDR10Plus(sideData []ffprobeSideData) bool {
for _, data := range sideData {
typ := strings.ToLower(data.SideDataType)
if strings.Contains(typ, "hdr10+") || strings.Contains(typ, "smpte2094-40") {
return true
}
}
return false
}
func videoRangeType(s ffprobeStream) string {
profile := dolbyVisionProfileNumber(s.SideDataList)
hdr10Plus := hasHDR10Plus(s.SideDataList)
if profile > 0 {
switch profile {
case 5:
return "DOVI"
case 7:
if hdr10Plus {
return "DOVIWithELHDR10Plus"
}
return "DOVIWithEL"
case 8:
if hdr10Plus {
return "DOVIWithHDR10Plus"
}
switch dolbyVisionBLCompatID(s.SideDataList) {
case 1:
return "DOVIWithHDR10"
case 2:
return "DOVIWithSDR"
case 4:
return "DOVIWithHLG"
default:
if isHLG(s.ColorTransfer) {
return "DOVIWithHLG"
}
if isHDR(s.ColorTransfer) {
return "DOVIWithHDR10"
}
return "DOVIWithSDR"
}
default:
return "DOVI"
}
}
if hdr10Plus {
return "HDR10Plus"
}
if isHLG(s.ColorTransfer) {
return "HLG"
}
if isHDR(s.ColorTransfer) {
return "HDR10"
}
return "SDR"
}
func subtitleResolutionLabel(s ffprobeStream) string {
if s.Width <= 0 || s.Height <= 0 {
return ""
}
return fmt.Sprintf("%dx%d", s.Width, s.Height)
}
func dispositionFlag(tags map[string]string, key string) bool {
if tags == nil {
return false
}
value := strings.TrimSpace(strings.ToLower(tags[key]))
return value == "1" || value == "true" || value == "yes"
}
func firstNonEmpty(values ...string) string {
for _, value := range values {
if strings.TrimSpace(value) != "" {
return value
}
}
return ""
}
// mapResolution converts video dimensions to a standard resolution string.
// Uses upper-bound bucketing (similar to Jellyfin) checking both width and
// height, which correctly handles ultra-wide and non-standard aspect ratios.
func mapResolution(width, height int) string {
switch {
case width <= 0 && height <= 0:
return ""
case width <= 854 && height <= 480:
return "480p"
case width <= 1280 && height <= 962:
return "720p"
case width <= 2560 && height <= 1440:
return "1080p"
case width <= 4096 && height <= 3072:
return "2160p"
case width <= 8192 && height <= 6144:
return "4320p"
default:
return "2160p"
}
}
// isHDR checks whether the color transfer characteristic indicates HDR content.
func isHDR(colorTransfer string) bool {
ct := strings.ToLower(colorTransfer)
return strings.Contains(ct, "smpte2084") || strings.Contains(ct, "arib-std-b67")
}
func isHLG(colorTransfer string) bool {
return strings.Contains(strings.ToLower(colorTransfer), "arib-std-b67")
}
// normalizeFormatTags lowercases tag keys so callers can look up
// "title", "artist", "album" without worrying about ffprobe's mixed-case
// output. Trims whitespace from values.
func normalizeFormatTags(raw map[string]string) map[string]string {
if len(raw) == 0 {
return nil
}
out := make(map[string]string, len(raw))
for k, v := range raw {
out[strings.ToLower(strings.TrimSpace(k))] = strings.TrimSpace(v)
}
return out
}
// detectContainer maps ffprobe format names to common container names.
func detectContainer(formatName string) string {
// ffprobe format_name can contain multiple names separated by commas
// e.g. "mov,mp4,m4a,3gp,3g2,mj2"
parts := strings.Split(formatName, ",")
for _, p := range parts {
p = strings.TrimSpace(p)
switch p {
case "matroska", "webm":
return "mkv"
case "mov", "mp4", "m4a":
return "mp4"
case "avi":
return "avi"
case "mpegts":
return "ts"
case "flv":
return "flv"
case "ogg":
return "ogg"
case "wmv", "asf":
return "wmv"
}
}
// Fallback: return first part
if len(parts) > 0 && parts[0] != "" {
return strings.TrimSpace(parts[0])
}
return formatName
}