* feat(collections): add profile-scoped display filters
* refactor(collections): dedup display-filter helpers per review
Address code-review feedback on the profile-scoped display filters
without changing behavior:
- Widen CompletedHistoryItemMap to accept ProgressCompletionStore and
drop the duplicate completedHistoryItemMapForProgress copy.
- Extract the duplicated MDBList candidate retry loop into a generic
collectionutil.FetchMDBListWithFallback helper, used by both the user
and library collection syncers, and cover it with unit tests.
- Reuse validateOptionalLibraryIDs in HandleUpdateCollection instead of
an inline positive-ID loop.
- Import the shared COLLECTION_{WATCH,MEDIA}_FILTER_OPTIONS in the
template config form rather than redefining them locally.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(collections): sanitize query_definition library_ids fallback
readSourceConfigLibraryIDs validated source_config.library_ids (finite,
positive, truncated, deduplicated) but returned the query_definition
fallback raw, so legacy rows could surface zero/negative/duplicate IDs
that the backend now rejects on save. Extract a shared sanitizer and
apply it to both paths.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* refactor(docs): This makes the agents annoying to work with
* Improve playback session handling
* Support collection source order in catalog filters
* fix(collections): address display filter review feedback
* refactor(catalog): remove duplicate collection query params
* Hide episode media scope for collection overlays
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
6.9 KiB
Repository Guidelines
Project Structure & Module Organization
cmd/silo contains the main server entrypoint. Backend code lives in internal/, organized by domain (api, catalog, metadata, playback, scanner, jellycompat, etc.); keep new code in the package that owns the behavior instead of creating catch-all helpers. Database changes belong in migrations/sql/ as Goose SQL migrations. Legacy converted migrations intentionally keep their original numeric versions so existing schema_versions rows can bootstrap cleanly into Goose. New migrations must use timestamped filenames created with make migrate-create NAME=add_thing; do not run goose fix or create paired .up.sql / .down.sql files. The React frontend lives in web/src/, with feature code split across components/, pages/, hooks/, player/, and lib/. Reference material belongs in docs/architecture/ or docs/superpowers/{specs,plans}/; ad hoc SQL helpers live in scripts/.
When creating or editing docs/superpowers/specs/ or docs/superpowers/plans/, never include local absolute filesystem paths or transient worktree IDs. Use repository-relative paths and wording like "Commands assume the repository root is the cwd."
This repository is a VERY EARLY WIP. Proposing sweeping changes that improve long-term maintainability is encouraged.
Core Priorities
- Performance first.
- Reliability first.
- Keep behavior predictable under load and during failures (session restarts, reconnects, partial streams).
If a tradeoff is required, choose correctness and robustness over short-term convenience.
Maintainability
Long term maintainability is a core priority. If you add new functionality, first check if there is shared logic that can be extracted to a separate module. Duplicate logic across multiple files is a code smell and should be avoided. Don't be afraid to change existing code. Don't take shortcuts by just adding local logic to solve a problem.
This repository is part of a broader multi-repo Silo workspace. The sibling repositories are usually checked out side-by-side in the same parent directory.
silo-serverowns the Go backend, web admin UI, API contracts, auth/session behavior, catalog/scanner/playback services, database migrations, Jellyfin compatibility, and host-side plugin runtime.silo-androidowns the Android phone and TV clients. Client-visible API, auth, playback, session, library, and metadata changes may require Android follow-up.silo-appleowns the iOS, tvOS, and macOS clients. Client-visible API, auth, playback, session, library, and metadata changes may require Apple follow-up.
When changing server behavior consumed by clients, check whether both client repos need model, routing, playback, or UX updates. Prefer coordinated multi-repo changes over leaving one platform behind.
Do not assume all plugin-related code lives in this repo.
silo-plugin-sdkowns the public plugin SDK, protobuf contracts, generated plugin API code, manifest helpers, and runtime bootstrap.silo-pluginsowns the central plugin catalog / repository manifest.- First-party plugins such as
silo-plugin-tmdb, andsilo-plugin-tvdblive in their own repositories. Siloowns host-side plugin installation, runtime management, API handlers, and integration logic.
When a task mentions plugins, first determine whether the change belongs in this repo, the SDK repo, the catalog repo, or a specific plugin repo. Prefer coordinated multi-repo changes over forcing plugin work into Silo.
Build, and Development Commands
Use the checked-in Makefile for the common paths:
make build: install frontend deps, buildweb/dist, compile./silomake dev-backend: run the Go server in integrated modemake dev-frontend: start the Vite dev server with HMRmake dev-proxy/make dev-transcode: run standalone worker modesmake lint: rungolangci-lintand frontend ESLintmake migrate-status/make migrate-up: inspect or apply Goose migrations through Silo's legacy-safe bootstrapping runner
Run before opening a merge request:
cd web && pnpm run lintcd web && pnpm run format:checkmake verify-local-paths
For local services, start PostgreSQL and Redis with docker compose up -d postgres redis.
Coding Style & Naming Conventions
Go code must stay gofmt/goimports clean and pass golangci-lint. Keep package names lowercase and focused; Frontend code is TypeScript with 2-space indentation, semicolons, double quotes, trailing commas, and a 100-character line width (web/.prettierrc). Use PascalCase.tsx for components/pages, useThing.ts for hooks, and keep shared utilities in web/src/lib or web/src/utils.
Deployment Debugging
When troubleshooting a Silo deployment (container health, playback failures,
database state, log analysis, deploys), follow the runbook at
.claude/skills/deployment-debugging/SKILL.md. It includes step-by-step
procedures and a first-run setup that configures SSH, database, and Redis
connection details for your environment.
Commit & Merge Request Guidelines
Recent history follows Conventional Commit-style subjects such as feat(playback): add realtime session hub, fix(playback): ..., and docs: .... Keep commits scoped to one concern. For non-trivial work, open an issue or discussion first; this codebase moves quickly. Merge requests should explain the problem, why this approach was chosen, linked issue/spec/plan, risks or follow-up work, and AI-use disclosure. Include screenshots or recordings for UI changes.
Learned User Preferences
- When implementing from an attached plan, do not edit the plan file itself.
- After feature work, user may invoke the
/simplifyskill to improve readability without changing behavior.
Learned Workspace Facts
- Silo separates login accounts (
users) from household profiles; multiple profiles on one account share the sameuser_id. - Profile
is_primarymarks the household parent for that account; it is not the same as server-wideadminrole on the user account. - Point the Vite dev frontend at a remote backend with
VITE_API_PROXY_TARGETinweb/.env.local(or inline) when runningmake dev-frontend; the frontend calls relative/apiURLs proxied by Vite.
Silo v1 Process (scope lock & API rules)
API rules — additive-only within /api/v1.
- Never rename or remove a response field, change a field's type, or repurpose a status code on an existing endpoint.
- New functionality adds new fields/endpoints; removals go through the existing Deprecation/Sunset header flow only.
- New features expose capability endpoints (feature detection) rather than relying on version sniffing.
- Contract strategy and tooling: issue #135.
PR requirements.
- Link the capability epic or sub-issue the PR serves (
Part of #NNN). PRs with no linked scope item will be questioned at review. - One concern per PR; Conventional Commit subject; AI-use disclosure in the PR body.