* docs(playback): plan protocol v3 server implementation * docs(playback): incorporate protocol v3 review * feat(playback): implement protocol v3 server * fix(playback): persist empty route diagnostics * feat(playback): harden protocol v3 HDR routing * feat(playback): complete protocol v3 client contract * fix(playback): harden protocol v3 recovery * fix(playback): restore dovi_rpu strip filter for DV remuxes The v3 work renamed the Dolby Vision strip recipe to a dovi_split=mode=bl bitstream filter that does not exist in stock FFmpeg or jellyfin-ffmpeg; the probe failed closed on every deployment, disabling the new validated DV7-to-HDR10 route and regressing the previously working dovi_rpu=strip=1 remux path from main. Restore dovi_rpu across the probe, remux and HLS copy arguments, and the recipe-card constant. Also from review: validate the remux DV mode for every profile (garbage modes on non-P7 sources silently no-opped), reject preserve mode for P7 outright (a base-layer-only remux cannot preserve dual-layer DV), tag dvhe sample entries only for the explicit v3 preserve recipe so legacy web/jellycompat remuxes keep their pre-v3 hev1 labeling, and honor the token-frozen DV mode in the proxy remux path instead of legacy-auto. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(playback): correct v3 planner policy and contract validation Review fixes to the v3 planner and wire contracts: - Bar Profile 7 sources from the non-strip progressive remux route: a base-layer-only remux can never deliver native dual-layer DV, so the planner no longer emits plans claiming validated Dolby Vision while the executed remux drops the enhancement layer. - Accept the device-quirks feature flag from either capability location, matching every other dual-location feature check. - Treat legacy hdr_unknown rows as HDR10 for HDR10-capable clients with a degradation warning instead of leaving them unplayable under v3. - Honor bandwidth_cap_kbps as a hard ceiling in every quality mode and wire the previously dead Metered signal into conservative auto rungs. - Degrade to the validated source-quality route instead of a terminal when only an implicit quality reduction demanded an unsupported transcode; explicit user-selected rungs keep terminal behavior. - Bound inner capability lists and strings; compare attempt keys exactly instead of case-folded; make ParseTrackIDV3 strict about canonical numerics; accept dvdsub/pgssub/dvbsub aliases and stop promising burn-in for unknown subtitle codecs; probe every h264 encoder rather than requiring libx264; normalize the file-level bitrate fallback. - Evaluate subtitle renderability against the engine each candidate route executes on, not always media3_direct. - Pin the with-quirks attempt-key preimage arity in the cross-language fixture so the Kotlin client stays in lockstep. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(playback): harden v3 control-plane reliability Review fixes to the v3 session, store, and handler layer: - Bound concurrent replans with a slot semaphore: each replan pins a pooled connection for its advisory lock while issuing further store queries from the same pool, so an unbounded recovery storm could turn every connection into a lock holder and deadlock the server. - Make CompleteReplan a real compare-and-swap (base-revision predicate, ErrReplanSupersededV3) and map BeginReplan insert races to a replay instead of a raw unique violation. - Fingerprint start requests (request_digest column): an attempt ID reused with different input is now a 409-style conflict rather than a silent replay, and both replay paths check session liveness so dead sessions surface as retryable terminals. - Pre-delete expired attempt rows on SaveAttempt so a retry during the cleanup window cannot wedge on an unreachable conflict. - Align the in-memory store's semantics with Postgres and add DB-backed planstore tests (SILO_TEST_DATABASE_URL), including a regression test inserting every route-event name against the real CHECK constraint. - Session manager: v3 route-set updates own RemuxDVMode outright so a replan onto an SDR source clears a stale strip mode; replacement reservations survive unrelated legacy stream updates; replacement admission excludes the replaced session explicitly instead of decrementing totals it may no longer be part of; the admission CAS loop is bounded and decider errors are logged. - Map transient store failures to 500s instead of terminal 404/403s; authorize route events via identity-only projections after the rate limiter; keep sanitized diagnostics deterministic. - Merge the server-computed durable plan key into replan exclusions so unreproducible client history cannot re-select the failed route. - Remap tracks only when the effective edition changes (a same-file replan no longer switches audio to a lookalike track) and remap ID-only subtitle selections on edition fallback. - Cache the v3/shadow feature flags for five seconds instead of one settings SELECT per playback request; stop remote transports best-effort when the start call times out; carry dvm/tid claims and the transport-scoped job identity through the legacy audio-change re-mint; index playback_route_events(received_at) for the retention delete; run store maintenance for DB-less deployments too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(transcode): reap idle node jobs and gate WebVTT conversion - Add an idle reaper to the transcode node: a job untouched by manifest or segment requests for ten minutes is closed and unregistered. After a v3 replan retires a transport ID, a stale in-flight stream token could resurrect the old job via reconstruct and encode to end-of-file for nobody; jobs waiting on readiness count registration as access and are never reaped mid-wait, and reaping keeps the recipe so a still-valid token reconstructs on the next hit. - Reject bitmap subtitle tracks (PGS) on the .vtt conversion path with 415 before headers are written instead of spawning an ffmpeg command that always fails mid-response, and make the extract-format override fall back to source-driven mapping for bitmap codecs. - Drain error bodies on non-202 node responses so the HTTP transport can reuse connections. - Pin the transcode-dir cleanup separator-boundary semantics with a regression test (a session ID sharing another's prefix must not retain foreign directories). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(playback): close v3 planner policy gaps from review - Clamp the final transcode bitrate to bandwidth_cap_kbps: the ladder has no rung below 480p/1500kbps, so lower caps were silently exceeded even though the cap is documented as a hard delivery ceiling. - Treat video-only media as audio-compatible instead of forcing an AAC conversion (or an audio_conversion_unsupported terminal) onto a file with no audio stream. Tracks whose codec failed to probe keep the gate. - Only promise a bitmap subtitle sidecar for embedded PGS with an engine that renders embedded bitmap: external/downloaded bitmap and embedded DVD/DVB published artifact URLs that always failed at fetch. They now fall through to burn-in or its terminal. - Accept client_video_transformations_v1 from either client_features or the nested context when validating client-executor transformations, matching the planner's dual-source reads. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(playback): probe and execute DV remuxes with one ffmpeg binary The v3 transformation registry probed the configured playback.ffmpeg_path while progressive remux execution resolved the process-global discovery path, so a deployment where only one binary carries dovi_rpu could plan a server_dv7_to_hdr10 route and then fail it at stream time. Resolution now goes through a shared ResolveFFmpegPath (configured path first, discovery fallback — the same rule the transcode pipeline already used), the dovi_rpu probe is cached per binary path, and the stream handler and proxy worker pass their configured path into ServeRemuxWithDVMode. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(playback): harden v3 replan identity and control-plane limits - Seed failure-replan track selections from the durable current plan before overlaying the request: after an alternate-version fallback the normalized request still carries requested-edition track IDs, so a replan omitting unchanged tracks was rejected as a track/file mismatch. - Remap ID-only audio selections across edition changes (parse the ID to an index like the subtitle remap already does) instead of leaving a stale file-bound ID to fail validation. - Release the node planner reservation when a prepared remote transport rolls back after the node accepted the job; repeated failed starts could otherwise pin max-job/bandwidth budgets for the full reservation age. - Size the replan semaphore below the PostgreSQL pool via a store capacity advisor: with max_connections at or below the fixed bound, advisory-lock holders could starve the inner store queries they need to finish. - Contain shadow-planner panics with a recover boundary; it runs on a bare goroutine where an escaped panic kills the process for what is telemetry-only work. Document why the memory store's session lock is deliberately a no-op. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(transcode): serialize node job teardown against reconstructs - Look up and touch manifest/segment sessions in one critical section so the idle reaper cannot unregister a job between the lookup and its liveness refresh. - Re-validate each reap candidate under the per-session lifecycle lock before closing it: Close removes the output directory, and without the lock it could race a token reconstruct and wipe the segments the fresh ffmpeg is writing. - Take the lifecycle lock in handleStop so a stop racing a RequireReady start's readiness wait blocks until registration and tears the job down, instead of 404ing and orphaning the ffmpeg until the reaper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
315 lines
8.9 KiB
Go
315 lines
8.9 KiB
Go
package playback
|
|
|
|
import (
|
|
"context"
|
|
"log/slog"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"runtime"
|
|
"sort"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
)
|
|
|
|
var (
|
|
defaultDRIDir = "/dev/dri"
|
|
defaultNVIDIAControlDevice = "/dev/nvidiactl"
|
|
defaultNVIDIADeviceGlob = "/dev/nvidia[0-9]*"
|
|
sysClassDRMDir = "/sys/class/drm"
|
|
currentGOOS = runtime.GOOS
|
|
nvencProbeCommandTimeout = 3 * time.Second
|
|
)
|
|
|
|
type nvencProbeResult struct {
|
|
available bool
|
|
reason string
|
|
}
|
|
|
|
var nvencProbeCache = struct {
|
|
sync.Mutex
|
|
byPath map[string]nvencProbeResult
|
|
}{
|
|
byPath: make(map[string]nvencProbeResult),
|
|
}
|
|
|
|
// HWAccelInfo describes the detected hardware acceleration capability.
|
|
type HWAccelInfo struct {
|
|
Resolved string `json:"resolved"`
|
|
RenderDevices []string `json:"render_devices"`
|
|
IntelDetected bool `json:"intel_detected"`
|
|
Source string `json:"source"`
|
|
NodeURL string `json:"node_url,omitempty"`
|
|
Transformations []TransformationV3 `json:"transformations,omitempty"`
|
|
}
|
|
|
|
// DetectHWAccel probes this host's GPU hardware and returns structured info.
|
|
func DetectHWAccel() HWAccelInfo {
|
|
return DetectHWAccelWithFFmpeg("")
|
|
}
|
|
|
|
// DetectHWAccelWithFFmpeg probes this host's GPU hardware and configured FFmpeg.
|
|
func DetectHWAccelWithFFmpeg(ffmpegPath string) HWAccelInfo {
|
|
devices := listRenderDevices(defaultDRIDir)
|
|
intel := false
|
|
for _, d := range devices {
|
|
if isIntelDevice(d) {
|
|
intel = true
|
|
break
|
|
}
|
|
}
|
|
return HWAccelInfo{
|
|
Resolved: ResolveHWAccelWithFFmpeg("auto", ffmpegPath),
|
|
RenderDevices: devices,
|
|
IntelDetected: intel,
|
|
Source: "local",
|
|
}
|
|
}
|
|
|
|
// PickRenderDevice returns the GPU render device path to use.
|
|
// If explicit is non-empty, it is returned as-is.
|
|
// Otherwise, it attempts to discover a render device under /dev/dri/.
|
|
// Returns empty string if no device is found (caller should fall back to CPU).
|
|
func PickRenderDevice(explicit string) string {
|
|
if explicit != "" {
|
|
return explicit
|
|
}
|
|
dev := detectRenderDevice(defaultDRIDir)
|
|
if dev != "" {
|
|
slog.Info("auto-detected GPU render device", "device", dev)
|
|
}
|
|
return dev
|
|
}
|
|
|
|
// ResolveHWAccel resolves "auto" using the default FFmpeg binary.
|
|
func ResolveHWAccel(hwAccel string) string {
|
|
return ResolveHWAccelWithFFmpeg(hwAccel, "")
|
|
}
|
|
|
|
// ResolveHWAccelWithFFmpeg resolves "auto" into a concrete acceleration method
|
|
// by probing the system and the configured FFmpeg binary.
|
|
// Preference order: nvenc > qsv > vaapi > none.
|
|
// Non-"auto" values are returned unchanged.
|
|
func ResolveHWAccelWithFFmpeg(hwAccel string, ffmpegPath string) string {
|
|
if hwAccel != "auto" {
|
|
return hwAccel
|
|
}
|
|
if currentGOOS != "linux" {
|
|
return "none"
|
|
}
|
|
|
|
devices := listRenderDevices(defaultDRIDir)
|
|
var intelDevice string
|
|
var nvidiaDevice string
|
|
var vaapiDevice string
|
|
for _, dev := range devices {
|
|
switch {
|
|
case isNVIDIADevice(dev):
|
|
if nvidiaDevice == "" {
|
|
nvidiaDevice = dev
|
|
}
|
|
case isIntelDevice(dev):
|
|
if intelDevice == "" {
|
|
intelDevice = dev
|
|
}
|
|
default:
|
|
if vaapiDevice == "" {
|
|
vaapiDevice = dev
|
|
}
|
|
}
|
|
}
|
|
|
|
if nvidiaDevice != "" || hasNVIDIADevice() {
|
|
if ok, reason := ffmpegSupportsNVENC(ffmpegPath); ok {
|
|
if nvidiaDevice != "" {
|
|
slog.Info("hw_accel=auto: NVIDIA GPU detected, using NVENC", "device", nvidiaDevice)
|
|
} else {
|
|
slog.Info("hw_accel=auto: NVIDIA device detected, using NVENC")
|
|
}
|
|
return "nvenc"
|
|
} else {
|
|
slog.Warn("hw_accel=auto: NVIDIA device detected but FFmpeg NVENC probe failed",
|
|
"ffmpeg", normalizeFFmpegPath(ffmpegPath), "reason", reason)
|
|
}
|
|
}
|
|
|
|
if intelDevice != "" {
|
|
slog.Info("hw_accel=auto: Intel GPU detected, using QSV", "device", intelDevice)
|
|
return "qsv"
|
|
}
|
|
|
|
if vaapiDevice != "" {
|
|
slog.Info("hw_accel=auto: non-Intel GPU detected, using VAAPI", "device", vaapiDevice)
|
|
return "vaapi"
|
|
}
|
|
|
|
slog.Info("hw_accel=auto: no compatible GPU devices found, using software encoding")
|
|
return "none"
|
|
}
|
|
|
|
func ffmpegSupportsNVENC(ffmpegPath string) (bool, string) {
|
|
ffmpegPath = normalizeFFmpegPath(ffmpegPath)
|
|
nvencProbeCache.Lock()
|
|
if result, ok := nvencProbeCache.byPath[ffmpegPath]; ok {
|
|
nvencProbeCache.Unlock()
|
|
return result.available, result.reason
|
|
}
|
|
nvencProbeCache.Unlock()
|
|
|
|
result := probeFFmpegNVENC(ffmpegPath)
|
|
nvencProbeCache.Lock()
|
|
nvencProbeCache.byPath[ffmpegPath] = result
|
|
nvencProbeCache.Unlock()
|
|
return result.available, result.reason
|
|
}
|
|
|
|
func normalizeFFmpegPath(ffmpegPath string) string {
|
|
ffmpegPath = strings.TrimSpace(ffmpegPath)
|
|
if ffmpegPath == "" {
|
|
ffmpegPath = ffmpegBinary()
|
|
}
|
|
if strings.ContainsRune(ffmpegPath, os.PathSeparator) {
|
|
return filepath.Clean(ffmpegPath)
|
|
}
|
|
return ffmpegPath
|
|
}
|
|
|
|
func probeFFmpegNVENC(ffmpegPath string) nvencProbeResult {
|
|
if output, err := runFFmpegProbe(ffmpegPath, "-hide_banner", "-hwaccels"); err != nil {
|
|
return nvencProbeResult{reason: "hwaccels probe failed: " + probeFailure(err, output)}
|
|
} else if !ffmpegOutputHasToken(output, "cuda") {
|
|
return nvencProbeResult{reason: "cuda hwaccel unavailable"}
|
|
}
|
|
|
|
if output, err := runFFmpegProbe(ffmpegPath, "-hide_banner", "-encoders"); err != nil {
|
|
return nvencProbeResult{reason: "encoders probe failed: " + probeFailure(err, output)}
|
|
} else if !ffmpegOutputHasToken(output, "h264_nvenc") {
|
|
return nvencProbeResult{reason: "h264_nvenc encoder unavailable"}
|
|
} else if !ffmpegOutputHasToken(output, "hevc_nvenc") {
|
|
return nvencProbeResult{reason: "hevc_nvenc encoder unavailable"}
|
|
}
|
|
|
|
if output, err := runFFmpegProbe(ffmpegPath, "-hide_banner", "-filters"); err != nil {
|
|
return nvencProbeResult{reason: "filters probe failed: " + probeFailure(err, output)}
|
|
} else if !ffmpegOutputHasToken(output, "scale_cuda") {
|
|
return nvencProbeResult{reason: "scale_cuda filter unavailable"}
|
|
} else if !ffmpegOutputHasToken(output, "hwupload_cuda") {
|
|
return nvencProbeResult{reason: "hwupload_cuda filter unavailable"}
|
|
}
|
|
|
|
if output, err := runFFmpegProbe(ffmpegPath,
|
|
"-hide_banner",
|
|
"-loglevel", "error",
|
|
"-f", "lavfi",
|
|
"-i", "testsrc2=size=640x360:rate=1",
|
|
"-frames:v", "1",
|
|
"-an",
|
|
"-c:v", "h264_nvenc",
|
|
"-f", "null",
|
|
"-",
|
|
); err != nil {
|
|
return nvencProbeResult{reason: "h264_nvenc smoke encode failed: " + probeFailure(err, output)}
|
|
}
|
|
|
|
return nvencProbeResult{available: true}
|
|
}
|
|
|
|
func runFFmpegProbe(ffmpegPath string, args ...string) ([]byte, error) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), nvencProbeCommandTimeout)
|
|
defer cancel()
|
|
return exec.CommandContext(ctx, ffmpegPath, args...).CombinedOutput()
|
|
}
|
|
|
|
func ffmpegOutputHasToken(output []byte, token string) bool {
|
|
for _, field := range strings.Fields(string(output)) {
|
|
if strings.EqualFold(field, token) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func probeFailure(err error, output []byte) string {
|
|
message := strings.TrimSpace(err.Error())
|
|
if trimmed := strings.TrimSpace(string(output)); trimmed != "" {
|
|
if len(trimmed) > 240 {
|
|
trimmed = trimmed[:240] + "..."
|
|
}
|
|
message += ": " + trimmed
|
|
}
|
|
return message
|
|
}
|
|
|
|
// listRenderDevices returns all accessible /dev/dri/renderD* paths, sorted.
|
|
func listRenderDevices(driDir string) []string {
|
|
pattern := filepath.Join(driDir, "renderD*")
|
|
matches, err := filepath.Glob(pattern)
|
|
if err != nil || len(matches) == 0 {
|
|
return nil
|
|
}
|
|
sort.Strings(matches)
|
|
|
|
var accessible []string
|
|
for _, dev := range matches {
|
|
if f, err := os.Open(dev); err == nil {
|
|
f.Close()
|
|
accessible = append(accessible, dev)
|
|
}
|
|
}
|
|
return accessible
|
|
}
|
|
|
|
// isIntelDevice checks whether a render device belongs to an Intel GPU by
|
|
// reading the PCI vendor ID from sysfs. Intel vendor ID is 0x8086.
|
|
func isIntelDevice(renderDevPath string) bool {
|
|
// /dev/dri/renderD128 → card name "renderD128"
|
|
name := filepath.Base(renderDevPath)
|
|
vendorPath := filepath.Join(sysClassDRMDir, name, "device", "vendor")
|
|
data, err := os.ReadFile(vendorPath)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
return strings.TrimSpace(string(data)) == "0x8086"
|
|
}
|
|
|
|
// isNVIDIADevice checks whether a render device belongs to an NVIDIA GPU by
|
|
// reading the PCI vendor ID from sysfs. NVIDIA vendor ID is 0x10de.
|
|
func isNVIDIADevice(renderDevPath string) bool {
|
|
name := filepath.Base(renderDevPath)
|
|
vendorPath := filepath.Join(sysClassDRMDir, name, "device", "vendor")
|
|
data, err := os.ReadFile(vendorPath)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
return strings.TrimSpace(string(data)) == "0x10de"
|
|
}
|
|
|
|
func hasNVIDIADevice() bool {
|
|
if file, err := os.Open(defaultNVIDIAControlDevice); err == nil {
|
|
file.Close()
|
|
return true
|
|
}
|
|
matches, err := filepath.Glob(defaultNVIDIADeviceGlob)
|
|
if err != nil || len(matches) == 0 {
|
|
return false
|
|
}
|
|
for _, dev := range matches {
|
|
if file, err := os.Open(dev); err == nil {
|
|
file.Close()
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// detectRenderDevice enumerates /dev/dri/renderD* and returns the first
|
|
// available device, or empty string if none found.
|
|
func detectRenderDevice(driDir string) string {
|
|
devices := listRenderDevices(driDir)
|
|
if len(devices) > 0 {
|
|
return devices[0]
|
|
}
|
|
return ""
|
|
}
|