* feat(observability): OpenTelemetry logs+traces with secret redaction Part of #265. Adds opt-in OpenTelemetry (logs + traces) alongside the existing stderr + opslog pipeline, plus secret redaction on all sinks. Default-off: with no OTEL_* / SILO_OTEL_ENABLED config, behavior is unchanged. Bootstrap (internal/telemetry): - Setup() builds one shared resource, a TracerProvider (parent-based trace-id ratio sampler), a LoggerProvider, and the W3C TraceContext+Baggage propagator from env. It installs NO MeterProvider — metrics stay on Prometheus, and the built-in no-op global MeterProvider keeps the trace instrumentation libs from double-emitting. Shutdown is deferred with a flush timeout. - Logs are bridged via otelslog fan-out (slog.MultiHandler), level-gated by the shared LevelVar and best-effort so a failing collector can't break the console or DB branches. stderr + opslog stay untouched. Secret redaction (internal/logredact): - A slog.Handler masks secret-keyed attributes (password, token, api_key, authorization, cookie, ...) — including .With-bound attrs, nested groups, secret-keyed group subtrees, and values behind a LogValuer — on the console and OTLP sinks, with a no-op fast path when a record has no secret keys. opslog.shouldRedact delegates to logredact.SecretKey so all sinks share one marker list. Rotation is infra-managed (no custom file sink): container runtime for stderr, collector/backend for OTLP, opslog partition-pruning for the DB. Documented in docs/architecture/observability.md. Verification: go build ./..., go vet, gofmt -l — clean; go test ./internal/telemetry/ ./internal/logredact/ -race pass. AI-use disclosure: implemented with AI assistance (Claude Code), including adversarial reviews that hardened the bootstrap and fixed two redaction leak paths; reviewed by the author. * refactor(observability): slog context+component sweep, sloglint gate (phase 3) Part of #265. Builds on the OTel bootstrap + redaction commit. Standardizes every log call site onto the context-carrying slog variants so records correlate with the active OpenTelemetry trace, and locks the standard in with a machine gate so future code (human- or AI-authored) can't drift back. - Call-site sweep: converted the remaining slog.<Level>(...) calls to the slog.<Level>Context(ctx, ...) form wherever a context.Context is in scope (background/init calls with no ctx are left as-is), across 183 files. Applied via a type-aware AST codemod. Log levels and message strings are preserved verbatim; a component attr (canonical per-package name) is added to direct package-level slog calls. Bound-logger calls keep their existing .With bindings. The main.go and telemetry package conversions rode with their file in the previous commit to keep each file within a single commit. - Enforcement (.golangci.yml): enable sloglint with context=scope, static-msg, key-naming-case=snake, no-mixed-args. After the sweep all four report zero violations repo-wide (tests included), so make lint / CI now blocks any regression to the non-context form. The gate ships with the sweep because it cannot be green until the legacy sites are converted. Metrics remain on Prometheus; no behavior change to /metrics or Grafana. Verification: go build ./..., go vet ./..., gofmt -l — clean; sloglint (all 4 rules) 0 violations repo-wide; log levels verified unchanged. AI-use disclosure: implemented with AI assistance (Claude Code), including the codemod; reviewed by the author. * fix(observability): honor per-signal OTLP protocol and secret WithGroup names Two Codex review findings on PR #290: - telemetry: OTEL_EXPORTER_OTLP_{TRACES,LOGS}_PROTOCOL now override the generic OTEL_EXPORTER_OTLP_PROTOCOL per signal, so mixed collector setups (e.g. HTTP logs + gRPC traces) build the right exporter. - logredact: entering a group whose name is secret-bearing (e.g. WithGroup("authorization")) now masks every leaf in that subtree, matching how slog.Group("authorization", ...) is masked as a whole. * fix(observability): address review feedback on telemetry bootstrap - Telemetry setup failure no longer kills boot: Setup returns usable no-op providers alongside the error and main logs and continues with telemetry disabled, honoring the best-effort contract. - Honor OTEL_TRACES_SAMPLER (always_on/off, traceidratio, parentbased_* variants); unsupported values fall back to parentbased_traceidratio. - Attach node identity as semconv service.instance.id instead of the non-semconv node.name. - Rename opslog retention-scope log attrs to target_component/target_level so they no longer collide with the canonical component routing key, and tag those lines with component=opslog. - Fix stale levelGated comment casing; use WarnContext in the telemetry shutdown defer; document the LogValuer double-resolve on the redaction slow path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Quick <31828688+Quick104@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
99 lines
4.2 KiB
Go
99 lines
4.2 KiB
Go
package playback
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"log/slog"
|
|
)
|
|
|
|
type subtitleReadySessionLookup interface {
|
|
GetSessionsByMediaFileID(fileID int) []*Session
|
|
}
|
|
|
|
// SubtitleReadyNotifier pushes "subtitle ready" events to active playback
|
|
// sessions when a generated subtitle track (AI translation, later ASR) becomes
|
|
// available, so the player can refresh and select it without a manual reload.
|
|
//
|
|
// It satisfies the subtitles/ai Notifier interface structurally, keeping the ai
|
|
// package free of any playback dependency.
|
|
type SubtitleReadyNotifier struct {
|
|
sessions subtitleReadySessionLookup
|
|
hub *RealtimeHub
|
|
}
|
|
|
|
// NewSubtitleReadyNotifier returns a notifier, or nil if its dependencies are
|
|
// missing (callers treat a nil notifier as a no-op).
|
|
func NewSubtitleReadyNotifier(sessions subtitleReadySessionLookup, hub *RealtimeHub) *SubtitleReadyNotifier {
|
|
if sessions == nil || hub == nil {
|
|
return nil
|
|
}
|
|
return &SubtitleReadyNotifier{sessions: sessions, hub: hub}
|
|
}
|
|
|
|
// SubtitleReady notifies active sessions for the file that a new subtitle track
|
|
// with the given downloaded-subtitle ID is available.
|
|
func (n *SubtitleReadyNotifier) SubtitleReady(ctx context.Context, mediaFileID, subtitleID int, language, label string) {
|
|
if n == nil || mediaFileID <= 0 || subtitleID <= 0 {
|
|
return
|
|
}
|
|
|
|
for _, session := range n.sessions.GetSessionsByMediaFileID(mediaFileID) {
|
|
if session == nil || session.ID == "" || !session.HasRealtimeConnection {
|
|
continue
|
|
}
|
|
event, err := NewSubtitleReadyEvent(session.ID, mediaFileID, subtitleID, language, label)
|
|
if err != nil {
|
|
slog.WarnContext(ctx, "failed to encode subtitle ready realtime event", "component", "playback",
|
|
"session_id", session.ID, "file_id", mediaFileID, "subtitle_id", subtitleID, "error", err)
|
|
continue
|
|
}
|
|
if err := n.hub.Send(session.ID, event); err != nil && !errors.Is(err, ErrRealtimeConnectionNotFound) {
|
|
slog.WarnContext(ctx, "failed to deliver subtitle ready realtime event", "component", "playback",
|
|
"session_id", session.ID, "file_id", mediaFileID, "subtitle_id", subtitleID, "error", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TranslationStarted tells one session a live translation has begun.
|
|
func (n *SubtitleReadyNotifier) TranslationStarted(ctx context.Context, sessionID string, fileID int, jobID int64, trackKey, language, label string, totalCues int) {
|
|
n.sendTranslation(sessionID, func() (EventEnvelope, error) {
|
|
return NewSubtitleTranslationStartedEvent(sessionID, fileID, jobID, trackKey, language, label, totalCues)
|
|
})
|
|
}
|
|
|
|
// TranslationCues pushes a batch of translated cues to one session.
|
|
func (n *SubtitleReadyNotifier) TranslationCues(ctx context.Context, sessionID string, fileID int, jobID int64, trackKey string, cues []StreamCue, done, total int) {
|
|
n.sendTranslation(sessionID, func() (EventEnvelope, error) {
|
|
return NewSubtitleTranslationCuesEvent(sessionID, fileID, jobID, trackKey, cues, done, total)
|
|
})
|
|
}
|
|
|
|
// TranslationCompleted tells one session a live translation finished.
|
|
func (n *SubtitleReadyNotifier) TranslationCompleted(ctx context.Context, sessionID string, fileID int, jobID int64, trackKey string, subtitleID int, language, label string) {
|
|
n.sendTranslation(sessionID, func() (EventEnvelope, error) {
|
|
return NewSubtitleTranslationCompletedEvent(sessionID, fileID, jobID, trackKey, subtitleID, language, label)
|
|
})
|
|
}
|
|
|
|
// TranslationFailed tells one session a live translation failed.
|
|
func (n *SubtitleReadyNotifier) TranslationFailed(ctx context.Context, sessionID string, fileID int, jobID int64, trackKey, message string) {
|
|
n.sendTranslation(sessionID, func() (EventEnvelope, error) {
|
|
return NewSubtitleTranslationFailedEvent(sessionID, fileID, jobID, trackKey, message)
|
|
})
|
|
}
|
|
|
|
// sendTranslation builds and delivers a translation event to a single session.
|
|
func (n *SubtitleReadyNotifier) sendTranslation(sessionID string, build func() (EventEnvelope, error)) {
|
|
if n == nil || n.hub == nil || sessionID == "" {
|
|
return
|
|
}
|
|
event, err := build()
|
|
if err != nil {
|
|
slog.Warn("failed to encode subtitle translation realtime event", "session_id", sessionID, "error", err)
|
|
return
|
|
}
|
|
if err := n.hub.Send(sessionID, event); err != nil && !errors.Is(err, ErrRealtimeConnectionNotFound) {
|
|
slog.Warn("failed to deliver subtitle translation realtime event", "session_id", sessionID, "error", err)
|
|
}
|
|
}
|