* feat(downloads): offline sync for mobile (downloads v2) Replace internal/download with a unified internal/downloads package and add fully-offline download + watch-sync support for mobile clients, across five independently-shippable phases: - Phase 0: reshape the downloads table and the /downloads contract to be device- and format-aware; add GET /downloads/capability; extend DownloadConfig (default-off keys); update the web download hooks/components in lockstep. This is the one approved pre-lock exception to the additive-only /api/v1 rule (the web app is the only consumer and is updated together). - Phase 1: managed device-library entries (create/list/PATCH/delete/serve), keyed on the X-Silo-Device-Id header. - Phase 2: offline playback manifest plus artwork/subtitle proxy endpoints that strip every presigned URL (inline thumbhashes + authenticated proxies). - Phase 3: prepare-to-file (remux + transcode-to-single-file) as a durable, leased artifact queue with startup recovery, hosted on the task manager; playback.PrepareFile emits one +faststart MP4. Adds the admin transcode toggle and per-artifact LRU cleanup. - Phase 4: offline progress reconciliation -- a clamped event_at LWW key plus a server-assigned synced_seq cursor on watch_progress; an optional clamped updated_at on POST /sync/progress and an opaque ?since= cursor on GET /progress (additive; existing callers unaffected). Security & reliability invariants, each with an acceptance test: 1. Server-owned sync ordering: ?since= delta delivery is driven only by the server-assigned synced_seq; the client clock is bounded (event_at, clamped to now+skew) and used only for last-write-wins on the caller's own profile. 2. Full profile+device authorization on every managed endpoint, with a per-profile content/library access re-check before serving any bytes/assets. 3. Durable artifact recovery: a transactionally-claimed (FOR UPDATE SKIP LOCKED), lease-heartbeat, attempt-counted queue with a startup sweep, so no crash strands a download in preparing and concurrent workers never double-encode. Migrations are timestamped Goose files: reshape downloads (device/format); download_artifacts (durable queue); watch_progress event_at/synced_seq. DB-backed acceptance tests skip without SILO_TEST_DATABASE_URL and run in CI; the invariant-1 progress test also runs against the real SQLite backend locally. Client repos (silo-android, silo-apple) consume the reshaped /downloads/* contract and the updated_at/?since= progress fields and require coordinated follow-up. Implements the maintainer-approved v1 capability proposal for offline sync (downloads v2). AI-use disclosure: implemented by Claude (Claude Code) from the approved design doc under docs/superpowers/specs, with human review. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * feat(downloads): series & season downloads + client-pull monitoring Build season downloads and a "monitor a series" capability on top of the downloads v2 (offline sync for mobile) work. Season downloads: - POST /downloads accepts season_number (with series:true) to download one season. CreateSeries/CreateSeason share one body via a listEpisodes closure and register managed entries under a shared batch_id (original-only). Episode files are resolved in a single batched query. Series monitoring (auto-download), client-driven: - New device-scoped download_subscriptions table with a Sonarr-style mode (all | future | latest_season | specific_seasons), a client-enforced delete_watched flag, and a max_storage_bytes cap. The server never deletes on-device files; retention and the hard cap are the client's, the server only soft-gates registration. - The client calls POST /downloads/subscriptions/sync on open / background refresh; the server registers the in-scope, not-yet-downloaded episodes (idempotent via the managed-entry unique index) and the device pulls them on its own schedule. No background worker and no dependency on the notifications subsystem. latest_season follows new seasons (>= subscribe-time season); future excludes the back catalog via air date. - Subscription CRUD + sync are profile+device authorized (device id from the X-Silo-Device-Id header only) with a per-request content-access re-check. The capability endpoint advertises season_download / series_monitoring / monitoring_modes. Also lands the downloads-v2 work already present in the tree: durable artifact (remux/transcode) preparation and offline watch-progress reconciliation, plus the design-spec updates. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * WIP: epitaxy pre-switch from feat/downloads-v2-offline-sync * test(downloads): fix deterministic ID collision in reconcile test Artifact IDs are time-sortable, so two artifacts created in the same moment share their first 8 chars; combined with a captured timestamp the two preparing-download IDs collided on downloads_pkey. Use the full artifact ID, which is unique per row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): support sqlite userdb backend for managed downloads With the sqlite userdb backend, profiles live only in per-user SQLite stores and public.user_profiles stays empty, so user_devices' profile FK made every managed create/subscription/offline-sync request fail with an FK violation. Drop the FK (shared Postgres tables must not FK profile tables — same rule as notifications) and replace the lost cascade with an app-level purge on profile deletion, wired through ProfileHandler for both backends. DB-backed regression tests cover the no-Postgres-profile-row path and the purge cascade. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): dispatch encode kick asynchronously triggerDrain invoked the kick inline, and the kick (taskmanager RunTask) executes the encode task on the caller's goroutine — so a POST /api/v1/downloads with a bitrate quality blocked the HTTP request on the entire queue drain, ffmpeg encodes included, delaying the 202 by minutes on an idle queue. Dispatch the kick on a goroutine; the task manager already serializes concurrent runs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): enforce per-user quota on the encode pipeline Two gaps let a user bypass MaxConcurrentPerUser entirely for prepared downloads: artifact-backed rows are created in 'preparing' (never 'queued'/'downloading'), which CountActiveByUser didn't count, and createArtifactDownload enqueued the encode job before limiter.Check, so even a 429-rejected request left a job the worker would transcode. Count 'preparing' as active and check the limiter before Ensure; managed replacements stay quota-exempt since they don't add a row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): protect ephemeral artifact links from LRU eviction HasActiveLink only counted managed (device_id IS NOT NULL) rows, so under a byte budget Cleanup could delete an artifact still referenced by a ready-but-unfetched ephemeral web download — permanently 404ing a row the API kept listing as ready (the artifact row is gone, so recovery can't re-queue it). Any non-terminal link now protects the artifact; only artifacts whose links are all cancelled/failed/revoked are evictable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): batch manifests skip bad entries instead of failing whole batch One deleted or access-filtered episode made GET /downloads/batches/{id}/manifests 404 for the entire season, so a client could no longer fetch manifests for the still-valid entries. Report unbuildable entries in a skipped[] array (revoked | not_found | error) alongside the delivered manifests, mirroring the create path's skip idiom. Also cut the batch cost: the shared series detail is resolved once per batch instead of once per episode, and buildSubtitles reuses the already-loaded media file instead of re-querying it per manifest. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(migrations): wrap DO block in StatementBegin/End markers Under NO TRANSACTION goose splits statements on semicolons, so the dollar-quoted DO block failed every fresh install with 'unterminated dollar-quoted string' (SQLSTATE 42601). Already-applied databases are unaffected. Same fix is being applied to main; identical content merges cleanly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(api): allow season 0 (Specials) in season downloads season_number was a plain int dispatched with '> 0', so requesting the Specials season was indistinguishable from omitting the field and silently broadened to a full-series download. Dispatch on pointer presence, treat 0 as the Specials season, and reject negatives with 400. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): capability quality_presets is never JSON null PresetsFor returned a nil slice when downloads are disabled or the user lacks the permission, and Capability's []string{} initialization was immediately overwritten by it — so GET /downloads/capability serialized "quality_presets": null where the contract documents an array. Normalize at the source so every caller inherits the guarantee. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): subscription sync correctness + batched registration Three subscription fixes: - A paused subscription no longer syncs: PATCHing scope (or pausing and changing scope in one request) registered episodes for a monitor the user had just stopped, inconsistently with SyncSubscriptions' guard. - SubModeFuture compares calendar days (UTC): air_date is date-only, so the strict instant comparison permanently excluded episodes airing the same day the user subscribed; episodes with no air date now fall back to their ingest time instead of never registering. - Registration is one batched fetch (GetManagedEntriesByKeys) plus one batched INSERT ... ON CONFLICT DO NOTHING RETURNING (CreateManagedEntriesBatch) instead of a SELECT+INSERT per episode — a 300-episode series cost ~600 sequential round trips per request and every no-op sync re-walked the full set. RETURNING yields exactly the new rows, so the sync response's 'registered' count now honestly reports 0 in the steady state instead of the full in-scope count on every app open. The now-unused InsertManagedEntryIfAbsent is removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(userstore): stamp triggers own the event_at LWW key MarkProgressBatch (jellycompat series mark-played) advanced updated_at but never event_at, and both stamp triggers only defaulted event_at when NULL — so a queued offline event with a client time between the row's old event_at and the mark could win SetProgressIfNewer and resurrect a stale resume position that then re-synced to every device. Make the triggers authoritative instead of adding a tenth hand-written SET clause: whenever an UPDATE changes updated_at without explicitly changing event_at, the trigger advances the LWW key; writes that do set event_at (offline sync's clamped client event time) keep their value. Postgres gets a CREATE OR REPLACE migration; SQLite gets a v12 userdb migration that drops and reinstalls the trigger bodies (CREATE TRIGGER IF NOT EXISTS never replaces). Conformance tests cover both batch paths, the preserved-client-time invariant, and the v11→v12 upgrade. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): lifecycle hygiene — squash migrations, dead status, stale-row sweeps Migrations: fold the 20260621 corrective migration back into the base Downloads V2 migrations (its columns/constraints already exist there) and fix the reshape Down, which re-added the narrow status CHECK without collapsing managed-lifecycle rows first — rollback aborted on any DB with preparing/ready/revoked rows; validated against a live row. Branch databases that applied the corrective migration need its version row removed: DELETE FROM goose_db_version WHERE version_id = 20260621020459. Code: drop the dead 'registered' status (nothing ever wrote it; the lifecycle is preparing -> ready; 'revoked' stays reserved for the planned admin revoke flow) along with unused KindDirect and ErrInvalidFormat. Sweeps: Cleanup now runs an age-based hygiene pass independent of the byte budget — cold terminally-failed artifacts (with .part leftovers), orphaned ready artifacts no download row references, and ephemeral web rows older than their convenience-record lifetime (also unpinning their artifacts and bounding GET /downloads growth). The byte budget remains the disk quota per the limits & restrictions design. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(downloads): sync API doc with v2 fixes; HEAD on file route; Android handoff Document the contract changes from the review fixes: batch-manifest skipped[] shape, honest subscription 'registered' semantics, season 0 = Specials, always-array quality_presets, bytes_sent actual behavior, ephemeral 7-day retention, header-pairing requirement, progress-delta deletion caveat, and the ready/failed push event schema (new §9.4). Add an Android client handoff section (§11) mirroring the Apple one, register HEAD on /downloads/{id}/file for download stacks that probe before ranged GETs, and add season_number to the web create-request type. Flag the /direct-download session-token-in-URL tradeoff; a short-lived download-scoped URL is a follow-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: consolidate download/progress helpers, prune dead code, gate sweeps Behavior-preserving consolidation from the Downloads V2 review: - appendVideoFilterArgs: one home for the burn-in/hwaccel -vf selection, shared by the HLS builder and the single-file prepare builder (the drift pattern that already bit tone-mapping once). - userstore.ResolveProgressState: one home for the min-resume/watched threshold rule, replacing five identical copies across both store backends and the offline-sync ingest. - Download file selection ranks resolutions via access.CompareQuality (adds 4320p, agrees with playback) instead of a private switch. - writeSubtitle uses the shared subtitles.SubtitleContentType mapping. - config.DefaultTranscodeDir replaces three '/tmp/silo-transcode' literals. - Read-side quality/revision defaulting helpers removed: insertArgs plus the NOT NULL/CHECK schema already guarantee the invariant. - Dead code removed: Repository.ListByUser, SubscriptionRepository. ListActiveBySeries, and the stale auto-register-worker comments (the design is client-pull; no worker exists). - Redundant left-prefix indexes dropped from the base migrations (their unique indexes serve the same prefixes). - recover()'s disk-presence sweep and the stale-row hygiene sweep run on startup then hourly instead of every 30s tick (both are O(cache size)). - gofmt/prettier fixes for pre-existing drift in handlers/playback.go and pages/Profiles.tsx. Deferred (noted for follow-ups): quality-ladder preset table collides with the drafted download limits & restrictions design, which specifies its own ladder helper; Download-literal construction consolidation and the managed-identity value object remain open. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(downloads): draft download limits & restrictions design Design input for the follow-up v1 capability proposal (quality ceiling, batch size cap, per-user quantity/bandwidth overrides). Committed with downloads v2 because the remediation work explicitly defers the quality ladder refactor and revocation wiring to this spec. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(progress): reject malformed updated_at; clamp negative progress inputs Review findings on #258: - A malformed (non-RFC3339) updated_at in POST /sync/progress previously parsed to the zero time, which clampEventAt treated as "now" — letting a stale offline event win LWW as a fresh server-time write. The item is now rejected with a per-item error instead. - ResolveProgressState now clamps negative position/duration before classification so no backend can persist negative progress through UpdateProgress/SetProgress. - The online-write event_at invariant test is table-driven over both SetProgress and UpdateProgress, which share the same contract. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): close review gaps — permission gates, file-access recheck, artifact-true manifests Review findings on #258: - UpdateSubscription now applies the same feature/DownloadAllowed gate as CreateSubscription and SyncSubscriptions; a PATCH could previously re-activate or widen a monitor and register managed rows after an admin disabled downloads or revoked the user. - Serving download bytes (managed and ephemeral) and /direct-download now mirror playback's per-file authorization via catalog.FileAllowedByAccess: library scope and the profile's max playback quality are re-checked at serve time, with artifact-backed rows checked against the artifact's resolution (a 720p transcode of a 4K source stays servable under a 1080p ceiling). - Offline manifests for remux/transcode entries now describe the prepared artifact (container, codecs, resolution, single selected audio track) instead of the catalog source file the client never receives. - ArtifactRepository.Requeue reports ErrNotFound when the row was concurrently swept; ArtifactManager.Ensure recreates the job in that case instead of linking downloads to a dead artifact id. - "No downloadable episodes" is a sentinel (mapped to 404 no_downloadable_episodes) rather than a bare error that surfaced as 500. - Subscription season_numbers are bounds-checked (0–9999) before the int32 narrowing in the repo could silently wrap them. - HandlePatchDownload reuses requireManaged instead of hand-rolling the same managed-identity checks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
751 lines
26 KiB
Go
751 lines
26 KiB
Go
package handlers
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"log/slog"
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
"github.com/google/uuid"
|
|
|
|
"github.com/Silo-Server/silo-server/internal/access"
|
|
apimw "github.com/Silo-Server/silo-server/internal/api/middleware"
|
|
"github.com/Silo-Server/silo-server/internal/models"
|
|
"github.com/Silo-Server/silo-server/internal/userstore"
|
|
)
|
|
|
|
// ProfileHandler handles profile CRUD endpoints.
|
|
type ProfileHandler struct {
|
|
storeProvider userstore.UserStoreProvider
|
|
SessionsReader playbackSessionsReader
|
|
UserRepo interface {
|
|
GetByID(ctx context.Context, id int) (*models.User, error)
|
|
}
|
|
ProfileTokens *access.ProfileTokenService
|
|
AvatarStore profileAvatarStore
|
|
AvatarTTL time.Duration
|
|
// DeviceLibraryPurger removes a deleted profile's device rows (and, via
|
|
// cascade, its managed downloads and subscriptions). Profiles may live
|
|
// outside Postgres, so no FK cascade covers these shared tables.
|
|
DeviceLibraryPurger interface {
|
|
PurgeProfileDevices(ctx context.Context, userID int, profileID string) error
|
|
}
|
|
}
|
|
|
|
// NewProfileHandler creates a new ProfileHandler.
|
|
func NewProfileHandler(provider userstore.UserStoreProvider) *ProfileHandler {
|
|
return &ProfileHandler{
|
|
storeProvider: provider,
|
|
AvatarTTL: 15 * time.Minute,
|
|
}
|
|
}
|
|
|
|
// --- Request/Response types ---
|
|
|
|
type createProfileRequest struct {
|
|
Name string `json:"name"`
|
|
Avatar string `json:"avatar,omitempty"`
|
|
PIN string `json:"pin,omitempty"`
|
|
IsChild bool `json:"is_child"`
|
|
MaxContentRating string `json:"max_content_rating,omitempty"`
|
|
QualityPreference string `json:"quality_preference,omitempty"`
|
|
Language string `json:"language,omitempty"`
|
|
PreferredMetadataLanguage string `json:"preferred_metadata_language,omitempty"`
|
|
SubtitleLanguage string `json:"subtitle_language,omitempty"`
|
|
SubtitleMode string `json:"subtitle_mode,omitempty"`
|
|
AutoSkipIntro bool `json:"auto_skip_intro"`
|
|
AutoSkipCredits bool `json:"auto_skip_credits"`
|
|
AutoSkipRecap bool `json:"auto_skip_recap"`
|
|
AutoPlayNextPreview bool `json:"auto_play_next_preview"`
|
|
ShowForcedSubtitles *bool `json:"show_forced_subtitles,omitempty"`
|
|
LibraryRestrictionsEnabled bool `json:"library_restrictions_enabled"`
|
|
AllowedLibraryIDs []int `json:"allowed_library_ids"`
|
|
MaxPlaybackQuality string `json:"max_playback_quality"`
|
|
}
|
|
|
|
type updateProfileRequest struct {
|
|
Name *string `json:"name,omitempty"`
|
|
Avatar *string `json:"avatar,omitempty"`
|
|
PIN *string `json:"pin,omitempty"`
|
|
IsChild *bool `json:"is_child,omitempty"`
|
|
MaxContentRating *string `json:"max_content_rating,omitempty"`
|
|
QualityPreference *string `json:"quality_preference,omitempty"`
|
|
Language *string `json:"language,omitempty"`
|
|
PreferredMetadataLanguage *string `json:"preferred_metadata_language,omitempty"`
|
|
SubtitleLanguage *string `json:"subtitle_language,omitempty"`
|
|
SubtitleMode *string `json:"subtitle_mode,omitempty"`
|
|
AutoSkipIntro *bool `json:"auto_skip_intro,omitempty"`
|
|
AutoSkipCredits *bool `json:"auto_skip_credits,omitempty"`
|
|
AutoSkipRecap *bool `json:"auto_skip_recap,omitempty"`
|
|
AutoPlayNextPreview *bool `json:"auto_play_next_preview,omitempty"`
|
|
ShowForcedSubtitles *bool `json:"show_forced_subtitles,omitempty"`
|
|
LibraryRestrictionsEnabled *bool `json:"library_restrictions_enabled,omitempty"`
|
|
AllowedLibraryIDs *[]int `json:"allowed_library_ids,omitempty"`
|
|
MaxPlaybackQuality *string `json:"max_playback_quality,omitempty"`
|
|
}
|
|
|
|
type verifyPINRequest struct {
|
|
PIN string `json:"pin"`
|
|
}
|
|
|
|
type profileResponse struct {
|
|
ID string `json:"id"`
|
|
Name string `json:"name"`
|
|
Avatar string `json:"avatar,omitempty"`
|
|
AvatarURL string `json:"avatar_url,omitempty"`
|
|
AvatarSource string `json:"avatar_source,omitempty"`
|
|
HasPIN bool `json:"has_pin"`
|
|
IsChild bool `json:"is_child"`
|
|
IsPrimary bool `json:"is_primary"`
|
|
MaxContentRating string `json:"max_content_rating,omitempty"`
|
|
QualityPreference string `json:"quality_preference,omitempty"`
|
|
Language string `json:"language,omitempty"`
|
|
PreferredMetadataLanguage string `json:"preferred_metadata_language,omitempty"`
|
|
SubtitleLanguage string `json:"subtitle_language,omitempty"`
|
|
SubtitleMode string `json:"subtitle_mode,omitempty"`
|
|
AutoSkipIntro bool `json:"auto_skip_intro"`
|
|
AutoSkipCredits bool `json:"auto_skip_credits"`
|
|
AutoSkipRecap bool `json:"auto_skip_recap"`
|
|
AutoPlayNextPreview bool `json:"auto_play_next_preview"`
|
|
ShowForcedSubtitles bool `json:"show_forced_subtitles"`
|
|
LibraryRestrictionsEnabled bool `json:"library_restrictions_enabled"`
|
|
AllowedLibraryIDs []int `json:"allowed_library_ids"`
|
|
MaxPlaybackQuality string `json:"max_playback_quality"`
|
|
CreatedAt string `json:"created_at"`
|
|
UpdatedAt string `json:"updated_at"`
|
|
}
|
|
|
|
type profileListResponse struct {
|
|
Profiles []profileResponse `json:"profiles"`
|
|
AvatarUploadEnabled bool `json:"avatar_upload_enabled"`
|
|
}
|
|
|
|
type verifyPINResponse struct {
|
|
Valid bool `json:"valid"`
|
|
ProfileToken string `json:"profile_token,omitempty"`
|
|
ExpiresAt string `json:"expires_at,omitempty"`
|
|
}
|
|
|
|
// canManageHouseholdProfiles reports whether the caller may create/update/delete
|
|
// profiles belonging to their user. Server admins always can. Otherwise the
|
|
// caller's active profile must be the primary profile for the household.
|
|
//
|
|
// When that primary profile has a PIN, management also requires a valid
|
|
// X-Profile-Token from `/profiles/{id}/verify-pin`; otherwise a client could
|
|
// bypass the profile lock by sending only X-Profile-Id.
|
|
func (h *ProfileHandler) canManageHouseholdProfiles(r *http.Request, store userstore.UserStore) (bool, error) {
|
|
ctx := r.Context()
|
|
if apimw.IsAdmin(ctx) {
|
|
return true, nil
|
|
}
|
|
activeProfileID := apimw.GetProfileID(ctx)
|
|
if activeProfileID == "" {
|
|
activeProfileID = r.Header.Get("X-Profile-Id")
|
|
}
|
|
if activeProfileID == "" {
|
|
return false, nil
|
|
}
|
|
active, err := store.GetProfile(ctx, activeProfileID)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
if active == nil {
|
|
return false, nil
|
|
}
|
|
if !active.IsPrimary {
|
|
return false, nil
|
|
}
|
|
if active.PINHash == "" {
|
|
return true, nil
|
|
}
|
|
if err := h.requireVerifiedProfileToken(r, active.ID); err != nil {
|
|
return false, err
|
|
}
|
|
return true, nil
|
|
}
|
|
|
|
func (h *ProfileHandler) requireVerifiedProfileToken(r *http.Request, profileID string) error {
|
|
if h.UserRepo == nil || h.ProfileTokens == nil {
|
|
return access.ErrProfileUnverified
|
|
}
|
|
|
|
claims := apimw.GetClaims(r.Context())
|
|
if claims == nil || claims.SessionID == "" {
|
|
return access.ErrProfileUnverified
|
|
}
|
|
|
|
userID := apimw.GetUserID(r.Context())
|
|
if userID == 0 {
|
|
return access.ErrProfileUnverified
|
|
}
|
|
|
|
user, err := h.UserRepo.GetByID(r.Context(), userID)
|
|
if err != nil {
|
|
return fmt.Errorf("loading user policy: %w", err)
|
|
}
|
|
if user == nil {
|
|
return access.ErrProfileUnverified
|
|
}
|
|
|
|
profileClaims, err := h.ProfileTokens.Validate(r.Header.Get("X-Profile-Token"))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if profileClaims.UserID != userID ||
|
|
profileClaims.SessionID != claims.SessionID ||
|
|
profileClaims.ProfileID != profileID ||
|
|
profileClaims.PolicyRevision != user.AccessPolicyRevision {
|
|
return access.ErrProfileUnverified
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func writeProfileManagementPermissionError(w http.ResponseWriter, err error) {
|
|
if errors.Is(err, access.ErrProfileUnverified) {
|
|
writeError(w, http.StatusForbidden, "forbidden", "Profile management requires verifying the primary profile PIN")
|
|
return
|
|
}
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to check profile permissions")
|
|
}
|
|
|
|
// isAllowedSelfServiceProfileUpdate reports whether a non-admin update request
|
|
// only touches fields the user is allowed to change on their own profiles.
|
|
// Admin-only fields (access policy: library restrictions, content rating,
|
|
// playback-quality cap, child-profile flag) must be rejected for non-admins.
|
|
func isAllowedSelfServiceProfileUpdate(req updateProfileRequest) bool {
|
|
return req.IsChild == nil &&
|
|
req.MaxContentRating == nil &&
|
|
req.LibraryRestrictionsEnabled == nil &&
|
|
req.AllowedLibraryIDs == nil &&
|
|
req.MaxPlaybackQuality == nil
|
|
}
|
|
|
|
// --- Handler methods ---
|
|
|
|
// HandleListProfiles handles GET /profiles.
|
|
func (h *ProfileHandler) HandleListProfiles(w http.ResponseWriter, r *http.Request) {
|
|
userID := apimw.GetUserID(r.Context())
|
|
if userID == 0 {
|
|
writeError(w, http.StatusUnauthorized, "unauthorized", "Authentication required")
|
|
return
|
|
}
|
|
|
|
store, err := h.storeProvider.ForUser(r.Context(), userID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to access user store")
|
|
return
|
|
}
|
|
|
|
profiles, err := store.ListProfiles(r.Context())
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to list profiles")
|
|
return
|
|
}
|
|
|
|
resp := profileListResponse{
|
|
Profiles: make([]profileResponse, 0, len(profiles)),
|
|
AvatarUploadEnabled: h.AvatarStore != nil,
|
|
}
|
|
for _, p := range profiles {
|
|
resp.Profiles = append(resp.Profiles, h.toProfileResponse(r.Context(), p))
|
|
}
|
|
|
|
writeJSON(w, http.StatusOK, resp)
|
|
}
|
|
|
|
// HandleCreateProfile handles POST /profiles.
|
|
func (h *ProfileHandler) HandleCreateProfile(w http.ResponseWriter, r *http.Request) {
|
|
userID := apimw.GetUserID(r.Context())
|
|
if userID == 0 {
|
|
writeError(w, http.StatusUnauthorized, "unauthorized", "Authentication required")
|
|
return
|
|
}
|
|
|
|
var req createProfileRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Invalid request body")
|
|
return
|
|
}
|
|
|
|
if req.Name == "" {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Profile name is required")
|
|
return
|
|
}
|
|
avatarRef, err := normalizePresetAvatarReference(req.Avatar)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, "bad_request", err.Error())
|
|
return
|
|
}
|
|
|
|
maxPlaybackQuality, ok := access.ParsePlaybackQualityPreset(req.MaxPlaybackQuality)
|
|
if !ok {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Invalid max_playback_quality")
|
|
return
|
|
}
|
|
|
|
store, err := h.storeProvider.ForUser(r.Context(), userID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to access user store")
|
|
return
|
|
}
|
|
existingProfiles, err := store.ListProfiles(r.Context())
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to list profiles")
|
|
return
|
|
}
|
|
// The very first profile on a user can be bootstrapped without
|
|
// primary/admin privileges (it becomes the primary); everything after
|
|
// requires either the server admin role or the caller's active profile
|
|
// being primary.
|
|
isBootstrap := len(existingProfiles) == 0
|
|
if !isBootstrap {
|
|
allowed, err := h.canManageHouseholdProfiles(r, store)
|
|
if err != nil {
|
|
writeProfileManagementPermissionError(w, err)
|
|
return
|
|
}
|
|
if !allowed {
|
|
writeError(w, http.StatusForbidden, "forbidden", "Profile management requires the primary profile or admin access")
|
|
return
|
|
}
|
|
}
|
|
// Access-policy fields only make sense when set by a manager on a managed
|
|
// profile. On bootstrap the caller is becoming primary themselves, so non-
|
|
// admin bootstrap creations must leave those fields at their defaults.
|
|
if isBootstrap && !apimw.IsAdmin(r.Context()) &&
|
|
(req.IsChild || req.MaxContentRating != "" ||
|
|
req.LibraryRestrictionsEnabled || len(req.AllowedLibraryIDs) > 0 ||
|
|
req.MaxPlaybackQuality != "") {
|
|
writeError(
|
|
w,
|
|
http.StatusForbidden,
|
|
"forbidden",
|
|
"Profile access settings require the primary profile or admin access",
|
|
)
|
|
return
|
|
}
|
|
if h.UserRepo != nil {
|
|
user, err := h.UserRepo.GetByID(r.Context(), userID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to load user")
|
|
return
|
|
}
|
|
if user != nil && user.MaxProfiles >= 1 && len(existingProfiles) >= user.MaxProfiles {
|
|
writeError(
|
|
w,
|
|
http.StatusConflict,
|
|
"profile_limit_reached",
|
|
fmt.Sprintf("This account has reached its profile limit (%d)", user.MaxProfiles),
|
|
)
|
|
return
|
|
}
|
|
}
|
|
|
|
showForcedSubtitles := true
|
|
if req.ShowForcedSubtitles != nil {
|
|
showForcedSubtitles = *req.ShowForcedSubtitles
|
|
}
|
|
|
|
profileID := uuid.New().String()
|
|
profile := userstore.Profile{
|
|
ID: profileID,
|
|
Name: req.Name,
|
|
Avatar: avatarRef,
|
|
IsChild: req.IsChild,
|
|
MaxContentRating: req.MaxContentRating,
|
|
QualityPreference: req.QualityPreference,
|
|
Language: req.Language,
|
|
PreferredMetadataLanguage: req.PreferredMetadataLanguage,
|
|
SubtitleLanguage: req.SubtitleLanguage,
|
|
SubtitleMode: req.SubtitleMode,
|
|
AutoSkipIntro: req.AutoSkipIntro,
|
|
AutoSkipCredits: req.AutoSkipCredits,
|
|
AutoSkipRecap: req.AutoSkipRecap,
|
|
AutoPlayNextPreview: req.AutoPlayNextPreview,
|
|
ShowForcedSubtitles: showForcedSubtitles,
|
|
LibraryRestrictionsEnabled: req.LibraryRestrictionsEnabled,
|
|
AllowedLibraryIDs: req.AllowedLibraryIDs,
|
|
MaxPlaybackQuality: maxPlaybackQuality,
|
|
}
|
|
|
|
if err := store.CreateProfile(r.Context(), profile); err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to create profile")
|
|
return
|
|
}
|
|
|
|
// Fetch the created profile directly by ID (no race condition).
|
|
createdPtr, err := store.GetProfile(r.Context(), profileID)
|
|
if err != nil || createdPtr == nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to retrieve created profile")
|
|
return
|
|
}
|
|
created := *createdPtr
|
|
|
|
// If PIN was provided, update the profile to set it.
|
|
if req.PIN != "" {
|
|
if err := store.UpdateProfile(r.Context(), created.ID, userstore.UpdateProfileInput{
|
|
PIN: &req.PIN,
|
|
}); err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to set profile PIN")
|
|
return
|
|
}
|
|
// Re-read the profile to get the updated state.
|
|
p, err := store.GetProfile(r.Context(), created.ID)
|
|
if err != nil || p == nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to retrieve profile after PIN set")
|
|
return
|
|
}
|
|
created = *p
|
|
}
|
|
if req.ShowForcedSubtitles != nil && !*req.ShowForcedSubtitles {
|
|
if err := store.UpdateProfile(r.Context(), created.ID, userstore.UpdateProfileInput{
|
|
ShowForcedSubtitles: req.ShowForcedSubtitles,
|
|
}); err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to set forced subtitle preference")
|
|
return
|
|
}
|
|
p, err := store.GetProfile(r.Context(), created.ID)
|
|
if err != nil || p == nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to retrieve profile after forced subtitle update")
|
|
return
|
|
}
|
|
created = *p
|
|
}
|
|
|
|
writeJSON(w, http.StatusCreated, h.toProfileResponse(r.Context(), created))
|
|
}
|
|
|
|
// HandleUpdateProfile handles PUT /profiles/{id}.
|
|
func (h *ProfileHandler) HandleUpdateProfile(w http.ResponseWriter, r *http.Request) {
|
|
userID := apimw.GetUserID(r.Context())
|
|
if userID == 0 {
|
|
writeError(w, http.StatusUnauthorized, "unauthorized", "Authentication required")
|
|
return
|
|
}
|
|
|
|
profileID := chi.URLParam(r, "id")
|
|
if profileID == "" {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Profile ID is required")
|
|
return
|
|
}
|
|
|
|
var req updateProfileRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Invalid request body")
|
|
return
|
|
}
|
|
var avatarRef *string
|
|
if req.Avatar != nil {
|
|
normalized, err := normalizePresetAvatarReference(*req.Avatar)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, "bad_request", err.Error())
|
|
return
|
|
}
|
|
avatarRef = &normalized
|
|
}
|
|
|
|
var maxPlaybackQuality *string
|
|
if req.MaxPlaybackQuality != nil {
|
|
normalized, ok := access.ParsePlaybackQualityPreset(*req.MaxPlaybackQuality)
|
|
if !ok {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Invalid max_playback_quality")
|
|
return
|
|
}
|
|
maxPlaybackQuality = &normalized
|
|
}
|
|
|
|
store, err := h.storeProvider.ForUser(r.Context(), userID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to access user store")
|
|
return
|
|
}
|
|
currentProfile, err := store.GetProfile(r.Context(), profileID)
|
|
if err != nil || currentProfile == nil {
|
|
writeError(w, http.StatusNotFound, "not_found", "Profile not found")
|
|
return
|
|
}
|
|
|
|
canManage, err := h.canManageHouseholdProfiles(r, store)
|
|
if err != nil {
|
|
writeProfileManagementPermissionError(w, err)
|
|
return
|
|
}
|
|
if !canManage {
|
|
// Non-managers may only update their own active profile and only a
|
|
// narrow set of playback preferences.
|
|
activeProfileID := apimw.GetProfileID(r.Context())
|
|
if activeProfileID == "" {
|
|
activeProfileID = r.Header.Get("X-Profile-Id")
|
|
}
|
|
if activeProfileID == "" || activeProfileID != profileID {
|
|
writeError(
|
|
w,
|
|
http.StatusForbidden,
|
|
"forbidden",
|
|
"You can only update the active profile's playback preferences",
|
|
)
|
|
return
|
|
}
|
|
if !isAllowedSelfServiceProfileUpdate(req) {
|
|
writeError(
|
|
w,
|
|
http.StatusForbidden,
|
|
"forbidden",
|
|
"Profile access settings require the primary profile or admin access",
|
|
)
|
|
return
|
|
}
|
|
}
|
|
|
|
input := userstore.UpdateProfileInput{
|
|
Name: req.Name,
|
|
Avatar: avatarRef,
|
|
PIN: req.PIN,
|
|
IsChild: req.IsChild,
|
|
MaxContentRating: req.MaxContentRating,
|
|
QualityPreference: req.QualityPreference,
|
|
Language: req.Language,
|
|
PreferredMetadataLanguage: req.PreferredMetadataLanguage,
|
|
SubtitleLanguage: req.SubtitleLanguage,
|
|
SubtitleMode: req.SubtitleMode,
|
|
AutoSkipIntro: req.AutoSkipIntro,
|
|
AutoSkipCredits: req.AutoSkipCredits,
|
|
AutoSkipRecap: req.AutoSkipRecap,
|
|
AutoPlayNextPreview: req.AutoPlayNextPreview,
|
|
ShowForcedSubtitles: req.ShowForcedSubtitles,
|
|
LibraryRestrictionsEnabled: req.LibraryRestrictionsEnabled,
|
|
AllowedLibraryIDs: req.AllowedLibraryIDs,
|
|
MaxPlaybackQuality: maxPlaybackQuality,
|
|
}
|
|
|
|
if err := store.UpdateProfile(r.Context(), profileID, input); err != nil {
|
|
writeError(w, http.StatusNotFound, "not_found", "Profile not found")
|
|
return
|
|
}
|
|
if currentProfile.Avatar != "" && avatarRef != nil && avatarRefReplacesUpload(currentProfile.Avatar, *avatarRef) {
|
|
if cleanupErr := deleteUploadedAvatarObjects(r.Context(), h.AvatarStore, userID, profileID); cleanupErr != nil {
|
|
slog.Warn("profile avatar cleanup failed after update", "user_id", userID, "profile_id", profileID, "error", cleanupErr)
|
|
}
|
|
}
|
|
|
|
// Re-read the profile to return the updated state.
|
|
profile, err := store.GetProfile(r.Context(), profileID)
|
|
if err != nil || profile == nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to retrieve updated profile")
|
|
return
|
|
}
|
|
|
|
writeJSON(w, http.StatusOK, h.toProfileResponse(r.Context(), *profile))
|
|
}
|
|
|
|
// HandleDeleteProfile handles DELETE /profiles/{id}.
|
|
func (h *ProfileHandler) HandleDeleteProfile(w http.ResponseWriter, r *http.Request) {
|
|
userID := apimw.GetUserID(r.Context())
|
|
if userID == 0 {
|
|
writeError(w, http.StatusUnauthorized, "unauthorized", "Authentication required")
|
|
return
|
|
}
|
|
|
|
profileID := chi.URLParam(r, "id")
|
|
if profileID == "" {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Profile ID is required")
|
|
return
|
|
}
|
|
|
|
store, err := h.storeProvider.ForUser(r.Context(), userID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to access user store")
|
|
return
|
|
}
|
|
allowed, err := h.canManageHouseholdProfiles(r, store)
|
|
if err != nil {
|
|
writeProfileManagementPermissionError(w, err)
|
|
return
|
|
}
|
|
if !allowed {
|
|
writeError(w, http.StatusForbidden, "forbidden", "Profile management requires the primary profile or admin access")
|
|
return
|
|
}
|
|
profile, err := store.GetProfile(r.Context(), profileID)
|
|
if err != nil || profile == nil {
|
|
writeError(w, http.StatusNotFound, "not_found", "Profile not found")
|
|
return
|
|
}
|
|
if profile.IsPrimary {
|
|
writeError(
|
|
w,
|
|
http.StatusConflict,
|
|
"primary_profile_protected",
|
|
"The primary profile cannot be deleted. Delete the user account instead.",
|
|
)
|
|
return
|
|
}
|
|
|
|
if err := store.DeleteProfile(r.Context(), profileID); err != nil {
|
|
writeError(w, http.StatusNotFound, "not_found", "Profile not found")
|
|
return
|
|
}
|
|
if isUploadedAvatarRef(profile.Avatar) {
|
|
if cleanupErr := deleteUploadedAvatarObjects(r.Context(), h.AvatarStore, userID, profileID); cleanupErr != nil {
|
|
slog.Warn("profile avatar cleanup failed after delete", "user_id", userID, "profile_id", profileID, "error", cleanupErr)
|
|
}
|
|
}
|
|
if h.DeviceLibraryPurger != nil {
|
|
purgeCtx, cancel := context.WithTimeout(context.WithoutCancel(r.Context()), 30*time.Second)
|
|
defer cancel()
|
|
if purgeErr := h.DeviceLibraryPurger.PurgeProfileDevices(purgeCtx, userID, profileID); purgeErr != nil {
|
|
slog.Warn("profile device-library purge failed after delete", "user_id", userID, "profile_id", profileID, "error", purgeErr)
|
|
}
|
|
}
|
|
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|
|
|
|
// HandleVerifyPIN handles POST /profiles/{id}/verify-pin.
|
|
func (h *ProfileHandler) HandleVerifyPIN(w http.ResponseWriter, r *http.Request) {
|
|
userID := apimw.GetUserID(r.Context())
|
|
if userID == 0 {
|
|
writeError(w, http.StatusUnauthorized, "unauthorized", "Authentication required")
|
|
return
|
|
}
|
|
|
|
profileID := chi.URLParam(r, "id")
|
|
if profileID == "" {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Profile ID is required")
|
|
return
|
|
}
|
|
|
|
var req verifyPINRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Invalid request body")
|
|
return
|
|
}
|
|
|
|
if req.PIN == "" {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "PIN is required")
|
|
return
|
|
}
|
|
|
|
store, err := h.storeProvider.ForUser(r.Context(), userID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to access user store")
|
|
return
|
|
}
|
|
|
|
valid, err := store.VerifyPIN(r.Context(), profileID, req.PIN)
|
|
if err != nil {
|
|
writeError(w, http.StatusNotFound, "not_found", "Profile not found or has no PIN")
|
|
return
|
|
}
|
|
if !valid || h.UserRepo == nil || h.ProfileTokens == nil {
|
|
writeJSON(w, http.StatusOK, verifyPINResponse{Valid: valid})
|
|
return
|
|
}
|
|
|
|
claims := apimw.GetClaims(r.Context())
|
|
if claims == nil {
|
|
writeError(w, http.StatusUnauthorized, "unauthorized", "Authentication required")
|
|
return
|
|
}
|
|
|
|
user, err := h.UserRepo.GetByID(r.Context(), userID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to load user policy")
|
|
return
|
|
}
|
|
|
|
token, expiresAt, err := h.ProfileTokens.Mint(access.ProfileTokenClaims{
|
|
UserID: userID,
|
|
SessionID: claims.SessionID,
|
|
ProfileID: profileID,
|
|
PolicyRevision: user.AccessPolicyRevision,
|
|
})
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to issue profile token")
|
|
return
|
|
}
|
|
|
|
resp := verifyPINResponse{
|
|
Valid: true,
|
|
ProfileToken: token,
|
|
}
|
|
if !expiresAt.IsZero() {
|
|
resp.ExpiresAt = expiresAt.UTC().Format(time.RFC3339)
|
|
}
|
|
|
|
writeJSON(w, http.StatusOK, resp)
|
|
}
|
|
|
|
// --- Helpers ---
|
|
|
|
func (h *ProfileHandler) toProfileResponse(ctx context.Context, p userstore.Profile) profileResponse {
|
|
avatarSource, avatarURL := resolveProfileAvatar(ctx, h.AvatarStore, h.AvatarTTL, p.Avatar)
|
|
return profileResponse{
|
|
ID: p.ID,
|
|
Name: p.Name,
|
|
Avatar: p.Avatar,
|
|
AvatarURL: avatarURL,
|
|
AvatarSource: avatarSource,
|
|
HasPIN: p.PINHash != "",
|
|
IsChild: p.IsChild,
|
|
IsPrimary: p.IsPrimary,
|
|
MaxContentRating: p.MaxContentRating,
|
|
QualityPreference: p.QualityPreference,
|
|
Language: p.Language,
|
|
PreferredMetadataLanguage: p.PreferredMetadataLanguage,
|
|
SubtitleLanguage: p.SubtitleLanguage,
|
|
SubtitleMode: p.SubtitleMode,
|
|
AutoSkipIntro: p.AutoSkipIntro,
|
|
AutoSkipCredits: p.AutoSkipCredits,
|
|
AutoSkipRecap: p.AutoSkipRecap,
|
|
AutoPlayNextPreview: p.AutoPlayNextPreview,
|
|
ShowForcedSubtitles: p.ShowForcedSubtitles,
|
|
LibraryRestrictionsEnabled: p.LibraryRestrictionsEnabled,
|
|
AllowedLibraryIDs: append([]int(nil), p.AllowedLibraryIDs...),
|
|
MaxPlaybackQuality: access.NormalizePlaybackQuality(p.MaxPlaybackQuality),
|
|
CreatedAt: p.CreatedAt,
|
|
UpdatedAt: p.UpdatedAt,
|
|
}
|
|
}
|
|
|
|
// HandleListHouseholdSessions handles GET /profiles/household/sessions.
|
|
func (h *ProfileHandler) HandleListHouseholdSessions(w http.ResponseWriter, r *http.Request) {
|
|
userID := apimw.GetUserID(r.Context())
|
|
if userID == 0 {
|
|
writeError(w, http.StatusUnauthorized, "unauthorized", "Authentication required")
|
|
return
|
|
}
|
|
|
|
store, err := h.storeProvider.ForUser(r.Context(), userID)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to access user store")
|
|
return
|
|
}
|
|
allowed, err := h.canManageHouseholdProfiles(r, store)
|
|
if err != nil {
|
|
writeProfileManagementPermissionError(w, err)
|
|
return
|
|
}
|
|
if !allowed {
|
|
writeError(w, http.StatusForbidden, "forbidden", "Profile management requires the primary profile or admin access")
|
|
return
|
|
}
|
|
if h.SessionsReader == nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Playback sessions are not configured")
|
|
return
|
|
}
|
|
|
|
sessions, err := h.SessionsReader.Load(r.Context(), r, PlaybackSessionsQuery{UserID: userID})
|
|
if err != nil {
|
|
slog.Error("failed to list household playback sessions", "user_id", userID, "error", err)
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to list playback sessions")
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, sessions)
|
|
}
|