* feat(downloads): offline sync for mobile (downloads v2) Replace internal/download with a unified internal/downloads package and add fully-offline download + watch-sync support for mobile clients, across five independently-shippable phases: - Phase 0: reshape the downloads table and the /downloads contract to be device- and format-aware; add GET /downloads/capability; extend DownloadConfig (default-off keys); update the web download hooks/components in lockstep. This is the one approved pre-lock exception to the additive-only /api/v1 rule (the web app is the only consumer and is updated together). - Phase 1: managed device-library entries (create/list/PATCH/delete/serve), keyed on the X-Silo-Device-Id header. - Phase 2: offline playback manifest plus artwork/subtitle proxy endpoints that strip every presigned URL (inline thumbhashes + authenticated proxies). - Phase 3: prepare-to-file (remux + transcode-to-single-file) as a durable, leased artifact queue with startup recovery, hosted on the task manager; playback.PrepareFile emits one +faststart MP4. Adds the admin transcode toggle and per-artifact LRU cleanup. - Phase 4: offline progress reconciliation -- a clamped event_at LWW key plus a server-assigned synced_seq cursor on watch_progress; an optional clamped updated_at on POST /sync/progress and an opaque ?since= cursor on GET /progress (additive; existing callers unaffected). Security & reliability invariants, each with an acceptance test: 1. Server-owned sync ordering: ?since= delta delivery is driven only by the server-assigned synced_seq; the client clock is bounded (event_at, clamped to now+skew) and used only for last-write-wins on the caller's own profile. 2. Full profile+device authorization on every managed endpoint, with a per-profile content/library access re-check before serving any bytes/assets. 3. Durable artifact recovery: a transactionally-claimed (FOR UPDATE SKIP LOCKED), lease-heartbeat, attempt-counted queue with a startup sweep, so no crash strands a download in preparing and concurrent workers never double-encode. Migrations are timestamped Goose files: reshape downloads (device/format); download_artifacts (durable queue); watch_progress event_at/synced_seq. DB-backed acceptance tests skip without SILO_TEST_DATABASE_URL and run in CI; the invariant-1 progress test also runs against the real SQLite backend locally. Client repos (silo-android, silo-apple) consume the reshaped /downloads/* contract and the updated_at/?since= progress fields and require coordinated follow-up. Implements the maintainer-approved v1 capability proposal for offline sync (downloads v2). AI-use disclosure: implemented by Claude (Claude Code) from the approved design doc under docs/superpowers/specs, with human review. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * feat(downloads): series & season downloads + client-pull monitoring Build season downloads and a "monitor a series" capability on top of the downloads v2 (offline sync for mobile) work. Season downloads: - POST /downloads accepts season_number (with series:true) to download one season. CreateSeries/CreateSeason share one body via a listEpisodes closure and register managed entries under a shared batch_id (original-only). Episode files are resolved in a single batched query. Series monitoring (auto-download), client-driven: - New device-scoped download_subscriptions table with a Sonarr-style mode (all | future | latest_season | specific_seasons), a client-enforced delete_watched flag, and a max_storage_bytes cap. The server never deletes on-device files; retention and the hard cap are the client's, the server only soft-gates registration. - The client calls POST /downloads/subscriptions/sync on open / background refresh; the server registers the in-scope, not-yet-downloaded episodes (idempotent via the managed-entry unique index) and the device pulls them on its own schedule. No background worker and no dependency on the notifications subsystem. latest_season follows new seasons (>= subscribe-time season); future excludes the back catalog via air date. - Subscription CRUD + sync are profile+device authorized (device id from the X-Silo-Device-Id header only) with a per-request content-access re-check. The capability endpoint advertises season_download / series_monitoring / monitoring_modes. Also lands the downloads-v2 work already present in the tree: durable artifact (remux/transcode) preparation and offline watch-progress reconciliation, plus the design-spec updates. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * WIP: epitaxy pre-switch from feat/downloads-v2-offline-sync * test(downloads): fix deterministic ID collision in reconcile test Artifact IDs are time-sortable, so two artifacts created in the same moment share their first 8 chars; combined with a captured timestamp the two preparing-download IDs collided on downloads_pkey. Use the full artifact ID, which is unique per row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): support sqlite userdb backend for managed downloads With the sqlite userdb backend, profiles live only in per-user SQLite stores and public.user_profiles stays empty, so user_devices' profile FK made every managed create/subscription/offline-sync request fail with an FK violation. Drop the FK (shared Postgres tables must not FK profile tables — same rule as notifications) and replace the lost cascade with an app-level purge on profile deletion, wired through ProfileHandler for both backends. DB-backed regression tests cover the no-Postgres-profile-row path and the purge cascade. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): dispatch encode kick asynchronously triggerDrain invoked the kick inline, and the kick (taskmanager RunTask) executes the encode task on the caller's goroutine — so a POST /api/v1/downloads with a bitrate quality blocked the HTTP request on the entire queue drain, ffmpeg encodes included, delaying the 202 by minutes on an idle queue. Dispatch the kick on a goroutine; the task manager already serializes concurrent runs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): enforce per-user quota on the encode pipeline Two gaps let a user bypass MaxConcurrentPerUser entirely for prepared downloads: artifact-backed rows are created in 'preparing' (never 'queued'/'downloading'), which CountActiveByUser didn't count, and createArtifactDownload enqueued the encode job before limiter.Check, so even a 429-rejected request left a job the worker would transcode. Count 'preparing' as active and check the limiter before Ensure; managed replacements stay quota-exempt since they don't add a row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): protect ephemeral artifact links from LRU eviction HasActiveLink only counted managed (device_id IS NOT NULL) rows, so under a byte budget Cleanup could delete an artifact still referenced by a ready-but-unfetched ephemeral web download — permanently 404ing a row the API kept listing as ready (the artifact row is gone, so recovery can't re-queue it). Any non-terminal link now protects the artifact; only artifacts whose links are all cancelled/failed/revoked are evictable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): batch manifests skip bad entries instead of failing whole batch One deleted or access-filtered episode made GET /downloads/batches/{id}/manifests 404 for the entire season, so a client could no longer fetch manifests for the still-valid entries. Report unbuildable entries in a skipped[] array (revoked | not_found | error) alongside the delivered manifests, mirroring the create path's skip idiom. Also cut the batch cost: the shared series detail is resolved once per batch instead of once per episode, and buildSubtitles reuses the already-loaded media file instead of re-querying it per manifest. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(migrations): wrap DO block in StatementBegin/End markers Under NO TRANSACTION goose splits statements on semicolons, so the dollar-quoted DO block failed every fresh install with 'unterminated dollar-quoted string' (SQLSTATE 42601). Already-applied databases are unaffected. Same fix is being applied to main; identical content merges cleanly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(api): allow season 0 (Specials) in season downloads season_number was a plain int dispatched with '> 0', so requesting the Specials season was indistinguishable from omitting the field and silently broadened to a full-series download. Dispatch on pointer presence, treat 0 as the Specials season, and reject negatives with 400. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): capability quality_presets is never JSON null PresetsFor returned a nil slice when downloads are disabled or the user lacks the permission, and Capability's []string{} initialization was immediately overwritten by it — so GET /downloads/capability serialized "quality_presets": null where the contract documents an array. Normalize at the source so every caller inherits the guarantee. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): subscription sync correctness + batched registration Three subscription fixes: - A paused subscription no longer syncs: PATCHing scope (or pausing and changing scope in one request) registered episodes for a monitor the user had just stopped, inconsistently with SyncSubscriptions' guard. - SubModeFuture compares calendar days (UTC): air_date is date-only, so the strict instant comparison permanently excluded episodes airing the same day the user subscribed; episodes with no air date now fall back to their ingest time instead of never registering. - Registration is one batched fetch (GetManagedEntriesByKeys) plus one batched INSERT ... ON CONFLICT DO NOTHING RETURNING (CreateManagedEntriesBatch) instead of a SELECT+INSERT per episode — a 300-episode series cost ~600 sequential round trips per request and every no-op sync re-walked the full set. RETURNING yields exactly the new rows, so the sync response's 'registered' count now honestly reports 0 in the steady state instead of the full in-scope count on every app open. The now-unused InsertManagedEntryIfAbsent is removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(userstore): stamp triggers own the event_at LWW key MarkProgressBatch (jellycompat series mark-played) advanced updated_at but never event_at, and both stamp triggers only defaulted event_at when NULL — so a queued offline event with a client time between the row's old event_at and the mark could win SetProgressIfNewer and resurrect a stale resume position that then re-synced to every device. Make the triggers authoritative instead of adding a tenth hand-written SET clause: whenever an UPDATE changes updated_at without explicitly changing event_at, the trigger advances the LWW key; writes that do set event_at (offline sync's clamped client event time) keep their value. Postgres gets a CREATE OR REPLACE migration; SQLite gets a v12 userdb migration that drops and reinstalls the trigger bodies (CREATE TRIGGER IF NOT EXISTS never replaces). Conformance tests cover both batch paths, the preserved-client-time invariant, and the v11→v12 upgrade. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): lifecycle hygiene — squash migrations, dead status, stale-row sweeps Migrations: fold the 20260621 corrective migration back into the base Downloads V2 migrations (its columns/constraints already exist there) and fix the reshape Down, which re-added the narrow status CHECK without collapsing managed-lifecycle rows first — rollback aborted on any DB with preparing/ready/revoked rows; validated against a live row. Branch databases that applied the corrective migration need its version row removed: DELETE FROM goose_db_version WHERE version_id = 20260621020459. Code: drop the dead 'registered' status (nothing ever wrote it; the lifecycle is preparing -> ready; 'revoked' stays reserved for the planned admin revoke flow) along with unused KindDirect and ErrInvalidFormat. Sweeps: Cleanup now runs an age-based hygiene pass independent of the byte budget — cold terminally-failed artifacts (with .part leftovers), orphaned ready artifacts no download row references, and ephemeral web rows older than their convenience-record lifetime (also unpinning their artifacts and bounding GET /downloads growth). The byte budget remains the disk quota per the limits & restrictions design. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(downloads): sync API doc with v2 fixes; HEAD on file route; Android handoff Document the contract changes from the review fixes: batch-manifest skipped[] shape, honest subscription 'registered' semantics, season 0 = Specials, always-array quality_presets, bytes_sent actual behavior, ephemeral 7-day retention, header-pairing requirement, progress-delta deletion caveat, and the ready/failed push event schema (new §9.4). Add an Android client handoff section (§11) mirroring the Apple one, register HEAD on /downloads/{id}/file for download stacks that probe before ranged GETs, and add season_number to the web create-request type. Flag the /direct-download session-token-in-URL tradeoff; a short-lived download-scoped URL is a follow-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: consolidate download/progress helpers, prune dead code, gate sweeps Behavior-preserving consolidation from the Downloads V2 review: - appendVideoFilterArgs: one home for the burn-in/hwaccel -vf selection, shared by the HLS builder and the single-file prepare builder (the drift pattern that already bit tone-mapping once). - userstore.ResolveProgressState: one home for the min-resume/watched threshold rule, replacing five identical copies across both store backends and the offline-sync ingest. - Download file selection ranks resolutions via access.CompareQuality (adds 4320p, agrees with playback) instead of a private switch. - writeSubtitle uses the shared subtitles.SubtitleContentType mapping. - config.DefaultTranscodeDir replaces three '/tmp/silo-transcode' literals. - Read-side quality/revision defaulting helpers removed: insertArgs plus the NOT NULL/CHECK schema already guarantee the invariant. - Dead code removed: Repository.ListByUser, SubscriptionRepository. ListActiveBySeries, and the stale auto-register-worker comments (the design is client-pull; no worker exists). - Redundant left-prefix indexes dropped from the base migrations (their unique indexes serve the same prefixes). - recover()'s disk-presence sweep and the stale-row hygiene sweep run on startup then hourly instead of every 30s tick (both are O(cache size)). - gofmt/prettier fixes for pre-existing drift in handlers/playback.go and pages/Profiles.tsx. Deferred (noted for follow-ups): quality-ladder preset table collides with the drafted download limits & restrictions design, which specifies its own ladder helper; Download-literal construction consolidation and the managed-identity value object remain open. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(downloads): draft download limits & restrictions design Design input for the follow-up v1 capability proposal (quality ceiling, batch size cap, per-user quantity/bandwidth overrides). Committed with downloads v2 because the remediation work explicitly defers the quality ladder refactor and revocation wiring to this spec. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(progress): reject malformed updated_at; clamp negative progress inputs Review findings on #258: - A malformed (non-RFC3339) updated_at in POST /sync/progress previously parsed to the zero time, which clampEventAt treated as "now" — letting a stale offline event win LWW as a fresh server-time write. The item is now rejected with a per-item error instead. - ResolveProgressState now clamps negative position/duration before classification so no backend can persist negative progress through UpdateProgress/SetProgress. - The online-write event_at invariant test is table-driven over both SetProgress and UpdateProgress, which share the same contract. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(downloads): close review gaps — permission gates, file-access recheck, artifact-true manifests Review findings on #258: - UpdateSubscription now applies the same feature/DownloadAllowed gate as CreateSubscription and SyncSubscriptions; a PATCH could previously re-activate or widen a monitor and register managed rows after an admin disabled downloads or revoked the user. - Serving download bytes (managed and ephemeral) and /direct-download now mirror playback's per-file authorization via catalog.FileAllowedByAccess: library scope and the profile's max playback quality are re-checked at serve time, with artifact-backed rows checked against the artifact's resolution (a 720p transcode of a 4K source stays servable under a 1080p ceiling). - Offline manifests for remux/transcode entries now describe the prepared artifact (container, codecs, resolution, single selected audio track) instead of the catalog source file the client never receives. - ArtifactRepository.Requeue reports ErrNotFound when the row was concurrently swept; ArtifactManager.Ensure recreates the job in that case instead of linking downloads to a dead artifact id. - "No downloadable episodes" is a sentinel (mapped to 404 no_downloadable_episodes) rather than a bare error that surfaced as 500. - Subscription season_numbers are bounds-checked (0–9999) before the int32 narrowing in the repo could silently wrap them. - HandlePatchDownload reuses requireManaged instead of hand-rolling the same managed-identity checks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
247 lines
8.2 KiB
Go
247 lines
8.2 KiB
Go
package downloads
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"log/slog"
|
|
"net/http"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/Silo-Server/silo-server/internal/catalog"
|
|
"github.com/Silo-Server/silo-server/internal/playback"
|
|
"github.com/Silo-Server/silo-server/internal/subtitles"
|
|
)
|
|
|
|
// authorizeManagedAsset applies invariant-2 row authorization (user, profile,
|
|
// device) and the revoked guard to a managed entry before any asset is served.
|
|
// The per-profile content-access re-check is performed by each caller (via
|
|
// GetItemDetail or EnsureAccessible) before bytes leave the server.
|
|
func (s *Service) authorizeManagedAsset(ctx context.Context, userID int, profileID, deviceID, downloadID string) (*Download, error) {
|
|
if _, err := s.enabledConfig(ctx); err != nil {
|
|
return nil, err
|
|
}
|
|
if profileID == "" || deviceID == "" {
|
|
return nil, ErrProfileRequired
|
|
}
|
|
dl, err := s.repo.GetManagedByID(ctx, downloadID, userID, profileID, deviceID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if dl.Status == StatusRevoked {
|
|
return nil, fmt.Errorf("download is revoked: %w", ErrDownloadNotActive)
|
|
}
|
|
return dl, nil
|
|
}
|
|
|
|
// BuildManifest returns the offline manifest for a managed entry, authorized on
|
|
// (user, profile, device) with a per-profile content-access re-check inside the
|
|
// builder's GetItemDetail call.
|
|
func (s *Service) BuildManifest(ctx context.Context, userID int, profileID, deviceID, downloadID string, filter catalog.AccessFilter) (*OfflineManifest, error) {
|
|
dl, err := s.authorizeManagedAsset(ctx, userID, profileID, deviceID, downloadID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if s.manifest == nil {
|
|
return nil, ErrManifestUnavailable
|
|
}
|
|
return s.manifest.Build(ctx, dl, filter)
|
|
}
|
|
|
|
// SkippedManifest reports a batch entry whose manifest could not be built —
|
|
// one bad episode (revoked, deleted from the catalog, access-filtered) must
|
|
// not make the rest of a season's manifests unfetchable.
|
|
type SkippedManifest struct {
|
|
DownloadID string `json:"download_id"`
|
|
Reason string `json:"reason"` // revoked | not_found | error
|
|
}
|
|
|
|
// BuildBatchManifests returns the manifests for every managed entry in a batch
|
|
// owned by the calling profile/device, plus the entries it had to skip.
|
|
// Entries in one batch share a series, so the series detail is resolved once.
|
|
func (s *Service) BuildBatchManifests(ctx context.Context, userID int, profileID, deviceID, batchID string, filter catalog.AccessFilter) ([]*OfflineManifest, []SkippedManifest, error) {
|
|
if _, err := s.enabledConfig(ctx); err != nil {
|
|
return nil, nil, err
|
|
}
|
|
if profileID == "" || deviceID == "" {
|
|
return nil, nil, ErrProfileRequired
|
|
}
|
|
if s.manifest == nil {
|
|
return nil, nil, ErrManifestUnavailable
|
|
}
|
|
rows, err := s.repo.ListManagedByBatch(ctx, userID, profileID, deviceID, batchID)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
if len(rows) == 0 {
|
|
return nil, nil, ErrNotFound
|
|
}
|
|
out := make([]*OfflineManifest, 0, len(rows))
|
|
skipped := make([]SkippedManifest, 0)
|
|
seriesCache := make(map[string]*catalog.ItemDetail, 1)
|
|
for _, dl := range rows {
|
|
if dl.Status == StatusRevoked {
|
|
skipped = append(skipped, SkippedManifest{DownloadID: dl.ID, Reason: "revoked"})
|
|
continue
|
|
}
|
|
m, err := s.manifest.build(ctx, dl, filter, seriesCache)
|
|
if err != nil {
|
|
reason := "error"
|
|
if errors.Is(err, catalog.ErrItemNotFound) {
|
|
reason = "not_found"
|
|
} else {
|
|
slog.Warn("batch manifest build failed", "download_id", dl.ID, "batch_id", batchID, "error", err)
|
|
}
|
|
skipped = append(skipped, SkippedManifest{DownloadID: dl.ID, Reason: reason})
|
|
continue
|
|
}
|
|
out = append(out, m)
|
|
}
|
|
return out, skipped, nil
|
|
}
|
|
|
|
// ServeArtwork streams poster/backdrop/logo bytes for a managed entry through
|
|
// the image resolver (never a presigned redirect), re-checking per-profile
|
|
// access via GetItemDetail before serving.
|
|
func (s *Service) ServeArtwork(ctx context.Context, w http.ResponseWriter, r *http.Request, userID int, profileID, deviceID, downloadID, kind string, filter catalog.AccessFilter) error {
|
|
dl, err := s.authorizeManagedAsset(ctx, userID, profileID, deviceID, downloadID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if s.artworkSource == nil {
|
|
return ErrManifestUnavailable
|
|
}
|
|
detail, err := s.artworkSource.GetItemDetail(ctx, manifestContentID(dl), filter)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
var url string
|
|
switch kind {
|
|
case "poster":
|
|
url = detail.PosterURL
|
|
case "backdrop":
|
|
url = detail.BackdropURL
|
|
case "logo":
|
|
url = detail.LogoURL
|
|
default:
|
|
return ErrAssetNotFound
|
|
}
|
|
if url == "" {
|
|
return ErrAssetNotFound
|
|
}
|
|
return s.streamArtwork(ctx, w, r, url)
|
|
}
|
|
|
|
func (s *Service) streamArtwork(ctx context.Context, w http.ResponseWriter, _ *http.Request, url string) error {
|
|
client := s.httpClient
|
|
if client == nil {
|
|
client = http.DefaultClient
|
|
}
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
|
|
if err != nil {
|
|
return fmt.Errorf("building artwork request: %w", err)
|
|
}
|
|
resp, err := client.Do(req)
|
|
if err != nil {
|
|
return fmt.Errorf("fetching artwork: %w", err)
|
|
}
|
|
defer func() { _ = resp.Body.Close() }()
|
|
if resp.StatusCode != http.StatusOK {
|
|
return fmt.Errorf("artwork upstream status %d: %w", resp.StatusCode, ErrAssetNotFound)
|
|
}
|
|
if ct := resp.Header.Get("Content-Type"); ct != "" {
|
|
w.Header().Set("Content-Type", ct)
|
|
}
|
|
if cl := resp.Header.Get("Content-Length"); cl != "" {
|
|
w.Header().Set("Content-Length", cl)
|
|
}
|
|
// Artwork is immutable for a stored manifest; let the client cache it once.
|
|
w.Header().Set("Cache-Control", "private, max-age=31536000, immutable")
|
|
if _, err := io.Copy(w, resp.Body); err != nil {
|
|
return fmt.Errorf("streaming artwork: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ServeSubtitle streams a subtitle asset (external sidecar or downloaded S3 file)
|
|
// for a managed entry, authorized on (user, profile, device) with a per-profile
|
|
// content-access re-check. ref encodes "external:{index}" or "downloaded:{id}".
|
|
func (s *Service) ServeSubtitle(ctx context.Context, w http.ResponseWriter, _ *http.Request, userID int, profileID, deviceID, downloadID, ref string, filter catalog.AccessFilter) error {
|
|
dl, err := s.authorizeManagedAsset(ctx, userID, profileID, deviceID, downloadID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if err := s.itemAccess.EnsureAccessible(ctx, dl.ContentID, filter); err != nil {
|
|
return err
|
|
}
|
|
|
|
kind, value, err := parseSubtitleRef(ref)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
switch kind {
|
|
case "external":
|
|
idx := value
|
|
file, err := s.fileRepo.GetByID(ctx, dl.MediaFileID)
|
|
if err != nil {
|
|
return fmt.Errorf("loading media file: %w", err)
|
|
}
|
|
if file == nil || idx < 0 || idx >= len(file.ExternalSubtitles) {
|
|
return ErrAssetNotFound
|
|
}
|
|
ext := file.ExternalSubtitles[idx]
|
|
data, err := playback.LoadExternalSubtitleRaw(ext.Path)
|
|
if err != nil {
|
|
return fmt.Errorf("reading external subtitle: %w", ErrAssetNotFound)
|
|
}
|
|
writeSubtitle(w, ext.Format, data)
|
|
return nil
|
|
case "downloaded":
|
|
if s.subtitleSource == nil {
|
|
return ErrManifestUnavailable
|
|
}
|
|
sub, data, err := s.subtitleSource.GetSubtitleContent(ctx, value)
|
|
if err != nil {
|
|
return fmt.Errorf("loading downloaded subtitle: %w", ErrAssetNotFound)
|
|
}
|
|
// The subtitle must belong to this download's media file; a download id
|
|
// never grants access to an arbitrary subtitle id.
|
|
if sub == nil || sub.MediaFileID != dl.MediaFileID {
|
|
return ErrAssetNotFound
|
|
}
|
|
writeSubtitle(w, string(sub.Format), data)
|
|
return nil
|
|
default:
|
|
return ErrInvalidSubtitleRef
|
|
}
|
|
}
|
|
|
|
// parseSubtitleRef parses a subtitle reference of the form "external:{index}"
|
|
// or "downloaded:{id}" into its kind and integer value.
|
|
func parseSubtitleRef(ref string) (kind string, value int, err error) {
|
|
k, v, ok := strings.Cut(ref, ":")
|
|
if !ok {
|
|
return "", 0, ErrInvalidSubtitleRef
|
|
}
|
|
switch k {
|
|
case "external", "downloaded":
|
|
n, perr := strconv.Atoi(v)
|
|
if perr != nil {
|
|
return "", 0, ErrInvalidSubtitleRef
|
|
}
|
|
return k, n, nil
|
|
default:
|
|
return "", 0, ErrInvalidSubtitleRef
|
|
}
|
|
}
|
|
|
|
// writeSubtitle writes subtitle bytes with a format-appropriate content type
|
|
// (the shared subtitles mapping — no local copy to drift).
|
|
func writeSubtitle(w http.ResponseWriter, format string, data []byte) {
|
|
w.Header().Set("Content-Type", subtitles.SubtitleContentType(subtitles.SubtitleFormat(strings.ToLower(format))))
|
|
w.Header().Set("Cache-Control", "private, max-age=31536000, immutable")
|
|
_, _ = w.Write(data)
|
|
}
|