* docs(playback): plan protocol v3 server implementation * docs(playback): incorporate protocol v3 review * feat(playback): implement protocol v3 server * fix(playback): persist empty route diagnostics * feat(playback): harden protocol v3 HDR routing * feat(playback): complete protocol v3 client contract * fix(playback): harden protocol v3 recovery * fix(playback): restore dovi_rpu strip filter for DV remuxes The v3 work renamed the Dolby Vision strip recipe to a dovi_split=mode=bl bitstream filter that does not exist in stock FFmpeg or jellyfin-ffmpeg; the probe failed closed on every deployment, disabling the new validated DV7-to-HDR10 route and regressing the previously working dovi_rpu=strip=1 remux path from main. Restore dovi_rpu across the probe, remux and HLS copy arguments, and the recipe-card constant. Also from review: validate the remux DV mode for every profile (garbage modes on non-P7 sources silently no-opped), reject preserve mode for P7 outright (a base-layer-only remux cannot preserve dual-layer DV), tag dvhe sample entries only for the explicit v3 preserve recipe so legacy web/jellycompat remuxes keep their pre-v3 hev1 labeling, and honor the token-frozen DV mode in the proxy remux path instead of legacy-auto. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(playback): correct v3 planner policy and contract validation Review fixes to the v3 planner and wire contracts: - Bar Profile 7 sources from the non-strip progressive remux route: a base-layer-only remux can never deliver native dual-layer DV, so the planner no longer emits plans claiming validated Dolby Vision while the executed remux drops the enhancement layer. - Accept the device-quirks feature flag from either capability location, matching every other dual-location feature check. - Treat legacy hdr_unknown rows as HDR10 for HDR10-capable clients with a degradation warning instead of leaving them unplayable under v3. - Honor bandwidth_cap_kbps as a hard ceiling in every quality mode and wire the previously dead Metered signal into conservative auto rungs. - Degrade to the validated source-quality route instead of a terminal when only an implicit quality reduction demanded an unsupported transcode; explicit user-selected rungs keep terminal behavior. - Bound inner capability lists and strings; compare attempt keys exactly instead of case-folded; make ParseTrackIDV3 strict about canonical numerics; accept dvdsub/pgssub/dvbsub aliases and stop promising burn-in for unknown subtitle codecs; probe every h264 encoder rather than requiring libx264; normalize the file-level bitrate fallback. - Evaluate subtitle renderability against the engine each candidate route executes on, not always media3_direct. - Pin the with-quirks attempt-key preimage arity in the cross-language fixture so the Kotlin client stays in lockstep. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(playback): harden v3 control-plane reliability Review fixes to the v3 session, store, and handler layer: - Bound concurrent replans with a slot semaphore: each replan pins a pooled connection for its advisory lock while issuing further store queries from the same pool, so an unbounded recovery storm could turn every connection into a lock holder and deadlock the server. - Make CompleteReplan a real compare-and-swap (base-revision predicate, ErrReplanSupersededV3) and map BeginReplan insert races to a replay instead of a raw unique violation. - Fingerprint start requests (request_digest column): an attempt ID reused with different input is now a 409-style conflict rather than a silent replay, and both replay paths check session liveness so dead sessions surface as retryable terminals. - Pre-delete expired attempt rows on SaveAttempt so a retry during the cleanup window cannot wedge on an unreachable conflict. - Align the in-memory store's semantics with Postgres and add DB-backed planstore tests (SILO_TEST_DATABASE_URL), including a regression test inserting every route-event name against the real CHECK constraint. - Session manager: v3 route-set updates own RemuxDVMode outright so a replan onto an SDR source clears a stale strip mode; replacement reservations survive unrelated legacy stream updates; replacement admission excludes the replaced session explicitly instead of decrementing totals it may no longer be part of; the admission CAS loop is bounded and decider errors are logged. - Map transient store failures to 500s instead of terminal 404/403s; authorize route events via identity-only projections after the rate limiter; keep sanitized diagnostics deterministic. - Merge the server-computed durable plan key into replan exclusions so unreproducible client history cannot re-select the failed route. - Remap tracks only when the effective edition changes (a same-file replan no longer switches audio to a lookalike track) and remap ID-only subtitle selections on edition fallback. - Cache the v3/shadow feature flags for five seconds instead of one settings SELECT per playback request; stop remote transports best-effort when the start call times out; carry dvm/tid claims and the transport-scoped job identity through the legacy audio-change re-mint; index playback_route_events(received_at) for the retention delete; run store maintenance for DB-less deployments too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(transcode): reap idle node jobs and gate WebVTT conversion - Add an idle reaper to the transcode node: a job untouched by manifest or segment requests for ten minutes is closed and unregistered. After a v3 replan retires a transport ID, a stale in-flight stream token could resurrect the old job via reconstruct and encode to end-of-file for nobody; jobs waiting on readiness count registration as access and are never reaped mid-wait, and reaping keeps the recipe so a still-valid token reconstructs on the next hit. - Reject bitmap subtitle tracks (PGS) on the .vtt conversion path with 415 before headers are written instead of spawning an ffmpeg command that always fails mid-response, and make the extract-format override fall back to source-driven mapping for bitmap codecs. - Drain error bodies on non-202 node responses so the HTTP transport can reuse connections. - Pin the transcode-dir cleanup separator-boundary semantics with a regression test (a session ID sharing another's prefix must not retain foreign directories). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(playback): close v3 planner policy gaps from review - Clamp the final transcode bitrate to bandwidth_cap_kbps: the ladder has no rung below 480p/1500kbps, so lower caps were silently exceeded even though the cap is documented as a hard delivery ceiling. - Treat video-only media as audio-compatible instead of forcing an AAC conversion (or an audio_conversion_unsupported terminal) onto a file with no audio stream. Tracks whose codec failed to probe keep the gate. - Only promise a bitmap subtitle sidecar for embedded PGS with an engine that renders embedded bitmap: external/downloaded bitmap and embedded DVD/DVB published artifact URLs that always failed at fetch. They now fall through to burn-in or its terminal. - Accept client_video_transformations_v1 from either client_features or the nested context when validating client-executor transformations, matching the planner's dual-source reads. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(playback): probe and execute DV remuxes with one ffmpeg binary The v3 transformation registry probed the configured playback.ffmpeg_path while progressive remux execution resolved the process-global discovery path, so a deployment where only one binary carries dovi_rpu could plan a server_dv7_to_hdr10 route and then fail it at stream time. Resolution now goes through a shared ResolveFFmpegPath (configured path first, discovery fallback — the same rule the transcode pipeline already used), the dovi_rpu probe is cached per binary path, and the stream handler and proxy worker pass their configured path into ServeRemuxWithDVMode. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(playback): harden v3 replan identity and control-plane limits - Seed failure-replan track selections from the durable current plan before overlaying the request: after an alternate-version fallback the normalized request still carries requested-edition track IDs, so a replan omitting unchanged tracks was rejected as a track/file mismatch. - Remap ID-only audio selections across edition changes (parse the ID to an index like the subtitle remap already does) instead of leaving a stale file-bound ID to fail validation. - Release the node planner reservation when a prepared remote transport rolls back after the node accepted the job; repeated failed starts could otherwise pin max-job/bandwidth budgets for the full reservation age. - Size the replan semaphore below the PostgreSQL pool via a store capacity advisor: with max_connections at or below the fixed bound, advisory-lock holders could starve the inner store queries they need to finish. - Contain shadow-planner panics with a recover boundary; it runs on a bare goroutine where an escaped panic kills the process for what is telemetry-only work. Document why the memory store's session lock is deliberately a no-op. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(transcode): serialize node job teardown against reconstructs - Look up and touch manifest/segment sessions in one critical section so the idle reaper cannot unregister a job between the lookup and its liveness refresh. - Re-validate each reap candidate under the per-session lifecycle lock before closing it: Close removes the output directory, and without the lock it could race a token reconstruct and wipe the segments the fresh ffmpeg is writing. - Take the lifecycle lock in handleStop so a stop racing a RequireReady start's readiness wait blocks until registration and tears the job down, instead of 404ing and orphaning the ffmpeg until the reaper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
618 lines
22 KiB
Go
618 lines
22 KiB
Go
package handlers
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"log/slog"
|
|
"net/http"
|
|
"os"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
|
|
apimw "github.com/Silo-Server/silo-server/internal/api/middleware"
|
|
"github.com/Silo-Server/silo-server/internal/config"
|
|
evt "github.com/Silo-Server/silo-server/internal/events"
|
|
"github.com/Silo-Server/silo-server/internal/models"
|
|
"github.com/Silo-Server/silo-server/internal/playback"
|
|
"github.com/Silo-Server/silo-server/internal/subtitles"
|
|
)
|
|
|
|
// FilePathResolver looks up a media file by its ID.
|
|
type FilePathResolver interface {
|
|
GetByID(ctx context.Context, id int) (*models.MediaFile, error)
|
|
}
|
|
|
|
// StreamHandler handles HTTP endpoints for streaming media content.
|
|
type StreamHandler struct {
|
|
sessionMgr SessionManagerInterface
|
|
fileResolver FilePathResolver
|
|
MissingMarker MissingFileMarker
|
|
EventsHub *evt.Hub
|
|
AdminStore PlaybackAdminStore
|
|
SessionSyncer PlaybackSessionSyncer
|
|
// TM is the shared transcode/reconstruct manager (same instance as the
|
|
// PlaybackHandler's). It lets a direct/remux stream rebuild its playback
|
|
// Session from the recipe card after a server restart instead of 404-ing.
|
|
// May be nil (tests / minimal setups) — reconstruct is then simply off.
|
|
TM *playback.TranscodeManager
|
|
// JWTSecret verifies the stream token carried on the serve URL (?st=), which
|
|
// is the reconstruction descriptor for direct/remux after a restart. Empty
|
|
// disables token-based reconstruct (tests / minimal setups).
|
|
JWTSecret string
|
|
// PlaybackConfig returns the current playback config; read it through
|
|
// ffmpegPath(). May be nil (tests).
|
|
PlaybackConfig func() config.PlaybackConfig
|
|
// SubtitleCache stores full-track PGS (.sup) extracts under the transcode
|
|
// dir so repeat selections skip the whole-file ffmpeg demux. May be nil
|
|
// (tests / minimal setups) — extraction then always streams uncached.
|
|
SubtitleCache *playback.SubtitleCache
|
|
SubtitleRepo subtitles.Repository // optional; enables S3-sourced subtitles
|
|
S3Client subtitles.S3Client // optional; needed for fetching S3 subtitles
|
|
S3Bucket string // bucket for subtitle storage
|
|
}
|
|
|
|
// ffmpegPath returns the currently configured ffmpeg binary path.
|
|
func (h *StreamHandler) ffmpegPath() string {
|
|
if h.PlaybackConfig != nil {
|
|
return h.PlaybackConfig().FFmpegPath
|
|
}
|
|
return ""
|
|
}
|
|
|
|
// NewStreamHandler creates a new StreamHandler backed by the given session
|
|
// manager and file resolver.
|
|
func NewStreamHandler(sessionMgr SessionManagerInterface, fileResolver FilePathResolver) *StreamHandler {
|
|
return &StreamHandler{
|
|
sessionMgr: sessionMgr,
|
|
fileResolver: fileResolver,
|
|
// A bare manager (no recipe store) behaves as "no reconstruct" — plain
|
|
// GetSession + ownership — so HandleStream has a single code path. The
|
|
// router overwrites this with the shared manager to enable reconstruct.
|
|
TM: playback.NewTranscodeManager(),
|
|
}
|
|
}
|
|
|
|
// HandleStream serves the video stream for a playback session.
|
|
// For direct play: serves the file with HTTP byte-range support.
|
|
// For remux: starts an ffmpeg remux and streams the output.
|
|
// For transcode: returns 400 (transcode uses manifest/segment endpoints).
|
|
func (h *StreamHandler) HandleStream(w http.ResponseWriter, r *http.Request) {
|
|
userID := apimw.GetUserID(r.Context())
|
|
if userID == 0 {
|
|
writeError(w, http.StatusUnauthorized, "unauthorized", "Authentication required")
|
|
return
|
|
}
|
|
|
|
sessionID := chi.URLParam(r, "session_id")
|
|
if sessionID == "" {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Session ID is required")
|
|
return
|
|
}
|
|
setPlaybackSessionLogContext(r, sessionID)
|
|
|
|
// Look up the session, reconstructing it from the recipe card on a not-found
|
|
// miss (e.g. after a server restart) so a direct/remux stream resumes instead
|
|
// of 404-ing. The client re-supplies its position (HTTP Range for direct, the
|
|
// ?seek= query for remux), so no runtime beyond the Session needs rebuilding.
|
|
// Without a token (or signing secret) reconstruct is off, collapsing to a
|
|
// plain GetSession + ownership check.
|
|
card := streamCardFromToken(r.URL.Query().Get(streamTokenParam), sessionID, h.JWTSecret)
|
|
session, status := h.TM.LoadOrReconstructSession(r.Context(), h.sessionMgr.GetSession, sessionID, userID, card)
|
|
switch status {
|
|
case playback.SessionMissing:
|
|
writePlaybackSessionNotFound(w)
|
|
return
|
|
case playback.SessionLoadFailed:
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to load playback session")
|
|
return
|
|
case playback.SessionForbidden:
|
|
writeError(w, http.StatusForbidden, "forbidden", "Session belongs to another user")
|
|
return
|
|
}
|
|
|
|
file, err := h.fileResolver.GetByID(r.Context(), session.MediaFileID)
|
|
if err != nil {
|
|
if isPlaybackFileLookupMissing(err) {
|
|
h.abortPlaybackSession(r.Context(), session)
|
|
writeError(w, http.StatusNotFound, "not_found", "Media file not found")
|
|
return
|
|
}
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to load media file")
|
|
return
|
|
}
|
|
if file == nil {
|
|
h.abortPlaybackSession(r.Context(), session)
|
|
writeError(w, http.StatusNotFound, "not_found", "Media file not found")
|
|
return
|
|
}
|
|
if err := preflightPlaybackFile(r.Context(), file, h.MissingMarker, h.EventsHub); err != nil {
|
|
if isPlaybackFileMissing(err) {
|
|
h.abortPlaybackSession(r.Context(), session)
|
|
}
|
|
writePlaybackFilePreflightError(w, err)
|
|
return
|
|
}
|
|
|
|
switch session.PlayMethod {
|
|
case playback.PlayDirect:
|
|
if err := h.sessionMgr.BeginTransport(sessionID); err == nil {
|
|
defer func() {
|
|
_ = h.sessionMgr.EndTransport(sessionID)
|
|
}()
|
|
}
|
|
if err := playback.ServeDirectPlay(w, r, file.FilePath); err != nil {
|
|
h.handleTransportStartFailure(r.Context(), session, file, err)
|
|
}
|
|
|
|
case playback.PlayRemux:
|
|
if err := h.sessionMgr.BeginTransport(sessionID); err == nil {
|
|
defer func() {
|
|
_ = h.sessionMgr.EndTransport(sessionID)
|
|
}()
|
|
}
|
|
seekSeconds := 0.0
|
|
if seekStr := r.URL.Query().Get("seek"); seekStr != "" {
|
|
if s, err := strconv.ParseFloat(seekStr, 64); err == nil && s >= 0 {
|
|
seekSeconds = s
|
|
}
|
|
}
|
|
if err := playback.ServeRemuxWithDVMode(w, r, file.FilePath, "mp4", seekSeconds, session.TranscodeAudio, session.AudioTrackIndex, file.PrimaryDVProfile(), session.RemuxDVMode, h.ffmpegPath()); err != nil {
|
|
h.handleTransportStartFailure(r.Context(), session, file, err)
|
|
}
|
|
|
|
case playback.PlayTranscode:
|
|
writeError(w, http.StatusBadRequest, "bad_request",
|
|
"Transcode streams use manifest/segment endpoints")
|
|
|
|
default:
|
|
writeError(w, http.StatusInternalServerError, "internal_error",
|
|
"Unknown play method")
|
|
}
|
|
}
|
|
|
|
// HandleSubtitle extracts a subtitle track from the media file associated with
|
|
// a playback session and serves it as WebVTT or raw ASS depending on the
|
|
// URL extension (e.g. /subtitles/2.ass or /subtitles/2.vtt).
|
|
func (h *StreamHandler) HandleSubtitle(w http.ResponseWriter, r *http.Request) {
|
|
userID := apimw.GetUserID(r.Context())
|
|
if userID == 0 {
|
|
writeError(w, http.StatusUnauthorized, "unauthorized", "Authentication required")
|
|
return
|
|
}
|
|
|
|
sessionID := chi.URLParam(r, "session_id")
|
|
if sessionID == "" {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Session ID is required")
|
|
return
|
|
}
|
|
setPlaybackSessionLogContext(r, sessionID)
|
|
|
|
trackParam := chi.URLParam(r, "track")
|
|
trackIndex, requestedFormat, err := playback.ParseSubtitleTrackParam(trackParam)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Invalid subtitle track index")
|
|
return
|
|
}
|
|
|
|
session, err := h.sessionMgr.GetSession(sessionID)
|
|
if err != nil {
|
|
writePlaybackSessionNotFound(w)
|
|
return
|
|
}
|
|
|
|
if session.UserID != userID {
|
|
writeError(w, http.StatusForbidden, "forbidden", "Session belongs to another user")
|
|
return
|
|
}
|
|
|
|
fileID, err := subtitleSourceFileID(r, session)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, "bad_request", err.Error())
|
|
return
|
|
}
|
|
file, err := h.fileResolver.GetByID(r.Context(), fileID)
|
|
if err != nil || file == nil {
|
|
writeError(w, http.StatusNotFound, "not_found", "Media file not found")
|
|
return
|
|
}
|
|
|
|
externalCount := len(file.ExternalSubtitles)
|
|
if trackIndex < externalCount {
|
|
sub := file.ExternalSubtitles[trackIndex]
|
|
|
|
// Serve ASS/SSA external subtitles as raw data for client-side rendering.
|
|
if playback.IsASS(sub.Format) && requestedFormat != "vtt" {
|
|
data, err := playback.LoadExternalSubtitleRaw(sub.Path)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error",
|
|
"Failed to load external subtitle")
|
|
return
|
|
}
|
|
playback.ServeSubtitle(w, data, "ass")
|
|
return
|
|
}
|
|
|
|
vttData, err := playback.LoadExternalSubtitleAsVTT(r.Context(), sub.Path, sub.Format, h.ffmpegPath())
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "internal_error",
|
|
"Failed to load external subtitle")
|
|
return
|
|
}
|
|
playback.ServeSubtitle(w, vttData, "vtt")
|
|
return
|
|
}
|
|
|
|
embeddedIndex := trackIndex - externalCount
|
|
|
|
// Check embedded tracks.
|
|
if embeddedIndex < len(file.SubtitleTracks) {
|
|
track := file.SubtitleTracks[embeddedIndex]
|
|
// PGS is the one bitmap codec we can deliver without burn-in: the
|
|
// track is copied losslessly into a .sup stream and rendered
|
|
// client-side. DVD/DVB bitmap subs still require burn-in.
|
|
if playback.NeedsBurnIn(track.Codec) && !playback.IsPGS(track.Codec) {
|
|
writeError(w, http.StatusBadRequest, "bad_request",
|
|
"Bitmap subtitle tracks cannot be extracted as text")
|
|
return
|
|
}
|
|
|
|
// Dedicated streaming extract — ffmpeg seeks to the current
|
|
// playback position and pipes cues to the response as they're
|
|
// demuxed, so the first byte lands within ~1s even on network
|
|
// storage. Works identically for direct-play, remux, and
|
|
// transcode because it doesn't depend on any other ffmpeg.
|
|
h.streamEmbeddedSubtitle(w, r, file, embeddedIndex, session, requestedFormat)
|
|
return
|
|
}
|
|
|
|
// Check downloaded subtitles (from S3).
|
|
if h.SubtitleRepo != nil && h.S3Client != nil {
|
|
downloaded, err := h.SubtitleRepo.ListDownloadedSubtitles(r.Context(), file.ID)
|
|
if err != nil {
|
|
// A DB failure here must not masquerade as "track not found":
|
|
// surface it as an internal error (with a server-side signal)
|
|
// so the real failure is diagnosable instead of looking like an
|
|
// intermittent 404 to the client.
|
|
slog.ErrorContext(r.Context(), "list downloaded subtitles failed", "component", "api",
|
|
"file_id", file.ID,
|
|
"track", trackIndex,
|
|
"error", err,
|
|
)
|
|
writeError(w, http.StatusInternalServerError, "internal_error", "Failed to list downloaded subtitles")
|
|
return
|
|
}
|
|
|
|
downloadedIndex := embeddedIndex - len(file.SubtitleTracks)
|
|
if downloadedIndex >= 0 && downloadedIndex < len(downloaded) {
|
|
dl := downloaded[downloadedIndex]
|
|
data, err := h.S3Client.GetObject(r.Context(), h.S3Bucket, dl.S3Key)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadGateway, "s3_error", "Failed to load subtitle from storage")
|
|
return
|
|
}
|
|
|
|
// Serve ASS/SSA downloaded subtitles as raw data.
|
|
if playback.IsASS(string(dl.Format)) && requestedFormat != "vtt" {
|
|
playback.ServeSubtitle(w, data, "ass")
|
|
return
|
|
}
|
|
|
|
// If the subtitle is already VTT, serve directly.
|
|
if dl.Format == subtitles.FormatVTT {
|
|
playback.ServeSubtitle(w, data, "vtt")
|
|
return
|
|
}
|
|
|
|
// Convert to VTT using the playback conversion pipeline.
|
|
vttData, err := playback.ConvertToVTTWithFFmpeg(r.Context(), data, string(dl.Format), h.ffmpegPath())
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "convert_error", "Failed to convert subtitle")
|
|
return
|
|
}
|
|
playback.ServeSubtitle(w, vttData, "vtt")
|
|
return
|
|
}
|
|
}
|
|
|
|
writeError(w, http.StatusNotFound, "not_found", "Subtitle track not found")
|
|
}
|
|
|
|
// subtitleSourceFileID pins a subtitle URL to the file whose track list was
|
|
// used to create it. A quality/seek restart may change session.MediaFileID to
|
|
// an alternate version; interpreting the old combined track index against the
|
|
// alternate file can silently serve a different language. Only the session's
|
|
// requested or current effective file may be named by the authenticated URL.
|
|
func subtitleSourceFileID(r *http.Request, session *playback.Session) (int, error) {
|
|
if session == nil {
|
|
return 0, errors.New("playback session is required")
|
|
}
|
|
raw := strings.TrimSpace(r.URL.Query().Get("file_id"))
|
|
if raw == "" {
|
|
return session.MediaFileID, nil
|
|
}
|
|
fileID, err := strconv.Atoi(raw)
|
|
if err != nil || fileID <= 0 {
|
|
return 0, errors.New("invalid subtitle source file")
|
|
}
|
|
if fileID != session.MediaFileID && fileID != session.RequestedMediaFileID {
|
|
return 0, errors.New("subtitle source file does not belong to playback session")
|
|
}
|
|
return fileID, nil
|
|
}
|
|
|
|
// HandleSubtitleFonts extracts embedded container font attachments for ASS/SSA
|
|
// playback. The web player loads these bytes into JASSUB before creating the
|
|
// renderer so libass can resolve script font names deterministically.
|
|
func (h *StreamHandler) HandleSubtitleFonts(w http.ResponseWriter, r *http.Request) {
|
|
userID := apimw.GetUserID(r.Context())
|
|
if userID == 0 {
|
|
writeError(w, http.StatusUnauthorized, "unauthorized", "Authentication required")
|
|
return
|
|
}
|
|
|
|
sessionID := chi.URLParam(r, "session_id")
|
|
if sessionID == "" {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Session ID is required")
|
|
return
|
|
}
|
|
setPlaybackSessionLogContext(r, sessionID)
|
|
|
|
session, err := h.sessionMgr.GetSession(sessionID)
|
|
if err != nil {
|
|
writePlaybackSessionNotFound(w)
|
|
return
|
|
}
|
|
if session.UserID != userID {
|
|
writeError(w, http.StatusForbidden, "forbidden", "Session belongs to another user")
|
|
return
|
|
}
|
|
|
|
fileID, err := subtitleSourceFileID(r, session)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, "bad_request", err.Error())
|
|
return
|
|
}
|
|
file, err := h.fileResolver.GetByID(r.Context(), fileID)
|
|
if err != nil {
|
|
writeError(w, http.StatusNotFound, "not_found", "Media file not found")
|
|
return
|
|
}
|
|
if file == nil {
|
|
writeError(w, http.StatusNotFound, "not_found", "Media file not found")
|
|
return
|
|
}
|
|
if err := preflightPlaybackFile(r.Context(), file, h.MissingMarker, h.EventsHub); err != nil {
|
|
if isPlaybackFileMissing(err) {
|
|
h.abortPlaybackSession(r.Context(), session)
|
|
}
|
|
writePlaybackFilePreflightError(w, err)
|
|
return
|
|
}
|
|
|
|
trackParam := chi.URLParam(r, "track")
|
|
trackIndex, _, err := playback.ParseSubtitleTrackParam(trackParam)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Invalid subtitle track index")
|
|
return
|
|
}
|
|
|
|
embeddedIndex := trackIndex - len(file.ExternalSubtitles)
|
|
if embeddedIndex < 0 || embeddedIndex >= len(file.SubtitleTracks) {
|
|
writeError(w, http.StatusNotFound, "not_found", "Embedded subtitle track not found")
|
|
return
|
|
}
|
|
if !playback.IsASS(file.SubtitleTracks[embeddedIndex].Codec) {
|
|
writeError(w, http.StatusBadRequest, "bad_request", "Subtitle font bundles are only available for ASS/SSA tracks")
|
|
return
|
|
}
|
|
|
|
fonts, err := playback.ExtractAttachedSubtitleFonts(r.Context(), file.FilePath, h.ffmpegPath())
|
|
if err != nil {
|
|
slog.WarnContext(r.Context(), "subtitle font extraction failed", "component", "api",
|
|
"file_id", file.ID,
|
|
"track", trackIndex,
|
|
"error", err,
|
|
)
|
|
writeError(w, http.StatusInternalServerError, "font_extract_failed", "Failed to extract subtitle fonts")
|
|
return
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
w.Header().Set("Access-Control-Allow-Origin", "*")
|
|
w.Header().Set("Cache-Control", "no-store")
|
|
if err := json.NewEncoder(w).Encode(playback.EncodeSubtitleFontBundle(fonts)); err != nil {
|
|
slog.WarnContext(r.Context(), "subtitle font response encode failed", "component", "api", "error", err)
|
|
}
|
|
}
|
|
|
|
func (h *StreamHandler) syncSessionsNow(ctx context.Context, reason string) {
|
|
if h == nil || h.SessionSyncer == nil {
|
|
return
|
|
}
|
|
if err := h.SessionSyncer.SyncNow(ctx); err != nil {
|
|
slog.ErrorContext(ctx, "failed to sync sessions", "component", "api", "reason", reason, "error", err)
|
|
}
|
|
}
|
|
|
|
func (h *StreamHandler) finalizeSessionAbort(ctx context.Context, session *playback.Session, syncNow bool, syncReason string) {
|
|
if h == nil || session == nil || session.ID == "" {
|
|
return
|
|
}
|
|
if ctx == nil {
|
|
ctx = context.Background()
|
|
}
|
|
|
|
if h.AdminStore != nil {
|
|
if err := h.AdminStore.DeleteSession(ctx, session.ID); err != nil {
|
|
slog.ErrorContext(ctx, "failed to delete synced session", "component", "api", "session", session.ID, "error", err)
|
|
}
|
|
}
|
|
if syncNow {
|
|
h.syncSessionsNow(ctx, syncReason)
|
|
}
|
|
}
|
|
|
|
func (h *StreamHandler) abortPlaybackSession(ctx context.Context, session *playback.Session) {
|
|
if h == nil || session == nil || session.ID == "" {
|
|
return
|
|
}
|
|
if err := h.sessionMgr.StopSession(session.ID); err != nil {
|
|
return
|
|
}
|
|
h.finalizeSessionAbort(ctx, session, true, "stream_abort")
|
|
}
|
|
|
|
func (h *StreamHandler) handleTransportStartFailure(ctx context.Context, session *playback.Session, file *models.MediaFile, err error) {
|
|
if ctx == nil || session == nil || err == nil {
|
|
return
|
|
}
|
|
if preflightErr := preflightPlaybackFile(ctx, file, h.MissingMarker, h.EventsHub); preflightErr != nil {
|
|
err = preflightErr
|
|
}
|
|
if isPlaybackFileMissing(err) || errors.Is(err, os.ErrNotExist) {
|
|
h.abortPlaybackSession(ctx, session)
|
|
return
|
|
}
|
|
slog.WarnContext(ctx, "stream transport startup failed", "component", "api",
|
|
"session", session.ID,
|
|
"file_id", session.MediaFileID,
|
|
"error", err,
|
|
"playback_session_id", session.ID,
|
|
)
|
|
}
|
|
|
|
// streamEmbeddedSubtitle runs a dedicated ffmpeg for a single embedded
|
|
// track, seeked to the best-known playback position, and pipes its
|
|
// stdout directly to w. Because this ffmpeg is independent of the video
|
|
// pipeline, it works the same for direct play, remux, and transcode.
|
|
func (h *StreamHandler) streamEmbeddedSubtitle(w http.ResponseWriter, r *http.Request, file *models.MediaFile, embeddedIndex int, session *playback.Session, requestedFormat ...string) {
|
|
track := file.SubtitleTracks[embeddedIndex]
|
|
outFormat := "vtt"
|
|
switch {
|
|
case playback.IsASS(track.Codec):
|
|
outFormat = "ass"
|
|
case playback.IsPGS(track.Codec):
|
|
outFormat = "sup"
|
|
}
|
|
|
|
// ASS is fetched exactly once and consumed whole by its client-side
|
|
// renderer (JASSUB), so it must never be windowed. PGS defaults to
|
|
// the same whole-track behavior, but a client that manages its own
|
|
// sliding window (the web player's libpgs hook) opts in explicitly
|
|
// with ?windowed=1 + ?position=/?duration=; there is deliberately no
|
|
// session-position fallback for sup — an implicit window would
|
|
// silently drop cues for clients that fetch once. Note
|
|
// subtitleSeekPosition falls back to the session's last reported
|
|
// position even without a ?position= query — relying on
|
|
// StreamExtractSubtitle's codec guard alone would still log a
|
|
// misleading nonzero seek here.
|
|
var seek, duration float64
|
|
var allowWindow bool
|
|
switch outFormat {
|
|
case "vtt":
|
|
seek = subtitleSeekPosition(r, session)
|
|
duration = subtitleWindowDuration(r)
|
|
case "sup":
|
|
allowWindow, seek, duration = playback.PGSWindowRequest(r.URL.Query())
|
|
}
|
|
slog.InfoContext(r.Context(), "subtitle stream requested", "component", "api",
|
|
"file_id", file.ID,
|
|
"embedded_index", embeddedIndex,
|
|
"track_language", track.Language,
|
|
"track_codec", track.Codec,
|
|
"track_probed_index", track.Index,
|
|
"seek_seconds", seek,
|
|
"duration_seconds", duration,
|
|
)
|
|
|
|
opts := playback.StreamExtractOpts{
|
|
InputPath: file.FilePath,
|
|
TrackIndex: embeddedIndex,
|
|
SourceCodec: track.Codec,
|
|
SeekSeconds: seek,
|
|
DurationSeconds: duration,
|
|
AllowWindow: allowWindow,
|
|
FFmpegPath: h.ffmpegPath(),
|
|
}
|
|
if len(requestedFormat) > 0 && requestedFormat[0] == "vtt" {
|
|
// Only text sources can be converted to WebVTT. A bitmap track (PGS
|
|
// reaches here because it is deliverable as .sup; DVD/DVB are rejected
|
|
// upstream) carries no text, so honoring the override would spawn an
|
|
// ffmpeg that always fails after the 200 and headers are committed.
|
|
// Reject before any spawn or header write.
|
|
if playback.NeedsBurnIn(track.Codec) {
|
|
writeError(w, http.StatusUnsupportedMediaType, "unsupported_media_type",
|
|
"Bitmap subtitle tracks cannot be converted to WebVTT")
|
|
return
|
|
}
|
|
opts.TargetFormat = "vtt"
|
|
outFormat = "vtt"
|
|
}
|
|
|
|
w.Header().Set("Access-Control-Allow-Origin", "*")
|
|
|
|
// Full-track PGS extracts are expensive (whole-file demux) and byte-
|
|
// identical across requests, so they are served from / teed into the
|
|
// subtitle cache; windowed PGS requests extract their slice from the
|
|
// cached full track when present (warming it in the background when
|
|
// not). All other formats stream uncached: VTT is already windowed
|
|
// and fast, ASS is small.
|
|
if outFormat == "sup" {
|
|
err := h.SubtitleCache.ServeSUPExtract(w, r, opts, playback.StreamExtractSubtitle)
|
|
playback.LogSubtitleStreamError(r.Context(), err, file.ID, embeddedIndex)
|
|
return
|
|
}
|
|
|
|
switch outFormat {
|
|
case "ass":
|
|
w.Header().Set("Content-Type", "text/x-ssa; charset=utf-8")
|
|
default:
|
|
w.Header().Set("Content-Type", "text/vtt; charset=utf-8")
|
|
}
|
|
w.Header().Set("Cache-Control", "no-store")
|
|
w.WriteHeader(http.StatusOK)
|
|
|
|
opts.Writer = w
|
|
if err := playback.StreamExtractSubtitle(r.Context(), opts); err != nil {
|
|
// Headers already committed — best we can do is log and let
|
|
// the client see a truncated response.
|
|
playback.LogSubtitleStreamError(r.Context(), err, file.ID, embeddedIndex)
|
|
}
|
|
}
|
|
|
|
// subtitleSeekPosition picks the best-known starting position for a
|
|
// subtitle extract. A caller-supplied ?position= query wins (the player
|
|
// has the most accurate clock), falling back to the session's last
|
|
// reported position, then to 0.
|
|
func subtitleSeekPosition(r *http.Request, session *playback.Session) float64 {
|
|
if raw := r.URL.Query().Get("position"); raw != "" {
|
|
if v, err := strconv.ParseFloat(raw, 64); err == nil && v >= 0 {
|
|
return v
|
|
}
|
|
}
|
|
if session != nil && session.Position > 0 {
|
|
return session.Position
|
|
}
|
|
return 0
|
|
}
|
|
|
|
// subtitleWindowDuration picks the bounded extract length. The client
|
|
// overrides via ?duration=; absent that we use a 10-minute window,
|
|
// which is long enough that a single fetch covers many minutes of
|
|
// uninterrupted playback but short enough that the ffmpeg process
|
|
// finishes (and frees its input handle) well before the next window
|
|
// is requested.
|
|
func subtitleWindowDuration(r *http.Request) float64 {
|
|
const defaultDuration = 600.0
|
|
const maxDuration = 3600.0
|
|
if raw := r.URL.Query().Get("duration"); raw != "" {
|
|
if v, err := strconv.ParseFloat(raw, 64); err == nil && v > 0 && v <= maxDuration {
|
|
return v
|
|
}
|
|
}
|
|
return defaultDuration
|
|
}
|