Notify the requesting profile once its media request is actually present in the catalog (roadmap 06, item 2). Completion transitions stay notification-agnostic; a presence-gated pass at the end of each reconcile run fires the notice, so it means "watchable in Silo", not "download finished". - New System.DispatchOperational: delivery insert + webhook/web-push outbox enqueue in one transaction, post-commit multi-dispatch. The webhook auto-disable notice now rides the same path (replacing its hand-rolled hub publish and the now-removed InsertOperational), which also delivers auto-disable notices over web push. - At-most-once delivery: partial unique index on (profile_id, reason_flags->>'request_id') plus a fulfilled_notified_at marker on media_requests, backfilled for pre-existing completed requests so deploys never flood. - Per-webhook notify_requests toggle (default on) through repo, service, API, and settings UI; gated independently of the episode reason flags. - request.fulfilled rendering in web inbox, realtime toast, web push payload, and Discord/generic webhook payloads, deep-linking to the matched catalog item. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
131 lines
3.7 KiB
Go
131 lines
3.7 KiB
Go
package notifications
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestBuildWebPushPayload(t *testing.T) {
|
|
t.Run("episode available", func(t *testing.T) {
|
|
raw, err := buildWebPushPayload(webhookTestRow(), "https://cdn.example.com/poster.jpg")
|
|
if err != nil {
|
|
t.Fatalf("build failed: %v", err)
|
|
}
|
|
var payload webPushPayload
|
|
if err := json.Unmarshal(raw, &payload); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if payload.Title != "New episode of Severance" {
|
|
t.Fatalf("unexpected title %q", payload.Title)
|
|
}
|
|
if payload.Body != "S2E1 — Hello, Ms. Cobel" {
|
|
t.Fatalf("unexpected body %q", payload.Body)
|
|
}
|
|
if payload.URL != "/item/episode-456" {
|
|
t.Fatalf("unexpected url %q", payload.URL)
|
|
}
|
|
if payload.Icon != "https://cdn.example.com/poster.jpg" || payload.DeliveryID != "01DELIVERY" {
|
|
t.Fatalf("unexpected payload: %+v", payload)
|
|
}
|
|
})
|
|
|
|
t.Run("request fulfilled deep-links to the matched item", func(t *testing.T) {
|
|
raw, err := buildWebPushPayload(requestFulfilledTestRow(), "https://cdn.example.com/poster.jpg")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var payload webPushPayload
|
|
if err := json.Unmarshal(raw, &payload); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if payload.Title != "Dune is now available" {
|
|
t.Fatalf("unexpected title %q", payload.Title)
|
|
}
|
|
if payload.URL != "/item/movie-123" {
|
|
t.Fatalf("unexpected url %q", payload.URL)
|
|
}
|
|
if payload.Icon != "https://cdn.example.com/poster.jpg" {
|
|
t.Fatalf("unexpected icon %q", payload.Icon)
|
|
}
|
|
})
|
|
|
|
t.Run("webhook auto-disable routes to settings", func(t *testing.T) {
|
|
row := DeliveryRow{Delivery: Delivery{ID: "01X", Type: DeliveryTypeWebhookAutoDisabled}}
|
|
raw, err := buildWebPushPayload(row, "")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var payload webPushPayload
|
|
if err := json.Unmarshal(raw, &payload); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if payload.URL != "/settings/notifications" {
|
|
t.Fatalf("unexpected url %q", payload.URL)
|
|
}
|
|
})
|
|
|
|
t.Run("unknown types render generically", func(t *testing.T) {
|
|
row := DeliveryRow{Delivery: Delivery{ID: "01Y", Type: "future.type"}}
|
|
raw, err := buildWebPushPayload(row, "")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var payload webPushPayload
|
|
if err := json.Unmarshal(raw, &payload); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if payload.Title != "Silo notification" || payload.URL != "/notifications" {
|
|
t.Fatalf("unexpected payload: %+v", payload)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestWebPushRetrySchedule(t *testing.T) {
|
|
total := time.Duration(0)
|
|
for attempt := 1; attempt < webPushMaxAttempts; attempt++ {
|
|
delay, ok := webPushRetryDelay(attempt)
|
|
if !ok {
|
|
t.Fatalf("schedule ended early at attempt %d", attempt)
|
|
}
|
|
total += delay
|
|
}
|
|
if total != 30*time.Minute {
|
|
t.Fatalf("schedule must span 30m, got %v", total)
|
|
}
|
|
if _, ok := webPushRetryDelay(webPushMaxAttempts); ok {
|
|
t.Fatal("attempt 5 must exhaust the schedule")
|
|
}
|
|
}
|
|
|
|
func TestWebPushSubscribeValidation(t *testing.T) {
|
|
// Validation failures reject before any repository access, so a nil repo
|
|
// is safe here.
|
|
service := newWebPushService(nil, NewSettings(nil), nil)
|
|
ctx := context.Background()
|
|
|
|
cases := []struct {
|
|
name string
|
|
endpoint string
|
|
p256dh string
|
|
auth string
|
|
}{
|
|
{"missing endpoint", "", "k", "a"},
|
|
{"missing keys", "https://push.example.com/x", "", ""},
|
|
{"plain http", "http://push.example.com/x", "k", "a"},
|
|
{"loopback", "https://127.0.0.1/x", "k", "a"},
|
|
{"v4-mapped loopback", "https://[::ffff:127.0.0.1]/x", "k", "a"},
|
|
{"private network", "https://192.168.1.10/x", "k", "a"},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
_, err := service.Subscribe(ctx, 1, "p1", tc.endpoint, tc.p256dh, tc.auth, "test")
|
|
if !errors.Is(err, ErrWebPushInvalid) {
|
|
t.Fatalf("Subscribe = %v, want ErrWebPushInvalid", err)
|
|
}
|
|
})
|
|
}
|
|
}
|