Add admin-owned broadcast destinations ("community channels"): Discord or
generic webhooks fed straight from release_events by a per-channel watermark
sweep, announcing newly added movies/episodes as grouped digest posts plus
configurable media request lifecycle events (submitted/approved/declined/
fulfilled).
- Extend release_events with a kind discriminator and add a movie
availability spine (movie_availability + kind-keyed
notification_content_seed_state; first full scan seeds silently so
upgrades never flood the movie back catalog)
- Sweep worker reads events by (created_at, id) cursor with batch-window
grouping, per-channel backoff, and auto-disable; request events post
best-effort via new requests.LifecycleNotifier hooks
- Reuse the webhook stack throughout: URL encryption (new AAD namespace),
SSRF guard, embed limits, HMAC signing; shared type/name validation
extracted for both services
- Admin CRUD API under /admin/notifications/server-channels and a Server
Channels section in the notifications admin settings UI
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
96 lines
3.8 KiB
Go
96 lines
3.8 KiB
Go
package requests
|
|
|
|
import (
|
|
"context"
|
|
"log/slog"
|
|
)
|
|
|
|
// FulfillmentNotifier delivers the request.fulfilled notification once a
|
|
// completed request's media is confirmed present in the catalog. contentID is
|
|
// the matched catalog item id. Implementations must tolerate repeat calls for
|
|
// the same request (delivery creation is idempotent); returning nil means the
|
|
// request counts as handled and will not be retried.
|
|
type FulfillmentNotifier interface {
|
|
NotifyFulfilled(ctx context.Context, req Request, contentID string) error
|
|
}
|
|
|
|
// SetFulfillmentNotifier wires the notification system into the reconcile
|
|
// service. Optional; without it completed requests are never notified.
|
|
func (s *Service) SetFulfillmentNotifier(n FulfillmentNotifier) { s.notifier = n }
|
|
|
|
// LifecycleNotifier observes request lifecycle transitions (submitted,
|
|
// approved, declined) for broadcast destinations such as admin server
|
|
// channels. Implementations must be fast and non-blocking (dispatch async)
|
|
// and must never fail the transition: methods return nothing.
|
|
//
|
|
// Fulfillment is deliberately not part of this interface — it stays on
|
|
// FulfillmentNotifier, whose presence-checked, idempotent flow runs on the
|
|
// reconcile service rather than the API service.
|
|
type LifecycleNotifier interface {
|
|
RequestSubmitted(ctx context.Context, req Request)
|
|
RequestApproved(ctx context.Context, req Request)
|
|
RequestDeclined(ctx context.Context, req Request)
|
|
}
|
|
|
|
// SetLifecycleNotifier wires lifecycle observation into the API-facing
|
|
// service. Optional; without it transitions are not broadcast.
|
|
func (s *Service) SetLifecycleNotifier(n LifecycleNotifier) { s.lifecycle = n }
|
|
|
|
// notifyLifecycle resolves requester display identity and invokes one
|
|
// lifecycle hook. Best-effort by construction: the notifier cannot return an
|
|
// error and identity resolution failures just leave the name empty.
|
|
func (s *Service) notifyLifecycle(ctx context.Context, req Request, notify func(LifecycleNotifier, context.Context, Request)) {
|
|
if s.lifecycle == nil {
|
|
return
|
|
}
|
|
s.populateRequesterIdentity(ctx, &req)
|
|
notify(s.lifecycle, ctx, req)
|
|
}
|
|
|
|
// notifyFulfilledLimit bounds one notification pass; the remainder lands on
|
|
// the next reconcile run.
|
|
const notifyFulfilledLimit = 100
|
|
|
|
// notifyFulfilledPending notifies completed requests whose media has arrived
|
|
// in the catalog. Requests completed by an integration before the library
|
|
// scan imports the files stay pending (fulfilled_notified_at IS NULL) and are
|
|
// re-checked every run until presence confirms — the notification means
|
|
// "watchable in Silo", not "download finished". The delivery insert is
|
|
// idempotent (partial unique index per request), so the notify-then-stamp
|
|
// ordering can never double-send: a crash between the two retries into a
|
|
// dedupe no-op.
|
|
func (s *Service) notifyFulfilledPending(ctx context.Context) {
|
|
if s.notifier == nil {
|
|
return
|
|
}
|
|
candidates, err := s.store.ListFulfilledUnnotified(ctx, notifyFulfilledLimit)
|
|
if err != nil {
|
|
slog.WarnContext(ctx, "request fulfill-notify: list candidates failed", "err", err)
|
|
return
|
|
}
|
|
for _, req := range candidates {
|
|
if ctx.Err() != nil {
|
|
return
|
|
}
|
|
matches, err := s.lookupPresence(ctx, req.MediaType, []PresenceCandidate{requestPresenceCandidate(*req)})
|
|
if err != nil {
|
|
slog.WarnContext(ctx, "request fulfill-notify: presence lookup failed",
|
|
"request_id", req.ID, "tmdb_id", req.TMDBID, "err", err)
|
|
continue
|
|
}
|
|
match := matches[req.TMDBID]
|
|
if !match.Available {
|
|
continue // not in the catalog yet; retry next run
|
|
}
|
|
if err := s.notifier.NotifyFulfilled(ctx, *req, match.ContentID); err != nil {
|
|
slog.WarnContext(ctx, "request fulfill-notify: dispatch failed",
|
|
"request_id", req.ID, "err", err)
|
|
continue
|
|
}
|
|
if err := s.store.MarkFulfilledNotified(ctx, req.ID); err != nil {
|
|
slog.WarnContext(ctx, "request fulfill-notify: mark failed",
|
|
"request_id", req.ID, "err", err)
|
|
}
|
|
}
|
|
}
|