* docs: define ebook architecture matching audiobooks * docs: plan ebook audiobook-parity implementation * feat: add ebook scanner parser foundation * fix: harden ebook scanner foundation * fix: handle ebook isbn labels * fix: guard ebook subtree scans * feat: scan ebook libraries in core * fix: preserve ebook scan people credits * fix: refresh ebook scan metadata safely * feat: persist ebook series membership * test: cover ebook series persistence decisions * fix: address ebook scanner PR review * docs: clarify ebook foundation PR scope * feat: add ebook metadata enricher * fix: harden ebook poster cache * feat: wire ebook metadata sync task * feat: expose ebook library metadata setup * feat: add ebook catalog scope support * feat: add ebook detail view * feat: label ebook file versions by format * feat: use file-size copy for downloads * feat: use file language in download dialog * test: cover ebook detail authors and downloads * fix: drop narrator credits from ebook scanner merges * fix: align ebook collection filters with book media * fix: drop asin provider ids from ebook enrichment * fix: force ebook people refresh for stale narrators * chore: omit ebook planning docs from branch * feat: add ebook detail related content * feat: add ebook reader file entrypoint * feat: render ebooks with foliate reader * feat: persist ebook reader progress * feat: add ebook reader controls * feat: extract ebook pdf metadata * feat: favor scanner isbn during ebook enrichment * feat: extract fbz ebook metadata * feat: count cbz ebook pages * feat: show ebook file page counts * feat: show ebook download summaries * feat: switch ebook reader files * feat: prefer epub for ebook read action * feat: surface ebook reader progress * feat: sync ebook reader progress cache * feat: hide ebook read action for unsupported files * feat: filter ebook reader file selector * fix: serve fbz ebook archives with reader mime type * fix: detect fbz ebooks from compound filename * fix: authorize fbz ebooks from compound filename * fix: scope ebook catalog facets * fix: reject narrator queries for ebooks * fix: build ebook recommendation text from authors * fix: include ebooks in embedding eligibility * fix: include ebooks in recommendation media mix * fix: include ebooks in recently added recommendations * feat: include ebook progress in recommendation signals * feat: include ebooks in continue watching sections * feat: include ebooks in catalog progress metrics * fix: read ebook isbn from epub metadata * fix: filter ebook asin provider aliases * fix: fall back from unsupported ebook reader files * fix: sort ebook catalogs by reader progress * fix: filter ebook catalogs by reader progress * fix: include ebooks in last watched catalog filters * feat: reflect ebook reader progress in item user state * feat: share ebook progress state across item surfaces * feat: report ebook scan progress * fix: include ebook activity in recommendations * fix: expose ebook reader progress on item detail * fix: support ebook subtree scans * fix: honor profile header for ebook item progress * fix: add ebook library default sections * fix: route ebook continue cards to reader * fix: hide watched toggle for ebooks * fix: route ebook watch tonight cards to reader * fix: route ebook hero actions to reader * fix: detect archive ebook reader formats by filename * feat: cache embedded ebook covers during scan * fix: encode ebook hero reader links * fix: persist non-epub ebook reader progress * fix: scope narrator catalog badges to audiobooks * fix: merge ebook reader progress during item repair * fix: label ebook progress filters as read * fix: show ebook related rails as book covers * fix: remove txt ebook reader support * fix: reject txt ebook reader files * fix: label ebook advanced filters as read * fix: label ebook personalized sorts as read * fix: remove plain text reader loader path * test: cover ebook unread catalog rules * fix: preserve ebook reader library context * fix: link ebook genres with library scope * fix: encode related rail item links * fix: encode catalog card item links * fix: encode hero and continue item links * fix: encode watch tonight item links * fix: encode recommendation and search item links * test: cover ebook scan format set * fix: label ebook search results clearly * fix: make global search prompt media neutral * fix: encode catalog read API ids * fix: encode item API ids * fix: include ebook reader vendor in docker build * fix: make ebook reader build clean * fix: clean ebook embedded descriptions * docs: plan ebook reader shell parity * feat: add ebook reader shell controls * fix: widen ebook scrolled reader flow * fix: remove scrolled reader content width cap * docs: plan ebook reader full parity * feat: persist ebook reader config * feat: add ebook annotations and bookmarks * feat: add ebook reader tools and aids * feat: add ebook advanced reader settings * fix: keep ebook reader panel in viewport * fix: use foliate sizing units for ebook scroll flow * fix: keep ebook settings controls readable * fix: simplify ebook reader settings controls * feat(ebooks): extract local covers during scan (#98) * feat(ebooks): extract local covers during scan * fix(ebooks): read nullable poster paths during cover scan * fix(catalog): coalesce nullable media artwork fields * fix(ebooks): group sibling formats by book identity * fix(ebooks): tolerate legacy ebook metadata encodings * fix(ebooks): decode PDF hex metadata strings * fix(ebooks): harden local cover extraction and format grouping Address review findings on the local cover scan: - Restrict generic sidecar covers (cover.jpg, folder.png, ...) to single-book directories, always accept images named after the book file, and apply exactly one cover per reconcile with sidecar taking precedence over the embedded cover. - Replace the read-then-write poster update with an atomic conditional UPDATE (ItemRepository.SetLocalPoster) so provider/admin artwork is never clobbered by concurrent writers, and refresh locally owned posters when the extracted cover bytes change (thumbhash compare). - Preserve UTF-8 PDF Info strings (including a UTF-8 BOM) instead of forcing everything through Windows-1252; the cp1252 fallback now only applies to non-UTF-8 bytes. - Select EPUB covers by manifest media-type with properties="cover-image" outranking the EPUB2 meta name="cover" id, so XHTML cover pages no longer shadow the real image. - Order CBZ pages naturally (2.jpg before 10.jpg, ch2/ before ch10/) when picking the cover page, via a single O(n) min-scan. - Bump the ebook content group key scheme to version 2 and reprocess rows written under older versions so pre-existing libraries gain sibling-format grouping instead of accumulating duplicates. - Group different formats only (a same-format sibling with colliding sparse metadata stays a separate item) and stop a joining sibling's embedded metadata from overwriting a provider-matched item. - Decode any IANA-labelled OPF/FB2 XML charset (windows-1251, koi8-r, shift_jis, ...) via x/net/html/charset, and wire the charset reader into FB2 parsing which previously had none. - Strip the full .fb2.zip double extension from filename-derived titles and group keys. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: rxwatcher <rxwatcher@users.noreply.github.com> Co-authored-by: Quick <31828688+Quick104@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(ebooks): add reader profiles and ruler (#99) * feat(ebooks): extract local covers during scan * fix(ebooks): read nullable poster paths during cover scan * fix(catalog): coalesce nullable media artwork fields * fix(ebooks): group sibling formats by book identity * fix(ebooks): tolerate legacy ebook metadata encodings * fix(ebooks): decode PDF hex metadata strings * feat(ebooks): add reader profiles and ruler * fix(ebooks): address reader ruler and profile review findings - skip renderer setStyles/render when computed styles and attributes are unchanged, so ruler position updates no longer re-style the book view - drag the ruler via a local draft that commits on release, with the surface rect cached at pointer-down - migrate font values persisted before the generic stacks (Inter, Georgia, Merriweather, legacy serif) so the font select never renders blank, with a Custom fallback option for unknown values - make the ruler band click-through and move dragging to a dedicated keyboard-accessible slider handle so links and text selection keep working under the band - share font stacks between options and profiles via READER_FONT_STACKS - surface the active reading profile, move presets to the top of the settings panel, and drop the redundant profile button aria-labels Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ebooks): resolve prefer-const lint error in readest document lib `pnpm run lint` failed on the branch because `direction` is never reassigned in getDirection; split the destructure so only the reassigned `writingMode` stays mutable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: rxwatcher <rxwatcher@users.noreply.github.com> Co-authored-by: Quick <31828688+Quick104@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * Merge branch 'main' into work/ebooks-reader-base Brings the ebook integration branch up to date with main (audiobook library redesign, continue-watching rework and card affordances, quic-go bump, jellycompat fixes). Conflict resolutions favor main's generalized mechanisms and register ebooks with them: - media scope validation goes through IsValidMediaScope (now including "ebook" alongside main's "video" group scope), in Go and in the web filter/search types - continue-watching uses main's typed rails; reading-type sections pull resume points from ebook_reader_progress and the ebook library default section is wired to ContinueTypeConfig(ContinueTypeReading) - item_repo keeps main's derived select-list machinery (itemColumnExpr) and both poster accessors (GetPoster/SetLocalPoster for ebook covers, GetPosterPath for audiobook covers) - web cards/hero/watch-tonight adopt main's buildMediaPlayHref helpers, which now route ebooks to /reader/ebook and encode content ids; ebook affordances (BookOpen icon, Read verb, percent-read subtitle) carry over onto main's reworked components - LibraryForm ebook support ported into main's refactored useLibraryForm/libraryTypes modules Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(docker): copy foliate-js vendor into Dockerfile.dev frontend stage foliate-js is a file:vendor/foliate-js dependency, so pnpm install needs the vendor directory before the lockfile install layer. The production Dockerfile already copies it; the dev image was missed, breaking make dev-deploy with ENOENT on /app/web/vendor/foliate-js. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(ebooks): render Continue Reading sections as upright poster cards All-ebook continue sections previously fell through to the horizontal 16:9 wide card; include ebooks in the poster-variant check so book covers render in their natural 2:3 framing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ui): stop related-rail highlight ring clipping on detail pages Move the current-item ring onto the cover artwork with a themed ring-offset color (matching the sidebar profile highlight) and give the scroll container top headroom so the ring is not cut off by overflow-x-auto. Applies to both ebook and audiobook detail rails. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(scanner): harden ebook scanning against data loss and bad metadata - Reconcile missing ebook files like video/audio, with real per-root walk failure tracking (failed/unmounted roots are excluded from deletion), symlinked-root support via the shared logical walker, and the empty-root cleanup allowance before any destructive reconciliation. - Create ebook items as 'pending' so enrichment can promote them to 'matched' (backfill migration included), and protect matched items from re-scan clobbering: title/year skipped, people/series fill-empty only. - PDF metadata: scan head + tail windows (non-linearized PDFs keep the Info dict at the end), require proper key delimiters, head values win. - Cap plain .fb2 reads like .fbz entries; drop .md as an ebook format. - gofmt internal/scanner/audiobook.go (pre-existing drift). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ebooks): make enrichment failures non-terminal with dedicated backoff state - Provider errors now record a failure (capped retries) instead of stamping last_refreshed, which permanently excluded items after transient outages. - Unconfigured metadata chains and the scan-window membership race skip the item without stamping or burning a retry. - Failure tracking moves to a new ebook_enrichment_state table, decoupling it from media_items.refresh_failures (shared with metadata refresh debt). - Preserve non-author people credits when persisting enrichment results. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(catalog): gate ebook progress on hidden history and centralize threshold - Apply user_history_hidden_items gating (video semantics) to the ebook watched/in-progress filters, progress sort plan, and Continue Reading. - Continue Reading pages past dismissed items via the shared collector and dedupes items across pages (also fixes the video path's latent exposure). - Centralize the 0.9 finished threshold as models.EbookFinishedProgressThreshold with a single SQL-interpolated mirror in catalog. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(recommendations): correct watcher counting and wire ebook taste signals - itemWatchersQuery dedupes to distinct (watcher, item) rows so one binge-watcher can no longer satisfy minWatchers; the eligibility floor now counts distinct accounts rather than profiles. - Hidden-history gating on GetEbookReaderProgressForUser (signal reader). - Ebook reading produces canonical implicit taste signals (weighted like the equivalent movie progress ratio); ebooks join taste-seed candidates. - Stale GetRecentlyAddedItems doc comment corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(api): harden ebook reader endpoints and serve a Content-Security-Policy - Serve a CSP on all SPA HTML responses: blob/srcdoc book iframes inherit it, so script-src 'self' 'wasm-unsafe-eval' blocks script execution from malicious book content (sandbox alone is defeated by the WebKit allow-scripts requirement). Threat model documented on the constant. - X-Content-Type-Options: nosniff on frontend, jellycompat, and ebook file responses; MIME resolution can no longer fall through to octet-stream for an admitted ebook file. - Annotation PATCH: presence-aware field semantics (absent keeps, present sets/clears), invariant re-validation on the merged row, and an atomic SELECT ... FOR UPDATE read-merge-write. - Request size caps (413) on progress/config/annotation writes; Content-Disposition via mime.FormatMediaType; hidden-history gating in the shared ebook progress lister; FK-cascade indexes for reader tables. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(api): native read-state endpoints for ebooks - POST/DELETE /watched/{id} accepts ebook content IDs: mark read upserts progress 1.0 preserving the reader's file/location (or picks the preferred reader file for never-opened books); mark unread mirrors video unwatch semantics and deletes the progress row. - /history/remove accepts ebooks: hides via user_history_hidden_items without touching the reading position (hidden != unread; next reading activity resurfaces the book, mirroring video re-watch). - Access-filter checks match the video branch; shared logic lives in ebook_read_state.go. Sort metrics/user-state thresholds use the shared constant; profile-header fallback deduplicated. Clients: response is {type: "ebook", affected_count: 1, played: bool}; the existing watched SSE event fires. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(web): harden the ebook reader UI - Open-flow race: cancellation checked after every await with full stale-run teardown (no wrong-file progress saves, no leaked views/blob URLs); book.destroy() on cleanup. - Progress: monotonic stale-response guard; visibilitychange flush uses the refresh-capable client, pagehide uses keepalive; per-book cross-format progress documented as deliberate. - Settings: side effects out of the setState updater; local edits no longer clobbered by late server config; pending saves flushed on unmount/pagehide. - TTS: generation token so Stop actually stops (Chromium/Firefox synthetic events); Media Session uninstalled on unmount. - External book links: http(s) only, opened with noopener,noreferrer. - apiBlob 512 MiB guard with a user-facing error; fraction bookmarks navigable; search-result key collisions fixed; dead e-ink code removed; getLibrarySortRelevanceScope deduplicated; md format dropped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(web): mark read/unread affordances for ebooks - Item detail gets a Mark Read/Unread button; card menus drop the ebook gate and share type-aware labels/toasts (also dedupes audiobook wording). - Watched-state invalidation includes the reader progress query key so the Continue button and percent refresh after toggling. - Continue Reading dismiss copy for ebooks; dismissal path now URL-encodes item IDs (ebook content IDs can contain reserved characters). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: record the PR #124 review and hardening pass Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: rxwatcher <rxwatcher@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
233 lines
6.9 KiB
Go
233 lines
6.9 KiB
Go
package sections
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/Silo-Server/silo-server/internal/models"
|
|
)
|
|
|
|
func TestCollapseContinueWatchingSeriesCandidatesPrefersNewestInProgressEpisode(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
seriesID := "series-8"
|
|
importedAt := time.Date(2025, 1, 1, 12, 0, 0, 0, time.UTC)
|
|
localAt := time.Date(2025, 1, 2, 12, 0, 0, 0, time.UTC)
|
|
nextUpAt := time.Date(2025, 1, 3, 12, 0, 0, 0, time.UTC)
|
|
|
|
items := []*models.MediaItem{
|
|
{ContentID: "movie-1", Type: "movie", Title: "Movie One"},
|
|
{ContentID: "ep-s8e6", Type: "episode", Title: "Imported partial"},
|
|
{ContentID: "ep-s8e11", Type: "episode", Title: "Local partial"},
|
|
{ContentID: "ep-s8e12", Type: "episode", Title: "Next up"},
|
|
{ContentID: "movie-2", Type: "movie", Title: "Movie Two"},
|
|
}
|
|
meta := map[string]SectionItemMeta{
|
|
"ep-s8e6": {
|
|
SeriesID: &seriesID,
|
|
SeasonNumber: intPtr(8),
|
|
EpisodeNumber: intPtr(6),
|
|
ItemSource: "in_progress",
|
|
SortTimestamp: importedAt,
|
|
},
|
|
"ep-s8e11": {
|
|
SeriesID: &seriesID,
|
|
SeasonNumber: intPtr(8),
|
|
EpisodeNumber: intPtr(11),
|
|
ItemSource: "in_progress",
|
|
SortTimestamp: localAt,
|
|
},
|
|
"ep-s8e12": {
|
|
SeriesID: &seriesID,
|
|
SeasonNumber: intPtr(8),
|
|
EpisodeNumber: intPtr(12),
|
|
ItemSource: "next_up",
|
|
SortTimestamp: nextUpAt,
|
|
},
|
|
}
|
|
|
|
collapsed := collapseContinueWatchingSeriesCandidates(items, meta)
|
|
|
|
gotIDs := contentIDs(collapsed)
|
|
wantIDs := []string{"movie-1", "ep-s8e11", "movie-2"}
|
|
if len(gotIDs) != len(wantIDs) {
|
|
t.Fatalf("collapsed IDs = %v, want %v", gotIDs, wantIDs)
|
|
}
|
|
for i := range wantIDs {
|
|
if gotIDs[i] != wantIDs[i] {
|
|
t.Fatalf("collapsed IDs = %v, want %v", gotIDs, wantIDs)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestCollapseContinueWatchingSeriesCandidatesKeepsNextUpWhenNoInProgress(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
seriesID := "series-8"
|
|
items := []*models.MediaItem{
|
|
{ContentID: "ep-s8e12", Type: "episode", Title: "Next up"},
|
|
}
|
|
meta := map[string]SectionItemMeta{
|
|
"ep-s8e12": {
|
|
SeriesID: &seriesID,
|
|
SeasonNumber: intPtr(8),
|
|
EpisodeNumber: intPtr(12),
|
|
ItemSource: "next_up",
|
|
SortTimestamp: time.Date(2025, 1, 3, 12, 0, 0, 0, time.UTC),
|
|
},
|
|
}
|
|
|
|
collapsed := collapseContinueWatchingSeriesCandidates(items, meta)
|
|
|
|
if len(collapsed) != 1 || collapsed[0].ContentID != "ep-s8e12" {
|
|
t.Fatalf("collapsed = %v, want only ep-s8e12", contentIDs(collapsed))
|
|
}
|
|
}
|
|
|
|
func TestMatchesContinueWatchingFilterIncludesAudiobooks(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
filterType string
|
|
itemType string
|
|
want bool
|
|
}{
|
|
{name: "movie keeps movie", filterType: "movie", itemType: "movie", want: true},
|
|
{name: "movie keeps episode through watching type", filterType: "movie", itemType: "episode", want: true},
|
|
{name: "series keeps episode", filterType: "series", itemType: "episode", want: true},
|
|
{name: "audiobook keeps audiobook", filterType: "audiobook", itemType: "audiobook", want: true},
|
|
{name: "audiobook rejects movie", filterType: "audiobook", itemType: "movie", want: false},
|
|
{name: "ebook keeps ebook", filterType: "ebook", itemType: "ebook", want: true},
|
|
{name: "unknown passes through audiobook", filterType: "unknown", itemType: "audiobook", want: true},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if got := matchesContinueWatchingFilter(tt.filterType, tt.itemType); got != tt.want {
|
|
t.Fatalf("matchesContinueWatchingFilter(%q, %q) = %v, want %v", tt.filterType, tt.itemType, got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParseContinueType(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
config string
|
|
want ContinueType
|
|
}{
|
|
{name: "missing defaults watching", config: `{}`, want: ContinueTypeWatching},
|
|
{name: "explicit watching", config: `{"continue_type":"watching"}`, want: ContinueTypeWatching},
|
|
{name: "explicit listening", config: `{"continue_type":"listening"}`, want: ContinueTypeListening},
|
|
{name: "legacy audiobook filter", config: `{"filter_type":"audiobook"}`, want: ContinueTypeListening},
|
|
{name: "legacy audiobook media scope", config: `{"media_scope":"audiobook"}`, want: ContinueTypeListening},
|
|
{name: "future reading", config: `{"continue_type":"reading"}`, want: ContinueTypeReading},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got, err := ParseContinueType([]byte(tt.config))
|
|
if err != nil {
|
|
t.Fatalf("ParseContinueType(%s): %v", tt.config, err)
|
|
}
|
|
if got != tt.want {
|
|
t.Fatalf("ParseContinueType(%s) = %q, want %q", tt.config, got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParseContinueTypeRejectsUnknownExplicitType(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
if _, err := ParseContinueType([]byte(`{"continue_type":"scrolling"}`)); err == nil {
|
|
t.Fatal("ParseContinueType accepted unknown continue_type")
|
|
}
|
|
}
|
|
|
|
func TestEbookContinueWatchingProgressQueryGatesHiddenHistory(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
query := strings.Join(strings.Fields(ebookContinueWatchingProgressQuery), " ")
|
|
|
|
// Continue Reading must honor user_history_hidden_items with the same
|
|
// semantics as the video path (pgstore ListProgress "in_progress"): a row
|
|
// is hidden while updated_at <= hidden_before and counts again once new
|
|
// reading activity lands after hidden_before.
|
|
for _, term := range []string{
|
|
"FROM ebook_reader_progress",
|
|
"NOT EXISTS",
|
|
"FROM user_history_hidden_items hhi",
|
|
"hhi.media_item_id = ebook_reader_progress.content_id",
|
|
"ebook_reader_progress.updated_at <= hhi.hidden_before",
|
|
} {
|
|
if !strings.Contains(query, term) {
|
|
t.Fatalf("ebook continue watching query missing %q:\n%s", term, query)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestAppendUniqueContinueItemsDedupesAcrossPages(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
seen := make(map[string]struct{})
|
|
limit := 4
|
|
|
|
pageOne := []*models.MediaItem{
|
|
{ContentID: "book-a"},
|
|
{ContentID: "book-b"},
|
|
}
|
|
ordered := appendUniqueContinueItems(nil, pageOne, seen, limit)
|
|
|
|
// A progress write between pages shifts rows across the LIMIT/OFFSET
|
|
// boundary, so page two re-serves book-b.
|
|
pageTwo := []*models.MediaItem{
|
|
{ContentID: "book-b"},
|
|
{ContentID: "book-c"},
|
|
}
|
|
ordered = appendUniqueContinueItems(ordered, pageTwo, seen, limit)
|
|
|
|
got := contentIDs(ordered)
|
|
want := []string{"book-a", "book-b", "book-c"}
|
|
if len(got) != len(want) {
|
|
t.Fatalf("ordered IDs = %v, want %v", got, want)
|
|
}
|
|
for i := range want {
|
|
if got[i] != want[i] {
|
|
t.Fatalf("ordered IDs = %v, want %v", got, want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestAppendUniqueContinueItemsRespectsLimit(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
seen := make(map[string]struct{})
|
|
page := []*models.MediaItem{
|
|
{ContentID: "a"},
|
|
{ContentID: "b"},
|
|
{ContentID: "c"},
|
|
}
|
|
|
|
ordered := appendUniqueContinueItems(nil, page, seen, 2)
|
|
if got := contentIDs(ordered); len(got) != 2 || got[0] != "a" || got[1] != "b" {
|
|
t.Fatalf("ordered IDs = %v, want [a b]", got)
|
|
}
|
|
}
|
|
|
|
func contentIDs(items []*models.MediaItem) []string {
|
|
ids := make([]string, 0, len(items))
|
|
for _, item := range items {
|
|
ids = append(ids, item.ContentID)
|
|
}
|
|
return ids
|
|
}
|
|
|
|
func intPtr(v int) *int {
|
|
return &v
|
|
}
|