* docs(markers): design + implementation plans for multi-source markers & TheIntroDB contribution * fix(markers): TheIntroDB read-path correctness (TVDB, real confidence, best candidate) Honor TVDB ids in /media lookups (previously dropped — anime/TheTVDB-first libraries got no markers), decode and use the real per-segment confidence and submission_count instead of a hardcoded 0.9, and pick the most-submitted / highest-confidence candidate when several are returned. Adds httptest coverage for the introdb client and provider. Phase 1 of docs/superpowers/plans/2026-06-06-marker-sources-and-contribution-implementation.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(markers): multi-source dispatch, per-provider config, per-segment provenance Add marker_provider_config (per-provider fetch enable/priority + contribute gates, contribution off by default) and a cached ProviderConfigStore. Add Registry.FetchMerged: query all fetch-enabled providers concurrently and keep the best candidate per segment (submission_count, then confidence, then fetch priority), stamping each winning marker with its provider/algorithm. Thread per-segment provenance through MarkerUpdatePayload and scanner.MarkerUpdate (additive SegmentProvenance overrides) so a merged result writes correct per-segment provider/confidence/algorithm; the legacy shared columns keep a summary. The lazy-playback path now uses FetchMerged. With only TheIntroDB enabled, behavior is unchanged. Phase 2 of docs/superpowers/plans/2026-06-06-marker-sources-and-contribution-implementation.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(markers): TheIntroDB submission client, contribution audit, service engine Add a markers.Submitter capability and implement it on the introdb provider (POST /v3/submit, GET /v3/user/stats; key required, usage-limit aware, applies the null start/end conventions). Add the marker_contributions audit table and a value-hash-keyed ContributionStore for idempotency. Add ContributionService: resolves enabled submitter providers, gates eligibility (never re-submit online-sourced markers; auto runs require contribute_auto_local + scanner-intro above the per-provider confidence threshold), checks idempotency, submits, and records. Wired in main.go; no trigger yet (admin API and task follow). Phase 3 of docs/superpowers/plans/2026-06-06-marker-sources-and-contribution-implementation.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(api): admin marker editing, contribution, and provider config endpoints Add the RequireAdmin marker API: GET/PUT /admin/files/{id}/markers (read with provenance; manual upsert where a segment object sets and null clears), DELETE .../markers/{segment}, POST .../contribute and GET .../contributions, plus GET/PUT /admin/markers/providers[/{provider}] and a .../validate key-check returning user stats. Manual writes go through the priority-gated UpsertMarkers (source=manual) and notify live sessions; a new FileRepository.ClearMarkers nulls a segment's columns. Validation mirrors the contribution rules. Phase 4 of docs/superpowers/plans/2026-06-06-marker-sources-and-contribution-implementation.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(markers): daily auto-contribution task for local intro markers Add ContributeMarkersTask (daily 04:00, after local detection): when a provider has contribute_enabled + contribute_auto_local, page through episode files with a scanner intro marker at/above the provider's confidence threshold (new ContributionStore.CandidateLocalIntroFiles keyset query) and run them through ContributionService with Auto=true. No-op when no provider opts in; idempotent and resumable across runs. Phase 5 of docs/superpowers/plans/2026-06-06-marker-sources-and-contribution-implementation.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(intromarkers): refine chromaprint starts with dialogue cues * feat(markers): finish marker management backend * feat(web): add marker editing UI * feat(markers): use plugin marker providers * fix(markers): address PR review feedback * feat(player): show marker labels on seek hover * fix(markers): type nullable marker mutation params * feat(markers): audit marker edits and add permission --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
119 lines
3.7 KiB
Go
119 lines
3.7 KiB
Go
package tasks
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/Silo-Server/silo-server/internal/markers"
|
|
"github.com/Silo-Server/silo-server/internal/models"
|
|
)
|
|
|
|
type contribTestProgress struct{ data json.RawMessage }
|
|
|
|
func (p *contribTestProgress) Report(float64, string) {}
|
|
func (p *contribTestProgress) SetResultData(d json.RawMessage) { p.data = d }
|
|
|
|
type fakeContribRunner struct {
|
|
calls []int
|
|
autoSeen bool
|
|
outcomes []markers.ContributionOutcome
|
|
}
|
|
|
|
func (f *fakeContribRunner) ContributeFile(_ context.Context, file *models.MediaFile, opts markers.ContributeOptions) ([]markers.ContributionOutcome, error) {
|
|
f.calls = append(f.calls, file.ID)
|
|
f.autoSeen = opts.Auto
|
|
return f.outcomes, nil
|
|
}
|
|
|
|
type fakeAutoConfig []markers.ProviderConfig
|
|
|
|
func (f fakeAutoConfig) List() []markers.ProviderConfig { return f }
|
|
|
|
type fakeCandidates struct {
|
|
ids []int
|
|
gotMin float64
|
|
delivered bool
|
|
}
|
|
|
|
func (f *fakeCandidates) CandidateLocalIntroFiles(_ context.Context, minConfidence float64, _, _ int) ([]int, error) {
|
|
f.gotMin = minConfidence
|
|
if f.delivered {
|
|
return nil, nil
|
|
}
|
|
f.delivered = true
|
|
return f.ids, nil
|
|
}
|
|
|
|
type fakeFileLoader struct{}
|
|
|
|
func (fakeFileLoader) GetByIDs(_ context.Context, ids []int) ([]*models.MediaFile, error) {
|
|
out := make([]*models.MediaFile, 0, len(ids))
|
|
for _, id := range ids {
|
|
out = append(out, &models.MediaFile{ID: id})
|
|
}
|
|
return out, nil
|
|
}
|
|
|
|
func TestContributeMarkersTaskNoAutoProvider(t *testing.T) {
|
|
runner := &fakeContribRunner{}
|
|
cfg := fakeAutoConfig{{Provider: "introdb", ContributeEnabled: true, ContributeAutoLocal: false}}
|
|
task := NewContributeMarkersTask(runner, cfg, &fakeCandidates{ids: []int{1}}, fakeFileLoader{})
|
|
|
|
if err := task.Execute(context.Background(), &contribTestProgress{}); err != nil {
|
|
t.Fatalf("Execute: %v", err)
|
|
}
|
|
if len(runner.calls) != 0 {
|
|
t.Errorf("expected no contributions when auto disabled, got %d", len(runner.calls))
|
|
}
|
|
}
|
|
|
|
func TestContributeMarkersTaskSubmitsCandidates(t *testing.T) {
|
|
runner := &fakeContribRunner{outcomes: []markers.ContributionOutcome{{Status: markers.SubmissionStatusPending}}}
|
|
cands := &fakeCandidates{ids: []int{10, 11}}
|
|
cfg := fakeAutoConfig{{Provider: "introdb", ContributeEnabled: true, ContributeAutoLocal: true, ContributeMinConfidence: 0.95}}
|
|
task := NewContributeMarkersTask(runner, cfg, cands, fakeFileLoader{})
|
|
|
|
prog := &contribTestProgress{}
|
|
if err := task.Execute(context.Background(), prog); err != nil {
|
|
t.Fatalf("Execute: %v", err)
|
|
}
|
|
if len(runner.calls) != 2 {
|
|
t.Fatalf("expected 2 contributions, got %d", len(runner.calls))
|
|
}
|
|
if !runner.autoSeen {
|
|
t.Error("ContributeFile should be called with Auto=true")
|
|
}
|
|
if cands.gotMin != 0.95 {
|
|
t.Errorf("min confidence passed = %v, want 0.95", cands.gotMin)
|
|
}
|
|
if prog.data == nil {
|
|
t.Error("expected result summary data")
|
|
}
|
|
}
|
|
|
|
func TestContributeMarkersTaskStopsOnRateLimit(t *testing.T) {
|
|
runner := &fakeContribRunner{outcomes: []markers.ContributionOutcome{{
|
|
Status: markers.OutcomeStatusRateLimited, RetryAfter: 90 * time.Second,
|
|
}}}
|
|
cands := &fakeCandidates{ids: []int{10, 11}}
|
|
cfg := fakeAutoConfig{{Provider: "introdb", ContributeEnabled: true, ContributeAutoLocal: true, ContributeMinConfidence: 0.95}}
|
|
task := NewContributeMarkersTask(runner, cfg, cands, fakeFileLoader{})
|
|
|
|
prog := &contribTestProgress{}
|
|
if err := task.Execute(context.Background(), prog); err != nil {
|
|
t.Fatalf("Execute: %v", err)
|
|
}
|
|
if len(runner.calls) != 1 {
|
|
t.Fatalf("expected task to stop after rate limit, calls=%d", len(runner.calls))
|
|
}
|
|
var data map[string]int
|
|
if err := json.Unmarshal(prog.data, &data); err != nil {
|
|
t.Fatalf("decode result data: %v", err)
|
|
}
|
|
if data["retry_after_seconds"] != 90 {
|
|
t.Fatalf("retry_after_seconds = %d, want 90", data["retry_after_seconds"])
|
|
}
|
|
}
|