haeaeae/Stirling-PDF
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(theme): dedupe default-blue literal in theme constants

Browse Source 
Collapse the two #3b82f6 occurrences (DEFAULT_ACCENT_COLOR + first preset) into
a single documented BLUE_500 const. The accent hexes stay JS literals by
necessity — stored verbatim and parsed by deriveAccessiblePrimary, so CSS
var(--p-*) refs can't be used; theme-lint scopes to CSS only.
This commit is contained in:
EthanHealy01
2026-07-13 00:25:56 +01:00
parent ffc0755b37
commit 41f507a9f0
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/editor/src/core/constants/theme.ts
+8 -3
View File
@@ -5,14 +5,19 @@ export type ThemeMode = "light" | "dark" | "system";
// The concrete light/dark base applied to Mantine + the neutral ramp.
export type ColorScheme = "light" | "dark";
// blue-500 (matches --p-blue-500 in primitives.css). Kept as a JS literal — not
// a CSS var() — because it's stored verbatim as the accent and parsed by
// deriveAccessiblePrimary; a var() string couldn't be parsed or persisted.
const BLUE_500 = "#3b82f6";
// lightPrimary/darkPrimary hold either a colour (tints surfaces) or this sentinel (neutral surfaces + blue buttons; ThemeProvider maps it to DEFAULT_ACCENT_COLOR and flags data-accent="default").
export const DEFAULT_ACCENT = "default";
export const DEFAULT_ACCENT_COLOR = "#3b82f6"; // blue-500 — buttons in the default theme
export const DEFAULT_ACCENT_COLOR = BLUE_500; // buttons in the default theme
// 14 curated mid-tone accents filling the 3×5 grid alongside the "Default" cell. Literal hex: the picker stores the value verbatim and deriveAccessiblePrimary parses it.
// 14 curated mid-tone accents filling the 3×5 grid alongside the "Default" cell. Literal hex (see BLUE_500): the picker stores the value verbatim and deriveAccessiblePrimary parses it, so CSS var() refs can't be used here.
export const THEME_ACCENT_PRESETS = [
// blues → purples (one purple trimmed so the grid leaves room for Default)
"#3b82f6", // blue
BLUE_500, // blue
"#6366f1", // indigo
"#8b5cf6", // violet
"#d946ef", // fuchsia