Update typescript-eslint packages to v8.51.0

Bump @typescript-eslint/eslint-plugin, @typescript-eslint/parser, and typescript-eslint to version 8.51.0 in package.json and package-lock.json to keep development dependencies up to date.

frontend/eslint.config.mjs

@@ -3,31 +3,133 @@
 import eslint from '@eslint/js';
 import globals from 'globals';
 import { defineConfig } from 'eslint/config';
+import reactHooksPlugin from 'eslint-plugin-react-hooks';
+import reactPlugin from 'eslint-plugin-react';
 import tseslint from 'typescript-eslint';
+import { fileURLToPath } from 'node:url';
 import importPlugin from 'eslint-plugin-import';
 
-const srcGlobs = [
-  'src/**/*.{js,mjs,jsx,ts,tsx}',
+const ignorePatterns = [
+  "__tests/**",
+  "dist/**",
+  "./dist/**",
+  "dist/**/*",
+  "./dist/**/*",
+  "**/dist/**",
+  "**/dist/**/*",
+  "build/**",
+  "./build/**",
+  "build/**/*",
+  "./build/**/*",
+  "**/build/**",
+  "**/build/**/*",
+  "node_modules/**",
+  "./node_modules/**",
+  "node_modules/**/*",
+  "./node_modules/**/*",
+  "**/node_modules/**",
+  "**/node_modules/**/*",
+  "public/**",
+  "./public/**",
+  "public/**/*",
+  "./public/**/*",
+  "**/public/**",
+  "**/public/**/*",
+  "src-tauri/**",
+  "./src-tauri/**",
+  "src-tauri/**/*",
+  "./src-tauri/**/*",
+  "**/src-tauri/**",
+  "**/src-tauri/**/*"
 ];
+const jsGlobs = ['{src,frontend/src}/**/*.{js,jsx}'];
+const srcGlobs = ['{src,frontend/src}/**/*.{ts,tsx}'];
 const nodeGlobs = [
   'scripts/**/*.{js,ts,mjs}',
-  '*.config.{js,ts,mjs}',
+  'vite.config.ts',
+  'vitest.config.ts',
+  'vitest.minimal.config.ts',
+  'playwright.config.ts',
+  'tailwind.config.js',
+  'postcss.config.js',
+  'eslint.config.mjs',
 ];
 
+const __dirname = fileURLToPath(new URL('./', import.meta.url));
+
 export default defineConfig(
+  { ignores: ignorePatterns },
+
+  // Shared settings for all files
+  {
+    ignores: ignorePatterns,
+    rules: {
+      semi: "error",
+      "prefer-const": "error",
+    },
+  },
+
+  // Core rules for all source files
+  eslint.configs.recommended,
+
+  // Specific rules for different types of files
   {
     // Everything that contains 3rd party code that we don't want to lint
     ignores: [
-      'dist',
-      'node_modules',
-      'public',
-      'src-tauri',
+      ...ignorePatterns,
+      ...jsGlobs,
+      ...nodeGlobs
     ],
-  },
-  eslint.configs.recommended,
-  tseslint.configs.recommended,
-  {
+    files: srcGlobs,
+    extends: [
+      reactPlugin.configs.flat.recommended,
+      reactPlugin.configs.flat['jsx-runtime'],
+      ...tseslint.configs.recommendedTypeChecked,
+    ],
+    languageOptions: {
+      parser: tseslint.parser,
+      parserOptions: {
+        projectService: {
+          allowDefaultProject: [
+            'src/components/tooltips/usePageSelectionTips.tsx',
+            'src/reportWebVitals.js',
+            'src/setupTests.js'
+          ],
+          defaultProject: './tsconfig.json'
+        },
+        tsconfigRootDir: __dirname,
+      },
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+      },
+    },
+    plugins: {
+      '@typescript-eslint': tseslint.plugin,
+      react: reactPlugin,
+      'react-hooks': reactHooksPlugin,
+    },
+    settings: {
+      react: {
+        version: 'detect',
+      },
+    },
     rules: {
+      // Enabled rules
+      'react-hooks/exhaustive-deps': 'error',
+      'react-hooks/rules-of-hooks': 'error',
+      'react/display-name': 'error',
+      'react/no-children-prop': 'error',
+      'react/prop-types': 'error',
+      'react/no-unescaped-entities': 'error',
+
+      '@typescript-eslint/require-await': 'error',
+      '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+      '@typescript-eslint/prefer-regexp-exec': 'error',
+      '@typescript-eslint/prefer-includes': 'error',
+      '@typescript-eslint/consistent-indexed-object-style': 'error',
+      '@typescript-eslint/class-literal-property-style': 'error',
+      '@typescript-eslint/consistent-type-definitions': 'error',
       'no-restricted-imports': [
         'error',
         {
@@ -44,38 +146,106 @@ export default defineConfig(
           allowInterfaces: 'with-single-extends',
         },
       ],
-      '@typescript-eslint/no-explicit-any': 'off', // Temporarily disabled until codebase conformant
-      '@typescript-eslint/no-require-imports': 'off', // Temporarily disabled until codebase conformant
-      '@typescript-eslint/no-unused-vars': [
-        'error',
+      "@typescript-eslint/no-explicit-any": "error",
+      "@typescript-eslint/no-require-imports": "error",
+      "@typescript-eslint/no-unused-vars": [
+        "error",
         {
-          'args': 'all', // All function args must be used (or explicitly ignored)
-          'argsIgnorePattern': '^_', // Allow unused variables beginning with an underscore
-          'caughtErrors': 'all', // Caught errors must be used (or explicitly ignored)
-          'caughtErrorsIgnorePattern': '^_', // Allow unused variables beginning with an underscore
-          'destructuredArrayIgnorePattern': '^_', // Allow unused variables beginning with an underscore
-          'varsIgnorePattern': '^_', // Allow unused variables beginning with an underscore
-          'ignoreRestSiblings': true, // Allow unused variables when removing attributes from objects (otherwise this requires explicit renaming like `({ x: _x, ...y }) => y`, which is clunky)
+          args: 'all', // All function args must be used (or explicitly ignored)
+          argsIgnorePattern: '^_', // Allow unused variables beginning with an underscore
+          caughtErrors: 'all', // Caught errors must be used (or explicitly ignored)
+          caughtErrorsIgnorePattern: '^_', // Allow unused variables beginning with an underscore
+          destructuredArrayIgnorePattern: '^_', // Allow unused variables beginning with an underscore
+          varsIgnorePattern: '^_', // Allow unused variables beginning with an underscore
+          ignoreRestSiblings: true, // Allow unused variables when removing attributes from objects (otherwise this requires explicit renaming like `({ x: _x, ...y }) => y`, which is clunky)
         },
       ],
+      "no-redeclare": "error",
+
+      // Disabled rules (too restrictive or not useful for this codebase)
+      'react/react-in-jsx-scope': 'off', // Not needed with React 17+
+      "no-unused-vars": "off", // Use the TypeScript version instead
+      "no-undef": "off", // Use the TypeScript version instead
+      '@typescript-eslint/no-empty-function': 'off', // Ignore empty functions (they're often useful)
+      '@typescript-eslint/prefer-nullish-coalescing': 'off', // Ignore preference of ?? over || (both have their uses)
+      '@typescript-eslint/unbound-method': 'off', // Ignore unbound methods (they're often useful)
+      '@typescript-eslint/restrict-template-expressions': 'off', // Ignore restrictions on template expressions (they're often useful)
+      '@typescript-eslint/dot-notation': 'off', // Ignore dot notation (it's often more readable to use bracket notation)
+      '@typescript-eslint/non-nullable-type-assertion-style': 'off', // Ignore preference of using !. over other methods (both have their uses)
+      '@typescript-eslint/consistent-generic-constructors': 'off', // Ignore preference of using new Array<T>() over Array<T> (both have their uses)
+      '@typescript-eslint/no-redundant-type-constituents': 'off', // Ignore redundant type constituents (they're often useful for clarity)
+      '@typescript-eslint/array-type': 'off', // see: https://github.com/Stirling-Tools/Stirling-PDF/pull/4521#issuecomment-3346477814
+
+      // Should be checked
+      "@typescript-eslint/no-inferrable-types": "error",
+      '@typescript-eslint/await-thenable': 'error',
+      '@typescript-eslint/no-unsafe-assignment': 'error',
+      '@typescript-eslint/no-unsafe-return': 'error',
+      '@typescript-eslint/no-unsafe-call': 'error',
+      '@typescript-eslint/no-unsafe-member-access': 'error',
+      '@typescript-eslint/no-unsafe-argument': 'error',
+      '@typescript-eslint/only-throw-error': 'error',
+      '@typescript-eslint/no-floating-promises': 'error',
+      '@typescript-eslint/prefer-promise-reject-errors': 'error',
+      '@typescript-eslint/prefer-optional-chain': 'error',
+      '@typescript-eslint/no-base-to-string': 'error',
+      '@typescript-eslint/no-misused-promises': 'error',
     },
   },
-  // Config for browser scripts
-  {
-    files: srcGlobs,
-    languageOptions: {
-      globals: {
-        ...globals.browser,
-      }
-    }
-  },
-  // Config for node scripts
   {
+    ignores: [
+      ...ignorePatterns,
+      ...jsGlobs
+    ],
     files: nodeGlobs,
+    extends: [
+      tseslint.configs.disableTypeChecked
+    ],
     languageOptions: {
       globals: {
         ...globals.node,
-      }
+      },
+      parserOptions: {
+        ecmaVersion: 'latest',
+        sourceType: 'module',
+      },
+      sourceType: 'module',
+    },
+  },
+  {
+    files: jsGlobs,
+    ignores: [
+      ...nodeGlobs,
+      ...ignorePatterns
+    ],
+    extends: [
+      reactPlugin.configs.flat.recommended,
+      eslint.configs.recommended,
+    ],
+    languageOptions: {
+      parserOptions: {
+        ecmaVersion: 'latest',
+        sourceType: 'module',
+        ecmaFeatures: {
+          jsx: true,
+        },
+        tsconfigRootDir: __dirname,
+      },
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+      },
+    },
+    plugins: {
+      react: reactPlugin,
+      'react-hooks': reactHooksPlugin,
+    },
+    settings: { react: { version: 'detect' } },
+    rules: {
+      'no-unused-vars': 'error',
+      'no-console': 'error',
+      'react/jsx-uses-react': 'error',
+      'react/jsx-uses-vars': 'error',
     }
   },
   // Config for import plugin

frontend/package.json

@@ -47,7 +47,7 @@
     "@tauri-apps/plugin-http": "^2.5.4",
     "autoprefixer": "^10.4.21",
     "axios": "^1.12.2",
-    "globals": "^16.4.0",
+    "globals": "^16.5.0",
     "i18next": "^25.5.2",
     "i18next-browser-languagedetector": "^8.2.0",
     "jszip": "^3.10.1",
@@ -117,7 +117,7 @@
     ]
   },
   "devDependencies": {
-    "@eslint/js": "^9.36.0",
+    "@eslint/js": "^9.39.2",
     "@iconify-json/material-symbols": "^1.2.48",
     "@iconify/utils": "^3.0.2",
     "@playwright/test": "^1.55.0",
@@ -126,21 +126,25 @@
     "@testing-library/jest-dom": "^6.8.0",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
+    "@tsconfig/vite-react": "^7.0.2",
     "@types/gapi": "^0.0.47",
     "@types/gapi.client.drive-v3": "^0.0.5",
     "@types/google.accounts": "^0.0.18",
     "@types/google.picker": "^0.0.51",
-    "@types/node": "^24.5.2",
+    "@types/node": "^24.10.1",
     "@types/react": "^19.1.13",
     "@types/react-dom": "^19.1.9",
-    "@typescript-eslint/eslint-plugin": "^8.44.1",
-    "@typescript-eslint/parser": "^8.44.1",
+    "@typescript-eslint/eslint-plugin": "^8.51.0",
+    "@typescript-eslint/parser": "^8.51.0",
     "@vitejs/plugin-react-swc": "^4.1.0",
     "@vitest/coverage-v8": "^3.2.4",
-    "eslint": "^9.36.0",
+    "eslint": "^9.39.2",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-import": "^2.32.0",
-    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^7.0.1",
+    "eslint-plugin-simple-import-sort": "^12.1.1",
+    "globals": "^16.5.0",
     "jsdom": "^27.0.0",
     "license-checker": "^25.0.1",
     "madge": "^8.0.0",
@@ -149,8 +153,8 @@
     "postcss-preset-mantine": "^1.18.0",
     "postcss-simple-vars": "^7.0.1",
     "puppeteer": "^24.25.0",
-    "typescript": "^5.9.2",
-    "typescript-eslint": "^8.44.1",
+    "typescript": "^5.9.3",
+    "typescript-eslint": "^8.51.0",
     "vite": "^7.1.7",
     "vite-plugin-static-copy": "^3.1.4",
     "vite-tsconfig-paths": "^5.1.4",

frontend/tsconfig.json

@@ -1,4 +1,5 @@
 {
+  "extends": "@tsconfig/vite-react/tsconfig.json",
   "compilerOptions": {
     /* Visit https://aka.ms/tsconfig to read more about this file */
 
@@ -11,9 +12,9 @@
     // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */
 
     /* Language and Environment */
-    "target": "es2022",                                  /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "target": "ES2022",                                  /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
     // "lib": [],                                        /* Specify a set of bundled library declaration files that describe the target runtime environment. */
-    "jsx": "react-jsx",                                /* Specify what JSX code is generated. */
+    "jsx": "react-jsx",                                  /* Specify what JSX code is generated. */
     // "libReplacement": true,                           /* Enable lib replacement. */
     // "experimentalDecorators": true,                   /* Enable experimental support for legacy experimental decorators. */
     // "emitDecoratorMetadata": true,                    /* Emit design-type metadata for decorated declarations in source files. */
@@ -26,11 +27,11 @@
     // "moduleDetection": "auto",                        /* Control what method is used to detect module-format JS files. */
 
     /* Modules */
-    "module": "esnext",                                /* Specify what module code is generated. */
+    "module": "esnext",                                  /* Specify what module code is generated. */
     // "rootDir": "./",                                  /* Specify the root folder within your source files. */
-    "moduleResolution": "bundler",                     /* Specify how TypeScript looks up a file from a given module specifier. */
-    "baseUrl": "./",                                  /* Specify the base directory to resolve non-relative module names. */
-    "paths": {                                       /* Specify a set of entries that re-map imports to additional lookup locations. */
+    "moduleResolution": "bundler",                       /* Specify how TypeScript looks up a file from a given module specifier. */
+    "baseUrl": "./",                                     /* Specify the base directory to resolve non-relative module names. */
+    "paths": {                                           /* Specify a set of entries that re-map imports to additional lookup locations. */
       "@app/*": [
         "src/desktop/*",
         "src/proprietary/*",
@@ -42,7 +43,7 @@
     },
     // "rootDirs": [],                                   /* Allow multiple folders to be treated as one when resolving modules. */
     // "typeRoots": [],                                  /* Specify multiple folders that act like './node_modules/@types'. */
-    // "types": [],                                      /* Specify type package names to be included without being referenced in a source file. */
+    "types": ["vite/client", "vitest/globals"],          /* Specify type package names to be included without being referenced in a source file. */
     // "allowUmdGlobalAccess": true,                     /* Allow accessing UMD globals from modules. */
     // "moduleSuffixes": [],                             /* List of file name suffixes to search when resolving a module. */
     // "allowImportingTsExtensions": true,               /* Allow imports to include TypeScript file extensions. Requires '--moduleResolution bundler' and either '--noEmit' or '--emitDeclarationOnly' to be set. */
@@ -51,7 +52,7 @@
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
     // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
-    "resolveJsonModule": true,                        /* Enable importing .json files. */
+    "resolveJsonModule": true,                           /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */
 
@@ -66,7 +67,7 @@
     // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
     // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
     // "inlineSourceMap": true,                          /* Include sourcemap files inside the emitted JavaScript. */
-    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
+    "noEmit": true,                                      /* Disable emitting files from a compilation. */
     // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
     // "outDir": "./",                                   /* Specify an output folder for all emitted files. */
     // "removeComments": true,                           /* Disable emitting comments. */
@@ -85,9 +86,9 @@
 
     /* Interop Constraints */
     // "isolatedModules": true,                          /* Ensure that each file can be safely transpiled without relying on other imports. */
-    // "verbatimModuleSyntax": true,                     /* Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting. */
+    "verbatimModuleSyntax": false,                       /* Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting. */
     // "isolatedDeclarations": true,                     /* Require sufficient annotation on exports so other tools can trivially generate declaration files. */
-    // "erasableSyntaxOnly": true,                       /* Do not allow runtime constructs that are not part of ECMAScript. */
+    "erasableSyntaxOnly": false,                         /* Do not allow runtime constructs that are not part of ECMAScript. */
     // "allowSyntheticDefaultImports": true,             /* Allow 'import x from y' when a module doesn't have a default export. */
     "esModuleInterop": true,                             /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables 'allowSyntheticDefaultImports' for type compatibility. */
     // "preserveSymlinks": true,                         /* Disable resolving symlinks to their realpath. This correlates to the same flag in node. */
@@ -104,8 +105,8 @@
     // "noImplicitThis": true,                           /* Enable error reporting when 'this' is given the type 'any'. */
     // "useUnknownInCatchVariables": true,               /* Default catch clause variables as 'unknown' instead of 'any'. */
     // "alwaysStrict": true,                             /* Ensure 'use strict' is always emitted. */
-    // "noUnusedLocals": true,                           /* Enable error reporting when local variables aren't read. */
-    // "noUnusedParameters": true,                       /* Raise an error when a function parameter isn't read. */
+    "noUnusedLocals": false,                             /* Enable error reporting when local variables aren't read. */
+    "noUnusedParameters": false,                         /* Raise an error when a function parameter isn't read. */
     // "exactOptionalPropertyTypes": true,               /* Interpret optional property types as written, rather than adding 'undefined'. */
     // "noImplicitReturns": true,                        /* Enable error reporting for codepaths that do not explicitly return in a function. */
     // "noFallthroughCasesInSwitch": true,               /* Enable error reporting for fallthrough cases in switch statements. */
@@ -121,6 +122,17 @@
   },
   "include": [
     "src",
-    "src/global.d.ts"
-, "vite.config.ts"  ]
+    "src/global.d.ts",
+    "vite.config.ts",
+    "vitest.config.ts",
+    "vitest.minimal.config.ts",
+    "playwright.config.ts",
+    "tailwind.config.js",
+    "postcss.config.js"
+  ],
+  "exclude": [
+    "dist",
+    "node_modules",
+    "public"
+  ]
 }