haeaeae/duplicati
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2761 from warwickmm/refactor/simplify_duplicate_file_check

Browse Source 
Use simpler data structures when detecting duplicate filenames
This commit is contained in:
Kenneth Skovhede
2017-09-26 15:42:46 +02:00
committed by GitHub
parent a3270e4323 d2adde730a
commit 436dd7f017
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Duplicati/Library/Main/Operation/FilelistProcessor.cs
+5 -7
View File
@@ -101,19 +101,17 @@ namespace Duplicati.Library.Main.Operation
throw new Duplicati.Library.Interface.UserInformationException(s);
}
var lookup = new Dictionary<string, string>();
var doubles = new Dictionary<string, string>();
var lookup = new HashSet<string>();
var doubles = new HashSet<string>();
foreach(var v in tp.ParsedVolumes)
{
if (lookup.ContainsKey(v.File.Name))
doubles[v.File.Name] = null;
else
lookup[v.File.Name] = null;
if (!lookup.Add(v.File.Name))
doubles.Add(v.File.Name);
}
if (doubles.Count > 0)
{
var s = string.Format("Found remote files reported as duplicates, either the backend module is broken or you need to manually remove the extra copies.\nThe following files were found multiple times: {0}", string.Join(", ", doubles.Keys));
var s = string.Format("Found remote files reported as duplicates, either the backend module is broken or you need to manually remove the extra copies.\nThe following files were found multiple times: {0}", string.Join(", ", doubles));
log.AddError(s, null);
throw new Duplicati.Library.Interface.UserInformationException(s);
}