haeaeae/duplicati
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #4611 from samuel-w/delay

Browse Source 
Use explicit waits to avoid race conditions in UI tests.
This commit is contained in:
warwickmm
2021-09-25 13:01:49 -07:00
committed by GitHub
parent 8cc9866fb3 5da43d89cf
commit 47cbe2d3be
1 changed files with 46 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
guiTests/guiTest.py
+46 -57
View File
@@ -33,8 +33,8 @@ else:
profile = webdriver.FirefoxProfile()
profile.set_preference("intl.accept_languages", "en")
options = Options()
options.set_headless(headless=True)
driver = webdriver.Firefox(profile, firefox_options=options)
options.headless = True
driver = webdriver.Firefox(profile, options=options)
def write_random_file(size, filename):
@@ -76,7 +76,9 @@ def sha1_folder(folder):
def wait_for_text(time, xpath, text):
WebDriverWait(driver, time).until(expected_conditions.text_to_be_present_in_element((By.XPATH, xpath), text))
def wait_for_load(time, by, target):
return WebDriverWait(driver, time).until(expected_conditions.presence_of_element_located((by, target)))
BACKUP_NAME = "BackupName"
PASSWORD = "the_backup_password_is_really_long_and_safe"
SOURCE_FOLDER = os.path.abspath("duplicati_gui_test_source")
@@ -101,67 +103,58 @@ write_random_file(100 * 1024, SOURCE_FOLDER + os.sep + "subfolder" + os.sep + "1
sha1_source = sha1_folder(SOURCE_FOLDER)
# Dismiss the password request
time.sleep(1)
driver.find_element_by_link_text("No, my machine has only a single account").click()
wait_for_load(10, By.LINK_TEXT, "No, my machine has only a single account").click()
# Add new backup
time.sleep(1)
driver.find_element_by_link_text("Add backup").click()
wait_for_load(10, By.LINK_TEXT, "Add backup").click()
# Choose the "add new" option
time.sleep(1)
driver.find_element_by_id("blank").click()
driver.find_element_by_xpath("//input[@class='submit next']").click()
wait_for_load(10, By.ID, "blank").click()
wait_for_load(10, By.XPATH, "//input[@class='submit next']").click()
# Add new backup - General page
time.sleep(1)
driver.find_element_by_id("name").send_keys(BACKUP_NAME)
driver.find_element_by_id("passphrase").send_keys(PASSWORD)
driver.find_element_by_id("repeat-passphrase").send_keys(PASSWORD)
driver.find_element_by_id("nextStep1").click()
wait_for_load(10, By.ID, "name").send_keys(BACKUP_NAME)
wait_for_load(10, By.ID, "passphrase").send_keys(PASSWORD)
wait_for_load(10, By.ID, "repeat-passphrase").send_keys(PASSWORD)
wait_for_load(10, By.ID, "nextStep1").click()
# Add new backup - Destination page
time.sleep(1)
driver.find_element_by_link_text("Manually type path").click()
driver.find_element_by_id("file_path").send_keys(DESTINATION_FOLDER)
driver.find_element_by_id("nextStep2").click()
wait_for_load(10, By.LINK_TEXT, "Manually type path").click()
wait_for_load(10, By.ID, "file_path").send_keys(DESTINATION_FOLDER)
wait_for_load(10, By.ID, "nextStep2").click()
# Add new backup - Source Data page
time.sleep(1)
driver.find_element_by_id("sourcePath").send_keys(os.path.abspath(SOURCE_FOLDER) + os.sep)
driver.find_element_by_id("sourceFolderPathAdd").click()
driver.find_element_by_id("nextStep3").click()
wait_for_load(10, By.ID, "sourcePath").send_keys(os.path.abspath(SOURCE_FOLDER) + os.sep)
wait_for_load(10, By.ID, "sourceFolderPathAdd").click()
wait_for_load(10, By.ID, "nextStep3").click()
# Add new backup - Schedule page
time.sleep(1)
useScheduleRun = driver.find_element_by_id("useScheduleRun")
useScheduleRun = wait_for_load(10, By.ID, "useScheduleRun")
if useScheduleRun.is_selected():
useScheduleRun.click()
driver.find_element_by_id("nextStep4").click()
wait_for_load(10, By.ID, "nextStep4").click()
# Add new backup - Options page
time.sleep(1)
driver.find_element_by_id("save").click()
wait_for_load(10, By.ID, "save").click()
# Run the backup job and wait for finish
time.sleep(1)
driver.find_element_by_link_text(BACKUP_NAME).click()
wait_for_load(10, By.LINK_TEXT, BACKUP_NAME).click()
[n for n in driver.find_elements_by_xpath("//dl[@class='taskmenu']/dd/p/span[contains(text(),'Run now')]") if n.is_displayed()][0].click()
wait_for_text(60, "//div[@class='task ng-scope']/dl[2]/dd[1]", "(took ")
# Restore
if len([n for n in driver.find_elements_by_xpath(u"//span[contains(text(),'Restore files \u2026')]") if n.is_displayed()]) == 0:
driver.find_element_by_link_text(BACKUP_NAME).click()
wait_for_load(10, By.LINK_TEXT, BACKUP_NAME).click()
[n for n in driver.find_elements_by_xpath(u"//span[contains(text(),'Restore files \u2026')]") if n.is_displayed()][0].click()
driver.find_element_by_xpath("//span[contains(text(),'" + SOURCE_FOLDER + "')]") # wait for filelist
time.sleep(1)
driver.find_element_by_xpath("//restore-file-picker/ul/li/div/a[2]").click() # select root folder checkbox
wait_for_load(10, By.XPATH, "//span[contains(text(),'" + SOURCE_FOLDER + "')]") # wait for filelist
time.sleep(1) # Delay so page has time to load
wait_for_load(10, By.XPATH, "//restore-file-picker/ul/li/div/a[2]").click() # select root folder checkbox
driver.find_element_by_xpath("//form[@id='restore']/div[1]/div[@class='buttons']/a/span[contains(text(), 'Continue')]").click()
driver.find_element_by_id("restoretonewpath").click()
driver.find_element_by_id("restore_path").send_keys(RESTORE_FOLDER)
driver.find_element_by_xpath("//form[@id='restore']/div/div[@class='buttons']/a/span[contains(text(),'Restore')]").click()
wait_for_load(10, By.XPATH, "//form[@id='restore']/div[1]/div[@class='buttons']/a/span[contains(text(), 'Continue')]").click()
wait_for_load(10, By.ID, "restoretonewpath").click()
wait_for_load(10, By.ID, "restore_path").send_keys(RESTORE_FOLDER)
wait_for_load(10, By.XPATH, "//form[@id='restore']/div/div[@class='buttons']/a/span[contains(text(),'Restore')]").click()
# wait for restore to finish
wait_for_text(60, "//form[@id='restore']/div[3]/h3/div[1]", "Your files and folders have been restored successfully.")
@@ -177,30 +170,26 @@ if os.path.exists(RESTORE_FOLDER):
os.rename(DESTINATION_FOLDER, DESTINATION_FOLDER_DIRECT_RESTORE)
# direct restore
time.sleep(1)
driver.find_element_by_link_text("Restore").click()
wait_for_load(10, By.LINK_TEXT, "Restore").click()
# Choose the "restore direct" option
time.sleep(1)
driver.find_element_by_id("direct").click()
driver.find_element_by_xpath("//input[@class='submit next']").click()
wait_for_load(10, By.ID, "direct").click()
wait_for_load(10, By.XPATH, "//input[@class='submit next']").click()
time.sleep(1)
driver.find_element_by_link_text("Manually type path").click()
driver.find_element_by_id("file_path").send_keys(DESTINATION_FOLDER_DIRECT_RESTORE)
driver.find_element_by_id("nextStep1").click()
wait_for_load(10, By.LINK_TEXT, "Manually type path").click()
wait_for_load(10, By.ID, "file_path").send_keys(DESTINATION_FOLDER_DIRECT_RESTORE)
wait_for_load(10, By.ID, "nextStep1").click()
driver.find_element_by_id("password").send_keys(PASSWORD)
driver.find_element_by_id("connect").click()
driver.find_element_by_xpath("//span[contains(text(),'" + SOURCE_FOLDER + "')]") # wait for filelist
time.sleep(1)
driver.find_element_by_xpath("//restore-file-picker/ul/li/div/a[2]").click() # select root folder checkbox
time.sleep(1)
driver.find_element_by_xpath("//form[@id='restore']/div[1]/div[@class='buttons']/a/span[contains(text(), 'Continue')]").click()
wait_for_load(10, By.ID, "password").send_keys(PASSWORD)
wait_for_load(10, By.ID, "connect").click()
wait_for_load(10, By.XPATH, "//span[contains(text(),'" + SOURCE_FOLDER + "')]") # wait for filelist
time.sleep(1) # Delay so page has time to load
wait_for_load(10, By.XPATH, "//restore-file-picker/ul/li/div/a[2]").click() # select root folder checkbox
wait_for_load(10, By.XPATH, "//form[@id='restore']/div[1]/div[@class='buttons']/a/span[contains(text(), 'Continue')]").click()
driver.find_element_by_id("restoretonewpath").click()
driver.find_element_by_id("restore_path").send_keys(DIRECT_RESTORE_FOLDER)
driver.find_element_by_xpath("//form[@id='restore']/div/div[@class='buttons']/a/span[contains(text(),'Restore')]").click()
wait_for_load(10, By.ID, "restoretonewpath").click()
wait_for_load(10, By.ID, "restore_path").send_keys(DIRECT_RESTORE_FOLDER)
wait_for_load(10, By.XPATH, "//form[@id='restore']/div/div[@class='buttons']/a/span[contains(text(),'Restore')]").click()
# wait for restore to finish
wait_for_text(60, "//form[@id='restore']/div[3]/h3/div[1]", "Your files and folders have been restored successfully.")