haeaeae/duplicati
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Dispose of manually enumerated enumerator.

Browse Source 
The IEnumerator<T> interface implements IDisposable, so the enumerator
should be disposed of after its use.
This commit is contained in:
Kenneth Hsu
2019-03-11 21:15:00 -07:00
parent 356ca81d8b
commit e57c714ee8
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Duplicati/Library/Main/Volumes/FilesetVolumeWriter.cs
+9 -7
View File
@@ -35,15 +35,17 @@ namespace Duplicati.Library.Main.Volumes
if (metablocklisthashes != null)
{
//Slightly akward, but we avoid writing if there are no entries
var en = metablocklisthashes.GetEnumerator();
if (en.MoveNext() && !string.IsNullOrEmpty(en.Current))
using (var en = metablocklisthashes.GetEnumerator())
{
m_writer.WritePropertyName("metablocklists");
m_writer.WriteStartArray();
m_writer.WriteValue(en.Current);
while (en.MoveNext())
if (en.MoveNext() && !string.IsNullOrEmpty(en.Current))
{
m_writer.WritePropertyName("metablocklists");
m_writer.WriteStartArray();
m_writer.WriteValue(en.Current);
m_writer.WriteEndArray();
while (en.MoveNext())
m_writer.WriteValue(en.Current);
m_writer.WriteEndArray();
}
}
}
else if (!string.IsNullOrWhiteSpace(metablockhash))