haeaeae/duplicati
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,798 Commits 140 Branches 416 Tags
242a1bd2272f8d8b9bc069b6028ea52e9b59bfd5
Commit Graph
5798 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Rune HenriksenandGitHub 242a1bd227 Merge pull request #3402 from warwickmm/constructor_virtual_members 
Avoid referencing virtual members in MicrosoftGraphBackend constructor
 2018-10-04 00:08:51 +02:00
Kenneth Hsu e2bc85c7e4 Merge remote-tracking branch 'upstream/master' into constructor_virtual_members 
Resolved Conflicts:
	Duplicati/Library/Backend/OneDrive/MicrosoftGraphBackend.cs
 2018-10-01 17:15:58 -07:00
Rune HenriksenandGitHub b9efd3a3a7 Merge pull request #3400 from warwickmm/fix_potential_null_reference 
Check for null reference before accessing property
 2018-10-01 23:20:24 +02:00
Rune HenriksenandGitHub 5f4236cbc2 Merge pull request #3399 from duplicati/remove_unused_variables_assignments 
Remove unused variables, fields, and unnecessary assignments
 2018-10-01 23:19:37 +02:00
Rune HenriksenandGitHub 38fe97b7f4 Merge pull request #3398 from duplicati/avoid_hiding_property 
Rename local variable to avoid hiding class field
 2018-10-01 23:16:31 +02:00
Kenneth Hsu 024bc5bea2 Mark immutable field as readonly. 2018-09-30 15:45:42 -07:00
Kenneth Hsu ee14862db5 Add comment to clarify use of Lazy. 2018-09-30 15:06:55 -07:00
Kenneth Hsu f59607d94d Rename property. 2018-09-30 15:06:55 -07:00
Kenneth Hsu f9022fec66 Avoid referencing virtual members in constructor. 
Since the call to GetRootPathFromUrl may be expensive, we cache the
value using a lazy initializer.
 2018-09-30 15:06:49 -07:00
Kenneth Hsu 7cf830cad7 Provide protocol key to MicrosoftGraphBackend constructor. 
This will help us avoid referencing virtual members in the constructor.
 2018-09-30 10:59:26 -07:00
Kenneth Hsu 6215fe1ac5 Extract string to private constant. 
This will allow us to provide the string as a parameter to the parent
class constructor to avoid referencing virtual members in the
constructor.
 2018-09-30 10:56:59 -07:00
Kenneth Hsu cd538de4b9 Check for null reference before accessing property. 2018-09-29 16:49:05 -07:00
Kenneth Hsu 11689159eb Disable warning about unreferenced field. 
This field is unreferenced, but we might now want the object to be
disposed of by the garbage collector.
 2018-09-29 13:38:11 -07:00
Kenneth Hsu 81875adcfb Restore removed reference to system settings context. 
This initializes some state and is IDisposable, so it is not so trivial
to remove.
 2018-09-29 13:20:16 -07:00
Kenneth Hsu 183ae4ede2 Remove additional unused variables. 2018-09-29 12:49:22 -07:00
Kenneth Hsu 8902da39f2 Undo removal of method parameters. 
This should be done on a separate branch for a different pull request.
 2018-09-29 10:44:05 -07:00
Kenneth Hsu 40f3e33835 Suppress warning about non-awaited task. 2018-09-29 10:44:05 -07:00
Kenneth Hsu 93304f0506 Add comment regarding removed code. 2018-09-29 10:44:05 -07:00
Kenneth Hsu 9ce1e807c7 Remove unused variables and fields. 2018-09-29 10:41:27 -07:00
Kenneth Hsu 44b7c29489 Rename local variable to avoid hiding class field. 2018-09-28 20:57:44 -07:00
Kenneth Hsu f4f676a1de Remove unnecessary variable assignment. 
These variables are assigned values that are never read by any
subsequent instruction.
 2018-09-28 20:13:45 -07:00
Kenneth SkovhedeandGitHub 7330aebaeb Merge pull request #3394 from warwickmm/remove_unnecessary_indirection 
Use built-in method to expand environment variables
 2018-09-28 22:25:46 +02:00
Kenneth SkovhedeandGitHub 0ec49d3a87 Merge pull request #3393 from warwickmm/fix_append_dir_separator 
Fix behavior of AppendDirSeparator utility method
 2018-09-28 22:24:11 +02:00
Kenneth SkovhedeandGitHub f24bce8e14 Merge pull request #3392 from warwickmm/simplify_method_resolution 
Simplify method resolution by removing default parameters
 2018-09-28 22:21:29 +02:00
Kenneth SkovhedeandGitHub 772d15bfd7 Merge pull request #3390 from warwickmm/configure_await_false 
Allow tasks to complete on any thread when context is irrelevant
 2018-09-28 22:15:51 +02:00
Kenneth Hsu d4692e2d35 Use built-in method to expand environment variables. 
After we removed the tilde expansion in revision c9aa6cf5fb ("Avoid
performing tilde expansion"), the Utility.ExpandEnvironmentVariables
method simply called System.Environment.ExpandEnvironmentVariables.  We
can simplify the code by just referencing the built-in method directly.
 2018-09-22 19:59:46 -07:00
Kenneth Hsu d4d1945faf Use utility method to append trailing slash. 
This removes some duplicated code.
 2018-09-22 10:19:45 -07:00
Kenneth Hsu 2d397745d0 Add unit test for utility that appends path separator. 2018-09-22 10:19:45 -07:00
Kenneth Hsu a325a8e0e7 Fix XML documentation to more accurately reflect behavior. 2018-09-22 10:19:45 -07:00
Kenneth Hsu 67871a76ed Fix bug. Append separator when string ends with same separator. 
Previously, the replacement would occur if the provided string did not
end with the platform-dependent directory separator.  However, this
utility method is often used to append a trailing slash to URL
specifiers.
 2018-09-22 10:19:45 -07:00
Kenneth Hsu 18aae7a5c4 Simplify method resolution by removing default parameters. 
The previous implementations resulted in an overload being hidden by one
without a default parameter, making it unclear which method was being
called.  For example, consider the following signatures:

public MultipartItem(string content, string contenttype = null, string name = null, string filename = null)
public MultipartItem(string contenttype, string name = null, string filename = null)

From https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/named-and-optional-arguments,

> If two candidates are judged to be equally good, preference goes to a
> candidate that does not have optional parameters for which arguments
> were omitted in the call. This is a consequence of a general preference
> in overload resolution for candidates that have fewer parameters.
 2018-09-20 19:30:49 -07:00
Rune HenriksenandGitHub 0901d3f62f Merge pull request #3387 from warwickmm/ordinal_case_insensitive_comparison 
Use ordinal case-insensitive comparison instead of ToLower and ToUpper
 2018-09-20 23:33:21 +02:00
Rune HenriksenandGitHub bb60050639 Merge pull request #3388 from warwickmm/remove_string_formatting 
Remove unnecessary call to String.Format
 2018-09-20 23:30:22 +02:00
Rune HenriksenandGitHub 840031b358 Merge pull request #3389 from warwickmm/use_local_variable 
Use existing local variable to improve readability
 2018-09-20 23:29:45 +02:00
Kenneth Hsu 1c8bb276b4 Allow tasks to complete on any thread when context is irrelevant. 
When the code following the await can be executed on any thread, it's
recommended to use ConfigureAwait(false) to avoid unnecessary context
switching and potential deadlocks.
 2018-09-19 16:57:17 -07:00
Kenneth Hsu df5f8e16b9 Use ordinal case-insensitive comparison instead of ToUpper. 2018-09-19 15:21:59 -07:00
Kenneth Hsu 0d23302220 Use ordinal case-insensitive comparison instead of ToLower. 2018-09-19 15:21:59 -07:00
Kenneth Hsu 25e2b40384 Use existing local variable to improve readability. 2018-09-18 21:52:31 -07:00
Kenneth Hsu 588363d6fb Remove unnecessary call to String.Format. 2018-09-18 21:37:12 -07:00
Kenneth SkovhedeandGitHub 2228cd7642 Merge pull request #3378 from dgehri/feature/PathTooLongException 
refs ##3311 : fix for PathTooLongException
 2018-09-15 00:29:56 +02:00
Kenneth SkovhedeandGitHub 5b98c4c8aa Merge pull request #3377 from dgehri/master 
refs #3372: tentative fix for FailedToUseChangeJournal
 2018-09-15 00:29:05 +02:00
Kenneth SkovhedeandGitHub b27e18cca1 Merge pull request #3380 from jkellerer/fix-linux-snapshot-is-block-device 
Fixed #3373 - LVM: Backup failure on removed files
 2018-09-15 00:27:59 +02:00
Kenneth SkovhedeandGitHub 01c3e52f68 Merge pull request #3368 from LacunaSoftware/progressBar 
Fix progress bar not updating size and number of files processed
 2018-09-15 00:27:05 +02:00
jkellererandjuergen kellerer fde179c2a2 Fixed #3373 - LVM: Backup failure on removed files 
Fixes a problem in IsBlockDevice(localPath) which throws an exception when a path that exists in the snapshot is removed from the disk during the backup.
 2018-09-14 12:00:20 +02:00
Daniel Gehriger a4f513710f refs ##3311 : fix for PathTooLongException 2018-09-12 22:02:33 +02:00
Daniel Gehriger 8ae700c05e refs ##3311 : fix for PathTooLongException 2018-09-12 21:59:54 +02:00
Daniel Gehriger a160ef305d refs #3372: tentative fix for FailedToUseChangeJournal: Failed to compare two elements in the array 2018-09-12 21:51:54 +02:00
Mikael MelloandGitHub 072f98ffe8 Fix wrong file size being added to the total 2018-09-08 11:21:46 -03:00
Kenneth Skovhede b4a031f6a8 Added consistency check to the test/verify command 2018-09-08 11:54:29 +02:00
Kenneth SkovhedeandGitHub 7a7924b14c Merge pull request #3365 from LacunaSoftware/localization-fix 
[FIX] Localizations that have a sub-code are not loaded
 2018-09-07 08:45:00 +02:00