Kenneth Hsu
1605dc8ede
Use utility method to read from stream.
2018-06-06 19:54:45 -07:00
Kenneth Skovhede
b534c5649e
Fixed a shared buffer being re-used for multiple results.
2018-06-06 08:37:09 +02:00
Kenneth Hsu
214e4c0428
Add test for reading stream into buffer.
2018-06-04 20:35:22 -07:00
Kenneth Hsu
08a897d7b0
Remove redundant calls to ToString.
2018-06-04 20:15:34 -07:00
Tyler Gill
5be38df560
Fix typo in OAuthHttpClient
2018-06-04 14:59:58 -06:00
verhoek
3ab394ed7d
Adjust according to review comments - prevent creating tempfolder when not needed.
...
Moved out one of multiple responsibilities out of function.
2018-06-04 18:03:24 +02:00
Kenneth Skovhede
d042e70ca2
Changed the returned IEnumerable values to be fully created, which avoids issues with locks and transactions being prematurely released.
...
This might help with #3202
2018-06-04 11:56:54 +02:00
Kenneth Skovhede
e6535e2cfa
Merge branch 'master' of github.com:duplicati/duplicati
...
# Conflicts:
# Duplicati/Server/WebServer/RESTMethods/UISettings.cs
2018-06-04 10:48:11 +02:00
Kenneth Skovhede
8da3f61346
Merge branch 'warwickmm-fix_line_endings'
2018-06-04 10:45:44 +02:00
Kenneth Skovhede and GitHub
b6a250db95
Merge pull request #3253 from warwickmm/missing_format_item_value
...
Provide missing values to format items
2018-06-04 10:42:34 +02:00
Kenneth Skovhede and GitHub
448d37f7cb
Merge pull request #3252 from warwickmm/remove_string_format
...
Remove unnecessary calls to String.Format
2018-06-04 10:42:02 +02:00
Kenneth Skovhede and GitHub
66e5dfe722
Merge pull request #3237 from tygill/fix/msgraph-delete-error
...
(MS Graph) When the delete operation fails due to a 'file not found' error, we don't need to bubble up an exception
2018-06-04 10:41:16 +02:00
Kenneth Skovhede and GitHub
3b6c2b61d5
Merge pull request #3242 from warwickmm/remove_ineffective_statements
...
Remove ineffective statements
2018-06-04 10:40:32 +02:00
verhoek
fe8ccfbab3
Added createfolder unit test for googledrive.
2018-06-03 19:52:22 +02:00
verhoek
40b83fe2dc
Moved out AboutInfoUrl and CreateFolderUrl.
2018-06-03 19:46:54 +02:00
Tyler Gill
f2f5d4c0a6
Change from swallowing delete errors to wrapping DriveItemNotFoundException in FileMissingException.
...
This way, the regular backend manager logic can handle and log the delete of a non-existant file.
Also update some of the other operations to throw FileMissingException (rather than the backend specific DriveItemNotFoundException).
2018-06-02 15:52:20 -06:00
Kenneth Hsu
afdae80716
Fix line ending issues.
2018-06-02 13:19:49 -07:00
Kenneth Hsu
e2b671bf9e
Provide missing values to format items.
2018-06-02 12:05:57 -07:00
Kenneth Hsu
20f2f37806
Remove unnecessary calls to String.Format.
2018-06-02 12:02:55 -07:00
Kenneth Skovhede and GitHub
e70f15287e
Merge pull request #3233 from warwickmm/make_fields_readonly
...
Mark fields that shouldn't be reassigned as readonly
2018-06-02 10:13:06 +02:00
Kenneth Skovhede and GitHub
018c01cfa9
Merge pull request #3234 from warwickmm/equals_instead_of_equality
...
Use Equals to compare CultureInfo instances
2018-06-02 10:10:59 +02:00
Kenneth Skovhede and GitHub
b2f1862584
Merge pull request #3238 from tygill/fix/help-logging
...
Update 'help logging' to mention --log-file-log-level and --console-log-level rather than the older --log-level
2018-06-02 10:10:32 +02:00
Kenneth Skovhede and GitHub
f8ef261f50
Merge pull request #3243 from warwickmm/remove_redundant_expression
...
Remove redundant expression
2018-06-02 10:08:29 +02:00
verhoek
c063fde018
Moved ListUrl, PutUrl and DeleteUrl to WebApi.
2018-06-01 16:21:28 +02:00
verhoek
83679c0f12
Moved Rename and Get Url to Google WebAPI.
2018-05-30 08:22:00 +02:00
verhoek
3691d6dfdf
Initiated basic unit tests to ensure correct url helper functions.
2018-05-29 22:13:09 +02:00
verhoek
1ba8814d76
Started moving url specific construction to webapi.
2018-05-28 08:29:23 +02:00
verhoek
4a0d6a2f5b
Inline var declaration.
2018-05-27 13:12:59 +02:00
verhoek
6287d369b1
Reverted accidental removing of static for SystemContextSettings.
2018-05-27 13:12:06 +02:00
verhoek
625db54f14
Throw proper exception. Removed unused imports.
2018-05-27 13:10:01 +02:00
verhoek
a9b88ab2ab
Return default settings in case no startcontext was previously called
...
by returning a null contextid.
2018-05-27 10:23:22 +02:00
verhoek
a108e328b6
Fix codacy issues.
2018-05-26 23:27:39 +02:00
verhoek
3fd6c3c602
Merge remote-tracking branch 'origin' into feature/tempdir
2018-05-26 22:55:29 +02:00
verhoek
e80f30f8a9
Added multiple context setting keys to callcontextsettings, exploiting
...
reflection. Contextsettings don't destroy each other anymore.
2018-05-26 21:56:15 +02:00
Kenneth Hsu
77443f61f6
Remove redundant expression.
2018-05-26 10:52:11 -07:00
Kenneth Hsu
bbe65f9dfb
Remove ineffective statements.
...
The removed code was introduced in revision ba58651e5a ("Fix for
CreateFolder with SSH"), presumably to fix an issue where some SSH
backends did not like the trailing slash when creating new folders.
However, since we are not using the output argument of the call to
Substring, these statements have no effect.
2018-05-26 10:36:50 -07:00
Kenneth Hsu
f12858e6a5
Mark fields that shouldn't be reassigned as readonly.
...
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
2018-05-25 10:04:52 -07:00
Kenneth Hsu
ee8788d08e
Use Equals to compare CultureInfo instances.
...
Since the Equals method is overridden in the CultureInfo class, we
should use it instead of the == operator to compare two instances.
2018-05-25 10:04:28 -07:00
Tyler Gill
f94a58d98c
Update 'help logging' to mention --log-file-log-level and --console-log-level rather than the older --log-level
2018-05-25 09:49:53 -06:00
Tyler Gill
8131e85581
(MS Graph) When the delete operation fails due to a 'file not found' error, we don't need to bubble up an exception.
2018-05-25 09:18:20 -06:00
Tyler Gill
8acc9ba5c9
Blocksets with a length of 0 are not broken if the block they reference by hash is not listed.
2018-05-24 15:22:05 -06:00
Kenneth Skovhede and GitHub
a7575d6bda
Merge pull request #3229 from verhoek/bugs/commandline
...
Bugfixes commandline
2018-05-24 11:28:40 +02:00
verhoek
d6171a76fd
Readded parameter file option aliases similar as in commandline.
2018-05-23 21:36:46 +02:00
verhoek
ea4302e45d
Rewrote parsing aliases of parameter file option in a loop.
2018-05-23 21:28:41 +02:00
verhoek
4972c9c865
Merge branch 'webapi/googlecloudstorage' of https://github.com/verhoek/duplicati into webapi/googlecloudstorage
2018-05-23 21:20:31 +02:00
verhoek
bbf5d71782
Merge branch 'master' into webapi/googlecloudstorage
2018-05-23 20:14:06 +02:00
verhoek
7556c3fa63
Merge branch 'master' into feature/tempdir
2018-05-23 20:13:48 +02:00
verhoek
b786da55a6
Adjusted display of help according to common standards,
...
show help on command appearing after "help" and not
on last.
2018-05-23 20:09:03 +02:00
verhoek
29eebaec5b
Rewrote parsing aliases of parameter file option in a loop.
2018-05-23 20:02:24 +02:00
verhoek
7450f498be
Revert "Removed weird mixed up if's."
...
This reverts commit 9f07a09621 .
2018-05-23 19:40:29 +02:00