Commit Graph
1925 Commits
Author SHA1 Message Date
Kenneth SkovhedeandGitHub 20877ce833 Merge pull request #2861 from jesjimher/added-dv-extension
Added dv extension
2017-11-06 20:48:14 +01:00
davegold24andGitHub 8ed6aac68b Spelling mistake loose changed to lose 2017-11-05 13:32:01 -05:00
Jesus JimenezandGitHub 6a30d27782 Added dv extension 2017-11-02 10:12:08 +01:00
Kenneth Skovhede 8bbe04f623 Fixed a case where entering an invalid value for the --number-of-retries or --retry-delay options would crash the uploader thread and bring down the server.
This fixes #2834
2017-10-30 16:12:44 +01:00
Kenneth Skovhede efc06b7210 Refactored the source path expansion/filtering into its own method.
Changed the check for subfolders to only work if the shortest path is a folder itself.
Changed the backup and test-filters method to use the same expansion logic so the filter test is more reliable.
This fixes #2778
2017-10-30 15:30:43 +01:00
Kenneth Hsu 3d51e9153b Avoid signing assemblies.
Using strong-named assemblies can cause difficulties with the GNU LGPL
license, which allows for one to recombine or relink their application
with modified versions of the code.  While one solution is to share the
private key so that people can sign the assemblies themselves, this
would break the trust that is expected from signed assemblies.  For now,
the easiest fix is to simply not sign the assemblies.  Note that by
doing so, we prevent the code from being referenced from other signed
assemblies.

This also fixes an issue introduced in revision ba94d36a80 ("Added
auto-update for WindowsService and Service."), where the WindowsService
project (signed) referenced the AutoUpdater project (not signed).

We also removed instances of <SignAssembly>false</SignAssembly> to be
consistent with newly created .csproj files that do not contain the
SignAssembly element.

This was motivated by the discussion in issue #2814.
2017-10-15 22:00:23 -07:00
Kenneth SkovhedeandGitHub 202a6641e5 Merge pull request #2818 from warwickmm/fix_out_of_range_arguments
Fix arguments to ArgumentOutOfRangeException constructor
2017-10-15 16:32:17 +02:00
Kenneth Hsu 8fdbbaa255 Avoid premature declaration of backup completion.
This addresses issue #2803.
2017-10-14 12:00:52 -07:00
Kenneth Hsu f95b5861f5 Fix parameter name in ArgumentOutOfRangeException. 2017-10-14 11:43:31 -07:00
Kenneth Hsu 07bfc4a5da Use nameof operator instead of string literal. 2017-10-14 11:43:31 -07:00
Kenneth Hsu 1846c67aae Rename variable to be consistent with exception message. 2017-10-13 19:28:06 -07:00
Kenneth Skovhede f03965eb65 Fixed compile error after refactor 2017-10-11 08:58:58 +02:00
Kenneth Skovhede 451c71ccb1 Changed remote-file delete logic to only delete files that look like Duplicati files and have the correct prefix.
This fixes #2678
2017-10-10 16:44:06 +02:00
Kenneth SkovhedeandGitHub b907aa607a Merge pull request #2802 from warwickmm/fix_line_endings
Fix line-ending characters
2017-10-10 13:43:37 +02:00
Kenneth Hsu 8bac875311 Fix line-ending characters. 2017-10-07 13:59:46 -07:00
Kenneth Hsu 604b6e4337 Dispose enumerators after manually iterating over elements.
Since the IEnumerator<T> interface implements IDisposable, we should
make sure to dispose of the enumerator when manually iterating over the
elements.
2017-10-07 12:27:11 -07:00
Kenneth SkovhedeandGitHub 38a8d11266 Merge pull request #2781 from TekkiWuff/retention-policy
Retention Policy
2017-10-04 15:12:19 +02:00
Kenneth SkovhedeandGitHub b4ef0e0f77 Merge pull request #2780 from warwickmm/feature/get_unique_items
Add method to get unique items and duplicates from collection
2017-10-04 14:56:41 +02:00
Kenneth SkovhedeandGitHub 1df44989d2 Update LocalListChangesDatabase.cs
Fixed issue with filters and ListCchanges / Compare
2017-10-03 11:08:43 +02:00
Daniel Radünz ed5daa60b5 Simplified code by removing one loop 2017-09-30 22:05:54 +02:00
Daniel Radünz 4e3d5d3e81 Fixed typo in option name 2017-09-30 22:05:54 +02:00
Daniel Radünz 28ad1e1bbd Better example in option description 2017-09-30 22:05:30 +02:00
Daniel Radünz 0a4a6edca1 Renamed all occurrences of "staggered version" to "retention policy" 2017-09-30 22:05:30 +02:00
Daniel Radünz 7b176e4dc2 Check validity of keep-staggered-versions option value 2017-09-30 22:05:30 +02:00
Daniel Radünz be19329d7f Compact if new the option is used 2017-09-30 22:05:29 +02:00
Daniel Radünz 04b7bf38c3 Reworded option description and added example 2017-09-30 22:05:29 +02:00
Daniel Radünz 40db42b29b Moved code related to deciding which backups to delete from Options into the DeleteHandler
Added logging
2017-09-30 22:05:29 +02:00
Daniel Radünz 3ec1fabc57 initial commit of staggered versioning feature 2017-09-30 12:07:02 +02:00
Kenneth Hsu 6abe087c18 Use helper method to get unique items and duplicates. 2017-09-28 21:55:15 -07:00
Kenneth Hsu 146f4aaa5b Use helper method to get unique items and duplicates. 2017-09-28 21:48:38 -07:00
Kenneth SkovhedeandGitHub 33314ce7c9 Merge pull request #2763 from tygill/fix/list-ienumerable
Change IBackend.List() to return IEnumerable instead of List
2017-09-28 11:06:41 +02:00
Kenneth SkovhedeandGitHub 1f0f73da6f Merge pull request #2772 from warwickmm/refactor/remove_string_format
Remove unnecessary call to String.Format
2017-09-28 11:00:02 +02:00
Kenneth SkovhedeandGitHub 3411d46474 Merge pull request #2773 from warwickmm/refactor/convert_if_to_switch
Convert if statements to switch statements for enums
2017-09-28 10:59:15 +02:00
Kenneth Skovhede 7ed1362e4c Merge branch 'master' into concurrent_processing
# Conflicts:
#	Duplicati/Library/Main/Operation/BackupHandler.cs
2017-09-27 09:58:29 +02:00
Kenneth Skovhede 3ceb1087a7 Merge branch 'master' of github.com:duplicati/duplicati 2017-09-27 09:55:49 +02:00
Kenneth Hsu 0738c5b624 Remove unnecessary call to String.Format. 2017-09-26 20:43:27 -07:00
Kenneth Hsu 79e0f69506 Convert if statement to switch statement.
When the comparison is performed on an enum, using a switch statement
can allow for additional compiler optimizations.
2017-09-26 20:20:14 -07:00
Kenneth Hsu 5da12a704d Convert if statement to switch statement.
When the comparison is performed on an enum, using a switch statement
can allow for additional compiler optimizations.
2017-09-26 20:13:40 -07:00
Kenneth Hsu c082b18389 Declare variable outside of if statement.
This will allow us to more easily convert the if statement to a switch
statement.
2017-09-26 20:10:19 -07:00
Kenneth Hsu 4edf8536da Remove unused argument in string formatting. 2017-09-26 19:56:29 -07:00
Kenneth Skovhede 37e42b718d Fix not shutting down backendmanager if it is required for something else.
This fixes #2759
2017-09-26 22:45:24 +02:00
Kenneth SkovhedeandGitHub 436dd7f017 Merge pull request #2761 from warwickmm/refactor/simplify_duplicate_file_check
Use simpler data structures when detecting duplicate filenames
2017-09-26 15:42:46 +02:00
Kenneth SkovhedeandGitHub a3270e4323 Merge pull request #2762 from warwickmm/improve_argument_exceptions
Improve construction of ArgumentExceptions
2017-09-26 15:42:07 +02:00
Kenneth Skovhede 9c0c5fbb97 Merge branch 'master' into concurrent_processing 2017-09-26 14:26:09 +02:00
Tyler Gill 44c53d3eb1 Merge branch 'master' of https://github.com/duplicati/duplicati into fix/list-ienumerable 2017-09-25 23:19:38 -06:00
Tyler Gill 38883285ee Change IBackend.List() to return IEnumerable instead of List
By changing to IEnumerable, it is possible to iterate only a portion of the list, which is useful when not all entries are needed (e.g., when testing a connection).
All existing backends have been updated, and any which were able to be changed to yield return results in a straightforward way now do.
Many backends had a try/catch in the List() method. Due to the fact that yield returns can't be placed within a try/catch block, these have been refactored to either scope the try/catch to the parts that (should) be the only places throwing exceptions, so that exceptions are still caught and handled.
Note that lazy evaluation may cause some changes in behavior - exceptions that were previously thrown at the point of invokation of List() may now be thrown while it is being enumerated.
I believe this will not be problematic though, as the only well-known exception seems to be FolderMissingException, which should be thrown by Test(), but TestList() attempts to enumerate the list to force this exception.
Any places that require the legacy behavior can get it by simply converting the lazy enumerable to a List()
2017-09-25 23:17:45 -06:00
Kenneth Hsu b84e7bd34d Avoid hard-coded parameter names.
This makes it easier to rename the parameter in the future as we don't
have to search for the parameter name within strings.
2017-09-25 19:54:54 -07:00
Kenneth Hsu e9ffc2cbe1 Add clearer exception message. 2017-09-25 19:54:54 -07:00
Tyler Gill b4f56750f8 Add IQuotaInfo interface
It also makes quota enabled backends return an instance of this interface instead of the quota components separately.
This way, getting quota stats requires only a single remote request on backends like Google Drive and OneDrive.
2017-09-24 17:30:52 -06:00
Kenneth Hsu d2adde730a Use simpler data structures to detect duplicate filenames.
A Dictionary is unnecessary since we don't have any key-value pairs.  We
just need to keep track of a unique collection of filenames.
2017-09-24 08:40:14 -07:00