haeaeae/duplicati
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,782 Commits 140 Branches 416 Tags
b73e94de7ee24c5261e14f29bcceecb39b519aa8
Commit Graph
8782 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kenneth Hsu 9374d6b208 Move comments and remove invalid XML tags. 
The comment was not placed before a valid language element.
 2018-10-13 20:52:30 -07:00
Kenneth Hsu 914b35e342 Escape characters in XML documentation. 2018-10-13 20:52:15 -07:00
Kenneth Hsu 6b8dc6e8b8 Rename parameter to match XML documentation. 
The use of camel case is also more consistent with the surrounding
style.
 2018-10-13 20:45:13 -07:00
Kenneth Hsu 22d5328e75 Remove extra XML documentation tag. 2018-10-13 20:43:38 -07:00
Kenneth Hsu 1d57ddd5a6 Flatten AggregateExceptions before referencing InnerException. 
The InnerException property of an AggregateException can be another
AggregateException.  By calling Flatten(), we remove inner
AggregateExceptions so that the InnerExceptions property contains all
the original exceptions.  The InnerException property is the first
element of InnerExceptions.
 2018-10-13 19:07:49 -07:00
Kenneth Hsu beb552fa9e Remove unnecessary use of partial keyword. 
These classes are defined in a single location.
 2018-10-13 16:53:28 -07:00
Rune HenriksenandGitHub 6550a69909 Merge pull request #3420 from warwickmm/remove_empty_methods_statements 
Remove unused empty methods and empty statements
 2018-10-11 22:54:52 +02:00
Rune HenriksenandGitHub 2165a52168 Merge pull request #3422 from LacunaSoftware/fix-httpinput-empty 
Fix error in POST requests with empty form
 2018-10-11 22:53:15 +02:00
Rune HenriksenandGitHub 681f4ee33b Merge pull request #3423 from LacunaSoftware/fix-logscope 
Revert hunk from 9ce1e80. Log redirect needs to be setup
 2018-10-11 22:51:39 +02:00
Mikael Mello c72d5ce236 Revert hunk from 9ce1e80. Log redirect needs to be setup 2018-10-11 11:09:06 -03:00
Mikael Mello 608e4e7972 Fix error when trying to add items to empty HttpForm (that is an empty HttpInput) 2018-10-11 09:30:28 -03:00
Kenneth Hsu 05d8fd425e Add comments to explain empty methods. 2018-10-10 21:28:00 -07:00
Kenneth Hsu 07c1d85b4a Remove empty statements. 2018-10-10 21:22:31 -07:00
Kenneth Hsu 731a8b1644 Remove unused empty methods. 2018-10-10 21:20:40 -07:00
Rune HenriksenandGitHub b4241f3096 Merge pull request #3417 from warwickmm/fix_default_value_comparison 
Constrain generic type to be a class to allow for null comparison
 2018-10-09 07:49:23 +02:00
Kenneth Hsu 8bb770964d Constrain generic type to be a class to allow for null comparison. 
The SendRequest method performs a comparison between an object of type T
and null.  While there are no use cases currently where the generic type
is a value type, we should constrain the generic type to be a class so
that the comparison remains meaningful.
 2018-10-08 19:13:23 -07:00
Kenneth Hsu 6c08f44394 Revert "Avoid potential comparison of value type with null." 
This reverts commit ecb670a2d9.

While there aren't any cases where the generic type is a struct, the
comparison with default(T) is incorrect.  If T is int, we wouldn't want
the behavior to differ based on whether the value was zero or nonzero.
 2018-10-08 18:54:36 -07:00
Rune HenriksenandGitHub aa1f99628c Merge pull request #3414 from warwickmm/avoid_value_null_comparison 
Avoid potential comparison of value type with null
 2018-10-07 22:35:25 +02:00
Rune HenriksenandGitHub fbab37d138 Merge pull request #3413 from warwickmm/avoid_null_reference 
Avoid potential null reference exception
 2018-10-07 19:14:34 +02:00
Rune HenriksenandGitHub 6b6faebea3 Merge pull request #3404 from lucascosti/server_stat_string_cleanup 
Fix server status strings grammar and consistency
 2018-10-07 19:13:22 +02:00
Rune HenriksenandGitHub 6c662a0d8b Merge pull request #3412 from mnaiman/normalize_path 
all drives letter uppercase
 2018-10-07 19:07:52 +02:00
Rune HenriksenandGitHub be7edb580d Merge pull request #3410 from warwickmm/simplify_enumerating_collections 
Simplify enumeration of collections
 2018-10-07 19:06:28 +02:00
Kenneth Hsu ecb670a2d9 Avoid potential comparison of value type with null. 
While there aren't currently any cases where the generic type is a value
type, this will make the code slightly more robust to future
implementations.
 2018-10-07 09:59:13 -07:00
Rune HenriksenandGitHub dc5a0dbc94 Merge pull request #3409 from warwickmm/remove_unused_parameters 
Remove unused method parameters
 2018-10-07 18:56:43 +02:00
Rune HenriksenandGitHub 9dac0c3b7b Merge pull request #3406 from Pectojin/upgrade_mega_api_client 
updated MegaApiClient from 1.6.0 to 1.6.3
 2018-10-07 18:56:15 +02:00
Max123456 73d7aaffdc Invariant Upper 2018-10-07 11:47:48 +02:00
Max123456 0c71f0af2c all drives letter uppercase 2018-10-07 11:32:25 +02:00
Kenneth Hsu b6e1e3e3f4 Avoid potential null reference exception. 2018-10-06 20:42:25 -07:00
Kenneth Hsu b824c86c7e Avoid unnecessary enumeration of collections. 
This improves performance by using Any() to avoid unnecessary
enumeration of collections.
 2018-10-06 16:20:18 -07:00
Kenneth Hsu 0c1ac9c489 Replace chained LINQ calls with call to overload with predicate. 
This simplifies the code by reducing the number of enumerators created
while also making the code slightly more readable.
 2018-10-06 16:20:18 -07:00
Kenneth Hsu d72128ec83 Remove unused method parameters. 2018-10-06 15:09:43 -07:00
Rune Henriksen 306ccabfef updated MegaApiClient from 1.6.0 to 1.6.3 2018-10-04 00:34:49 +02:00
Rune HenriksenandGitHub 439e319061 Merge pull request #3391 from sffetlio/description_field 
Add Description field to backups
 2018-10-04 00:13:05 +02:00
Rune HenriksenandGitHub 242a1bd227 Merge pull request #3402 from warwickmm/constructor_virtual_members 
Avoid referencing virtual members in MicrosoftGraphBackend constructor
 2018-10-04 00:08:51 +02:00
Lucas Costi 1be80fde3e Fix server status strings grammar and consistency 2018-10-02 17:37:17 +10:00
Kenneth Hsu e2bc85c7e4 Merge remote-tracking branch 'upstream/master' into constructor_virtual_members 
Resolved Conflicts:
	Duplicati/Library/Backend/OneDrive/MicrosoftGraphBackend.cs
 2018-10-01 17:15:58 -07:00
Rune HenriksenandGitHub b9efd3a3a7 Merge pull request #3400 from warwickmm/fix_potential_null_reference 
Check for null reference before accessing property
 2018-10-01 23:20:24 +02:00
Rune HenriksenandGitHub 5f4236cbc2 Merge pull request #3399 from duplicati/remove_unused_variables_assignments 
Remove unused variables, fields, and unnecessary assignments
 2018-10-01 23:19:37 +02:00
Rune HenriksenandGitHub 38fe97b7f4 Merge pull request #3398 from duplicati/avoid_hiding_property 
Rename local variable to avoid hiding class field
 2018-10-01 23:16:31 +02:00
sffetlio e933d806b4 Fix schema version 2018-10-01 11:52:16 +03:00
Kenneth Hsu 024bc5bea2 Mark immutable field as readonly. 2018-09-30 15:45:42 -07:00
Kenneth Hsu ee14862db5 Add comment to clarify use of Lazy. 2018-09-30 15:06:55 -07:00
Kenneth Hsu f59607d94d Rename property. 2018-09-30 15:06:55 -07:00
Kenneth Hsu f9022fec66 Avoid referencing virtual members in constructor. 
Since the call to GetRootPathFromUrl may be expensive, we cache the
value using a lazy initializer.
 2018-09-30 15:06:49 -07:00
Kenneth Hsu 7cf830cad7 Provide protocol key to MicrosoftGraphBackend constructor. 
This will help us avoid referencing virtual members in the constructor.
 2018-09-30 10:59:26 -07:00
Kenneth Hsu 6215fe1ac5 Extract string to private constant. 
This will allow us to provide the string as a parameter to the parent
class constructor to avoid referencing virtual members in the
constructor.
 2018-09-30 10:56:59 -07:00
Kenneth Hsu cd538de4b9 Check for null reference before accessing property. 2018-09-29 16:49:05 -07:00
Kenneth Hsu 11689159eb Disable warning about unreferenced field. 
This field is unreferenced, but we might now want the object to be
disposed of by the garbage collector.
 2018-09-29 13:38:11 -07:00
Kenneth Hsu 81875adcfb Restore removed reference to system settings context. 
This initializes some state and is IDisposable, so it is not so trivial
to remove.
 2018-09-29 13:20:16 -07:00
Kenneth Hsu 183ae4ede2 Remove additional unused variables. 2018-09-29 12:49:22 -07:00