Kenneth Hsu
8902da39f2
Undo removal of method parameters.
...
This should be done on a separate branch for a different pull request.
2018-09-29 10:44:05 -07:00
Kenneth Hsu
40f3e33835
Suppress warning about non-awaited task.
2018-09-29 10:44:05 -07:00
Kenneth Hsu
93304f0506
Add comment regarding removed code.
2018-09-29 10:44:05 -07:00
Kenneth Hsu
9ce1e807c7
Remove unused variables and fields.
2018-09-29 10:41:27 -07:00
Kenneth Hsu
44b7c29489
Rename local variable to avoid hiding class field.
2018-09-28 20:57:44 -07:00
Kenneth Hsu
f4f676a1de
Remove unnecessary variable assignment.
...
These variables are assigned values that are never read by any
subsequent instruction.
2018-09-28 20:13:45 -07:00
Kenneth Skovhede and GitHub
7330aebaeb
Merge pull request #3394 from warwickmm/remove_unnecessary_indirection
...
Use built-in method to expand environment variables
2018-09-28 22:25:46 +02:00
Kenneth Skovhede and GitHub
0ec49d3a87
Merge pull request #3393 from warwickmm/fix_append_dir_separator
...
Fix behavior of AppendDirSeparator utility method
2018-09-28 22:24:11 +02:00
Kenneth Skovhede and GitHub
f24bce8e14
Merge pull request #3392 from warwickmm/simplify_method_resolution
...
Simplify method resolution by removing default parameters
2018-09-28 22:21:29 +02:00
Kenneth Skovhede and GitHub
772d15bfd7
Merge pull request #3390 from warwickmm/configure_await_false
...
Allow tasks to complete on any thread when context is irrelevant
2018-09-28 22:15:51 +02:00
Kenneth Hsu
d4692e2d35
Use built-in method to expand environment variables.
...
After we removed the tilde expansion in revision c9aa6cf5fb ("Avoid
performing tilde expansion"), the Utility.ExpandEnvironmentVariables
method simply called System.Environment.ExpandEnvironmentVariables. We
can simplify the code by just referencing the built-in method directly.
2018-09-22 19:59:46 -07:00
Kenneth Hsu
d4d1945faf
Use utility method to append trailing slash.
...
This removes some duplicated code.
2018-09-22 10:19:45 -07:00
Kenneth Hsu
2d397745d0
Add unit test for utility that appends path separator.
2018-09-22 10:19:45 -07:00
Kenneth Hsu
a325a8e0e7
Fix XML documentation to more accurately reflect behavior.
2018-09-22 10:19:45 -07:00
Kenneth Hsu
67871a76ed
Fix bug. Append separator when string ends with same separator.
...
Previously, the replacement would occur if the provided string did not
end with the platform-dependent directory separator. However, this
utility method is often used to append a trailing slash to URL
specifiers.
2018-09-22 10:19:45 -07:00
Kenneth Hsu
18aae7a5c4
Simplify method resolution by removing default parameters.
...
The previous implementations resulted in an overload being hidden by one
without a default parameter, making it unclear which method was being
called. For example, consider the following signatures:
public MultipartItem(string content, string contenttype = null, string name = null, string filename = null)
public MultipartItem(string contenttype, string name = null, string filename = null)
From https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/named-and-optional-arguments ,
> If two candidates are judged to be equally good, preference goes to a
> candidate that does not have optional parameters for which arguments
> were omitted in the call. This is a consequence of a general preference
> in overload resolution for candidates that have fewer parameters.
2018-09-20 19:30:49 -07:00
Rune Henriksen and GitHub
0901d3f62f
Merge pull request #3387 from warwickmm/ordinal_case_insensitive_comparison
...
Use ordinal case-insensitive comparison instead of ToLower and ToUpper
2018-09-20 23:33:21 +02:00
Rune Henriksen and GitHub
bb60050639
Merge pull request #3388 from warwickmm/remove_string_formatting
...
Remove unnecessary call to String.Format
2018-09-20 23:30:22 +02:00
Rune Henriksen and GitHub
840031b358
Merge pull request #3389 from warwickmm/use_local_variable
...
Use existing local variable to improve readability
2018-09-20 23:29:45 +02:00
sffetlio
70febafc2b
Add Description field to backups
2018-09-20 14:46:32 +03:00
Kenneth Hsu
1c8bb276b4
Allow tasks to complete on any thread when context is irrelevant.
...
When the code following the await can be executed on any thread, it's
recommended to use ConfigureAwait(false) to avoid unnecessary context
switching and potential deadlocks.
2018-09-19 16:57:17 -07:00
Kenneth Hsu
df5f8e16b9
Use ordinal case-insensitive comparison instead of ToUpper.
2018-09-19 15:21:59 -07:00
Kenneth Hsu
0d23302220
Use ordinal case-insensitive comparison instead of ToLower.
2018-09-19 15:21:59 -07:00
Kenneth Hsu
25e2b40384
Use existing local variable to improve readability.
2018-09-18 21:52:31 -07:00
Kenneth Hsu
588363d6fb
Remove unnecessary call to String.Format.
2018-09-18 21:37:12 -07:00
Kenneth Skovhede and GitHub
2228cd7642
Merge pull request #3378 from dgehri/feature/PathTooLongException
...
refs ##3311 : fix for PathTooLongException
2018-09-15 00:29:56 +02:00
Kenneth Skovhede and GitHub
5b98c4c8aa
Merge pull request #3377 from dgehri/master
...
refs #3372 : tentative fix for FailedToUseChangeJournal
2018-09-15 00:29:05 +02:00
Kenneth Skovhede and GitHub
b27e18cca1
Merge pull request #3380 from jkellerer/fix-linux-snapshot-is-block-device
...
Fixed #3373 - LVM: Backup failure on removed files
2018-09-15 00:27:59 +02:00
Kenneth Skovhede and GitHub
01c3e52f68
Merge pull request #3368 from LacunaSoftware/progressBar
...
Fix progress bar not updating size and number of files processed
2018-09-15 00:27:05 +02:00
jkellerer and juergen kellerer
fde179c2a2
Fixed #3373 - LVM: Backup failure on removed files
...
Fixes a problem in IsBlockDevice(localPath) which throws an exception when a path that exists in the snapshot is removed from the disk during the backup.
2018-09-14 12:00:20 +02:00
Daniel Gehriger
a4f513710f
refs ##3311 : fix for PathTooLongException
2018-09-12 22:02:33 +02:00
Daniel Gehriger
8ae700c05e
refs ##3311 : fix for PathTooLongException
2018-09-12 21:59:54 +02:00
Daniel Gehriger
a160ef305d
refs #3372 : tentative fix for FailedToUseChangeJournal: Failed to compare two elements in the array
2018-09-12 21:51:54 +02:00
Max
881087f968
allow projects to execute
2018-09-10 14:44:44 +02:00
Max
86d015997b
Dependency info suppress
2018-09-10 14:34:20 +02:00
Max
2cac7cecd2
AlphaFS, AlphaVSS fully functional
2018-09-10 13:31:26 +02:00
Max
ed9af377d2
Utility buildable
2018-09-09 21:33:32 +02:00
Max
513a4c71cf
Snapshots convert
2018-09-09 21:19:41 +02:00
Max
00887055cc
Utility convert
...
Battery status without Forms dependance
2018-09-09 20:56:07 +02:00
Max
d2ed5c6b27
UpdateVersionStamp converted
2018-09-09 16:29:24 +02:00
Max
478d4565af
DependencyFinder converted
2018-09-09 16:25:52 +02:00
Max
c2a7bed781
AutoUpdateBuilder converted
2018-09-09 16:19:14 +02:00
Max
8ddc41fc70
cleanup
2018-09-09 16:09:35 +02:00
Max
b6fc1d2b52
SQLiteTool converted
2018-09-09 16:00:08 +02:00
Max
be503ea028
utility cleanup
...
zipfiledebugger converted
2018-09-09 15:54:14 +02:00
Max
a22a7a7d24
remove of FasterHashing component
2018-09-09 14:42:40 +02:00
Max
30fab22340
unsinged whole solution
2018-09-09 14:21:55 +02:00
Max
64d8e114ff
sync of cocol versions
2018-09-09 14:10:26 +02:00
Max
b11f4d7cdd
Merge branch 'master' into netstandard
2018-09-09 12:24:31 +02:00
Max and GitHub
5253bc7c31
Merge pull request #45 from duplicati/master
...
upstream
2018-09-09 12:02:02 +02:00