Commit Graph
5427 Commits
Author SHA1 Message Date
Kenneth Hsu bbe65f9dfb Remove ineffective statements.
The removed code was introduced in revision ba58651e5a ("Fix for
CreateFolder with SSH"), presumably to fix an issue where some SSH
backends did not like the trailing slash when creating new folders.
However, since we are not using the output argument of the call to
Substring, these statements have no effect.
2018-05-26 10:36:50 -07:00
Kenneth SkovhedeandGitHub a7575d6bda Merge pull request #3229 from verhoek/bugs/commandline
Bugfixes commandline
2018-05-24 11:28:40 +02:00
verhoek b786da55a6 Adjusted display of help according to common standards,
show help on command appearing after "help" and not
on last.
2018-05-23 20:09:03 +02:00
verhoek 29eebaec5b Rewrote parsing aliases of parameter file option in a loop. 2018-05-23 20:02:24 +02:00
verhoek 7450f498be Revert "Removed weird mixed up if's."
This reverts commit 9f07a09621.
2018-05-23 19:40:29 +02:00
Kenneth SkovhedeandGitHub fd26732e1f Merge pull request #3228 from warwickmm/use_string_join
Simplify construction of query parameter string
2018-05-23 11:11:02 +02:00
Kenneth SkovhedeandGitHub 19851c88f0 Merge pull request #3227 from warwickmm/use_string_builder
Replace string concatenation with StringBuilder
2018-05-23 11:10:36 +02:00
Kenneth SkovhedeandGitHub b73ad59021 Merge pull request #3226 from verhoek/refactored
Minor refactoring and modifications in travis build script.
2018-05-23 11:09:40 +02:00
verhoek 271273c9af Added escapes, now e.g. help --include works again. 2018-05-20 16:51:56 +02:00
verhoek e4398d3b68 Fixed broken help output in commandline.
E.g. "help find" works again.
2018-05-20 16:51:53 +02:00
verhoek 9f07a09621 Removed weird mixed up if's. 2018-05-20 16:51:47 +02:00
Kenneth Hsu 2384e6eb30 Simplify construction of query parameter string. 2018-05-19 16:12:12 -07:00
Kenneth Hsu 0b016cea2c Replace string concatenation with StringBuilder.
When appending to a string in a loop, using a StringBuilder should in
general yield better performance.
2018-05-19 15:36:00 -07:00
verhoek f0276bf949 Added shebang to travis build script. 2018-05-18 08:07:44 +02:00
verhoek 2f41e02ca9 Merge branch 'master' into refactored 2018-05-18 08:05:19 +02:00
verhoek d9fc1cac08 Moved travis script steps to separate bash script with trap on error, to prevent continuing executing further steps on error. 2018-05-18 07:57:55 +02:00
Kenneth SkovhedeandGitHub b7b4fbe778 Merge pull request #3221 from verhoek/webapi/googledrive
Webapi/googledrive
2018-05-17 14:44:50 +02:00
Kenneth SkovhedeandGitHub 1071bf8bb0 Merge pull request #3224 from tnwhitwell/add-memset
Add Memset's Cloud Storage to Openstack providers
2018-05-17 14:37:07 +02:00
Tom Whitwell 54ae844536 Add Memset's Cloud Storage to Openstack providers 2018-05-17 12:03:30 +01:00
verhoek 92777a168b Removed unused imports. 2018-05-16 21:46:42 +02:00
verhoek abf937249f Corrected spelling of comparision in server.cs release mode. 2018-05-16 21:40:27 +02:00
verhoek 0b9712ee84 Removed unused var. 2018-05-16 21:21:35 +02:00
verhoek 8a4031f66b Added skipped file in comparison spelling correction commit. 2018-05-16 20:24:31 +02:00
verhoek 143725c0b9 Removed some duplication. 2018-05-16 20:10:06 +02:00
verhoek 30cd41585b Corrected spelling function name. 2018-05-16 20:08:40 +02:00
verhoek 7a8a040e4b Renamed unit test category UrlUtility to UriUtility for consistency. Added to travis.yml. 2018-05-16 08:11:17 +02:00
verhoek be79384966 Removed duplicate ? when building urls with query parameters. 2018-05-15 21:50:14 +02:00
verhoek c5783b2ae4 Merge branch 'master' into webapi/googledrive 2018-05-15 20:31:58 +02:00
verhoek 0cca2797df Use concat paths in helper functions of googledrive. 2018-05-15 20:29:08 +02:00
verhoek 1cde60c640 Removed misplaced leftover line. 2018-05-15 20:28:52 +02:00
Kenneth Skovhede 2c44cce136 Merge branch 'feature/remove-console-writeline' 2018-05-15 12:12:07 +02:00
Kenneth Skovhede ee64517f7d Removed calls to Console.WriteLine as we may run somewhere without a console. 2018-05-15 11:29:08 +02:00
Kenneth SkovhedeandGitHub 8df0f40f26 Merge pull request #3218 from warwickmm/missing_format_item_value
Provide value to format item
2018-05-15 10:08:54 +02:00
Kenneth SkovhedeandGitHub 78dc70f01a Merge pull request #3219 from warwickmm/add_braces_readability
Improve readability of single-statement if and foreach blocks
2018-05-15 10:08:29 +02:00
Kenneth SkovhedeandGitHub cb71480806 Merge pull request #3215 from warwickmm/use_thread_safe_collection
Use thread-safe collection in SynologyAuthenticationHandler
2018-05-15 10:07:39 +02:00
verhoek bbf489c86f Corrected appending paths to urls. 2018-05-14 22:53:13 +02:00
verhoek 6dd64a553d Fixed code quality issues. 2018-05-14 21:01:18 +02:00
Kenneth Hsu 0777d9c98a Fix indentation to improve readability.
The previous indentation could give the impression that it belongs to
the preceding if-statement.
2018-05-13 14:24:13 -07:00
Kenneth Hsu 9c6bccf478 Use braces to improve readability.
Previously, the indentation of the following code block gave the
impression that it was part of the foreach loop when in fact it would
only be executed once.
2018-05-13 14:24:13 -07:00
verhoek dae12fee53 Organized imports. 2018-05-13 16:27:14 +02:00
verhoek a67248f51f Moved Api strings to separate class similarly to the constant setup in Strings.cs. 2018-05-13 16:22:41 +02:00
verhoek 007e4c0829 Cleaned up imports. 2018-05-13 12:48:00 +02:00
Kenneth Hsu 8c0128b0f9 Provide missing value to format item. 2018-05-12 17:06:12 -07:00
verhoek 051b030836 Fixed typo regarding pageToken. Integrated other strings in static string class. 2018-05-12 12:42:51 +02:00
verhoek 6539c36e51 Merge branch 'master' into webapi/googledrive 2018-05-12 09:30:57 +02:00
Kenneth Hsu c184b1871d Remove unused lock object.
The Dictionary used to cache the authenticated logins was made
thread-safe in revision 2653791227 ("Use thread-safe collection in
SynologyAuthenticationHandler").
2018-05-11 22:00:29 -07:00
Kenneth Hsu 2653791227 Use thread-safe collection in SynologyAuthenticationHandler.
Since the SynologyAuthenticationHandler class inherits from HttpModule,
we should ensure that access to its internal collections are
thread-safe.
2018-05-11 21:57:58 -07:00
verhoek 44b5b00276 Renamed some googledriveapi var names. Modified ListFolder to be more readable. 2018-05-11 19:57:09 +02:00
verhoek 78a46c3a5c Renamed misspelled class urluttility to urlutility and newly added urlutility to uriutility. 2018-05-11 19:09:14 +02:00
verhoek d303db30d6 Replacing magic strings in google drive rest calls by query key value pairs. 2018-05-11 18:23:16 +02:00