Commit Graph
21 Commits
Author SHA1 Message Date
Kenneth Skovhede 842fd96543 Implemented a new logging system that is more transparent and allows a more granular way of picking log messages.
Added ID's to each log message and each exception to allow later introduction of a Knowledgebase service that explains each error in more detail.
2018-03-15 09:12:34 +01:00
Kenneth Skovhede bd863016fa Added support for returning multiple DNS names for cache invalidation.
Updated most backends to return the actual DNS names for cache invalidation.
2018-02-26 11:37:10 +01:00
Rune Henriksen fc77b476fc changed from NYI to null returns. Added check to skip DNS check if no DNSName is provided 2018-02-21 22:38:01 +01:00
Rune Henriksen 00292953c3 added DNSName getter on Backend interface and added NotImplementedException methods on each backend class 2018-02-18 00:18:44 +01:00
Kenneth Hsu 8810e0130d Make string comparisons use ordinal (binary) sort rules.
These string comparisons should not be culture-aware.
2017-11-26 11:19:54 -08:00
Tyler Gill 38883285ee Change IBackend.List() to return IEnumerable instead of List
By changing to IEnumerable, it is possible to iterate only a portion of the list, which is useful when not all entries are needed (e.g., when testing a connection).
All existing backends have been updated, and any which were able to be changed to yield return results in a straightforward way now do.
Many backends had a try/catch in the List() method. Due to the fact that yield returns can't be placed within a try/catch block, these have been refactored to either scope the try/catch to the parts that (should) be the only places throwing exceptions, so that exceptions are still caught and handled.
Note that lazy evaluation may cause some changes in behavior - exceptions that were previously thrown at the point of invokation of List() may now be thrown while it is being enumerated.
I believe this will not be problematic though, as the only well-known exception seems to be FolderMissingException, which should be thrown by Test(), but TestList() attempts to enumerate the list to force this exception.
Any places that require the legacy behavior can get it by simply converting the lazy enumerable to a List()
2017-09-25 23:17:45 -06:00
Tyler Gill 83a1dcfb64 Replace all instances of InvariantCultureIgnoreCase with OrdinalIgnoreCase in string comparisons.
InvariantCulture is useful when comparing / sorting human language strings in a culturely correct way. It handles things like accented letters in a way that makes sense to humans (e.g., 'a' should be sorted next to 'á', rather than after 'z').
Ordinal looks just at the raw code points of the characters. As such, it is recommended for use in cases when comparing system strings (file paths, command line parameters, config settings, etc.). Since it doesn't need to use the culture specific sorting rules, this method can often be faster.

For more information, see https://stackoverflow.com/questions/492799/difference-between-invariantculture-and-ordinal-string-comparison (and other related questions)
2017-09-18 23:55:08 -06:00
vnau 8f6aacb8c6 AlternativeFTP Backend: Check access permissions (Read/Write/Delete) using test file during connection test.
Issue: #2473
2017-05-24 01:39:30 +07:00
Kenneth Skovhede 43d5afe5c9 More disabling of assembly signing 2017-01-13 00:17:27 +01:00
Kenneth Skovhede a029890409 Implemented better default error messsages 2017-01-09 11:35:38 +01:00
Kenneth SkovhedeandGitHub 3c621ed659 Merge pull request #2212 from seaeagle1/master
Use CWD to change to path in AlternativeFTP client connection
2016-12-30 00:17:12 +01:00
Kenneth Skovhede 52eb8e8478 Disabled MSBuild for much faster builds on MacOS 2016-12-29 23:12:41 +01:00
seaeagle1 ed62f77864 Fix Listing 2016-12-29 21:20:12 +01:00
seaeagle1 bc9a852fac Reuse FTP connection 2016-12-29 15:00:19 +01:00
seaeagle1 901966ccdd Use CWD to change to path in AlternativeFTP client connection 2016-12-28 19:31:25 +01:00
Kenneth Skovhede 0c68daff6c Fixed all whitespace to be 4 spaces instead of tabs 2016-09-15 11:39:27 +02:00
Kenneth Skovhede aa7af328fb Fixed an issue with parsing ssl options in aftp 2016-04-27 14:48:11 +02:00
Kenneth Skovhede 71911f63c0 Whitespace fix 2016-04-10 23:59:35 +02:00
Kenneth Skovhede 75826aa60e Cleaned up the commit a bit 2016-04-10 16:27:51 +02:00
Tim Mylemans 699853ec10 Fixed: Compilation on Linux 2016-04-09 12:06:12 +02:00
Tim Mylemans 9e5c4a81b2 Implemented an alternative FTP backend using System.Net.FtpClient 2016-04-09 11:45:15 +02:00