Commit Graph
87 Commits
Author SHA1 Message Date
Kenneth Hsu e6587a2c6f Fix retrieval of HAS_FIXED_INVALID_BACKUPID setting.
The previous implementation returned false for null or empty or
whitespace values, and true for unparsable values.  A default value of
false seems more appropriate for these cases.
2018-04-12 19:19:32 -07:00
Kenneth Hsu c15e4b17b6 Fix retrieval of SERVER_PORT_CHANGED setting.
The previous implementation returned true for null, empty or whitespace,
or unparsable values.  A default value of false seems more appropriate
for this setting.

Since the ServerSettings constructor initializes the m_values Dictionary
with keys from the CONST class, we can assume that the
SERVER_PORT_CHANGED key exists.
2018-04-08 19:36:41 -07:00
Kenneth Hsu b50b02a59b Fix retrieval of UNACKED_ERROR and UNACKED_WARNING settings.
The previous implementation returned true for null, empty or whitespace,
or unparsable values.  A default value of false seems more appropriate
for these settings.  In particular, if no warning or error has occurred
yet (e.g., upon first installation), these properties should return
false.

This addresses issue #3126.
2018-04-08 19:36:41 -07:00
Kenneth Hsu 6953ffe710 Simplify retrieval of HAS_ASKED_FOR_PASSWORD_PROTECTION setting.
The previous implementation:

	1. Assumes that the relevant key exists in the Dictionary.
 	2. Returns true if the value is null, empty or whitespace, or
	   unparsable.  Otherwise, it returns the parsed value.

 This simplifies the code while capturing the same logic.
2018-04-08 19:36:41 -07:00
Kenneth Hsu 7c55df81e2 Simplify retrieval of IS_FIRST_RUN setting.
The previous implementation:

	1. Assumes that the relevant key exists in the Dictionary.
	2. Returns true if the value is null, empty or whitespace, or
	   unparsable.  Otherwise, it returns the parsed value.

This simplifies the code while capturing the same logic.
2018-04-08 19:36:41 -07:00
Kenneth Skovhede e124329f1e Merge branch 'feature/improved-logging' 2018-03-16 08:38:14 +01:00
Kenneth Skovhede 842fd96543 Implemented a new logging system that is more transparent and allows a more granular way of picking log messages.
Added ID's to each log message and each exception to allow later introduction of a Knowledgebase service that explains each error in more detail.
2018-03-15 09:12:34 +01:00
Kenneth Hsu 1f8b542604 Use nameof operator when constructing ArgumentNullException.
This will make rename refactorings easier in the future.
2018-03-07 17:53:08 -08:00
Pectojin 15284ce445 Altered the DeleteFromDb() method so that it can be used to delete rows defined by arbitrary identifiers. Added overloaded function that turns legacy calls to DeleteFromDb() into calls to the new DeleteFromDb() method 2018-02-01 20:12:10 +01:00
Pectojin b68dda3d59 Added calls to clean up dependency tables when a backup is deleted 2018-02-01 20:12:04 +01:00
Kenneth SkovhedeandGitHub 36aadc4ad1 Merge pull request #2910 from warwickmm/refactor/remove_redundant_tostring
Remove redundant calls to ToString
2017-11-27 08:50:00 +01:00
Kenneth Hsu 5fb1958ceb Remove redundant calls to ToString. 2017-11-26 15:44:34 -08:00
Kenneth Hsu 8810e0130d Make string comparisons use ordinal (binary) sort rules.
These string comparisons should not be culture-aware.
2017-11-26 11:19:54 -08:00
Tyler Gill 83a1dcfb64 Replace all instances of InvariantCultureIgnoreCase with OrdinalIgnoreCase in string comparisons.
InvariantCulture is useful when comparing / sorting human language strings in a culturely correct way. It handles things like accented letters in a way that makes sense to humans (e.g., 'a' should be sorted next to 'á', rather than after 'z').
Ordinal looks just at the raw code points of the characters. As such, it is recommended for use in cases when comparing system strings (file paths, command line parameters, config settings, etc.). Since it doesn't need to use the culture specific sorting rules, this method can often be faster.

For more information, see https://stackoverflow.com/questions/492799/difference-between-invariantculture-and-ordinal-string-comparison (and other related questions)
2017-09-18 23:55:08 -06:00
Kenneth Skovhede cae0fb7b9e Added nag dialog for first launch asking to set a password on multi-user machines. 2017-08-24 13:55:29 +02:00
Dan Stahr 58a95e03e6 Autovacuum option added 2017-08-04 12:09:01 +01:00
Kenneth Skovhede 5cea95bb54 Merge branch 'tray_readpassword' of https://github.com/mnaiman/duplicati into tray_readpassword
# Conflicts:
#	Duplicati/Server/Database/ServerSettings.cs
2017-06-21 08:43:04 +02:00
Kenneth Skovhede da0de9983b Implemented the live throttle control.
This fixes #1730
This fixes #1261
2017-06-20 13:00:52 +02:00
Max 319288ef9f upstream 2017-06-17 17:19:34 +02:00
Kenneth Skovhede ded920178d Fixed a few issues with storing and reading UI settings 2017-05-31 22:44:16 +02:00
Max 0c97194cf7 Move GetDatabaseConnection to Server 2017-05-21 19:25:39 +02:00
Max c300c1fb47 added ability to survive password change or on/off 2017-05-03 00:03:16 +02:00
Max 91f4f79559 added posibility to read server password from database 2017-05-02 21:14:28 +02:00
Albertony c87f3946df Fixed unreported issue: The block size validation was not triggered, and did also not allow setting the value to 1KB (similar to issue #2387) 2017-03-20 12:36:08 +01:00
Albertony a8905a4da8 Fixed issue #2387: Volume size cannot be set to 1 MB 2017-03-20 12:31:13 +01:00
Kenneth Skovhede 3c5a45bdff Layout fix 2017-02-27 09:09:13 +01:00
Kenneth Skovhede 8c8a0907c0 Added checks to ensure that hyphens are not used in --prefix as that would make it possible to craft prefixes that confuse the filename parser, e.g. --prefix=duplicati-b1234.zip
This fixes #2295
2017-02-27 09:09:02 +01:00
Max 15ce7bab8a added support for ssl under linux 2017-02-11 23:39:42 +01:00
Kenneth Skovhede 1424be05f9 Fixed a bunch of typos.
This fixes #2278.
2017-01-23 22:12:24 +01:00
Kenneth Skovhede 71933b2674 Added serverside validation of backups on save/update 2016-10-14 00:15:49 +02:00
Kenneth Skovhede 53a7459f29 Fixed problem with UI saving global options in ApplicationSettings/ServerSettings.
This fixes #1720.
This fixes #1830
2016-09-23 23:23:44 +02:00
4m1g0 c48b4ee73e Fix for issue: #1828 - Add autoincrement atribute to backup id 2016-07-15 13:50:54 +02:00
Max b1d19210d8 adds ability to save ssl certificate to database 2016-06-26 16:09:07 +02:00
Kenneth Skovhede 742eab0913 Fixed multiple cases where connections and command instances were not disposed.
This should fix all cases of "File is locked" on windows.
2016-04-06 20:40:34 +02:00
Kenneth Skovhede 41f20301a3 Implemented settings for controlling what data is sent with the usage reporter 2016-03-12 00:29:51 +01:00
Kenneth Skovhede e0237b5309 Implemented two new build channels: beta and canary.
Updated build system to allow building various types of releases.
2016-03-11 22:55:32 +01:00
Kenneth Skovhede b1a2115fc7 Fixed a case where a backup save failed if a schedule was created 2015-12-08 23:48:29 +01:00
Kenneth Skovhede bcf9985ee8 Added web-interface support for changing the local database for a backup 2015-12-08 20:42:53 +01:00
Kenneth Skovhede 2ffdf582ad Fixed an issue with updating advanced settings 2015-12-07 21:57:54 +01:00
Kenneth Skovhede 0bfe3daac4 Fixed issues with the REST interface 2015-08-26 12:38:27 +01:00
Kenneth Skovhede ae0ef1a912 Fixed some issues with applying server settings through PATCH 2015-08-05 13:04:52 +02:00
Kenneth Skovhede 3972211757 Added automatic log cleanup
This fixes #1298
2015-02-15 23:44:20 +01:00
Kenneth Skovhede 3ab1632f43 Cleanup broken database.
This fixes #1295.
This fixes #1287.
2015-02-15 22:54:49 +01:00
Kenneth Skovhede a3d21c1f6d Fixed saving with ID=-1 which is what causes #1295 and #1287 2015-02-15 22:28:34 +01:00
Kenneth Skovhede a0efbed111 Protecting against saving with ID=-1 as mentioned in #1295 2015-02-15 22:26:43 +01:00
Kenneth Skovhede 4846ffa103 Now using the file modification timestamp and the filesize as indicators that trigger file scanning.
This fixes #1099.
2015-01-24 21:59:53 +01:00
Kenneth Skovhede 8d13e698eb Updated copyright notices 2015-01-20 21:44:52 +01:00
Kenneth Skovhede c2fc930411 Implemented storing backup task info in the backup data 2014-10-14 14:45:49 +02:00
Kenneth Skovhede d0f306dba9 Store sqlite databases in the Datafolder to support portable installs 2014-09-02 18:04:50 +02:00
Kenneth Skovhede b50dac37f3 Fixed a crash that was introduced with 0198fb8. 2014-08-25 15:35:49 +02:00