The previous implementation returned false for null or empty or
whitespace values, and true for unparsable values. A default value of
false seems more appropriate for these cases.
The previous implementation returned true for null, empty or whitespace,
or unparsable values. A default value of false seems more appropriate
for this setting.
Since the ServerSettings constructor initializes the m_values Dictionary
with keys from the CONST class, we can assume that the
SERVER_PORT_CHANGED key exists.
The previous implementation returned true for null, empty or whitespace,
or unparsable values. A default value of false seems more appropriate
for these settings. In particular, if no warning or error has occurred
yet (e.g., upon first installation), these properties should return
false.
This addresses issue #3126.
The previous implementation:
1. Assumes that the relevant key exists in the Dictionary.
2. Returns true if the value is null, empty or whitespace, or
unparsable. Otherwise, it returns the parsed value.
This simplifies the code while capturing the same logic.
The previous implementation:
1. Assumes that the relevant key exists in the Dictionary.
2. Returns true if the value is null, empty or whitespace, or
unparsable. Otherwise, it returns the parsed value.
This simplifies the code while capturing the same logic.
Kenneth Hsu