Commit Graph
5 Commits
Author SHA1 Message Date
Kenneth Hsu c184b1871d Remove unused lock object.
The Dictionary used to cache the authenticated logins was made
thread-safe in revision 2653791227 ("Use thread-safe collection in
SynologyAuthenticationHandler").
2018-05-11 22:00:29 -07:00
Kenneth Hsu 2653791227 Use thread-safe collection in SynologyAuthenticationHandler.
Since the SynologyAuthenticationHandler class inherits from HttpModule,
we should ensure that access to its internal collections are
thread-safe.
2018-05-11 21:57:58 -07:00
vnau 9b9d9b1297 Fixed compiler warnings. 2017-12-17 01:34:21 +07:00
Tyler Gill 83a1dcfb64 Replace all instances of InvariantCultureIgnoreCase with OrdinalIgnoreCase in string comparisons.
InvariantCulture is useful when comparing / sorting human language strings in a culturely correct way. It handles things like accented letters in a way that makes sense to humans (e.g., 'a' should be sorted next to 'á', rather than after 'z').
Ordinal looks just at the raw code points of the characters. As such, it is recommended for use in cases when comparing system strings (file paths, command line parameters, config settings, etc.). Since it doesn't need to use the culture specific sorting rules, this method can often be faster.

For more information, see https://stackoverflow.com/questions/492799/difference-between-invariantculture-and-ordinal-string-comparison (and other related questions)
2017-09-18 23:55:08 -06:00
Kenneth Skovhede d57215aaef Switched to using nginx based proxy instead of the slow CGI proxy on Synology 2017-07-03 00:52:40 +02:00