Files
duplicati/Duplicati/Library/Main/Operation/Backup/SpillCollectorProcess.cs
T
Kenneth Skovhede 179d1ceb47 Make controller Async
This PR has a large blast radius because it takes the final step and bumps up the Controller to be fully async.

We have historically done a piece-by-piece update, so all operations were already async but the controller interface was kept synchronous.

With this update, the controller is now fully async and all tests are updated.

Most places where the new C# compiler warns about function names not ending in `Async` were also adressed, giving a massive refactor change.

Functionally, no changes are done.
2026-05-13 15:04:13 +02:00

187 lines
8.8 KiB
C#

// Copyright (C) 2026, The Duplicati Team
// https://duplicati.com, hello@duplicati.com
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the "Software"),
// to deal in the Software without restriction, including without limitation
// the rights to use, copy, modify, merge, publish, distribute, sublicense,
// and/or sell copies of the Software, and to permit persons to whom the
// Software is furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
// DEALINGS IN THE SOFTWARE.
using CoCoL;
using Duplicati.Library.Main.Operation.Common;
using Duplicati.Library.Main.Volumes;
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
namespace Duplicati.Library.Main.Operation.Backup
{
internal class SpillVolumeRequest
{
public BlockVolumeWriter BlockVolume { get; private set; }
public TemporaryIndexVolume IndexVolume { get; private set; }
public SpillVolumeRequest(BlockVolumeWriter blockvolume, TemporaryIndexVolume indexvolume)
{
BlockVolume = blockvolume;
IndexVolume = indexvolume;
}
}
/// <summary>
/// This process just waits until all block processes are terminated
/// and collects the non-written volumes.
/// All remaining volumes are re-packed into one or more filled
/// volumes and uploaded
/// </summary>
internal static class SpillCollectorProcess
{
public static Task RunAsync(Channels channels, Options options, BackupDatabase database, IBackendManager backendManager, ITaskReader taskreader)
{
return AutomationExtensions.RunTask(
new
{
Input = channels.SpillPickup.AsRead()
},
async self =>
{
var lst = new List<SpillVolumeRequest>();
while (!await self.Input.IsRetiredAsync.ConfigureAwait(false))
try
{
lst.Add(await self.Input.ReadAsync().ConfigureAwait(false));
}
catch (Exception ex)
{
if (ex.IsRetiredException())
break;
throw;
}
async Task<SpillVolumeRequest> GetNextTarget(SpillVolumeRequest source)
{
SpillVolumeRequest target = null;
if (lst.Count == 0)
{
// No more targets, make one
target = new SpillVolumeRequest(new BlockVolumeWriter(options), source.IndexVolume == null ? null : new TemporaryIndexVolume(options));
target.BlockVolume.VolumeID = await database.RegisterRemoteVolumeAsync(target.BlockVolume.RemoteFilename, RemoteVolumeType.Blocks, RemoteVolumeState.Temporary, taskreader.ProgressToken).ConfigureAwait(false);
}
else
{
// Grab the next target
target = lst[0];
lst.RemoveAt(0);
}
// We copy all blocklisthashes as they are pre-filtered to be unique
if (source.IndexVolume != null)
source.IndexVolume.CopyTo(target.IndexVolume, true);
return target;
}
var buffer = new byte[options.Blocksize];
while (lst.Count > 1)
{
// We ignore the stop signal, but not the pause and terminate
await taskreader.ProgressRendevouzAsync().ConfigureAwait(false);
SpillVolumeRequest target = null;
var source = lst[0];
// Finalize the current work
source.BlockVolume.Close();
// Remove it from the list of active operations
lst.RemoveAt(0);
using (var rd = new BlockVolumeReader(options.CompressionModule, source.BlockVolume.LocalFilename, options))
{
// Make sure we process the blocklisthashes, even if the blockvolume is empty
target = await GetNextTarget(source).ConfigureAwait(false);
foreach (var file in rd.Blocks)
{
// Grab a target
if (target == null)
target = await GetNextTarget(source).ConfigureAwait(false);
var len = rd.ReadBlock(file.Key, buffer);
await target.BlockVolume.AddBlockAsync(file.Key, buffer, 0, len, Duplicati.Library.Interface.CompressionHint.Default).ConfigureAwait(false);
await database.MoveBlockToVolumeAsync(file.Key, len, source.BlockVolume.VolumeID, target.BlockVolume.VolumeID, taskreader.ProgressToken).ConfigureAwait(false);
if (target.IndexVolume != null)
target.IndexVolume.AddBlock(file.Key, len);
if (target.BlockVolume.Filesize > options.VolumeSize - options.Blocksize)
{
target.BlockVolume.Close();
await UploadVolumeAndIndexAsync(target, options, database, backendManager, taskreader).ConfigureAwait(false);
target = null;
}
}
}
// Make sure they are out of the database
System.IO.File.Delete(source.BlockVolume.LocalFilename);
await database.SafeDeleteRemoteVolumeAsync(source.BlockVolume.RemoteFilename, taskreader.ProgressToken).ConfigureAwait(false);
// Re-inject the target if it has content
if (target != null)
lst.Insert(lst.Count == 0 ? 0 : 1, target);
}
foreach (var n in lst)
{
// We ignore the stop signal, but not the pause and terminate
await taskreader.ProgressRendevouzAsync().ConfigureAwait(false);
n.BlockVolume.Close();
await UploadVolumeAndIndexAsync(n, options, database, backendManager, taskreader).ConfigureAwait(false);
}
});
}
private static async Task UploadVolumeAndIndexAsync(SpillVolumeRequest target, Options options, BackupDatabase database, IBackendManager backendManager, ITaskReader taskreader)
{
IndexVolumeWriter indexVolumeCopy = null;
if (target.IndexVolume != null)
{
// TODO: It is much easier to let the BackendManager deal with index files,
// but it adds a bit of strain to the database
indexVolumeCopy = await target.IndexVolume.CreateVolumeAsync(target.BlockVolume.RemoteFilename, options, database, taskreader.ProgressToken).ConfigureAwait(false);
// Create link before upload is started, it will be removed later if upload fails
await database.AddIndexBlockLinkAsync(indexVolumeCopy.VolumeID, target.BlockVolume.VolumeID, taskreader.ProgressToken).ConfigureAwait(false);
}
if (options.Dryrun)
{
Logging.Log.WriteDryrunMessage(Logging.Log.LogTagFromType(typeof(SpillCollectorProcess)), "WouldUploadFile", "Would upload file: {0}", target.BlockVolume.RemoteFilename);
}
else
{
await database.CommitTransactionAsync("UploadSpillVolume", true, taskreader.ProgressToken).ConfigureAwait(false);
await backendManager.PutAsync(target.BlockVolume, indexVolumeCopy, null, false, () => database.FlushBackendMessagesAndCommitAsync(backendManager, taskreader.ProgressToken), taskreader.ProgressToken).ConfigureAwait(false);
}
}
}
}