haeaeae/silo-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(auth): keep sessions on library scope changes

Browse Source
This commit is contained in:
zZebrahz
2026-05-30 19:31:46 -07:00
parent af2c54c8f0
commit 07e50b72b6
2 changed files with 7 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/api/handlers/admin.go
-9
View File
@@ -774,7 +774,6 @@ func updateMayRequireSessionRevocation(input models.UpdateUserInput) bool {
return input.Password != nil ||
input.Role != nil ||
input.Enabled != nil ||
input.LibraryIDs != nil ||
input.Permissions != nil ||
input.MaxPlaybackQuality != nil
}
@@ -792,14 +791,6 @@ func updateRequiresSessionRevocation(current *models.User, input models.UpdateUs
if input.Enabled != nil && *input.Enabled != current.Enabled {
return true
}
if input.LibraryIDs != nil {
if (*input.LibraryIDs == nil) != (current.LibraryIDs == nil) {
return true
}
if *input.LibraryIDs != nil && !slices.Equal(*input.LibraryIDs, current.LibraryIDs) {
return true
}
}
if input.Permissions != nil && !slices.Equal(*input.Permissions, current.Permissions) {
return true
}
internal/api/handlers/admin_test.go
+7 -7
View File
@@ -67,9 +67,9 @@ func TestUpdateRequiresSessionRevocation(t *testing.T) {
want: false,
},
{
name: "library ids",
name: "library ids does not revoke session",
in: models.UpdateUserInput{LibraryIDs: &libraryIDs},
want: true,
want: false,
},
{
name: "library ids unchanged",
@@ -77,9 +77,9 @@ func TestUpdateRequiresSessionRevocation(t *testing.T) {
want: false,
},
{
name: "library ids nil differs from restricted",
name: "library ids nil does not revoke session",
in: models.UpdateUserInput{LibraryIDs: &allLibraryIDs},
want: true,
want: false,
},
{
name: "max playback quality",
@@ -118,9 +118,9 @@ func TestUpdateRequiresSessionRevocation(t *testing.T) {
unrestrictedCurrent := *current
unrestrictedCurrent.LibraryIDs = nil
t.Run("library ids empty differs from nil", func(t *testing.T) {
if got := updateRequiresSessionRevocation(&unrestrictedCurrent, models.UpdateUserInput{LibraryIDs: &emptyLibraryIDs}); !got {
t.Fatalf("updateRequiresSessionRevocation() = %v, want true", got)
t.Run("library ids empty does not revoke session", func(t *testing.T) {
if got := updateRequiresSessionRevocation(&unrestrictedCurrent, models.UpdateUserInput{LibraryIDs: &emptyLibraryIDs}); got {
t.Fatalf("updateRequiresSessionRevocation() = %v, want false", got)
}
})