haeaeae/silo-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(api): move account-level Discord routes out of RequireProfile

Browse Source 
The Discord DM channel's prefs, link-init, and unlink endpoints are
account-level — the handlers only read the user ID — but were mounted
inside the /notifications subrouter, whose RequireProfile middleware
400s any request without an X-Profile-Id header. Register them as
static paths on the auth-only group instead, the same coexistence
pattern the public email-link routes already use (static paths win over
the mounted subrouter's wildcards; verified empirically, no middleware
leak onto profile-scoped routes).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Quick
2026-06-11 22:06:09 -04:00
co-authored by Claude Fable 5
parent b83df36636
commit beb6b880fc
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/api/router.go
+10 -6
View File
@@ -1558,6 +1558,16 @@ func NewRouter(deps Dependencies) chi.Router {
}
notificationsHandler := handlers.NewNotificationsHandler(deps.Notifications, deps.EventsHub)
r.With(apimw.RequireProfile).Post("/events/ws-ticket", notificationsHandler.HandleMintWSTicket)
// Discord DM channel: the linked identity and mode hang off
// the login account, not a profile, so these stay outside
// the RequireProfile subrouter below (static paths coexist
// with it, same as the public email-link routes above).
if discordNotificationsHandler != nil {
r.Get("/notifications/discord-preferences", discordNotificationsHandler.HandleGetPreferences)
r.Put("/notifications/discord-preferences", discordNotificationsHandler.HandleUpdatePreferences)
r.Delete("/notifications/discord-link", discordNotificationsHandler.HandleUnlink)
r.Post("/notifications/discord/link/init", discordNotificationsHandler.HandleLinkInit)
}
r.Route("/notifications", func(r chi.Router) {
r.Use(apimw.RequireProfile)
r.Get("/", notificationsHandler.HandleList)
@@ -1570,12 +1580,6 @@ func NewRouter(deps Dependencies) chi.Router {
r.Put("/email-preferences", notificationsHandler.HandleUpdateEmailPreferences)
r.Put("/email-preferences/address", notificationsHandler.HandleRequestEmailAddress)
r.Delete("/email-preferences/address", notificationsHandler.HandleClearEmailAddress)
if discordNotificationsHandler != nil {
r.Get("/discord-preferences", discordNotificationsHandler.HandleGetPreferences)
r.Put("/discord-preferences", discordNotificationsHandler.HandleUpdatePreferences)
r.Delete("/discord-link", discordNotificationsHandler.HandleUnlink)
r.Post("/discord/link/init", discordNotificationsHandler.HandleLinkInit)
}
r.Post("/read-all", notificationsHandler.HandleReadAll)
r.Route("/webhooks", func(r chi.Router) {
r.Get("/", notificationsHandler.HandleListWebhooks)